Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-10-01 Thread Stefan Priebe - Profihost AG
pve-devel@pve.proxmox.com >> Subject: [pve-devel] [PATCH] do not use -w switch as it breaks modules >> >> -w enabled warnings for all modules - even when these modules comes from the >> OS and are not compatible with warnings. This is the reason to NO

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-10-01 Thread Dietmar Maurer
applied, thank! > -Original Message- > From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel- > boun...@pve.proxmox.com] On Behalf Of Stefan Priebe > Sent: Montag, 30. September 2013 11:51 > To: pve-devel@pve.proxmox.com > Subject: [pve-devel] [PATCH] do not use -w s

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Stefan Priebe - Profihost AG
Am 30.09.2013 13:16, schrieb Dietmar Maurer: >>> If we do not use '-w', we need to add 'use warnings' to all library files >>> (I guess >> it is not used everywhere)? >> >> If the modules are compatible hey should contain use warnings. > > I am just thinking about our library files in PVE/API/*

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Dietmar Maurer
> > If we do not use '-w', we need to add 'use warnings' to all library files > > (I guess > it is not used everywhere)? > > If the modules are compatible hey should contain use warnings. I am just thinking about our library files in PVE/API/* ___ pve

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Stefan Priebe - Profihost AG
Am 30.09.2013 12:06, schrieb Dietmar Maurer: > q >> -w enabled warnings for all modules - even when these modules comes from the >> OS and are not compatible with warnings. > > Interesting. Why/when is a module not compatible with warnings? If the developer has not cleanly programmed. But as lon

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Stefan Priebe - Profihost AG
Am 30.09.2013 12:30, schrieb Dietmar Maurer: >> -w enabled warnings for all modules - even when these modules comes from the >> OS and are not compatible with warnings. This is the reason to NOT use -w and >> instead use "use warnings". > > If we do not use '-w', we need to add 'use warnings' to a

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Dietmar Maurer
> -w enabled warnings for all modules - even when these modules comes from the > OS and are not compatible with warnings. This is the reason to NOT use -w and > instead use "use warnings". If we do not use '-w', we need to add 'use warnings' to all library files (I guess it is not used everywhere

Re: [pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Dietmar Maurer
q > -w enabled warnings for all modules - even when these modules comes from the > OS and are not compatible with warnings. Interesting. Why/when is a module not compatible with warnings? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve

[pve-devel] [PATCH] do not use -w switch as it breaks modules

2013-09-30 Thread Stefan Priebe
-w enabled warnings for all modules - even when these modules comes from the OS and are not compatible with warnings. This is the reason to NOT use -w and instead use "use warnings". --- bin/pveam |3 ++- bin/pvectl|3 ++- bin/pvedaemon |3 ++- bin/pvem