Re: [pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Dietmar Maurer
> On March 2, 2016 at 8:45 PM Wolfgang Link wrote: > > > syscmd use run_command with noout what return the only exitcode. OK, but why do you use > eval { syscmd ("/sbin/vgcreate pve $lvmdev") }; then? I am confused now. > > Dietmar Maurer hat am 2. März 2016 um 17:11 > > geschrieben: >

Re: [pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Wolfgang Link
syscmd use run_command with noout what return the only exitcode. > Dietmar Maurer hat am 2. März 2016 um 17:11 geschrieben: > > > comments inline: > > > diff --git a/proxinstall b/proxinstall > > index ec15477..7a67623 100755 > > --- a/proxinstall > > +++ b/proxinstall > > @@ -834,8 +834,11 @@

Re: [pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Dietmar Maurer
comments inline: > diff --git a/proxinstall b/proxinstall > index ec15477..7a67623 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -834,8 +834,11 @@ sub create_lvm_volumes { > # so pe_start is aligned on a 128k boundary (advantage for SSDs) > syscmd ("/sbin/pvcreate --metadatasize 25

[pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Wolfgang Link
This is necessary, if the volume group "pve" exists, say from a previous installation. But whitout printing the reason no user will understand why this happens. --- proxinstall | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/proxinstall b/proxinstall index ec15477..7a67