Sorry, but you need to resend with correct e-mail.
From: Игорь Шестаков [mailto:sh...@selectel.ru]
Sent: Montag, 13. Jänner 2014 22:36
To: Dietmar Maurer
Cc: pve-devel
Subject: Re: [pve-devel] [PATCH][pve-manager] Changes set_userpasswd method
Oh, i'm sorry.
Can you just change it or i ne
se the email address you used to send the CLA (sh...@selectel.ru)
>
>
>
> *From:* Игорь Шестаков [mailto:sh...@selectel.ru]
> *Sent:* Montag, 30. Dezember 2013 12:12
>
> *To:* Dietmar Maurer
> *Cc:* pve-devel
> *Subject:* Re: [pve-devel] [PATCH][pve-manager] Changes set_us
rer
Cc: pve-devel
Subject: Re: [pve-devel] [PATCH][pve-manager] Changes set_userpasswd method
Yes, i test it with patched vzctl
It mount vm, set password and unmount vm(for ploop and for simfs too)
On Mon, Dec 30, 2013 at 3:07 PM, Dietmar Maurer
mailto:diet...@proxmox.com>> wrote:
> what a
Yes, i test it with patched vzctl
It mount vm, set password and unmount vm(for ploop and for simfs too)
On Mon, Dec 30, 2013 at 3:07 PM, Dietmar Maurer wrote:
> > what about this patch?
>
> There is no changelog - so what changed from previous version? Is it
> tested this time?
>
>
--
С уваж
> what about this patch?
There is no changelog - so what changed from previous version? Is it tested
this time?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Hello and merry Christmas!
what about this patch?
On Mon, Dec 16, 2013 at 7:35 PM, Игорь Шестаков wrote:
> From 8118b81626a73fcb83b6b21d498b6724c4b63817 Mon Sep 17 00:00:00 2001
> From: Igor Shestakov
> Date: Mon, 16 Dec 2013 17:39:09 +0400
> Subject: [PATCH] changed set_rootpasswd method for
>From 8118b81626a73fcb83b6b21d498b6724c4b63817 Mon Sep 17 00:00:00 2001
From: Igor Shestakov
Date: Mon, 16 Dec 2013 17:39:09 +0400
Subject: [PATCH] changed set_rootpasswd method for ploop support
Signed-off-by: Igor Shestakov
---
PVE/API2/OpenVZ.pm | 12 +++-
PVE/OpenVZ.pm | 7 ++
> Can we apply this patch as preparation for future ploop use?
> If yes, later(this week) i send you correct patch.
Yes, but only if it works without problems. So please test your code before
sending
patches to the list.
___
pve-devel mailing list
pve-
Can we apply this patch as preparation for future ploop use?
If yes, later(this week) i send you correct patch.
On Thu, Nov 14, 2013 at 1:52 PM, Dietmar Maurer wrote:
> > And we need to discuss, how to solve this problem. We need to update
> vzctl in
> > new versions of proxmox and somehow pas
> And we need to discuss, how to solve this problem. We need to update vzctl in
> new versions of proxmox and somehow pass vztemplate param. Or we need to
> recompile vzctl(remove template download functions and change container
> create function to support full path to templates)
We apply various
On Mon, Nov 11, 2013 at 9:25 AM, Dietmar Maurer wrote:
> Please can you use 'git send-email' to send patches? Also add correct
> 'signed-of-by' entries.
>
> > diff --git a/PVE/OpenVZ.pm b/PVE/OpenVZ.pm
> > index a16d4fc..7788f66 100644
> > --- a/PVE/OpenVZ.pm
> > +++ b/PVE/OpenVZ.pm
> > @@ -1244,
Please can you use 'git send-email' to send patches? Also add correct
'signed-of-by' entries.
> diff --git a/PVE/OpenVZ.pm b/PVE/OpenVZ.pm
> index a16d4fc..7788f66 100644
> --- a/PVE/OpenVZ.pm
> +++ b/PVE/OpenVZ.pm
> @@ -1244,13 +1244,13 @@ sub replacepw {
> }
>
> sub set_rootpasswd {
> - m
What about this patch?
On Mon, Oct 28, 2013 at 1:31 PM, Игорь Шестаков wrote:
> Done.
>
> diff --git a/PVE/OpenVZ.pm b/PVE/OpenVZ.pm
> index a16d4fc..7788f66 100644
> --- a/PVE/OpenVZ.pm
> +++ b/PVE/OpenVZ.pm
> @@ -1244,13 +1244,13 @@ sub replacepw {
> }
>
> sub set_rootpasswd {
> -my ($p
Done.
diff --git a/PVE/OpenVZ.pm b/PVE/OpenVZ.pm
index a16d4fc..7788f66 100644
--- a/PVE/OpenVZ.pm
+++ b/PVE/OpenVZ.pm
@@ -1244,13 +1244,13 @@ sub replacepw {
}
sub set_rootpasswd {
-my ($privatedir, $opt_rootpasswd) = @_;
+my ($opt_rootpasswd, $rootdir) = @_;
-my $pwfile = "$priva
> Of course, we can use "vzctl mount", but then function set_rootpasswd must be
> rewrited to use "vzctl mount" for simfs too.
I guess that is the correct way to implement it.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/
> > And if we use "vzctl mount", we must pass "VE_ROOT" to function.
>
> Why?
>
vzctl mounting any image/simfs to VE_ROOT. If we use ploop, in VE_PRIVATE
we only heave XML file with description and image file.
___
pve-devel mailing list
pve-devel@pve.pro
> And if we use "vzctl mount", we must pass "VE_ROOT" to function.
Why?
> Of course, we can use "vzctl mount", but then function set_rootpasswd must be
> rewrited to use "vzctl mount" for simfs too.
I do not really understand why that is required? But I will take a closer look
at that next wee
@selectel.ru]
> > Sent: Freitag, 25. Oktober 2013 15:37
> > To: Dietmar Maurer
> > Cc: pve-devel
> > Subject: Re: [pve-devel] [PATCH][pve-manager] Changes set_userpasswd
> > method
> >
> > Done
> >
> > diff --git a/PVE/API2/OpenVZ.pm b/PVE/AP
Sorry if this is a stupid question, but does 'vzctl mount' does not work with
ploop?
> -Original Message-
> From: Игорь Шестаков [mailto:sh...@selectel.ru]
> Sent: Freitag, 25. Oktober 2013 15:37
> To: Dietmar Maurer
> Cc: pve-devel
> Subject: Re: [pve-devel]
Yes, you are right. I need to send changed version?
On Fri, Oct 25, 2013 at 5:53 PM, Michael Rasmussen wrote:
> On Fri, 25 Oct 2013 17:37:19 +0400
> Игорь Шестаков wrote:
>
> > + my $fstype = "ext4";
> Just a comment: What will happen in case the file system is not ext4?
>
> Why not simply ski
On Fri, 25 Oct 2013 17:37:19 +0400
Игорь Шестаков wrote:
> + my $fstype = "ext4";
Just a comment: What will happen in case the file system is not ext4?
Why not simply skip this and let the mount command deside which kind
of file system to mount? Mount will only fail if the image uses an
unsuppor
Done
diff --git a/PVE/API2/OpenVZ.pm b/PVE/API2/OpenVZ.pm
index 06fe60b..eeba1a2 100644
--- a/PVE/API2/OpenVZ.pm
+++ b/PVE/API2/OpenVZ.pm
@@ -413,7 +413,7 @@ __PACKAGE__->register_method({
# hack: vzctl '--userpasswd' starts the CT, but we want
# to avoid that for create
- PVE::OpenVZ::set_ro
> Previous solution work only with simfs.
> If we use ploop, we need to mount VM image and then change password.
>
> Why we can't solve this with simple, built-in solution?
Because that made many troubles. Starting a container at create stage
is really unexpected and not what we want to do (for e
Previous solution work only with simfs.
If we use ploop, we need to mount VM image and then change password.
Why we can't solve this with simple, built-in solution?
VM will start, but only for password change.
On Thu, Oct 24, 2013 at 7:18 PM, Dietmar Maurer wrote:
> > - # hack:
> - # hack: vzctl '--userpasswd' starts the CT, but we want
> - # to avoid that for create
> - PVE::OpenVZ::set_rootpasswd($private, $password)
> + PVE::OpenVZ::set_rootpassword($vmid, $password)
As mentioned in the comment, we don't want to
Current solution with changing passwd and shadow files in VM private
directories doesn't work with PLOOP.
We MUST use vzctl set --userpasswd
diff --git a/PVE/API2/OpenVZ.pm b/PVE/API2/OpenVZ.pm
index 06fe60b..13fdb5a 100644
--- a/PVE/API2/OpenVZ.pm
+++ b/PVE/API2/OpenVZ.pm
@@ -411,9 +411,7 @@ __PA
26 matches
Mail list logo
