[pve-devel] [PATCH common] zsh-completion: Add missing flag to compadd

s flags or options for compadd. Details can be found in the compadd documentation: http://zsh.sourceforge.net/Doc/Release/Completion-Widgets.html#Completion-Builtin-Commands Signed-off-by: Christian Ebner --- src/PVE/CLIHandler.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pve-devel] [PATCH firewall] logging: Add missing logmsg for inbound rules

Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 255bb9a..d22b15a 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2491,6 +2491,7 @@ sub enable_host_firewall { $rule

[pve-devel] [PATCH firewall] macros: add macro for Proxmox Mail Gateway web interface

Macro to allow access to the PMG web interface when hosted on PVE. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 4a534d0..255bb9a 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE

[pve-devel] [PATCH docs] firewall-doc: update list of default ports by range used for migration

Signed-off-by: Christian Ebner --- pve-firewall.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index 2bcdf6e..7c60330 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc @@ -426,6 +426,8 @@ following traffic is still allowed for all {pve

[pve-devel] [PATCH firewall] rules: allow connections on port range 60000:60050 in management network for migration

Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index db16e0f..ae67bcd 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2505,6 +2505,7 @@ sub enable_host_firewall

Re: [pve-devel] [PATCH common] cli-formatter: avoid warning when trying to sort on undefined key

Please do not apply, this breaks sorting! > On November 21, 2019 3:21 PM Christian Ebner wrote: > > > Example: > pvesh get /nodes/{node}/qemu/{vmid}/rrddata --timeframe day > > If the sorting key is not defined in the dataset, e.g. when a VM was not > running &g

[pve-devel] [PATCH v2 common] cli-formatter: avoid warning when trying to sort on undefined key

Example: pvesh get /nodes/{node}/qemu/{vmid}/rrddata --timeframe day If the sorting key is not defined in the dataset, e.g. when a VM was not running for some time within the given timeframe, this resulted in several ugly warnings. Signed-off-by: Christian Ebner --- v2: Oops, v1 is

[pve-devel] [PATCH common] cli-formatter: avoid warning when trying to sort on undefined key

Example: pvesh get /nodes/{node}/qemu/{vmid}/rrddata --timeframe day If the sorting key is not defined in the dataset, e.g. when a VM was not running for some time within the given timeframe, this resulted in several ugly warnings. Signed-off-by: Christian Ebner --- src/PVE

[pve-devel] [PATCH docs] qm: fix typo: /ghen/When/

Signed-off-by: Christian Ebner --- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 9ee4460..429cff6 100644 --- a/qm.adoc +++ b/qm.adoc @@ -507,7 +507,7 @@ host. .Fixed Memory Allocation [thumbnail="screenshot/gui-create-vm-memor

[pve-devel] [PATCH v5 manager] fix #1291: add purge checkbox to VM/CT destroy dialog

Signed-off-by: Christian Ebner --- version 5: * only show checkbox for CT/VM destroy dialog (as suggested) * added qtip to checkbox www/manager6/window/SafeDestroy.js | 22 ++ 1 file changed, 22 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www

[pve-devel] [PATCH v4 guest-common 2/2] fix #1291: implement remove_vmid_from_backup_jobs

remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs, excluding the given vmid. Signed-off-by: Christian Ebner --- version 4: * VZDump::Common cfs registers vzdump.cron instead of PVE::VZDump PVE/VZDump/Plugin.pm | 46 1 file changed

[pve-devel] [PATCH v4 manager 2/2] fix #1291: add purge checkbox to VM/CT destroy dialog

Signed-off-by: Christian Ebner --- version 4: * no changes since v3 www/manager6/window/SafeDestroy.js | 12 1 file changed, 12 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index eb3e6665..ef867deb 100644 --- a/www

[pve-devel] [PATCH v4 pve-docs 1/1] gen vzdump: json_config_properties() moved from VZDump to VZDump::Common

Signed-off-by: Christian Ebner --- version 4: * not present in v3 gen-vzdump.conf.5-opts.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gen-vzdump.conf.5-opts.pl b/gen-vzdump.conf.5-opts.pl index 4e013fb..dc1e0c5 100755 --- a/gen-vzdump.conf.5-opts.pl +++ b/gen

[pve-devel] [patch v4 container 1/1] fix #1291: add option purge for destroy_vm api call

When destroying a CT, we intentionally did not remove all related configs such as backup or replication jobs. The intention of this flag is to allow the removal of such configs on destroy. Signed-off-by: Christian Ebner --- version 4: * no changes since v3 src/PVE/API2/LXC.pm | 17

[pve-devel] [PATCH v4 guest-common 1/2] vzdump: move registration of vzdump.cron from manager to guest-common to avoid cyclic dependency

: Christian Ebner --- version 4: * not present in v3 Makefile | 1 + PVE/VZDump/Common.pm | 391 +++ 2 files changed, 392 insertions(+) create mode 100644 PVE/VZDump/Common.pm diff --git a/Makefile b/Makefile index c5a5967..47ac8a6 100644

[pve-devel] [PATCH v4 manager 1/2] vzdump: move code needed for cfs register of vzdump.cron to guest-common

This removes the cfs register code for vzdump.cron, now located in pve-guest-common. It therefore relies on the corresponding patches in pve-guest-common be6bd58a51f2bba931136595b93cb1ad41b0abdd and pve-docs 82af9e5b9a7f620356e46c76f324c1a425964243 as build dependencies. Signed-off-by: Christian

[pve-devel] [patch v4 qemu 1/1] fix #1291: add option purge for vm_destroy api call

When destroying a VM, we intentionally did not remove all related configs such as backup or replication jobs. The intention of this flag is to allow the removal of such configs on destroy. Signed-off-by: Christian Ebner --- version 4: * no changes since v3 PVE/API2/Qemu.pm | 19

[pve-devel] [PATCH v4 0/7] add purge option for VM/CT destroy

vzdump.cron to pve-guest-common to avoid a cyclic dependency. Christian Ebner (2): vzdump: move registration of vzdump.cron from manager to guest-common to avoid cyclic dependency fix #1291: implement remove_vmid_from_backup_jobs Makefile | 1 + PVE/VZDump/Common.pm | 391

Re: [pve-devel] [PATCH manager 3/4] spice: Add enhancements to VM Options panel

> On September 16, 2019 2:44 PM Stefan Reiter wrote: > > > On 9/13/19 3:16 PM, Aaron Lauterer wrote: > > Signed-off-by: Aaron Lauterer > > --- > > www/manager6/Utils.js| 18 ++ > > www/manager6/qemu/Options.js | 13 + > > 2 files changed, 31 insertions

Re: [pve-devel] [PATCH v3 guest-common 1/2] fix #1291: implement remove_vmid_from_backup_jobs

Okay, sounds good to me, I will prepare a v4. Thanks for the feedback! > On September 5, 2019 10:01 AM Fabian Grünbichler > wrote: > > > On September 4, 2019 4:41 pm, Thomas Lamprecht wrote: > > On 01.07.19 15:43, Christian Ebner wrote: > >> remove_vmi

Re: [pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

8/19 9:42 AM, Thomas Lamprecht wrote: > >> On 27.08.19 16:31, Aaron Lauterer wrote: > >>> On 8/27/19 12:27 PM, Christian Ebner wrote: > >>>> Signed-off-by: Christian Ebner > >>> > >>>> +In contrast to Linux virtual bridges, OVS bridges

[pve-devel] [PATCH docs] pve-network: add short section explaining Open vSwitch

Signed-off-by: Christian Ebner --- pve-network.adoc | 140 ++- 1 file changed, 139 insertions(+), 1 deletion(-) diff --git a/pve-network.adoc b/pve-network.adoc index b2dae97..e8f17af 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -489,7

[pve-devel] [PATCH firewall] firewall macros: add new Ceph protocol v2 port while keeping v1 port

Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index c946040..0c34439 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -214,7 +214,10 @@ my $pve_fw_macros = { ], '

Re: [pve-devel] Wrong path for ipset

Thank you for testing and reporting! We did notice this and fixed it with https://git.proxmox.com/?p=pve-firewall.git;a=commit;h=c1031ab16cda7208eb161c891eceac31976a74b9 Best regards, Chris > On July 12, 2019 12:33 PM Caspar Smit wrote: > > > Hi, > > This commit changes the path for ipset

[pve-devel] [PATCH v3 qemu 5/7] Newline cleanup

Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 9 - 1 file changed, 9 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e2a63be..5bdd052 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1436,7 +1436,6 @@ __PACKAGE__->register_met

[pve-devel] [PATCH v3 manager 7/7] fix #1291: add purge checkbox to VM/CT destroy dialog

Signed-off-by: Christian Ebner --- www/manager6/window/SafeDestroy.js | 12 1 file changed, 12 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index eb3e6665..ef867deb 100644 --- a/www/manager6/window/SafeDestroy.js +++ b/www

[pve-devel] [PATCH v3 container 4/7] fix #1291: add option purge for destroy_vm api call

When destroying a CT, we intentionally did not remove all related configs such as backup or replication jobs. The intention of this flag is to allow the removal of such configs on destroy. Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 17 ++--- 1 file changed, 14

[pve-devel] [PATCH v3 qemu 6/7] fix #1291: add option purge for vm_destroy api call

When destroying a VM, we intentionally did not remove all related configs such as backup or replication jobs. The intention of this flag is to allow the removal of such configs on destroy. Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 19 +++ 1 file changed, 15

[pve-devel] [PATCH v3 0/7] add purge option for VM/CT destroy

When destroying a VM/CT, we intentionally did not remove all related configs such as backup or replication jobs. The intention of this flag is to allow the removal of such configs on destroy. Christian Ebner (2): fix #1291: implement remove_vmid_from_backup_jobs fix #1291: implement

[pve-devel] [PATCH v3 container 3/7] Newline cleanups

Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 4 1 file changed, 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index cf14d75..1561cfe 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -636,16 +636,12 @@ __PACKAGE__->register_met

[pve-devel] [PATCH v3 guest-common 2/2] fix #1291: implement remove_vmid_jobs for ReplicationConfig

Allows to remove replication jobs from the config based on the vmid. Signed-off-by: Christian Ebner --- PVE/ReplicationConfig.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index d597799..e58597e 100644 --- a/PVE

[pve-devel] [PATCH v3 guest-common 1/2] fix #1291: implement remove_vmid_from_backup_jobs

remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs, excluding the given vmid. Signed-off-by: Christian Ebner --- PVE/VZDump/Plugin.pm | 46 1 file changed, 46 insertions(+) diff --git a/PVE/VZDump/Plugin.pm b/PVE/VZDump/Plugin.pm index

[pve-devel] [RFC v2 0/3] fix #1291: add purge option for VM/CT destroy

The purge flag allows to remove the vmid from the vzdump.cron backup jobs on VM/CT destruction. Christian Ebner (1): fix #1291: implement remove_vmid_from_backup_jobs PVE/VZDump/Plugin.pm | 46 1 file changed, 46 insertions(+) Christian Ebner (1

[pve-devel] [RFC v2 qemu 2/3] fix #1291: add purge option to vm_destroy api call

The purge flag allows to remove the vmid from the vzdump.cron backup jobs. Signed-off-by: Christian Ebner --- version 2: * s/remove_vmid_from_cronjobs/remove_vmid_from_backup_jobs/ PVE/API2/Qemu.pm | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/PVE

[pve-devel] [RFC v2 container 3/3] fix #1291: add option purge for destroy_vm api call

The purge option allows to remove the vmid from the vzdump.cron jobs. Signed-off-by: Christian Ebner --- version 2: * s/remove_vmid_from_cronjobs/remove_vmid_from_backup_jobs/ src/PVE/API2/LXC.pm | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2

[pve-devel] [RFC v2 guest-common 1/3] fix #1291: implement remove_vmid_from_backup_jobs

remove_vmid_from_backup_jobs updates the vzdump.cron backup jobs, excluding the given vmid. Signed-off-by: Christian Ebner --- version 2: * refactored remove_vmid_form_list * s/exclude/remove/ * s/cron_cfg/vzdump_jobs/ * refactored closure PVE/VZDump/Plugin.pm | 46

[pve-devel] [RFC qemu 2/3] fix #1291: add purge option to vm_destroy api call

The purge flag allows to remove the vmid from the vzdump.cron backup jobs. Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index a628a20..60b0f11 100644 --- a/PVE/API2

[pve-devel] [RFC 0/3] fix #1291: add purge option for VM/CT destroy

The purge flag allows to remove the vmid from the vzdump.cron backup jobs on VM/CT destruction. Christian Ebner (1): fix #1291: implement remove_vmid_from_cronjobs PVE/VZDump/Plugin.pm | 51 +++ 1 file changed, 51 insertions(+) Christian Ebner

[pve-devel] [RFC guest-common 1/3] fix #1291: implement remove_vmid_from_cronjobs

remove_vmid_from_cronjobs updates the vzdump.cron backup jobs, excluding the given vmid. Signed-off-by: Christian Ebner --- PVE/VZDump/Plugin.pm | 51 +++ 1 file changed, 51 insertions(+) diff --git a/PVE/VZDump/Plugin.pm b/PVE/VZDump/Plugin.pm

[pve-devel] [RFC container 3/3] fix #1291: add option purge for destroy_vm api call

The purge option allows to remove the vmid from the vzdump.cron jobs. Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index cf14d75..563cfb9 100644 --- a/src/PVE/API2

[pve-devel] [PATCH manager] backup jobs: Aquire lock before modifying vzdump.cron

Signed-off-by: Christian Ebner --- PVE/API2/Backup.pm | 108 + 1 file changed, 59 insertions(+), 49 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 3dfe8a0d..141402b1 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2

[pve-devel] [PATCH ha-manager] fix #2234: fix typo in service description

replace Ressource by Resource Signed-off-by: Christian Ebner --- debian/pve-ha-crm.service | 2 +- debian/pve-ha-lrm.service | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/pve-ha-crm.service b/debian/pve-ha-crm.service index 800ce9b..b54992f 100644 --- a/debian

[pve-devel] [PATCH v5 manager] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to qemu-server to pass parameter verification and correct parsing. Signed-off-by: Christian Ebner --- Version 5: * As discussed offline

[pve-devel] [PATCH v4 manager 2/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to qemu-server to pass parameter verification and correct parsing. Signed-off-by: Christian Ebner --- Version 4: * Cleaner code by the

[pve-devel] [PATCH v4 qemu 1/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to pve-manager to obtain base64 encoded values. Signed-off-by: Christian Ebner --- Version 4: * Improved regex for base64 encoded

[pve-devel] [PATCH v4 0/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided, backwards compatibility is maintained. Christian Ebner (1): fix #2190: Base64 encode SMBIOS value strings in order to allow more characters PVE

[pve-devel] [PATCH qemu 1/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to pve-manager to obtain base64 encoded values. Signed-off-by: Christian Ebner --- Version 3: * use base64 instead of URL encoding

[pve-devel] [PATCH manager 2/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided. Relies on the corresponding patch to qemu-server to pass parameter verification and correct parsing. Signed-off-by: Christian Ebner --- Version 3: * use base64 encoding

[pve-devel] [PATCH 0/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

corresponding fields in the structure type 1 (System Information). By base64 encoding the values clashing of the config is avoided, backwards compatibility is maintained. Christian Ebner (1): fix #2190: Base64 encode SMBIOS value strings in order to allow more characters PVE/QemuServer.pm

[pve-devel] [PATCH firewall] Remove redundant logging of packets passing the tap chain.

Incomming and outgoing packets passing the firewall bridge were unneccessarily logged, leading to double entries. The first log entry occurred when passing the bridge, the second when the packets fate was decided (ACCEPT/DROP/REJECT). Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 4

Re: [pve-devel] pve-firewall: default loglevel behaviour change

Hi Alexandre, you are right, logging the packets passing the firewall bridge seems a bit overkill and redundant. Will send a patch to fix this. > On May 15, 2019 at 4:08 PM Alexandre DERUMIER wrote: > > > Hi, > > since this commit > > > https://git.proxmox.com/?p=pve-firewall.git;a=blobdi

[pve-devel] [PATCH v2 0/2] URI encode SMBIOS value strings in order to allow more

. Christian Ebner (1): fix #2190: URI encode SMBIOS value strings in order to allow more characters PVE/QemuServer.pm | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) Christian Ebner (1): fix #2190: URI encode SMBIOS value strings in order to allow more

[pve-devel] [PATCH v2 qemu 1/1] fix #2190: URI encode SMBIOS value strings in order to allow more characters

-off-by: Christian Ebner --- Version 2: - Changed format verification to url encoded PVE/QemuServer.pm | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9d560ec..8b2fd49 100644 --- a/PVE

[pve-devel] [PATCH v2 manager 1/1] fix #2190: URI encode SMBIOS value strings in order to allow more characters

verification. Signed-off-by: Christian Ebner --- Version 2: - URI encode SMBIOS values www/manager6/Parser.js | 4 ++-- www/manager6/qemu/Smbios1Edit.js | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index

[pve-devel] [PATCH manager 2/2] fix #2190: allow multiple words separated by whitespaces in SMBIOS manufacturer string

verification. Signed-off-by: Christian Ebner --- www/manager6/qemu/Smbios1Edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/Smbios1Edit.js b/www/manager6/qemu/Smbios1Edit.js index fdb0d150..b482f90d 100644 --- a/www/manager6/qemu/Smbios1Edit.js +++ b/www

[pve-devel] [PATCH qemu 1/2] fix #2190: allow multiple words separated by whitespaces in SMBIOS manufacturer string

On some occasions, e.g. license checking, the manufacturer string for the SMBIOS configuration has to allow for multiple words separated by whitespaces. https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/ Signed-off-by: Christian Ebner --- PVE/QemuServer.pm | 2

[pve-devel] [PATCH 0/2] fix #2190: allow multiple words separated by whitespaces in SMBIOS manufacturer string

Christian Ebner (1): fix #2190: allow multiple words separated by whitespaces in SMBIOS manufacturer string PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Christian Ebner (1): fix: #2190 allow multiple words separated by whitespaces in SMBIOS manufacturer

[pve-devel] Bug #2193

does not mangle with the rule and the hash should be equal. Also, note that the $pve_ebtables_chainname_regex must probably be updated to include the -ARP suffix. If you want I can provide a patch for this, if your intention was different please let us know. --- Best regards, Christian Ebner

Re: [pve-devel] [PATCH qemu] fix: #1075: Restore VM template to VM and try to convert to template.

, only full clones are possible. So the code simply mimics the current behavior, where the user restores to VM and then manually converts to template. This leads to the same result. > On April 24, 2019 at 7:56 PM Thomas Lamprecht wrote: > > > Am 4/19/19 um 12:06 PM schrieb Chr

[pve-devel] [PATCH qemu] fix: #1075: Restore VM template to VM and try to convert to template.

The restore of a backup from a VM template will first restore the VM and then convert the restored VM back into a template. This automatically performes the steps of the current behaviour, where the user has to manually convert the restored VM back to a template. Signed-off-by: Christian Ebner

[pve-devel] [PATCH v2 container] fix: #1075: Correctly restore CT templates form backup

CT. Signed-off-by: Christian Ebner --- Version 2: * Minor changes to improve code readability as suggested * Refactor check if storage supports templates * Omit unneeded call of PVE::LXC::update_lxc_config as the config does not exist after a restore anyway src/PVE/API2/LXC.pm

[pve-devel] [PATCH container] fix: #1075: Correctly restore CT templates form backup

CT. Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 28 src/PVE/LXC/Create.pm | 2 +- 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 5a8a9c9..42e11fb 100644 --- a/src/PVE/API2/LXC.pm +++ b/src

Re: [pve-devel] [RFC firewall 1/3] make verbose a global state

Looks fine, definitely an improvement in readability. > On April 11, 2019 at 3:28 PM Thomas Lamprecht wrote: > > > This is part of the project 'stop the parameter rabbit hole madness' > and tries to make reading the firewall code a little bit easier. > > Here we remove passing $verbose from 44

[pve-devel] [PATCH firewall] fix: Check if VM firewall enabled before generating NICs tap rules

Only if the VM firewall is enabled, the tap rules for each of the NICs should be generated, analogous to the current behaviour for CTs. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/PVE

[pve-devel] [PATCH storage] Status: Include command error in error message when storage activation fails

Signed-off-by: Christian Ebner --- PVE/API2/Storage/Status.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 1b0486a..9a5a952 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/API2/Storage/Status.pm @@ -442,7

[pve-devel] [PATCH manager] ui: Restore.js: Fix error where the textfield did not default to next free VMID

Signed-off-by: Christian Ebner --- www/manager6/window/Restore.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js index d7e1fb3d..870b0dde 100644 --- a/www/manager6/window/Restore.js +++ b/www/manager6/window

[pve-devel] [PATCH i18n] it: Improvements and additions to italian translation

Signed-off-by: Christian Ebner --- it.po | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/it.po b/it.po index 8051363..8e86f29 100644 --- a/it.po +++ b/it.po @@ -63,7 +63,7 @@ msgstr "" #: pmg-gui/js/Navigation

[pve-devel] [PATCH manager] Allow to set the IP broadcast address used to send the WoL packet

In order to send the WoL packet to a specific broadcast domain, the user can define the broadcast address in the config, as fallback 255.255.255.255 is used. By this, the route and therefore the NIC is decided by the kernel. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm| 25

[pve-devel] [PATCH qemu-server] qm create: Set the NICs firewall to enabled by default on container creation

Signed-off-by: Christian Ebner --- PVE/API2/Qemu.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5469089..f9ce355 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -526,6 +526,10 @@ __PACKAGE__->register_met

[pve-devel] [PATCH container] pct create: Set the NICs firewall to enabled by default on container creation

Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 4 1 file changed, 4 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 5a8a9c9..8234df4 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -296,6 +296,10 @@ __PACKAGE__->register_met

[pve-devel] [PATCH manager] fix: #1218 Expose unique MAC address generation on restore of VMs and CTs in UI

Adds a checkbox to the restore window, allowing the user to avoid MAC address collisions when restoring a VM/CT to a different vmid. When restoring to the same vmid the checkbox is not visible. Signed-off-by: Christian Ebner --- www/manager6/window/Restore.js | 10 +- 1 file changed, 9

[pve-devel] [PATCH manager] fix: #1145 enable CT/VM firewall by default on creation via WebUI

Signed-off-by: Christian Ebner --- www/manager6/lxc/Network.js | 1 + www/manager6/qemu/HardwareView.js | 3 ++- www/manager6/qemu/NetworkEdit.js | 6 -- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js index

[pve-devel] [PATCH container] fix: #1218 Add flag 'unique' to pct restore in order to set new MAC addresses to NICs

Signed-off-by: Christian Ebner --- src/PVE/API2/LXC.pm | 9 - src/PVE/LXC/Create.pm | 9 - 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6de121f..3d5460c 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm

[pve-devel] [PATCH manager v2] Allow to set the firewall log rate limit and burst from the UI

Signed-off-by: Christian Ebner --- Version 2: * Values are retained in config while disable/enable * Removed disabling of the textfield and combobox when unchecking enable in order to get the values instead of undefined. * initComponent -> autoLoad: true www/manager6/Makef

Re: [pve-devel] [RFC firewall] allow to enable/disable and modify cluster wide log ratelimits

Looks good! Acknowledged > On March 21, 2019 at 7:59 AM Thomas Lamprecht wrote: > > > Signed-off-by: Thomas Lamprecht > Cc: Christian Ebner > --- > > just a POC, but should all be working, @christian could you take a look at > this? >

[pve-devel] [PATCH manager] Allow to set the firewall log rate limit and burst from the UI

Signed-off-by: Christian Ebner --- www/manager6/Makefile | 1 + www/manager6/grid/FirewallOptions.js | 8 +++ www/manager6/window/FirewallLograteEdit.js | 105 + 3 files changed, 114 insertions(+) create mode 100644 www/manager6/window

[pve-devel] [PATCH docs] Extending the firewall documentation regarding standard rules and logging

Signed-off-by: Christian Ebner --- pve-firewall.adoc | 123 -- 1 file changed, 110 insertions(+), 13 deletions(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index 0781334..286c24b 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc

[pve-devel] [RFC v3 manager] fix: # 2123 Logging of user defined firewall rules

: Christian Ebner --- Version 3: * fieldName -> fieldLabel * set defaults for name and fieldLabel www/manager6/grid/FirewallOptions.js | 20 +++- www/manager6/grid/FirewallRules.js | 17 +++-- 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/

[pve-devel] [PATCH firewall] Remove hard coded rate limit of logged packets

As some users rely on logging of all packets dropped/rejected, this removes the hard coded rate limit. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index f294d36..30e2b4b

Re: [pve-devel] applied: [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

gt; > The patch change the current behaviour on default vm log action, where we > don't have limit currently. > > (and I really need to log all dropped/reject) > > > BTW, are you sure that's it's only limiting logging ? What happen on an > ACCEPT log

[pve-devel] [PATCH docs] Fixed some typos and slight language improvements

Signed-off-by: Christian Ebner --- pve-firewall.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index acaca95..3e417e8 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc @@ -35,7 +35,7 @@ containers. Features like firewall

[pve-devel] [RFC v2 manager 1/1] fix: # 2123 Logging of user defined firewall rules

: Christian Ebner --- Version 2: * Introduced PVE.FirewallLogLevel to share it between FirewallOptions.js and FirewallRules.js * Reordered elements of the array to be in order of the corresponding numeric value from the log_level_hash as defined in pve-firewall/src/PVE

[pve-devel] [RFC docs 0/3] Add logging for user-defined firewall rules

This patches allow to set per rule log-levels for user-defined firewall rules. pve-docs: Christian Ebner (1): fix: #2123 Logging of user defined firewall rules pve-firewall.adoc | 43 +++ 1 file changed, 43 insertions(+) pve-firewall: Christian Ebner

[pve-devel] [RFC docs 1/1] fix: #2123 Logging of user defined firewall rules

Extends the documentation to mention the additional option to define a per-rule log level for user-defined rules. Signed-off-by: Christian Ebner --- pve-firewall.adoc | 43 +++ 1 file changed, 43 insertions(+) diff --git a/pve-firewall.adoc b/pve

[pve-devel] [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

g amount, logging is limited to 1 entry per second. For now the rule has to be created or edited via the pvesh API call or via the firewall config in order to set the log level. Signed-off-by: Christian Ebner --- Version 2: * Added missing $logmsg to PVEFW-FWBRR-IN and PVEFW-FWBR-OUT rules

[pve-devel] [RFC manager] fix: # 2123 Logging of user defined firewall rules

: Christian Ebner --- www/manager6/grid/FirewallRules.js | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js index 85b30371..27795e96 100644 --- a/www/manager6/grid/FirewallRules.js +++ b

[pve-devel] [PATCH docs] Remove all mentions of sheepdog from the docs

As sheepdog is no longer actively maintained according to one of the developers, it is planed to remove it for the upcomming version 6 of Proxmox VE. This removes mentions of sheepdog from the docs. Signed-off-by: Christian Ebner --- api-viewer/apidata.js | 2 -- pve-intro.adoc| 5

Re: [pve-devel] [RFC firewall] fix: #2123 Logging of user defined firewall rules

gt; > On 3/14/19 1:06 PM, Christian Ebner wrote: > > This allows a user to log traffic filtered by a self defined firewall rule. > > Therefore the API is extended to include a 'log' option allow to specify the > > log level for each rule individually. > > &

[pve-devel] [RFC firewall] fix: #2123 Logging of user defined firewall rules

g amount, logging is limited to 1 entry per second. For now the rule has to be created or edited via the pvesh API call or via the firewall config in order to set the log level. Signed-off-by: Christian Ebner --- This is a tentative patch in order to allow fine grained logging of packets dropped b

[pve-devel] [PATCH v6 manager] 1145 Warn if datacenter firewall is disabled

This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 6: * moved FirewallEnableEdit from grid to window folder * use cbind to set the checkbox * use fixed width of 350 for the window

[pve-devel] [PATCH storage] fix #585: remove leftover disks/directory after VM creation failed

When trying to create a qcow2 disk image with a size larger than available on the storage, this will fail. As qemu-img does not clean up the disk afterwards, it needs to be deleted explicitly. Further, the vmid folder is cleaned up once it is empty. Signed-off-by: Christian Ebner --- PVE

[pve-devel] [PATCH v5 manager] 1145 Warn if datacenter firewall is disabled

This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 5: * Removed unneeded fieldDefaults * Removed unneeded fwtype * Put warning text into gettext() www/manager6/Makefile

[pve-devel] [PATCH v4 manager] 1145 Warn if datacenter firewall is disabled

This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 4: * Code refactored to be more declarative as suggested * Removed warning about pve-firewall service not running * Fixed logic

[pve-devel] [PATCH v3 manager] 1145 Warn if datacenter firewall or host firewall service is disabled

This shows a warning when the user edits the host firewall status or the VM/CT firewall status, but the datacenter level firewall is disabled or the pve-firewall service is not running on the host. Signed-off-by: Christian Ebner --- Version 3: * As discussed offline with Dominik and Thomas

Re: [pve-devel] applied: [PATCH qemu-server] Fix 2097 allow to set and pass wwn parameter for ide, sata and scsi disks

Ah, yes sorry for that. Note to myself: include such info in future commit messages. Thx for the feedback! > On February 26, 2019 at 7:58 AM Thomas Lamprecht > wrote: > > > On 2/25/19 5:30 PM, Christian Ebner wrote: > > This allows to set the wwn parameter for ide, s

[pve-devel] [PATCH qemu-server] Fix 2097 allow to set and pass wwn parameter for ide, sata and scsi disks

This allows to set the wwn parameter for ide, sata and scsi disks in the VM config and passes it to the qemu command on execution. Signed-off-by: Christian Ebner --- PVE/QemuServer.pm | 16 1 file changed, 16 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm

[pve-devel] [PATCH container 7/7] 1891 Add zsh command completion generation for pct

Generates the zsh command completion scripts for pct. Signed-off-by: Christian Ebner --- src/Makefile | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/Makefile b/src/Makefile index f68eb5d..b0c30de 100644 --- a/src/Makefile +++ b/src/Makefile @@ -16,6 +16,7

[pve-devel] [PATCH storage] 1891 Add zsh command completion for pvesm

This adds the zsh command completion generation for pvesm. Signed-off-by: Christian Ebner --- Makefile | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8f27cd1..bece3f1 100644 --- a/Makefile +++ b/Makefile @@ -10,6 +10,7 @@ MANDIR=${PREFIX

[pve-devel] [PATCH qemu-server] 1891 Add zsh command completion for qm and qmrestore

This adds the zsh command completion for qm and qmrestore. Signed-off-by: Christian Ebner --- Makefile | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 369e660..bdad719 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,7 @@ MAN1DIR

[pve-devel] [PATCH cluster] 1891 Add zsh command completion for pvecm

This adds the generation of the zsh command completion scripts for pvecm. Signed-off-by: Christian Ebner --- data/PVE/Makefile | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/data/PVE/Makefile b/data/PVE/Makefile index b87a0f8..509f0ea 100644 --- a/data/PVE

  1   2   >