Re: [pve-devel] [pve-zsync] Discussion/Feedback: Extending pve-zsync to handle intervening snapshots

2020-06-15 Thread Wolfgang Link
Hello, I think that's a good idea. However, I am not sure whether the additional flag described in point 1 is necessary, since old jobs already have an independent dest dataset. So the new logic should not conflict it. I think it would be great to rewrite the "snapshot_get" and "snapshot_exist

[pve-devel] [pve-zsync] Discussion/Feedback: Extending pve-zsync to handle intervening snapshots

2020-06-15 Thread Bruce Wainer
Hello, I am considering making an improvement to pve-zsync and submitting it as a patch, but I would like some feedback before doing so. Problem: pve-zsync can't be used multiple times between the same source and destination pool. For example, these two commands are allowed: pve-zsync create --s

[pve-devel] [PATCH widget-toolkit v2 2/4] show Task warnings differently

2020-06-15 Thread Dominik Csapak
tasks can now show also 'WARNINGS: ' filter it out and provide a 'parse_task_status' function for easy reuse Signed-off-by: Dominik Csapak --- src/Utils.js | 17 + src/css/ext6-pmx.css | 4 src/node/Tasks.js| 22 -- 3 files changed, 37 insert

[pve-devel] [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

2020-06-15 Thread Dominik Csapak
but only when the caller gives us the endtime, since the status api call does not give us the endtime Signed-off-by: Dominik Csapak --- changes from v1: * always show duration and calculate the endtime from 'now' src/node/Tasks.js| 1 + src/window/TaskViewer.js | 25 +++

[pve-devel] [PATCH widget-toolkit v2 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

2020-06-15 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v1: * do not truncate the decimal places src/data/ProxmoxProxy.js | 12 1 file changed, 12 insertions(+) diff --git a/src/data/ProxmoxProxy.js b/src/data/ProxmoxProxy.js index 53e92f3..7df8f28 100644 --- a/src/data/ProxmoxProxy.js +++ b

[pve-devel] [PATCH widget-toolkit v2 4/4] format_duration_human: say <0.1s instead of 0s

2020-06-15 Thread Dominik Csapak
if we get a duration of <=0.1s it should actually be somewhere betweeen 0 and 0.1 so return <0.1s Signed-off-by: Dominik Csapak --- changes from v1: * change <1s to <0.1s which is more inline with our normal display (e.g. 1.5s) src/Utils.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [pve-devel] [PATCH v5 manager 1/2] vzdump: move remaining guest include logic to single method

2020-06-15 Thread Aaron Lauterer
On 6/5/20 8:39 PM, Thomas Lamprecht wrote: On 5/6/20 11:57 AM, Aaron Lauterer wrote: [...] @@ -1169,34 +1158,39 @@ sub get_included_guests { my $nodename = PVE::INotify::nodename(); my $vmids = []; +my $vmids_per_node = {}; + +my $vmlist = PVE::Cluster::get_vmlist();

[pve-devel] applied: [PATCH common] debian/postinst: check for existing /etc/aliases

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 11:14 AM schrieb Stoiko Ivanov: > Signed-off-by: Stoiko Ivanov > --- > Tested by installing libpve-common-perl=6.0-4 on a buster system w/o > /etc/aliases and then installing one with this patch applied (and the > libproxmox-acme-perl dependency removed). > debian/postinst | 2 +- >

[pve-devel] applied: [PATCH pve-manager] api : cluster resources: add sdn audit permission

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:31 PM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Cluster.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm > index 76560fa4..062ca849 100644 > --- a/PVE/API2/Cluster.pm > +++

[pve-devel] applied: [PATCH pve-manager] sdn: browser: fix Permissions.Modify

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 11:58 AM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > www/manager6/sdn/Browser.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.co

[pve-devel] applied: [PATCH pve-access-control] api2: AccessControl: add sdn permissions.modify

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 11:53 AM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/AccessControl.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com h

Re: [pve-devel] [PATCH widget-toolkit 4/4] format_duration_human: say <1s instead of 0s

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:29 PM schrieb Dominik Csapak: > if we get a duration of <=0s it should actually be somewhere > betweeen 0 and 1s so return <1s Hmm, I get where you come from it was initially just as a safe guard and 0s should be understandable as well if start and endtime is shown the same. If we

Re: [pve-devel] [PATCH widget-toolkit 3/4] TaskViewer: show endtime and duration in status

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:29 PM schrieb Dominik Csapak: > but only when the caller gives us the endtime, since the status > api call does not give us the endtime > > Signed-off-by: Dominik Csapak > --- > src/node/Tasks.js| 1 + > src/window/TaskViewer.js | 23 +++ > 2 files ch

Re: [pve-devel] [PATCH widget-toolkit 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

2020-06-15 Thread Thomas Lamprecht
Am 6/12/20 um 1:29 PM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > src/data/ProxmoxProxy.js | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/data/ProxmoxProxy.js b/src/data/ProxmoxProxy.js > index 53e92f3..40fdc08 100644 > --- a/src/data/ProxmoxProxy.

[pve-devel] applied: [PATCH common] fix #2374: bridge-ports is assumed to be defined

2020-06-15 Thread Thomas Lamprecht
Am 6/10/20 um 4:03 PM schrieb Mira Limbeck: > bridge-ports is an optional parameter but was assumed to be defined in > the code. This resulted in 'use of uninitialized value' warnings. > > By reordering of the $ports definition before the replace, we get rid of > the 'use of uninitialized value' w

Re: [pve-devel] [PATCH v2 storage 05/13] Add prune_backups to storage API

2020-06-15 Thread Thomas Lamprecht
Am 6/10/20 um 1:23 PM schrieb Fabian Ebner: > Implement it for generic storages supporting backups > (i.e. directory-based storages) and add a wrapper for PBS. > > Signed-off-by: Fabian Ebner > --- > > Changes in v2: > * Return actual volid in PBS using the new print_volid helper > * Spl

[pve-devel] RFC: sdn: add ip management (IPAM -DHCP) ideas

2020-06-15 Thread Alexandre DERUMIER
Hi, the sdn beta seem to works fine currently, I think the model is good enough to handle users need. I'm already thinking about the next step: ip management (ipam) && dhcp. The main idea is to be able to defined subnets with pools of address ip on vnets, and when user create a vm on this vnet

Re: [pve-devel] [PATCH v2 storage 03/13] Add archive_remove

2020-06-15 Thread Thomas Lamprecht
Am 6/10/20 um 1:23 PM schrieb Fabian Ebner: > to keep the removal of the archive and its log file together. > > Signed-off-by: Fabian Ebner > --- > > New in v2 > > PVE/Storage.pm | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index ac0d