[pve-devel] applied: [PATCH container] allow reading snapshot config for VM.Audit

2020-01-31 Thread Thomas Lamprecht
On 1/31/20 11:40 AM, Dominik Csapak wrote: > VM.Audit can see the current config and the list of snapshots > already, so there is no real reason to disallow > the config of snapshots > > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/LXC/Snapshot.pm | 2 +- > 1 file changed, 1 insertion(+),

[pve-devel] applied: [PATCH manager] gui: do not allow to edit 'special' roles

2020-01-31 Thread Thomas Lamprecht
On 1/31/20 11:48 AM, Dominik Csapak wrote: > since any change to them is currently silently ignored by the backend > and should result in an error anyway > > partially fixes #2575 > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/RoleView.js | 10 +++--- > 1 file changed, 3 insertio

[pve-devel] applied: [PATCH manager] ui CT Features: add checkbox for new "allow mknod device creation in CT"

2020-01-31 Thread Thomas Lamprecht
note that it's experimental.. Signed-off-by: Thomas Lamprecht --- www/manager6/lxc/FeaturesEdit.js | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/lxc/FeaturesEdit.js b/www/manager6/lxc/FeaturesEdit.js index f53e8d27..63cd41a7 100644 --- a/www/manager6/lxc

[pve-devel] applied-series: [PATCH qemu-server 1/2] move the vmgenid device after readconfig on q35

2020-01-31 Thread Thomas Lamprecht
On 1/31/20 3:41 PM, Dominik Csapak wrote: > and adapt the tests > > this does not impact live migration, since the order here does not > change the device layout > > we want this to consistently have the readconfig first > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.pm

[pve-devel] applied: [PATCH access-control] fix #2575: die when trying to edit built-in roles

2020-01-31 Thread Thomas Lamprecht
On 1/31/20 11:54 AM, Dominik Csapak wrote: > instead of silently ignoring the change > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Role.pm | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm > index 83e4a9d..70a92b6 100644 > -

[pve-devel] applied: [PATCH qemu-server] allow reading snapshot config for VM.Audit

2020-01-31 Thread Thomas Lamprecht
On 1/31/20 11:40 AM, Dominik Csapak wrote: > VM.Audit can see the current config and the list of snapshots > already, so there is no real reason to disallow > the config of snapshots > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[pve-devel] applied-series: [PATCH container 0/4] use seccomp proxy to handle mknod for

2020-01-31 Thread Thomas Lamprecht
On 1/30/20 9:27 AM, Wolfgang Bumiller wrote: > This series adds an `mknod` feature flag for unprivileged containers > which is handled by setting `lxc.seccomp.proxy.notify` to point to the > socket where pve-lxc-syscalld is listening (and `….proxy.cookie` to > the vmid for possible future use). >

[pve-devel] [PATCH manager v2 2/2] Fix #2124: Add zstd pkg as install dependency

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index bcc6bb6e..497395da 100644 --- a/debian/control +++ b/debian/control @@ -60,6 +60,7 @@ Depends: apt-transport-https | apt (>= 1.5~), logrotate,

[pve-devel] [PATCH qemu-server v2 1/2] restore: replace archive regex

2020-01-31 Thread Alwin Antreich
to reduce the code duplication, as archive_info provides the same information as well. Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 7374bf1

[pve-devel] [PATCH qemu-server v2 2/2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ff7dcab..8af1cb6 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7217,7 +7217,7 @@ sub complete_backup_archives { my

[pve-devel] [PATCH manager v2 1/2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
Adds the zstd to the compression selection for backup on the GUI and the .zst extension to the backup file filter. Signed-off-by: Alwin Antreich --- PVE/VZDump.pm| 6 -- www/manager6/form/CompressionSelector.js | 3 ++- 2 files changed, 6 insertions(+), 3 deletio

[pve-devel] [PATCH storage v2 1/3] compact regex for backup file filter

2020-01-31 Thread Alwin Antreich
this, more compact form of the regex should allow easier addition of new file extensions. Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 2 +- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 0bd103e..

[pve-devel] [PATCH guest-common v2] Fix: #2124 add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/VZDump/Common.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..a661552 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE/VZDump/Common.pm @@ -88,7 +88,7 @@ my $confdesc = { typ

[pve-devel] [PATCH storage v2 2/3] storage: merge archive format/compressor

2020-01-31 Thread Alwin Antreich
detection into a separate function to reduce code duplication and allow for easier modification. Signed-off-by: Alwin Antreich --- PVE/Storage.pm | 78 -- 1 file changed, 57 insertions(+), 21 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.

[pve-devel] [PATCH storage v2 3/3] Fix: #2124 storage: add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage.pm| 10 +++--- PVE/Storage/Plugin.pm | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index bf12634..51c8bc9 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -514,7 +514,7 @@ sub

[pve-devel] [PATCH container v2] Fix #2124: Add support for zstd

2020-01-31 Thread Alwin Antreich
This seems to me as a totally new try, since so much time has passed. :) Zstandard (zstd) [0] is a data compression algorithm, in addition to gzip, lzo for our backup/restore. v1 -> v2: * factored out the decompressor info first, as Thomas suggested * made the regex pattern of backup file

[pve-devel] [PATCH container v2] Fix: #2124 add zstd support

2020-01-31 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- v1 -> v2: less code changes for container restores src/PVE/LXC/Create.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index c13f30d..65d5068 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -7

[pve-devel] [PATCH qemu-server 1/2] move the vmgenid device after readconfig on q35

2020-01-31 Thread Dominik Csapak
and adapt the tests this does not impact live migration, since the order here does not change the device layout we want this to consistently have the readconfig first Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 8 test/cfg2cmd/pinned-versi

[pve-devel] [PATCH qemu-server 2/2] fix #2566: increase scsi limit to 31

2020-01-31 Thread Dominik Csapak
to achieve this we have to add 3 new scsihw addresses since lsi controllers can only hold 7 scsi drives we go up to 31, since this is the limit for virtio-scsi-single devices we have reserved (we can increase this in the future) to make it more future proof, we add a new pci bridge under pci brid

[pve-devel] applied: [PATCH kernel] backport fixes for information leak within a KVM guest

2020-01-31 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- ...w-Reserved-types-to-be-overwritten-i.patch | 1 + ...ul-not-to-clear-KVM_VCPU_FLUSH_TLB-b.patch | 38 +++ ...09-x86-kvm-Introduce-kvm_-un-map_gfn.patch | 111 +++ ...x86-kvm-Cache-gfn-to-pfn-translation.patch | 292 ++ ...e-KVM_VCPU_FL

[pve-devel] [PATCH access-control] fix #2575: die when trying to edit built-in roles

2020-01-31 Thread Dominik Csapak
instead of silently ignoring the change Signed-off-by: Dominik Csapak --- PVE/API2/Role.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index 83e4a9d..70a92b6 100644 --- a/PVE/API2/Role.pm +++ b/PVE/API2/Role.pm @@ -126,11 +126,14

[pve-devel] [PATCH manager] gui: do not allow to edit 'special' roles

2020-01-31 Thread Dominik Csapak
since any change to them is currently silently ignored by the backend and should result in an error anyway partially fixes #2575 Signed-off-by: Dominik Csapak --- www/manager6/dc/RoleView.js | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/www/manager6/dc/RoleView.

[pve-devel] [PATCH qemu-server] allow reading snapshot config for VM.Audit

2020-01-31 Thread Dominik Csapak
VM.Audit can see the current config and the list of snapshots already, so there is no real reason to disallow the config of snapshots Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 8

[pve-devel] [PATCH container] allow reading snapshot config for VM.Audit

2020-01-31 Thread Dominik Csapak
VM.Audit can see the current config and the list of snapshots already, so there is no real reason to disallow the config of snapshots Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC/Snapshot.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/LXC/Snapshot.pm b/