On 9/20/19 9:00 AM, Thomas Lamprecht wrote:
On 18.09.19 12:22, Dominik Csapak wrote:
lgtm, i find it understandable that the 'spice enhancments' are disabled
because spice is not selected, but maybe someone else has a comment on that?
IMO this is highly confusing and bad UX... The fields re
merging $conf->{lxc} causes lxc.idmap entries to be duplicated in the
restored configuration. instead, we can overwrite the contents from the
extracted configuration file. this way we don't duplicate these entries.
(having duplicate idmap entries causes container to crash during start)
Co-develope
The fix introduced in commit bf4a933 did not work as intended. We're
iterating over the $oldconf, not over $virtdev_hash. This means
$drive->{is_cloudinit} is always undefined. Instead use the more costly
call to drive_is_cloudinit.
Signed-off-by: Mira Limbeck
---
Tested on PVE 6 and 5.
PVE/Qem
Now that it can be saved without enabling USB3 I found another issue :/
If I save a USB3 dev or port passthrough without USB3 enabled, it is
done so as expected. Once I open the edit dialog of that device again
the USB3 checkbox is checked again on load. This means that the form is
changed and