> On September 16, 2019 2:44 PM Stefan Reiter wrote:
>
>
> On 9/13/19 3:16 PM, Aaron Lauterer wrote:
> > Signed-off-by: Aaron Lauterer
> > ---
> > www/manager6/Utils.js| 18 ++
> > www/manager6/qemu/Options.js | 13 +
> > 2 files changed, 31 insertions
Tried my hand at a proper code review, I like the patches in general.
On 9/13/19 3:16 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js | 66 +++
2 files changed, 67
Akin to what you mentioned on the cover, there's a connection missing
between the "Graphic card" field and the SPICE ones - there is no clear
indication of *why* they are disabled by default in a new VM.
Maybe make it a section of some sort titled "SPICE"?
On 9/13/19 3:16 PM, Aaron Lauterer wr
On 9/13/19 3:16 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js| 18 ++
www/manager6/qemu/Options.js | 13 +
2 files changed, 31 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 6a489e7e..139
On 9/16/19 9:46 AM, Fabian Ebner wrote:
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index b30931d..ab5912c 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3341,6 +3341,9 @@ __PACKAGE__->re
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index b30931d..ab5912c 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3341,6 +3341,9 @@ __PACKAGE__->register_method({
if (PVE::QemuServer:
On 9/12/19 11:03 AM, Fabian Ebner wrote:
On 9/11/19 1:18 PM, Thomas Lamprecht wrote:
On 11.09.19 11:46, Fabian Ebner wrote:
Migration with --targetstorage was broken because of this.
Signed-off-by: Fabian Ebner
---
PVE/Storage.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
d
