Re: [pve-devel] Bug #2193

2019-04-30 Thread Alexandre DERUMIER
>>@Alexandre: Does the assumption is correct, that you simply want to allow >>only the one source ip, here 10.0.0.1? If I remember, I'm using netX ip interface from ct.conf + ipfilter ips address from ct.fw. Can you send both files configuration ? - Mail original - De: "Christian Ebn

[pve-devel] Bug #2193

2019-04-30 Thread Christian Ebner
It seems that the ARP filtering with ebtables introduced a bug: https://bugzilla.proxmox.com/show_bug.cgi?id=2193 After some digging, it turned out that the problem is that ebtables masks the provided arp-ip-src address. So while the provided rule looks like this: -A veth100i0-OUT-ARP -p ARP --ar

Re: [pve-devel] [PATCH qemu-server v7 2/3] add QemuMigrateExternal.pm

2019-04-30 Thread Thomas Lamprecht
in general: please reorder patch 1 and 2, as the API entry depends on the QemuMigrateExternal to exist. Am 4/29/19 um 12:01 PM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/Makefile | 1 + > PVE/QemuMigrateExternal.pm | 340 > +++

Re: [pve-devel] [PATCH qemu-server 14/15] phase3_cleanup: add delete_local_volumes

2019-04-30 Thread Thomas Lamprecht
Am 4/30/19 um 4:07 PM schrieb Alexandre DERUMIER: >> -my $conf = $self->{vmconf}; >> return if $self->{phase2errors}; >> >> -my $tunnel = $self->{tunnel}; >> - > >>> above does probably not belongs in this patch, I'd guess. > > As it was the last sub in the phase, they were not us

Re: [pve-devel] [PATCH qemu-server 14/15] phase3_cleanup: add delete_local_volumes

2019-04-30 Thread Alexandre DERUMIER
> -my $conf = $self->{vmconf}; > return if $self->{phase2errors}; > > -my $tunnel = $self->{tunnel}; > - >>above does probably not belongs in this patch, I'd guess. As it was the last sub in the phase, they were not used anymore. but I can make an extra patch if you want. -

Re: [pve-devel] [PATCH qemu-server 14/15] phase3_cleanup: add delete_local_volumes

2019-04-30 Thread Thomas Lamprecht
Am 4/29/19 um 12:01 PM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuMigrate.pm | 36 +++- > 1 file changed, 19 insertions(+), 17 deletions(-) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 4b521fd..6dd97e3 10064

[pve-devel] applied: [PATCH widget-toolkit] reduce syslog api calls

2019-04-30 Thread Thomas Lamprecht
Am 4/30/19 um 3:03 PM schrieb Dominik Csapak: > do not poll the syslog api call multiple times simultaneously, > since it can be very costly, depending on the journal size > > with this, there is always only one per client > > Signed-off-by: Dominik Csapak > --- > panel/LogView.js | 7 ++- >

[pve-devel] applied: [PATCH v2 qemu-server] fix #2173: use file_size_info to check existence

2019-04-30 Thread Thomas Lamprecht
initially just wanted to review but to finaly move this forward: applied comments still inline, can you please answer the question about the second file info call? because I just threw a few followup on top, and it would be great to verify that I did not missed anything ;-) Am 4/30/19 um 2:20 PM s

Re: [pve-devel] [PATCH v2 qemu-server] fix #2173: use file_size_info to check existence

2019-04-30 Thread Dietmar Maurer
maybe it is worth to introduce a volume_exists() helper? > On 30 April 2019 at 14:20 Mira Limbeck wrote: > > > use file_size_info to check for existence of cloudinit disk instead of > '-e'. this should solve the problem with rbd where the path returned by > PVE::Storage::path is not checkable w

[pve-devel] [PATCH widget-toolkit] reduce syslog api calls

2019-04-30 Thread Dominik Csapak
do not poll the syslog api call multiple times simultaneously, since it can be very costly, depending on the journal size with this, there is always only one per client Signed-off-by: Dominik Csapak --- panel/LogView.js | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/p

[pve-devel] [PATCH v2 qemu-server] fix #2173: use file_size_info to check existence

2019-04-30 Thread Mira Limbeck
use file_size_info to check for existence of cloudinit disk instead of '-e'. this should solve the problem with rbd where the path returned by PVE::Storage::path is not checkable with '-e'. Any size > 0 is interpreted as the image existing. Signed-off-by: Mira Limbeck --- v2: - switched to file_

[pve-devel] applied: [PATCH pve-firewall] fix ipv6 PVEFW-reject

2019-04-30 Thread Thomas Lamprecht
Am 4/29/19 um 4:18 PM schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > src/PVE/Firewall.pm | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index 1607b74..806fd4b 100644 > --- a/src/PVE/Firewall.pm