[pve-devel] [PATCH qemu-server] fix #2131: get correct device when deleting iothreads

2019-03-13 Thread Dominik Csapak
we map scsiX to virtioscsiX/scsihwX when we use virtio-scsi-single to add and iothread so we have to map it back when we delete an iothread, else the parsing fails with 'invalid drive key: virtioscsi0' Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 6 +- 1 file changed, 5 insertions(

Re: [pve-devel] [PATCH qemu-server v2 3/6] implement suspend to disk for running vms

2019-03-13 Thread Thomas Lamprecht
On 3/13/19 9:55 AM, Dominik Csapak wrote: > the idea is to have the same logic as with snapshots, but without > the snapshotting of the disks, and after saving the vm state (incl memory), > we hard shut off the guest. > > this way the disks will not be touched anymore by the guest > > to prevent

[pve-devel] [PATCH v3 cluster 1/2] cluster: add cfs_lock_authkey

2019-03-13 Thread Fabian Grünbichler
used for authkey rotation in pve-access-control Signed-off-by: Fabian Grünbichler --- Notes: unchanged since v1 data/PVE/Cluster.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index e52bf9d..83b401c 100644 --- a/data/PVE/Cluster.pm +++

[pve-devel] [PATCH v3 access-control 1/2] fix #2079: add periodic auth key rotation

2019-03-13 Thread Fabian Grünbichler
and modify checks to accept still valid tickets generated using the previous auth key. the slightly complicated caching mechanism is needed for reading the key and its modification timestamp in one go while only reading and parsing it again if it has changed. the +- 300 seconds fuzzing is kept fo

[pve-devel] [PATCH v3 cluster 2/2] cluster: use lock for legacy authkey generation

2019-03-13 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- Notes: changes since v2: - make error handling more readable data/PVE/Cluster.pm | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 83b401c..e641cc1 100644 --- a/data/PVE/Clu

[pve-devel] [PATCH v3 manager] pvestatd: rotate auth keys if necessary

2019-03-13 Thread Fabian Grünbichler
as a fallback to ensure rotation even if no logins happen on a given cluster. Signed-off-by: Fabian Grünbichler --- Notes: VERSIONED DEPENDENCY: pve-access-control with auth key rotation patch unchanged since v2 PVE/Service/pvestatd.pm | 12 1 file changed, 12 insertio

[pve-devel] [PATCH v3 access-control 2/2] add postinst script

2019-03-13 Thread Fabian Grünbichler
to reset auth key age until the first rotation has happened, otherwise all currently existing tickets get invalidated immediately once the rotation code gets enabled. disabled until first PVE 6.0 package release Signed-off-by: Fabian Grünbichler --- Notes: new in v3 debian/postinst | 25 ++

[pve-devel] [PATCH v3 access-control/cluster/manager 0/5] auth key rotation

2019-03-13 Thread Fabian Grünbichler
changes since v2: - clean up error handling for calls to cfs_lock_authkey - disable rotation until PVE 6.0 - add posinst for smoother upgrading once rotation gets enabled changes since v1: - add rotation in pvestatd - accept tickets signed with current key if cluster is not quorate (no rotation p

[pve-devel] applied: [PATCH manager 1/2] pvereport: add ip route information

2019-03-13 Thread Thomas Lamprecht
On 3/8/19 10:23 AM, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 375c5aa3..9ad6e915 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -37,6 +37,7 @@ my $report_

Re: [pve-devel] [PATCH manager] add host firewall config to pvereport

2019-03-13 Thread Thomas Lamprecht
On 3/13/19 1:15 PM, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 375c5aa3..78ad27f8 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -41,6 +41,7 @@ my $report_def = { > ]

[pve-devel] [PATCH manager] add host firewall config to pvereport

2019-03-13 Thread Tim Marx
Signed-off-by: Tim Marx --- PVE/Report.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Report.pm b/PVE/Report.pm index 375c5aa3..78ad27f8 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -41,6 +41,7 @@ my $report_def = { ], firewall => [ sub { dir2text('/etc/pve/fire

[pve-devel] applied: [PATCH firmware] minimize skip list for current fw submodule version

2019-03-13 Thread Fabian Grünbichler
On Tue, Mar 12, 2019 at 11:39:17AM +0100, Thomas Lamprecht wrote: > As once added to the list we never check if it'd be available now we > have some unnecessary entries in the skip list, which this patch > cleans up. Produced by deleting all skip list entries and successive > re-adding them by doin

[pve-devel] applied: [PATCH v6 manager] 1145 Warn if datacenter firewall is disabled

2019-03-13 Thread Thomas Lamprecht
On 3/13/19 9:57 AM, Christian Ebner wrote: > This warns the user that the datacenter firewall is disabled when editing the > host or the VM/CT firewall status. > applied, thanks! Please try to use the "fix #XYZ: ..." format in the commit subject for such fixes, just the number alone without anyth

[pve-devel] [PATCH v6 manager] 1145 Warn if datacenter firewall is disabled

2019-03-13 Thread Christian Ebner
This warns the user that the datacenter firewall is disabled when editing the host or the VM/CT firewall status. Signed-off-by: Christian Ebner --- Version 6: * moved FirewallEnableEdit from grid to window folder * use cbind to set the checkbox * use fixed width of 350 for the window

[pve-devel] [PATCH qemu-server v2 5/6] add ability to suspend a vm to disk from the api

2019-03-13 Thread Dominik Csapak
this enables the use of the suspend to disk code Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 49aaa48..8448ac4 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -23

[pve-devel] [PATCH qemu-server v2 2/6] correct comment about size

2019-03-13 Thread Dominik Csapak
and remove comment that makes no sense Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1d1b687..02bb798 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7123,8 +7123,7

[pve-devel] [PATCH qemu-server v2 6/6] add statestorage parameter to suspend API

2019-03-13 Thread Dominik Csapak
this makes it possible to give a storage for state saving, if one wants to use a different storage than for snapshots or does not want to save this info into the config Signed-off-by: Dominik Csapak --- new in v2 the reordering of the parameters of prepare_save_vmstate is ok since we just added

[pve-devel] [PATCH qemu-server v2 4/6] resume suspended vm on start

2019-03-13 Thread Dominik Csapak
if a vm has the 'suspend' lock, we resume with the saved state and remove the lock, the saved vmstate and the saved runningmachine after the vm started Signed-off-by: Dominik Csapak --- changes from v1: * pull out has_lock * better comment * better variable naming * more consise deletion of hash

[pve-devel] [PATCH qemu-server v2 3/6] implement suspend to disk for running vms

2019-03-13 Thread Dominik Csapak
the idea is to have the same logic as with snapshots, but without the snapshotting of the disks, and after saving the vm state (incl memory), we hard shut off the guest. this way the disks will not be touched anymore by the guest to prevent any alteration of the vm (incl migration, hw changes, et

[pve-devel] [PATCH qemu-server v2 0/6] implement suspend to disk

2019-03-13 Thread Dominik Csapak
implement suspend to disk for vms the idea is the following: add a 'suspend' lock halt execution of the vm save the vmstate to a file/disk/etc. hard poweroff the vm (qmp quit) on the next start check for 'suspend' lock resume from saved state the lock prevents any changes to the vm that would p

[pve-devel] [PATCH qemu-server v2 1/6] move code of save_vmstate preparation

2019-03-13 Thread Dominik Csapak
we will reuse this later Signed-off-by: Dominik Csapak --- PVE/QemuConfig.pm | 30 +- PVE/QemuServer.pm | 34 ++ 2 files changed, 35 insertions(+), 29 deletions(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index 6ba0cc3..6d701