On Wed, Jan 23, 2019 at 03:38:21PM +0100, Dominik Csapak wrote:
> On 1/23/19 3:29 PM, Fabian Grünbichler wrote:
> > same as qemu-server, I'd limit adding a hookscript to a CT config to
> > root@pam (for now).
>
> yes you are correct
>
> i thought we had the same default as for vms (new ones defau
On Wed, Jan 23, 2019 at 03:34:56PM +0100, Dominik Csapak wrote:
> On 1/23/19 3:27 PM, Fabian Grünbichler wrote:
> > On Mon, Jan 21, 2019 at 09:44:35AM +0100, Dominik Csapak wrote:
> > > this adds a new config option for it, and executes it on four
> > > points in time:
> > >
> > > 'pre-start'
> >
On 1/23/19 2:56 PM, Fabian Grünbichler wrote:
> otherwise there is no way to find out about (all) active tasks over the
> API if their UPIDs were not recorded when the initial API calls happened.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
applied whole series, thanks!
_
Remove directories if they are empty after destroying a VM.
Signed-off-by: Christian Ebner
---
PVE/Storage/Plugin.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index e0c2a4e..00131df 100644
--- a/PVE/Storage/Plugin.pm
+++ b/PVE/Storage/
On Mon, Jan 21, 2019 at 09:44:34AM +0100, Dominik Csapak wrote:
> this can be called from qemu-server/pve-container to execute a hookscript
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/GuestHelpers.pm | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git a/PVE/Gues
On 1/23/19 3:29 PM, Fabian Grünbichler wrote:
same as qemu-server, I'd limit adding a hookscript to a CT config to
root@pam (for now).
yes you are correct
i thought we had the same default as for vms (new ones default to
root@pam only, maybe we should do this for cts also?)
On Mon, Jan 21,
On 1/23/19 3:27 PM, Fabian Grünbichler wrote:
On Mon, Jan 21, 2019 at 09:44:35AM +0100, Dominik Csapak wrote:
this adds a new config option for it, and executes it on four
points in time:
'pre-start'
'post-start'
'pre-stop'
'post-stop'
on pre-start we abort if the script fails
and pre-stop wil
same as qemu-server, I'd limit adding a hookscript to a CT config to
root@pam (for now).
On Mon, Jan 21, 2019 at 09:44:36AM +0100, Dominik Csapak wrote:
> this adds the config (hookscript) and executes it
> on four points in time for the container
>
> the same notes as with vms are in place regar
On Mon, Jan 21, 2019 at 09:44:35AM +0100, Dominik Csapak wrote:
> this adds a new config option for it, and executes it on four
> points in time:
>
> 'pre-start'
> 'post-start'
> 'pre-stop'
> 'post-stop'
>
> on pre-start we abort if the script fails
> and pre-stop will not be called if the vm cra
convenience filter if caller is only interested in certain actions
Signed-off-by: Fabian Grünbichler
Reviewed-by: Thomas Lamprecht
Tested-by: Thomas Lamprecht
---
Notes:
unchanged from v1
PVE/API2/Tasks.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/API2/Tasks.pm b/PV
both task sources use PVE::Tools::upid_decode, which ensures all of the
':' delimited fields are set.
this only leaves 'status' and 'endtime' as optional, which are not set
for currently running tasks.
reorder them in the code for easier matching with their on-disk format.
Signed-off-by: Fabian
otherwise there is no way to find out about (all) active tasks over the
API if their UPIDs were not recorded when the initial API calls happened.
Signed-off-by: Fabian Grünbichler
---
Notes:
changed from v2:
- set fake 'RUNNING' status for tasks from 'active' source
changed from
Signed-off-by: Fabian Grünbichler
---
Notes:
new in v3
PVE/CLI/pvenode.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm
index 9b9ad6d3..647fad19 100644
--- a/PVE/CLI/pvenode.pm
+++ b/PVE/CLI/pvenode.pm
@@ -165,7 +165,7 @@ our $cm
Signed-off-by: Fabian Grünbichler
---
Notes:
new in v3
PVE/CLI/pvenode.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm
index 647fad19..1989e8b3 100644
--- a/PVE/CLI/pvenode.pm
+++ b/PVE/CLI/pvenode.pm
@@ -165,7 +165,9 @@ our
Signed-off-by: Thomas Lamprecht
---
src/PVE/HA/Resources/PVEVM.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
index c5276dc..d07d5c9 100644
--- a/src/PVE/HA/Resources/PVEVM.pm
+++ b/src/PVE/HA/Resources/
Signed-off-by: Friedrich Ramberger
---
certificate-managment.adoc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/certificate-managment.adoc b/certificate-managment.adoc
index 3eabee8..7970f61 100644
--- a/certificate-managment.adoc
+++ b/certificate-managment.adoc
@@ -9,
meta:
it might still make sense to have all those identical options only
defined once (e.g., in a local variable in this module) to prevent
unnecessary churn when adding new commands.
ideally, we would also pull out the mapping from 'cmd' value to actual
command array, so that we only need to upd
service_is_ha_managed returns false if a service is in the resource
configuration but marked as 'ignore', as for the internal stack it is
as it wasn't HA managed at all.
But user should be able to remvoe it from the configuration easily
even in this state, without setting the requesttate to anythi
The vm_shutdown parameter forceStop differs in behaviour between VMs
and CTs. While on VMs it ensures that a VM gets stoppped if it could
not shutdown gracefully only after the timeout passed, the container
stack always ignores any timeout if forceStop is set and hard stops
the CT immediately.
To a
> Dominik Csapak hat am 22. Januar 2019 um 14:19
> geschrieben:
>
>
> hi, looks good, one nitpick inline
>
> On 1/22/19 12:22 PM, Tim Marx wrote:
> > Signed-off-by: Tim Marx
> > ---
> > www/manager6/Utils.js| 21 +
> > www/manager6/button/ConsoleButton.
> Dominik Csapak hat am 22. Januar 2019 um 14:22
> geschrieben:
>
>
> one comment inline, otherwise looks good
>
> On 1/22/19 12:22 PM, Tim Marx wrote:
> > Signed-off-by: Tim Marx
> > ---
> > changed since v2:
> > * whitespace fix
> >
> > www/manager6/Makefile | 1 +
> > ww
21 matches
Mail list logo
