Re: [pve-devel] [PATCH pve-manager 1/2] Nodes: wakeonlan return MAC address send via WOL packet

2019-01-18 Thread Fabian Grünbichler
On Fri, Jan 18, 2019 at 11:13:08AM +0100, Christian Ebner wrote: > The wake on LAN call now returns a string containing the MAC address send in > the > WOL packet. > > Signed-off-by: Christian Ebner > --- > PVE/API2/Nodes.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [pve-devel] [PATCH manager] fix #2058: show correct pool for external ceph clusters

2019-01-18 Thread Friedrich Ramberger
Patch works fine - thx! > On January 18, 2019 at 2:09 PM Dominik Csapak wrote: > > > instead of having two inputfields and displayfields (where only one gets the > correct value), have two inputfileds but one displayfield when we need it > > Signed-off-by: Dominik Csapak > --- > www/manager6

[pve-devel] [PATCH pve-docs] pvenode: add WOL section to doc

2019-01-18 Thread Christian Ebner
Adds a section containing information about the wake on LAN feature to the pvenode documentation. Signed-off-by: Christian Ebner --- pvenode.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index a41085f..df17f93 100644 --- a/pvenode.adoc +++ b/pv

[pve-devel] [PATCH manager] fix #2058: show correct pool for external ceph clusters

2019-01-18 Thread Dominik Csapak
instead of having two inputfields and displayfields (where only one gets the correct value), have two inputfileds but one displayfield when we need it Signed-off-by: Dominik Csapak --- www/manager6/storage/RBDEdit.js | 28 1 file changed, 20 insertions(+), 8 deletion

[pve-devel] [PATCH pve-manager 0/2] Return MAC address on successful WOL packet

2019-01-18 Thread Christian Ebner
Two patches to give some user feedback in form of the MAC address used in the WOL packet. The first makes a change so that the used MAC address is returned by the API call, the second prints the MAC to the user if 'pvenode wakonlan ' returned with success. Christian Ebner (2): Nodes: wakeonlan r

[pve-devel] [PATCH pve-manager 1/2] Nodes: wakeonlan return MAC address send via WOL packet

2019-01-18 Thread Christian Ebner
The wake on LAN call now returns a string containing the MAC address send in the WOL packet. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 7f829b29..2c8bfc35 100644 --- a/PV

[pve-devel] [PATCH pve-manager 2/2] pvenode: Print MAC address used for WOL packet on success

2019-01-18 Thread Christian Ebner
Show the MAC address used in the wake on LAN packet if it was send successfully via 'pvenode wakeonlan '. Signed-off-by: Christian Ebner --- PVE/CLI/pvenode.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index b698d2a5..6fa0870

[pve-devel] applied: [PATCH storage] Fix #2050: only provide 'conv=sparse' for LvmThin

2019-01-18 Thread Thomas Lamprecht
On 1/17/19 4:31 PM, Stoiko Ivanov wrote: > LVMPlugin->volume_import (used during cross-node offline, storage migration) > passed 'conv=sparse' to `dd`. This can lead to data-corruption, if the target > volume is not zero-initialized. > > Dropping the argument fixes the problem, but breaks keeping

[pve-devel] [PATCH pve-manager] Nodes: Check if target node even exists before sending WOL packet

2019-01-18 Thread Christian Ebner
Checks if the specified target node even exists before trying to read its MAC address from the config and sending the wake on LAN magic packet. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 7f8

Re: [pve-devel] [PATCH #1941 qemu-server] Clean up empty image subdirectories on dir based storage on VM destruction

2019-01-18 Thread Christian Ebner
Thanks for the feedback! I totally agree with your reasoning, I was not yet aware of the plugin system. Will implement it in the pve-storage Dir plugin. > On January 18, 2019 at 9:14 AM Thomas Lamprecht > wrote: > > > On 1/17/19 5:10 PM, Christian Ebner wrote: > > No, I had no special reason

Re: [pve-devel] [PATCH #1941 qemu-server] Clean up empty image subdirectories on dir based storage on VM destruction

2019-01-18 Thread Thomas Lamprecht
On 1/17/19 5:10 PM, Christian Ebner wrote: > No, I had no special reason to put it there, I was just looking for the > seemingly easiest place to clean up the directory. > > I will implement it for the Dir plugin if this is more suitable! pve-storage, and its plugin system, is here to abstract t

[pve-devel] applied: [PATCH pve-manager] pvenode: Add CLI call interface for wake on LAN

2019-01-18 Thread Thomas Lamprecht
On 1/17/19 3:46 PM, Christian Ebner wrote: > Adds a CLI call interface to pvenode which allows to wake sleeping nodes in a > cluster via a wake on LAN packet. > > pvenode wakeonlan > > Signed-off-by: Christian Ebner > --- > PVE/CLI/pvenode.pm | 3 +++ > 1 file changed, 3 insertions(+) > > dif