Re: [pve-devel] [PATCH qemu-server] Fix #1650: add content type filter to rescan

2018-07-03 Thread Dietmar Maurer
> Seems not really wrong, IMO, and we use this for pve ceph, where the > same backing storage can get added twice, with and without KRBD to our > storage.cfg by our pool creator UI - one for CT which need KRBD and one > for VMs which normally do not want it. IMHO this is totally wrong and we shoul

Re: [pve-devel] [PATCH qemu-server] Fix #1650: add content type filter to rescan

2018-07-03 Thread Thomas Lamprecht
On 7/3/18 8:28 PM, Dietmar Maurer wrote: > I always tell users that is is dangerous to add the same storage > multiple times (using different names and options). This breaks very > basic assumptions and locking will not work as expected. > Hmm, shouldn't it be totally valid to have two storage e

Re: [pve-devel] [PATCH qemu-server] Fix #1717: delete snapshot when vm running and drive not attached

2018-07-03 Thread Alexandre DERUMIER
any comment ? - Mail original - De: "aderumier" À: "pve-devel" Cc: "aderumier" Envoyé: Samedi 30 Juin 2018 13:18:49 Objet: [PATCH qemu-server] Fix #1717: delete snapshot when vm running and drive not attached if we try to delete a snapshot, and that is disk from the snapshot is not a

Re: [pve-devel] [PATCH qemu-server] Fix #1650: add content type filter to rescan

2018-07-03 Thread Dietmar Maurer
I always tell users that is is dangerous to add the same storage multiple times (using different names and options). This breaks very basic assumptions and locking will not work as expected. Also, the purpose of 'rescan' is to detect all stale volumes. So your patch makes the whole thing pointle

[pve-devel] [PATCH qemu-server] Fix #1650: add content type filter to rescan

2018-07-03 Thread Alwin Antreich
Unused disk(s) appeared after a rescan of storages. Especially shown with ceph pools, where two storage entries are made, _ct and _vm. The rescan method did include images from both storages. This patch filters any storage not containing the content type 'images'. Signed-off-by: Alwin Antreich -

[pve-devel] [qemu-server] fix #1829 check cloud-init disk format.

2018-07-03 Thread Wolfgang Link
Directory storage support raw and qcow2 format. It is not good to implicitly set the cloud-init format and ignore the selected format. Signed-off-by: Wolfgang Link --- PVE/API2/Qemu.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu

[pve-devel] [PATCH manager v3] ui: storage: combine RBD external and hyperconverged add dialog

2018-07-03 Thread Thomas Lamprecht
Combine both dialogues. This not only helps to reuse code but also reduces storage choices from the Storage -> Add menu, and thus improves usability. Signed-off-by: Thomas Lamprecht --- changes v2 -> v3: * don't show pveceph checkbox when editing * address the issue that displayfields have no su

Re: [pve-devel] [PATCH v2 ifupdown2] remove upstreamed patches

2018-07-03 Thread Alexandre DERUMIER
Thanks wolfgang ! - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 3 Juillet 2018 11:54:48 Objet: Re: [pve-devel] [PATCH v2 ifupdown2] remove upstreamed patches On Wed, Jun 20, 2018 at 05:34:33PM +0200, Alexandre Derumier wrote: > Almost all patch

[pve-devel] applied: [PATCH cluster] pvecm updatecerts: time out after 30 seconds

2018-07-03 Thread Thomas Lamprecht
On 7/2/18 4:34 PM, Thomas Lamprecht wrote: > We call this in pve-cluster.service as ExecStartPost. We prefix it > with '-' to tell systemd that it should ignore non-zero exit codes, > but if the command hangs (e.g., on IO) systemd kills it after a > timeout (90 seconds default) which then doesn't g

[pve-devel] applied: [pve-common v2 2/4] CLIFormatter: define some commonly useful rendering functions

2018-07-03 Thread Thomas Lamprecht
On 7/3/18 1:11 PM, Dietmar Maurer wrote: > Signed-off-by: Dietmar Maurer > --- > > Changes in v2: > > Improved render functions as suggested by Thomas - thanks! > applied, for the record > src/PVE/CLIFormatter.pm | 52 > + > 1 file changed, 52

[pve-devel] applied: [pve-common 1/4] JSONSchema: define 'renderer' property

2018-07-03 Thread Thomas Lamprecht
On 7/2/18 1:34 PM, Dietmar Maurer wrote: > Signed-off-by: Dietmar Maurer > --- > src/PVE/JSONSchema.pm | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index f0ac441..793ec60 100644 > --- a/src/PVE/JSONSchema.pm > +++ b/src/PVE/JSONSch

Re: [pve-devel] [PATCH cluster] pvecm updatecerts: time out after 30 seconds

2018-07-03 Thread Stoiko Ivanov
On Mon, Jul 02, 2018 at 04:34:10PM +0200, Thomas Lamprecht wrote: > We call this in pve-cluster.service as ExecStartPost. We prefix it > with '-' to tell systemd that it should ignore non-zero exit codes, > but if the command hangs (e.g., on IO) systemd kills it after a > timeout (90 seconds defaul

[pve-devel] [pve-common v2 2/4] CLIFormatter: define some commonly useful rendering functions

2018-07-03 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- Changes in v2: Improved render functions as suggested by Thomas - thanks! src/PVE/CLIFormatter.pm | 52 + 1 file changed, 52 insertions(+) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index b50

[pve-devel] applied: [PATCH storage 0/5] adding hooks for storage addition and deletion

2018-07-03 Thread Wolfgang Bumiller
applied On Mon, Jul 02, 2018 at 03:54:43PM +0200, Thomas Lamprecht wrote: > Motivated by the storage specific code in the Config API module used to set > things up when adding a storage, and cleaning up when deleting one this > series came to life. > > Add two hooks, on_add_hook and on_delete_hoo

Re: [pve-devel] [PATCH v2 ifupdown2] remove upstreamed patches

2018-07-03 Thread Wolfgang Bumiller
On Wed, Jun 20, 2018 at 05:34:33PM +0200, Alexandre Derumier wrote: > Almost all patches have been upstreamed. > we only have proxmox specific patches now Upstream also has the address-on-vlan-aware-bridge patch in by now which we had in the pve/ dir. I just rebased to current master-next and chan

Re: [pve-devel] [PATCH qemu-server] add discard_granularity to 4M for rbd storage

2018-07-03 Thread Wolfgang Bumiller
I'm answering here instead of the storage patches since I think we should finish the discussion first. On Fri, Jun 29, 2018 at 10:27:52AM +0200, Alexandre DERUMIER wrote: > >>IMHO: I would be up for this approach, as a first measure, so the discard > >>granularity can be overwritten. > > I'll re

Re: [pve-devel] Xen to Proxmox: one perl question

2018-07-03 Thread Gandalf Corvotempesta
Il giorno mar 3 lug 2018 alle ore 09:12 Wolfgang Bumiller ha scritto: > Or you just extract the files while downloading by piping to tar/bsdtar. > Also, seeing how this isn't a task you do 100 times a day every day, > time shouldn't be that much of an issue. Biggest issue is that you have to extr

Re: [pve-devel] [manager] Submit pool if non-empty in lxc CreateWizard

2018-07-03 Thread Thomas Lamprecht
On 7/2/18 4:46 PM, Andrew Neitsch wrote: > The lxc CreateWizard ignores the pool setting. That makes creating > containers impossible for users who are restricted to using a pool. This > patch fixes that. > > Signed-off-by: Andrew Neitsch > --- > www/manager6/lxc/CreateWizard.js | 5 - > 1 f

Re: [pve-devel] Xen to Proxmox: one perl question

2018-07-03 Thread Wolfgang Bumiller
On Mon, Jul 02, 2018 at 08:44:30PM +0200, Gandalf Corvotempesta wrote: > I'm trying to convert my simple bash script to a perl one (hoping > would be included in PVE), for directly convert a Xen VM to a PVE/KVM > on ZFS, in a single pass. > > I have one question: can someone tell me how to read a