[pve-devel] Xen to Proxmox: one perl question

2018-07-02 Thread Gandalf Corvotempesta
I'm trying to convert my simple bash script to a perl one (hoping would be included in PVE), for directly convert a Xen VM to a PVE/KVM on ZFS, in a single pass. I have one question: can someone tell me how to read a huge tar file (from a pipe) and extract one file at once? Something like the fol

[pve-devel] [manager] Submit pool if non-empty in lxc CreateWizard

2018-07-02 Thread Andrew Neitsch
The lxc CreateWizard ignores the pool setting. That makes creating containers impossible for users who are restricted to using a pool. This patch fixes that. Signed-off-by: Andrew Neitsch --- www/manager6/lxc/CreateWizard.js | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a

[pve-devel] [PATCH cluster] pvecm updatecerts: time out after 30 seconds

2018-07-02 Thread Thomas Lamprecht
We call this in pve-cluster.service as ExecStartPost. We prefix it with '-' to tell systemd that it should ignore non-zero exit codes, but if the command hangs (e.g., on IO) systemd kills it after a timeout (90 seconds default) which then doesn't get ignored and the unit will also be put in failure

[pve-devel] [PATCH storage 0/5] adding hooks for storage addition and deletion

2018-07-02 Thread Thomas Lamprecht
Motivated by the storage specific code in the Config API module used to set things up when adding a storage, and cleaning up when deleting one this series came to life. Add two hooks, on_add_hook and on_delete_hook, which are called in the create (i.e., add) storage config and delete storage confi

[pve-devel] [PATCH storage 3/5] rbd: use add/delete hooks

2018-07-02 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Storage/Config.pm | 22 -- PVE/Storage/RBDPlugin.pm | 34 ++ 2 files changed, 34 insertions(+), 22 deletions(-) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index 240c9e0..b

[pve-devel] [PATCH storage 2/5] cifs: use add/delete hooks

2018-07-02 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Storage/Config.pm | 11 +-- PVE/Storage/CIFSPlugin.pm | 17 + 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index 0d56115..240c9e0 100755 --- a/PVE/API2

[pve-devel] [PATCH storage 1/5] add on_add and on_delete hooks

2018-07-02 Thread Thomas Lamprecht
on_add_hook allows to encapsulate storage specific add steps, like copying a keyring (RDB) or creating a volume group (LVM) in a clean manner. The same for deletion with on_delete_hook, here all should be cleaned up, as much as possible. Until now, this was done directly in the api config CREATE a

[pve-devel] [PATCH storage 5/5] api add: remove now uneeded $cred_file variable

2018-07-02 Thread Thomas Lamprecht
was used for cleanup, which is now handled by on_delete_hook Signed-off-by: Thomas Lamprecht --- PVE/API2/Storage/Config.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index 434b1f3..b16054b 100755 --- a/PVE/API2/Storage/Config.pm

[pve-devel] [PATCH storage 4/5] lvm: use add hook

2018-07-02 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Storage/Config.pm | 19 --- PVE/Storage/LVMPlugin.pm | 22 ++ 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm index bb9d0a5..434b1f3 100755 -

[pve-devel] applied: [PATCH manager 1/3] ui/storage: cifs: only allow entering a password if user is set

2018-07-02 Thread Thomas Lamprecht
On 6/29/18 1:08 PM, Thomas Lamprecht wrote: > we ignore the password in the backend if no user is passed, > which can be very confusing for the user - or more important, me, > when testing cifs/storage stuff. > > So change the mechanics slightly. Previously we changed the > allowBlank property of

[pve-devel] applied: [PATCH storage 1/2] add cifs: fix variable declaration in post if

2018-07-02 Thread Thomas Lamprecht
On 6/29/18 1:20 PM, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > PVE/API2/Storage/Config.pm | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm > index 258820d..49cf3c8 100755 > --- a/PVE

Re: [pve-devel] [PATCH qemu-server v2 1/2] move disk: simplify and remove progress output

2018-07-02 Thread Wolfgang Link
Tested everything work and it looks OK to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/3] ui/storage: cifs: only allow entering a password if user is set

2018-07-02 Thread Wolfgang Link
Reviewed and tested. Everything work and it looks OK to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage 2/2] storage add: always extract password from parameters

2018-07-02 Thread Wolfgang Link
Reviewed and tested. Everything work and it looks OK to me. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [pve-common 2/4] CLIFormatter: define some commonly useful rendering functions

2018-07-02 Thread Thomas Lamprecht
On 7/2/18 1:34 PM, Dietmar Maurer wrote: > Signed-off-by: Dietmar Maurer > --- > src/PVE/CLIFormatter.pm | 54 > + > 1 file changed, 54 insertions(+) > > diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm > index b50464d..14ca9d4 10064

[pve-devel] [pve-common 3/4] PVE::CLIFormatter::extract_properties_to_print - new helper

2018-07-02 Thread Dietmar Maurer
This improves sort order. We now priorize required values, and list them before optional values. Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 43 --- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/src/PVE/CLIFormatter.pm b/s

[pve-devel] [pve-common 2/4] CLIFormatter: define some commonly useful rendering functions

2018-07-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIFormatter.pm | 54 + 1 file changed, 54 insertions(+) diff --git a/src/PVE/CLIFormatter.pm b/src/PVE/CLIFormatter.pm index b50464d..14ca9d4 100644 --- a/src/PVE/CLIFormatter.pm +++ b/src/PVE/CLIFormatter

[pve-devel] [pve-common 1/4] JSONSchema: define 'renderer' property

2018-07-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/JSONSchema.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index f0ac441..793ec60 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -1081,6 +1081,11 @@ my $default_schema_noref = {

[pve-devel] [pve-common 4/4] JSONSchema: register new standard option 'pve-output-format'

2018-07-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/JSONSchema.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 793ec60..aa82167 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -105,6 +105,14 @@ register_standard_option('fi

[pve-devel] applied: [installer] Allow more than 26 SCSI disk devices.

2018-07-02 Thread Thomas Lamprecht
On 7/2/18 12:05 PM, Wolfgang Link wrote: > Some customers have more than 26 devices, > for example, if they use multipath on a DAS box. > > In the Linux Documentation admin-guide/devices.txt > is written 256 SCSI disk devices are possible. > > Signed-off-by: Wolfgang Link > --- > proxinstall |

[pve-devel] [installer] Allow more than 26 SCSI disk devices.

2018-07-02 Thread Wolfgang Link
Some customers have more than 26 devices, for example, if they use multipath on a DAS box. In the Linux Documentation admin-guide/devices.txt is written 256 SCSI disk devices are possible. Signed-off-by: Wolfgang Link --- proxinstall | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif