Re: [pve-devel] applied: [PATCH i18n 0/1] update french translation

2018-03-02 Thread Alexandre DERUMIER
>>But next time just press enter when git ask after the encoding :) arf, sorry, I was not sure with utf-8 encoding :/ - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Vendredi 2 Mars 2018 08:57:44 Objet: applied: [pve-devel] [PATCH i18n 0/1] update french tr

[pve-devel] applied: [PATCH storage 1/2 v2] Fix #1574: could not disable krbd-incompatible image features

2018-03-02 Thread Fabian Grünbichler
applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH V2 pve-common 5/6] rename $can_read_pass to $read_password_func

2018-03-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIHandler.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 2d77145..5e2d3b8 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -117,7 +117,7 @@ sub generate_us

[pve-devel] [PATCH V2 pve-common 1/6] introduce compute_param_mapping_hash helper

2018-03-02 Thread Dietmar Maurer
This allows us to specify a arbitrary mapping func for any param. Signed-off-by: Dietmar Maurer --- src/PVE/RESTHandler.pm | 68 +- 1 file changed, 50 insertions(+), 18 deletions(-) diff --git a/src/PVE/RESTHandler.pm b/src/PVE/RESTHandler.pm inde

[pve-devel] [PATCH V2 pve-common 6/6] use better name for string_param_file_mapping (param_mapping).

2018-03-02 Thread Dietmar Maurer
But keep old one for compatibility. Signed-off-by: Dietmar Maurer --- src/PVE/CLIHandler.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 5e2d3b8..1fd7b02 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.p

[pve-devel] [PATCH V2 pve-common 3/6] rename $can_str_param_fmap to $param_mapping_func

2018-03-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIHandler.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 736e5ec..33b7aca 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -118,7 +118,7 @@ sub generate_us

[pve-devel] [PATCH V2 pve-common 4/6] rename $pwcallback to $read_password_func

2018-03-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIHandler.pm | 14 +++--- src/PVE/RESTHandler.pm | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 33b7aca..2d77145 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/

[pve-devel] [PATCH V2 pve-common 2/6] rename $stringfilemap to $param_mapping_func

2018-03-02 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- src/PVE/CLIHandler.pm | 14 +++--- src/PVE/RESTHandler.pm | 16 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 45c0427..736e5ec 100644 --- a/src/PVE/CLIHandler.pm +++

[pve-devel] [PATCH V2 pve-common 0/6] CLI/RESTHandler: more generic parameter mapping

2018-03-02 Thread Dietmar Maurer
Changes since V1: - split patch into smaller parts - new helper $compute_param_mapping_hash() - improve parameter names - add some inline docs Besides, functionality should be still the same. Dietmar Maurer (6): introduce compute_param_mapping_hash helper rename $stringfilemap to $param_mapp

[pve-devel] [PATCH storage 1/2 v2] Fix #1574: could not disable krbd-incompatible image features

2018-03-02 Thread Alwin Antreich
To prevent an error when disabling features of a rbd image with already disabled flags. This aborted the CT/VM cloning halfway through with a leftover rbd image, but no vmid.conf to it. Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 17 ++--- 1 file changed, 14 insertio

[pve-devel] [PATCH storage 2/2 v2] Fix typo in sub s/krdb_feature_disable/krbd_feature_disable

2018-03-02 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/Storage/RBDPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 06e0a0a..9e0e720 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -101,7 +101,7 @@

Re: [pve-devel] [PATCH manager] fix #1683: do not send non-numeric values to graphite

2018-03-02 Thread Thomas Lamprecht
On 3/1/18 4:44 PM, Dominik Csapak wrote: > the graphite daemons which accept the data (carbon), only > accepts numeric values, and logs all invalid lines > > since that were about 5 values per vm/ct this generated lot of noise > in the carbon log > > Signed-off-by: Dominik Csapak > --- > PVE/St

[pve-devel] [PATCH manager 2/5] Report: refactor to simple schema definition of subreports

2018-03-02 Thread Thomas Lamprecht
Easier to add new commands, or change flags of existing ones. Use an hash for top level definition as we can push optional commands easier there than in an array, it resembles also more our normal schema definitions. Add a truth-y value at the bottom, to ensure perls require is happy with this mo

[pve-devel] [PATCH manager 5/5] Report: add info about PCI devices

2018-03-02 Thread Thomas Lamprecht
Good to have when a NIC or other peripheral devices does not works. Flags used: -k Show kernel drivers handling each device and also kernel modules capable of handling it. -nn Show PCI vendor and device codes as both numbers and names. Signed-off-by: Thomas Lamprecht --- PVE/Report.pm | 5

[pve-devel] [PATCH manager 4/5] Report: add pct list

2018-03-02 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/Report.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Report.pm b/PVE/Report.pm index 0083d28f..fa943bea 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -32,6 +32,7 @@ my $report_def = { 'virtual guests' => [ 'qm list', su

[pve-devel] [PATCH manager 1/5] Report: remove useless version check

2018-03-02 Thread Thomas Lamprecht
this is packaged with pve-manager and runs locally on the node, so we're pretty sure that the version is the one from pve-manager anyway, this check just makes no sense... Signed-off-by: Thomas Lamprecht --- PVE/Report.pm | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff

[pve-devel] [PATCH manager 3/5] Report: use findmnt instead of mount

2018-03-02 Thread Thomas Lamprecht
much easier to parse visually while keeping the same amount of information Signed-off-by: Thomas Lamprecht --- PVE/Report.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 906c489e..0083d28f 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @