applied
On Wed, Aug 09, 2017 at 02:08:26PM +0200, Dominik Csapak wrote:
> we do not set an Expire header for our js files, and certain browsers
> do not even make the request then (on which we would answer
> with a correct 304 not modified)
>
> so to force the browser to load a new version of the
On Thu, Aug 10, 2017 at 09:34:00AM +0200, Fabian Grünbichler wrote:
> On Wed, Aug 09, 2017 at 06:17:20PM +0200, Dietmar Maurer wrote:
> > Looks quite strange to me, because PVE::HTTPServer calls:
> >
> > PVE::API2->find_handler
> >
> > so we should use PVE::API2 in PVE::HTTPServer?
> >
> > Not
applied
On Tue, Nov 07, 2017 at 08:27:37AM +0100, Thomas Lamprecht wrote:
> Signed-off-by: Thomas Lamprecht
> ---
> PVE/QemuServer.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 321c9f6..4586a3d 100644
> --- a/PVE/Qemu
applied
On Tue, Nov 07, 2017 at 08:18:56AM +0100, Dominik Csapak wrote:
> if the efidisk is in 'raw' format, qemu will prevent writes
> on block zero if the format is not explicitely given
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * make sure $format is not undefined
> PVE/Qe
Signed-off-by: Thomas Lamprecht
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 321c9f6..4586a3d 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -281,7 +281,8 @@ w2k3;; Microsoft Windows 2003
w2k8;;
if the efidisk is in 'raw' format, qemu will prevent writes
on block zero if the format is not explicitely given
Signed-off-by: Dominik Csapak
---
changes from v1:
* make sure $format is not undefined
PVE/QemuServer.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/Qe
On Fri, Nov 03, 2017 at 02:58:41PM +0100, Dominik Csapak wrote:
> if the efidisk is in 'raw' format, qemu will prevent writes
> on block zero if the format is not explicitely given
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuServer.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion
On 08/09/2017 02:08 PM, Dominik Csapak wrote:
> we do not set an Expire header for our js files, and certain browsers
> do not even make the request then (on which we would answer
> with a correct 304 not modified)
>
> so to force the browser to load a new version of the gui when we change
> somet
On 11/03/2017 02:58 PM, Dominik Csapak wrote:
> if the efidisk is in 'raw' format, qemu will prevent writes
> on block zero if the format is not explicitely given
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/QemuServer.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --gi
edit the vm config via PVE::Tools::edit_file minus the snapshot sections
(we do not want to update those manually)
Signed-off-by: Dominik Csapak
---
changes since v2:
* use PVE::Tools::edit_file
* do not remove pending section, as one might want to edit that directly
* use correct completion help
this opens the container config file via PVE::Tools::edit_file, minus
the snapshot section
Signed-off-by: Dominik Csapak
---
changes since v1:
* open temp file instead of real file
* warn and die when digest is different on write than on read
* use PVE::Tools::edit_file
src/PVE/CLI/pct.pm | 60 +
this series implements pct/qm edit
incorporated the feedback from thomas from qemu-servers v2
and includes a new version for pct
now the editing deleting part is done in a wrapper in PVE::Tools
so that we can reuse that logic
[PATCH common] add edit_file subroutine
[PATCH container v2] implement
this is a wrapper for editing a file via a temporary file in
/run/pve-edit.tmp.PID with the editor set with update-alternatives
(/usr/bin/editor)
Signed-off-by: Dominik Csapak
---
src/PVE/Tools.pm | 35 +++
1 file changed, 35 insertions(+)
diff --git a/src/PVE/To
allow to use sub commands alá
# pveum user add
The new resolve_cmd traverses $cmddef, resolves one level of aliases
and returns the respective sub command, its cmddef, arguments and if
it was expanded (e.g., pveum u d ... => pveum user delete ...) which
allows quite easy integration in the usage/
will be reused in later patches too
---
src/PVE/CLIHandler.pm | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 311cc69..4e3342f 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandler.pm
@@ -20,6 +
reduce code reuse and prepare for sub commands
---
src/PVE/CLIHandler.pm | 137 --
1 file changed, 76 insertions(+), 61 deletions(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 4e3342f..64a35c1 100644
--- a/src/PVE/CLIHandler.pm
Improves usabillity by allowing to pass a sub command unquoted to
the help command, e.g.:
# pveum help user delete
without this only a quoted version worked, e.g.:
# pveum help "user delete"
---
src/PVE/CLIHandler.pm | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --
---
src/PVE/CLIHandler.pm | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 5111b7a..a771e40 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandler.pm
@@ -10,6 +10,28 @@ use PVE::INotify;
use base qw(PVE::RESTHan
passing one param less to the helper methods
---
src/PVE/CLIHandler.pm | 29 -
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 73e8ee6..29a7f57 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandle
use shorter and also a bit faster methods to expand and get comand
names
---
src/PVE/CLIHandler.pm | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index c787ac4..ab1440c 100644
--- a/src/PVE/CLIHandler.pm
move variables nearer to where they actually used.
drop program name early from argv array
drop unnecessary variables
---
src/PVE/CLIHandler.pm | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.p
---
src/PVE/CLIHandler.pm | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm
index 29a7f57..c787ac4 100644
--- a/src/PVE/CLIHandler.pm
+++ b/src/PVE/CLIHandler.pm
@@ -14,6 +14,12 @@ my $cmddef;
my $exename;
my $cli_
I picked up Philips sub command patch, tried to split it up in
digestible chunks, refactored a few things and tried to address the
open comments from my last review where this series was still owned by
Philip.
I'm at the point where I a looked at the code a bit to long without
getting inspiration t
On 10/30/2017 01:52 PM, Dominik Csapak wrote:
> edit the vm config via /usr/bin/editor (this can be set via
> update-alternatives) minus the pending and snapshot sections (we do not
> want to update those manually)
>
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * use a tmpfile in /r
any comments? i believe this will vastly improve the cache behavior of
the gui, so it i would be a shame if this does not get applied in one
form or another
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/l
Some users, including me, are discussing about the possibilities to extend the
backup routines to offer more compression programs:
https://forum.proxmox.com/threads/suggestion-add-lrzip-to-backup-compression-options.29496
I've made a small set of patches to be able to use zstd
(https://github.co
allow our caller to set alarm on us.
Ensure that the new alarm sub gets assigned before the new alarm gets set.
---
new in v2
maybe there should be even:
alarm(0)
local $SIG{ALRM} = sub {...};
alarm(60);
to ensure we always call the matching alarm sub, but as this is not a
likely nor big prob
We checked if a specific error was set or, respectively, not set to
know if we got the lock or not.
The check if we may unlock again was negated and thus could lead to
problems, in specific - rather unlikely - cases.
Add a $got_lock variable which only gets set when we really got the
lock, this is
helps debugging
---
new in v2
data/PVE/Cluster.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index f0708a0..f634c84 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
@@ -878,8 +878,7 @@ my $cfs_lock = sub {
We checked if a specific error was set or, respectively, not set to
know if we got the lock or not.
The check if we may unlock again was negated and thus could lead to
problems, in specific - rather unlikely - cases.
Add a $got_lock variable which only gets set when we really got the
lock, this is
On 11/02/2017 02:22 PM, Dominik Csapak wrote:
> after finishing the code in cfs_lock, we want to release the lock only
> when we got it before, so we need to check the correct lock
>
> Signed-off-by: Dominik Csapak
> ---
> note: better would be a different approach than parsing the
> error messag
31 matches
Mail list logo
