Re: [pve-devel] [PATCH container] add vm_stop helper

2017-10-13 Thread Dietmar Maurer
> +# Helper to stop a container completely and make sure it has stopped > completely. > +# This is necessary because we want the post-stop hook to have completed its > +# unmount-all step, but post-stop happens after lxc puts the container into > the > +# STOPPED state. > +sub vm_stop { > +my (

Re: [pve-devel] [PATCH manager] ui: GuestStatusView: simplify HA state display

2017-10-13 Thread Dominik Csapak
Acked-By: Dominik Csapak On 10/11/2017 02:10 PM, Thomas Lamprecht wrote: simplify HA Information in VM/CT Summary panel. Use the already translated 'HA State' instead of 'Managed by HA' (which now becomes obsolete as it was the single appearance). Simplify PVE.Utils.format_ha respectively to ma

Re: [pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

2017-10-13 Thread Dominik Csapak
Acked-By: Dominik Csapak On 10/11/2017 12:09 PM, Thomas Lamprecht wrote: First two patches make adding a new services over DC->HA->Add more confortable by switching out the simple VMID integer spinner with a combobox grid showing more details for each VM/CT, addressing #1517 Third one is a small

Re: [pve-devel] [PATCH manager] ui: re-align global search field to now shorter version

2017-10-13 Thread Dominik Csapak
Acked-by: Dominik Csapak On 10/11/2017 09:16 AM, Thomas Lamprecht wrote: commit 48de6c299a33fe124d7193b2565d754efdbf8cd3 removed showing the short SHA1 commit hash in the version info field but did not realigned the search field so that it got a asymmetric space. Adapt the Version info minimal

Re: [pve-devel] [PATCH manager v2 0/3] help/manual button improvement

2017-10-13 Thread Dominik Csapak
v3 of 1/3 v2 of 2/3 and 3/3 Acked-by: Dominik Csapak On 10/10/2017 12:49 PM, Thomas Lamprecht wrote: changes since v1: * use the shorter name 'Manual' instead of 'Documenation' (note: our screenshots are based on a 1280 pixel wide window, so both would be OK) * use the 'fa-book' font awes

Re: [pve-devel] [PATCH manager] ui: inline novnc: always focus console panel after render

2017-10-13 Thread Dominik Csapak
LGTM, the gain is much higher than the drawback IMHO ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container] add vm_stop helper

2017-10-13 Thread Wolfgang Bumiller
Since we use a post-stop hook to unmount all file systems at container shutdown rather than a stop hook (because at this point there are still multiple mount namespaces around), we need to wait for the lxc-start/monitor process to exit to be sure all the unmounting has succeeded, because it will pu

[pve-devel] applied: [PATCH common] tools: more general run_fork_with_timeout + run_fork

2017-10-13 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v5 container 0/4] lxc@ service: fix dependencies

2017-10-13 Thread Wolfgang Bumiller
applied whole series On Wed, Oct 11, 2017 at 02:13:09PM +0200, Fabian Grünbichler wrote: > this series improves the systemd integration of LXC containers by: > - ensuring PVE LXC container units don't have a (transitive) conflict with > shutdown.target, thus preventing races between systemd- and

[pve-devel] applied: [PATCH docs 1/3] ha: document ignored state

2017-10-13 Thread Fabian Grünbichler
series with cleanup On Fri, Oct 13, 2017 at 01:00:41PM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > ha-manager.adoc | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/ha-manager.adoc b/ha-manager.adoc > index fa7cb26..07a2370 100644 > --- a/ha-manager.ad

[pve-devel] [PATCH docs 3/3] various wording improvement

2017-10-13 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- had this still lying around, its not to much changes, just use `git show --word-diff=color` to see the effective ones. ha-manager.adoc | 8 qm.adoc | 15 +++ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/ha-man

[pve-devel] [PATCH docs 1/3] ha: document ignored state

2017-10-13 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- ha-manager.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ha-manager.adoc b/ha-manager.adoc index fa7cb26..07a2370 100644 --- a/ha-manager.adoc +++ b/ha-manager.adoc @@ -319,6 +319,13 @@ Do not touch the service state. We use this state while w

[pve-devel] [PATCH docs 2/3] ceph: add references for onlineHelp

2017-10-13 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- pve-storage-rbd.adoc | 1 + pveceph.adoc | 3 +++ 2 files changed, 4 insertions(+) diff --git a/pve-storage-rbd.adoc b/pve-storage-rbd.adoc index c782ee1..5d0b7b7 100644 --- a/pve-storage-rbd.adoc +++ b/pve-storage-rbd.adoc @@ -27,6 +27,7 @@ services d

[pve-devel] applied: ha-manager: add ignore state v2

2017-10-13 Thread Fabian Grünbichler
please also send a patch for pve-docs/ha-manager.adoc On Tue, Jan 24, 2017 at 06:37:21PM +0100, Thomas Lamprecht wrote: > V2 of this series is a refactored version of v1, the implementation behaves > the same. > > The ignore state is the state where a service has a HA configuration but > wants to

[pve-devel] applied: [PATCH ha-manager 1/3] lrm.service: do not timeout on stop

2017-10-13 Thread Fabian Grünbichler
all three patches On Wed, Oct 11, 2017 at 03:10:18PM +0200, Thomas Lamprecht wrote: > we must shut all services down when stopping the LRM for a host > shutdown, this can take longer than 95 seconds and should not > get interrupted to ensure a gracefull poweroff. > > The watchdog is still active

[pve-devel] applied: [PATCH qemu-server] check if base volumes are unused before deleting a template

2017-10-13 Thread Fabian Grünbichler
___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH guest-common] Send email when a replication job fails.

2017-10-13 Thread Wolfgang Link
A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27 ins

[pve-devel] PVE Replica Email notification on failure.

2017-10-13 Thread Wolfgang Link
Now you get a email if a replication job fail. The mail is only send the first time, when a job switched from ok state in error state. No more notification will come when a job with error state retry to sync. ___ pve-devel mailing list pve-devel@pve.pr

[pve-devel] [PATCH guest-common] Remove noerr form replication.

2017-10-13 Thread Wolfgang Link
We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..2b3df36 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -304

[pve-devel] [PATCH qemu-server] check if base volumes are unused before deleting a template

2017-10-13 Thread Dominik Csapak
we only checked if a vm had in use base disks when deleting them, at which point we do not stop to delete the vm even when a disk deletion fails, which means we could successfully delete the config and all not used (base) disks of a template, resulting in left over vm disks Signed-off-by: Dominik