[pve-devel] [PATCH access-control] api: fix typo in 'GET ticket' description

2017-09-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/AccessControl.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index 444fb69..318ee15 100644 --- a/PVE/API2/AccessControl.pm +++ b/PVE/API2/AccessControl.pm @@ -184,7 +184,7 @@

[pve-devel] [PATCH access-control v2 3/3] Whitespace fixes

2017-09-20 Thread Philip Abernethy
--- PVE/API2/Role.pm | 71 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index 107523e..4ee023b 100644 --- a/PVE/API2/Role.pm +++ b/PVE/API2/Role.pm @@ -12,11 +12,11 @@ use PVE::RESTHandl

[pve-devel] [PATCH access-control v2 1/3] fix #1501: pveum: die when deleting special role

2017-09-20 Thread Philip Abernethy
Die with a helpful error message instead of silently ignoring the user when trying to delete a special role. --- v2: Fixed 'special' appearing in WebUI roles list PVE/API2/Role.pm | 7 ++- PVE/AccessControl.pm | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Ro

[pve-devel] [PATCH access-control v2 2/3] Remove unused Dumper use

2017-09-20 Thread Philip Abernethy
--- PVE/API2/Role.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index d6d17db..107523e 100644 --- a/PVE/API2/Role.pm +++ b/PVE/API2/Role.pm @@ -7,8 +7,6 @@ use PVE::AccessControl; use PVE::SafeSyslog; -use Data::Dumper; # fixme: remove - use PVE:

[pve-devel] [PATCH access-control 1/3] fix #1501: pveum: die when deleting special role

2017-09-20 Thread Philip Abernethy
Die with a helpful error message instead of silently ignoring the user when trying to delete a special role. --- PVE/API2/Role.pm | 3 +++ PVE/AccessControl.pm | 1 + 2 files changed, 4 insertions(+) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index 6392e13..d8d8e17 100644 --- a/PVE/API2

[pve-devel] [PATCH access-control 2/3] Remove unused Dumper use

2017-09-20 Thread Philip Abernethy
--- PVE/API2/Role.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index d8d8e17..b218e67 100644 --- a/PVE/API2/Role.pm +++ b/PVE/API2/Role.pm @@ -7,8 +7,6 @@ use PVE::AccessControl; use PVE::SafeSyslog; -use Data::Dumper; # fixme: remove - use PVE:

[pve-devel] [PATCH access-control 3/3] Whitespace fixes

2017-09-20 Thread Philip Abernethy
--- PVE/API2/Role.pm | 71 1 file changed, 35 insertions(+), 36 deletions(-) diff --git a/PVE/API2/Role.pm b/PVE/API2/Role.pm index b218e67..9e8b7b8 100644 --- a/PVE/API2/Role.pm +++ b/PVE/API2/Role.pm @@ -12,11 +12,11 @@ use PVE::RESTHandl

[pve-devel] applied: [PATCH cluster v4 0/4] corosync config parser refactoring

2017-09-20 Thread Wolfgang Bumiller
applied On Wed, Sep 20, 2017 at 03:11:01PM +0200, Thomas Lamprecht wrote: > This iteration addresses a problem with older configs where the nodes > name entry was not guaranteed by us, adds also a test for this > behaviour to save us from this regressions once nobody of the > reviewers have such a

[pve-devel] [PATCH cluster v4 4/4] test: add test for legacy corosync.conf

2017-09-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- new in thsi iteration data/test/corosync_configs/old.conf | 29 + 1 file changed, 29 insertions(+) create mode 100644 data/test/corosync_configs/old.conf diff --git a/data/test/corosync_configs/old.conf b/data/test/corosync_conf

[pve-devel] [PATCH cluster v4 2/4] corosync: transform config to allow easier access

2017-09-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- changes v3 -> v4: * parse: fallback to ring0_addr if node name is not set data/PVE/Corosync.pm | 47 +++ 1 file changed, 19 insertions(+), 28 deletions(-) diff --git a/data/PVE/Corosync.pm b/data/PVE/Corosync.pm in

[pve-devel] [PATCH cluster v4 0/4] corosync config parser refactoring

2017-09-20 Thread Thomas Lamprecht
This iteration addresses a problem with older configs where the nodes name entry was not guaranteed by us, adds also a test for this behaviour to save us from this regressions once nobody of the reviewers have such an old cluster around. I omitted the WIP patches this time, the v3 ones are still O

[pve-devel] [PATCH cluster v4 3/4] corosync: add atomic_write_conf and cleanup

2017-09-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- no changes data/PVE/Corosync.pm | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/data/PVE/Corosync.pm b/data/PVE/Corosync.pm index 0ee74b8..cf88022 100644 --- a/data/PVE/Corosync.pm +++ b/data/PV

[pve-devel] [PATCH cluster v4 1/4] corosync config parser: move to hash format

2017-09-20 Thread Thomas Lamprecht
The old parser itself was simple and easy but resulted in quite a bit of headache when changing corosync config sections, especially if multiple section levelsshould be touched. Move to a more practical internal format which represents the corosync configuration in hash Signed-off-by: Thomas Lamp

Re: [pve-devel] [PATCH cluster v3 4/7] corosync: transform config to allow easier access

2017-09-20 Thread Thomas Lamprecht
On 09/20/2017 02:06 PM, Wolfgang Bumiller wrote: On Mon, Sep 18, 2017 at 10:32:55AM +0200, Thomas Lamprecht wrote: Signed-off-by: Thomas Lamprecht --- changes v2 -> v3: * use map instead of foreach in transform helpers * rename those helper to conciser names data/PVE/Corosync.pm | 51 ++

[pve-devel] applied: [PATCH cluster v3 2/7] pvecm: import often needed run_command

2017-09-20 Thread Wolfgang Bumiller
applied On Mon, Sep 18, 2017 at 10:32:53AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > no changes > > data/PVE/CLI/pvecm.pm | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm >

[pve-devel] applied: [PATCH cluster v3 1/7] pvecm: remove Data::Dumper

2017-09-20 Thread Wolfgang Bumiller
applied On Mon, Sep 18, 2017 at 10:32:52AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > no changes > > data/PVE/CLI/pvecm.pm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm > index 7ca98f7..41c2f9c 100755 > --

Re: [pve-devel] [PATCH cluster v3 4/7] corosync: transform config to allow easier access

2017-09-20 Thread Wolfgang Bumiller
On Mon, Sep 18, 2017 at 10:32:55AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > changes v2 -> v3: > * use map instead of foreach in transform helpers > * rename those helper to conciser names > > data/PVE/Corosync.pm | 51 +++--

Re: [pve-devel] pve api offline during log rotation

2017-09-20 Thread Stefan Priebe - Profihost AG
Hi, Am 20.09.2017 um 10:36 schrieb Thomas Lamprecht: > On 09/20/2017 06:40 AM, Stefan Priebe - Profihost AG wrote: >> Nobody? >> > > We register the restart command from pveproxy with the $use_hup parameter, > this then send a SIGHUP when calling pveproxy restart - which gets > mapped to > syste

[pve-devel] applied: [PATCH manager] vzdump/pigz: use ProcFSTools for core count, not sysconf

2017-09-20 Thread Wolfgang Bumiller
applied On Wed, Sep 13, 2017 at 11:10:57AM +0200, Thomas Lamprecht wrote: > A "sysconf(84)" is not really descripitve. There is no POSIX const > entry for _SC_NPROCESSORS_ONLN (number of processors online) as its > not standard but an adoption of glibc. > Better just use our proven ProcFSTool's cp

[pve-devel] applied: [PATCH guest-common] AbstractMigrate: remove unused obsolete variables

2017-09-20 Thread Wolfgang Bumiller
applied On Wed, Sep 13, 2017 at 10:40:52AM +0200, Thomas Lamprecht wrote: > --- > PVE/AbstractMigrate.pm | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/PVE/AbstractMigrate.pm b/PVE/AbstractMigrate.pm > index 5fa17ba..17fdb5d 100644 > --- a/PVE/AbstractMigrate.pm > +++ b/PVE/AbstractM

Re: [pve-devel] Kernel: CONFIG_MLX4_EN_VXLAN=y not present anymore

2017-09-20 Thread Alexander Schmid
Hi, thanks, this makes sense. I just followed the Mellanox Guide on vxlan offload and wondered why ethtool shows tx-udp_tnl-segmentation: off [fixed] https://community.mellanox.com/docs/DOC-1446 Obviously this doesn't reflect the change yet. Will verify if it works by having a look at the tra

Re: [pve-devel] Kernel: CONFIG_MLX4_EN_VXLAN=y not present anymore

2017-09-20 Thread Thomas Lamprecht
Hi, On 09/20/2017 11:55 AM, Alexander Schmid wrote: Hello, i just noticed that CONFIG_MLX4_EN_VXLAN, what is important for vxlan hw offload with ConnectX-3, is not set anymore. The reason for this is that it does not exist anymore, cannot grep it in current git tree. This commit removed it,

[pve-devel] Kernel: CONFIG_MLX4_EN_VXLAN=y not present anymore

2017-09-20 Thread Alexander Schmid
Hello, i just noticed that CONFIG_MLX4_EN_VXLAN, what is important for vxlan hw offload with ConnectX-3, is not set anymore. I see it on kernel 4.4.15-1-pve: # uname -a Linux cl1-1-s0c1 4.4.15-1-pve #1 SMP Thu Jul 28 10:54:13 CEST 2016 x86_64 GNU/Linux # cat /boot/config-`uname -r`|grep ML

Re: [pve-devel] rfc : implementing a cloudinit metadata server

2017-09-20 Thread Emmanuel Kasper
On 08/30/2017 07:52 AM, Alexandre DERUMIER wrote: > Hi, > > the previous cloudinit patches used a cdrom for config drive. > > Wolfgang tell me that it could be great to get it work for lxc too. > > > So maybe we could try to implement a cloudinit metadataserver, with same api > than cloudstack

Re: [pve-devel] pve api offline during log rotation

2017-09-20 Thread Thomas Lamprecht
On 09/20/2017 06:40 AM, Stefan Priebe - Profihost AG wrote: Nobody? We register the restart command from pveproxy with the $use_hup parameter, this then send a SIGHUP when calling pveproxy restart - which gets mapped to systemctl reload-or-restart pveproxy.service, which sends the HUP signal t

[pve-devel] applied: [RFC access-control] API/ticket: rework coarse grained permission computation

2017-09-20 Thread Wolfgang Bumiller
applied On Thu, Sep 14, 2017 at 03:17:09PM +0200, Thomas Lamprecht wrote: > We accessed methods from PVE::Storage here but did not define a > "use PVE::Storage". This thus only worked if modules if the > PVE::Storage module got pulled in by something else, by luck. > Simply including said use stat

[pve-devel] applied: [PATCH manager 0/3] Turn the Online checkbox of the Migrate Window into a displayfield

2017-09-20 Thread Wolfgang Bumiller
applied series On Thu, Aug 24, 2017 at 11:45:17AM +0200, Emmanuel Kasper wrote: > This checkbox had no use, as checking/unchecking it would not be able to > change the migration type. > (see details in third patch). > I also took the opportunity to rewrite the component with a ViewController, >