The size of this image is not fixed, it increased to 528k in more
recent build of OVMF and could increase further (not likely, but
possible).
Instead of changing the hardcoded value move to a more generic
approach and read the size from the base image at creation time.
Use the new convert_size me
factor out code in a new create_efidisk submethod, as else this code
is hardly readable as the efidisk0 case is a special case. Refer from
putting all this specialised handling directly to the much shorter
code for all other cases.
Also the disk was created with a specific format and then a format
this was only kept for PVE 4.X where the switch to the newer OVMF
image with actual working persisten EFIVARS was made.
We do not ship this old image in PVE 5.0 anymore so remove this
legacy code as it can never trigger anyhow.
Signed-off-by: Thomas Lamprecht
---
PVE/QemuServer.pm | 48
We often need to convert between file sizes, for formatting output,
but also code-internal. Some methods expect kilobytes, some gigabytes
and sometimes we need bytes.
While conversion from smaller to bigger units can be simply done with
a left-shift, the opposite conversion may need more attention
On Mon, Sep 11, 2017 at 08:13:06AM +0200, Alexandre DERUMIER wrote:
> >>I am not sure whether that is worth it - 4.10 won't be around much
> >>longer.. unless this is very urgent for you or you know that 4.13 is
> >>broken as well, I suggest waiting 2-3 weeks.
>
> Don't have tested 4.13 yet. (I ca
>>I am not sure whether that is worth it - 4.10 won't be around much
>>longer.. unless this is very urgent for you or you know that 4.13 is
>>broken as well, I suggest waiting 2-3 weeks.
Don't have tested 4.13 yet. (I can wait, don't have migrated to proxmox 5 yet)
What is the proxmox plan ? wait
On Fri, Sep 08, 2017 at 02:45:19PM +0200, Alexandre DERUMIER wrote:
> Hi,
> Seem than mellanox connectx-5 card are buggy on kernel 4.10.
>
> works fine with kernel 4.4 and 4.12.
>
> I'll try to backport last patches from 4.12 or 4.9.
I am not sure whether that is worth it - 4.10 won't be around
