Hello,
I noticed that when i create a new VM and select under "hard disc" the bus
type "SCSI" and check the "IO-Thread" proxmox doesnt automatically use the
scsi controller type "virtIO scsi single", instead always the normal
"virtIO scsi" (without single).
So if i understand the pve-docs correctl
both patches - the fix and the refactoring - look good to me and are an
improvement, IMO.
Reviewed-by: Thomas Lamprecht
On 05/15/2017 09:31 AM, Fabian Grünbichler wrote:
25d9bda94127b1a91181cd80bb9948093dea389b broke this check,
but it is a better idea to check against the actual type
rather
Adds a check if an unprivileged container is configured to use
quota on any of its mountpoints. If so an understandable error
message is given. Ideally I'd like to catch those
configurations on the GUI, too, to avoid users just running
into it.
---
src/PVE/API2/LXC/Status.pm | 10 ++
1 fil
This avoid failing the check where the auto detected type differs
from the configs ostype.
Signed-off-by: Thomas Lamprecht
---
src/PVE/LXC/Setup.pm | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
index a503461..8be1b90 10
On Wed, Aug 16, 2017 at 06:24:29PM +0200, Philip Abernethy wrote:
> Where possible I reworked the code to remove the resulting inversion.
> The result should be easier to read and understand.
small nitpick: commit messages should be written in the present tense /
imperative, not past. phrases like
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reformatted commit message - please don't use --- as delimiter inside
commit messages, see "man git-am":
· three-dashes and end-of-line, or
· a line that begins with "diff -", or
· a line that begins with "Index: "
is taken as the beginning of a patch, and the
We tried to limit the size of the tasklist by including non-running
task only if we have less than 25 entries. A reason, among others,
was that a single status entry in the cfs_status.kvhash is limited to
32 KiB.
The "max. 25 entry" heuristic assumes that entries are small, which
is also the norm.
On Tue, Jul 25, 2017 at 03:32:21PM +0200, Thomas Lamprecht wrote:
> Signed-off-by: Thomas Lamprecht
> ---
> src/PVE/RESTEnvironment.pm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
> index 2aee8de..15eef90 100644
> --- a/src/PVE/R
On Tue, Jul 25, 2017 at 03:32:23PM +0200, Thomas Lamprecht wrote:
> Don't die because the tasklist could not be broadcasted, just log the
> error.
> Else we may hinder all task to run with a quite confusing error (i.e.
> "ipcc_send_rec: file to big").
>
> This may happen if there are a lot current
On Tue, Jul 25, 2017 at 03:32:20PM +0200, Thomas Lamprecht wrote:
> we return early from this function if the $rest_env singleton doesn't
> evaluates to true yet, so this check is useless here.
>
> Signed-off-by: Thomas Lamprecht
> ---
> src/PVE/RESTEnvironment.pm | 3 +--
> 1 file changed, 1 in
any feedback on this?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
it can happen that nothing in the tree is selected,
then PVE.curSelectedNode is undefined, generating an exception there.
so we check if this is available
Signed-off-by: Dominik Csapak
---
www/manager6/form/NodeSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/m
14 matches
Mail list logo
