[pve-devel] [PATCH manager 14/17] hide migrate button in lxc for non cluster setups

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 245de8ed..fbaccefe 100644 --- a/www/manager6/lxc/Config.js +++ b/www/manager6/lxc/Config.js @@ -85,6 +85,7 @@ Ext.define('

[pve-devel] [PATCH manager 07/17] move lxc mountpoint edit from ResourceEdit.js to MPEdit.js

2017-07-19 Thread Dominik Csapak
to follow qemu code also fix the jslint errors in MountPointInputPanel and MountPointEdit Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/lxc/MPEdit.js | 395 +++ www/manager6/lxc/ResourceEdit.js | 395 --

[pve-devel] [PATCH manager 11/17] use DiskStorageSelector in qemu/HDMove.js

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDMove.js | 55 - 1 file changed, 9 insertions(+), 46 deletions(-) diff --git a/www/manager6/qemu/HDMove.js b/www/manager6/qemu/HDMove.js index 745c7911..8e38b53c 100644 --- a/www/manager6/qemu/HDMove

[pve-devel] [PATCH manager 03/17] whitespace cleanup

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/API2.pm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/API2.pm b/PVE/API2.pm index f2663956..9aad03b1 100644 --- a/PVE/API2.pm +++ b/PVE/API2.pm @@ -19,32 +19,32 @@ use PVE::API2::AccessControl; use PVE::API2::

[pve-devel] [PATCH manager 15/17] hide migrate in contextmenu when no cluster or no rights

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/CmdMenu.js | 9 - www/manager6/qemu/CmdMenu.js | 3 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/CmdMenu.js b/www/manager6/lxc/CmdMenu.js index a96618af..f02f19c4 100644 --- a/www/manager6/lxc/CmdM

[pve-devel] [PATCH manager 17/17] fix #1358: add clustername to datacenter element in tree

2017-07-19 Thread Dominik Csapak
this is useful when having more than one cluster, but all with the same/similar node naming scheme we need to pass this information via the /version api call and get it in the gui Signed-off-by: Dominik Csapak --- PVE/API2.pm | 6 ++ www/manager6/Workspace.js |

[pve-devel] [PATCH manager 12/17] use DiskStorageSelector in lxc/MPEdit.js

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/MPEdit.js | 119 - 1 file changed, 32 insertions(+), 87 deletions(-) diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js index 1238d086..eaab0193 100644 --- a/www/manager6/lxc/MPEdit.j

[pve-devel] [PATCH manager 16/17] disable discard for non-scsi disks

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index aeac7dd0..3db3f3ca 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -18,6 +18,7 @@ Ext.def

[pve-devel] [PATCH manager 10/17] use DiskStorageSelector in qemu/Clone.js

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/qemu/Clone.js | 70 +- 1 file changed, 13 insertions(+), 57 deletions(-) diff --git a/www/manager6/qemu/Clone.js b/www/manager6/qemu/Clone.js index c5dad4da..6b9bcdd9 100644 --- a/www/manager6/qemu/Clone.j

[pve-devel] [PATCH manager 13/17] hide not usable buttons for qemu

2017-07-19 Thread Dominik Csapak
this hides not usuable buttons for qemu e.g. start/shutdown for templates migrate for non-cluster setups Signed-off-by: Dominik Csapak --- www/manager6/qemu/Config.js | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Con

[pve-devel] [PATCH manager 09/17] use DiskStorageSelector in qemu/HDEfi.js

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDEfi.js | 67 +++--- 1 file changed, 4 insertions(+), 63 deletions(-) diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js index 45c9d706..344cbc79 100644 --- a/www/manager6/qemu/HDEfi.js

[pve-devel] [PATCH manager 05/17] get storage info from /version api call in gui

2017-07-19 Thread Dominik Csapak
we parse and save the storage type infos in PVE.Utils.storageformats and can get them with PVE.Utils.getStorageFormat(type) so that we do not have to hardcode the values the returned object contains: * an array formats, which contains the file/volume formats, e.g. raw, qcow2, vmdk * a default

[pve-devel] [PATCH manager 08/17] use DiskStorageSelector in qemu/HDEdit.js

2017-07-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/qemu/HDEdit.js | 84 - 1 file changed, 6 insertions(+), 78 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 8f5c9dbe..aeac7dd0 100644 --- a/www/manager6/qemu/HDEdit

[pve-devel] [PATCH manager 06/17] add new DiskStorageSelector.js

2017-07-19 Thread Dominik Csapak
this is a wrapper for selecting a storage/disk image it is a simple container with 4 form fields inside which can be reused, whenever we need to select a storage for a disk, image etc. we have code similar to this four times already (qemu image creation, lxc mp creation, qemu cloning, qemu efidis

[pve-devel] [PATCH manager 04/17] get storage type info in /version api call

2017-07-19 Thread Dominik Csapak
this will be used in the gui, for selecting/creating disks/mps/etc. this means, that we get the information about a storage from the backend, instead of hardcoding types in the frontend (like the lun selector for iscsi) Signed-off-by: Dominik Csapak --- PVE/API2.pm | 10 ++ 1 file change

[pve-devel] [PATCH manager 00/17] gui storage and other improvements

2017-07-19 Thread Dominik Csapak
this series does a few things: (i did not split it up, because the hunks are near each other, and then only the first applied series would work or none at all) patches 01/17 - 03/17 are for preparing to resolve a cyclic dependency in pve-access-control patches 04/17 - 12/17 are for getting the st

[pve-devel] [PATCH manager 02/17] get the api permissions info from /version

2017-07-19 Thread Dominik Csapak
instead of the /access/ticket api call Signed-off-by: Dominik Csapak --- www/manager6/Workspace.js | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 74c67652..fdade908 100644 --- a/www/manager6/Workspace.js ++

[pve-devel] [PATCH manager 01/17] copy api permission calculation to /version api call

2017-07-19 Thread Dominik Csapak
the code is copied from the /access/ticket api call from the pve-access-control package this will be used instead of the /access/ticket call, because we will be using the /version api call to get info from the backend to the frontend (e.g. storage type capabilities) i do not want to remove the co

[pve-devel] [PATCH storage] add select to plugindata for iscsi(direct)

2017-07-19 Thread Dominik Csapak
this will be used in the gui, for determining if we need to select something from the storage when using for an image Signed-off-by: Dominik Csapak --- this patch is needed for my upcoming series for pve-manager, otherwise one can no longer select luns on the gui then PVE/Storage/ISCSIDirectPlug

Re: [pve-devel] [PATCH manager 0/5] Usability and Esthetics improvement

2017-07-19 Thread Wolfgang Bumiller
On Wed, Jul 19, 2017 at 01:59:51PM +0200, Emmanuel Kasper wrote: > On 07/10/2017 11:19 AM, Dominik Csapak wrote: > > On 07/06/2017 02:01 PM, Emmanuel Kasper wrote: > >> This patch serie tries to iron out some rough aspects of the UI. > >> From the usability perspective the first one is the most imp

Re: [pve-devel] [PATCH manager 0/5] Usability and Esthetics improvement

2017-07-19 Thread Emmanuel Kasper
On 07/10/2017 11:19 AM, Dominik Csapak wrote: > On 07/06/2017 02:01 PM, Emmanuel Kasper wrote: >> This patch serie tries to iron out some rough aspects of the UI. >> From the usability perspective the first one is the most important IMHO >> >> Emmanuel Kasper (5): >> Add a "Run task in background

[pve-devel] applied: [PATCH manager] Use emptyText to inform the user of the value that will set be when the field is empty

2017-07-19 Thread Wolfgang Bumiller
applied On Mon, Jun 26, 2017 at 02:18:05PM +0200, Emmanuel Kasper wrote: > emptyText is not submitted, because it does not count as value when > getSubmitValue() is > called on it in PVE.panel.InputPanel.getValues() > --- > www/manager6/lxc/DNS.js | 3 ++- > 1 file changed, 2 insertions(+), 1 de

[pve-devel] applied: [PATCH pve-manager] Fix pveceph createosd

2017-07-19 Thread Wolfgang Bumiller
applied On Tue, Jul 18, 2017 at 11:07:12AM +0200, Wolfgang Link wrote: > The --filestore flag is now required see doc of ceph. > > If the --bluestore argument is given, a bluestore objectstore will be > created. If --filestore is provided, a legacy FileStore objectstore > will be created. If ne

[pve-devel] applied: [PATCH kernel] add CVE fixes

2017-07-19 Thread Wolfgang Bumiller
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH RFC manager 2/2] Do not link against libdl since we use none of its symbols

2017-07-19 Thread Wolfgang Bumiller
On Tue, Jul 18, 2017 at 05:37:28PM +0200, Emmanuel Kasper wrote: > This fixes the warning: > dpkg-shlibdeps: warning: package could avoid a useless dependency if > debian/pve-manager/usr/bin/pvemailforward was not linked against libdl.so.2 > (it uses none of the library's symbols) > --- > bin/Ma

[pve-devel] applied: [PATCH manager 1/2] Fix #1450 : restore setgid bit on pvemailforward binary

2017-07-19 Thread Wolfgang Bumiller
applied On Tue, Jul 18, 2017 at 05:37:27PM +0200, Emmanuel Kasper wrote: > When calling chown on a setuid/setgid executable, the > setuid/setgid bits are reset to 0. So ordering matters > here. See chown(2). > --- > debian/rules | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --