Re: [pve-devel] [PATCH v6 pve-storage 0/1] FreeNAS storage plugin

On Mon, Jun 19, 2017 at 08:28:57AM +0200, Michael Rasmussen wrote: > Hi Fabian, > If I understand you correctly you want a separate patch for every fix comment? > no. please re-read the rather lengthy part of my e-mail in response to v5 (quoted in full below). a short summary: - individual commi

Re: [pve-devel] [PATCH v6 pve-storage 0/1] FreeNAS storage plugin

Hi Fabian, If I understand you correctly you want a separate patch for every fix comment? On June 19, 2017 8:24:36 AM GMT+02:00, "Fabian Grünbichler" wrote: >On Sat, Jun 17, 2017 at 11:52:41PM +0200, m...@datanom.net wrote: >> From: Michael Rasmussen >> >> This is a patch to be added to v5 of

Re: [pve-devel] [PATCH v6 pve-storage 0/1] FreeNAS storage plugin

On Sat, Jun 17, 2017 at 11:52:41PM +0200, m...@datanom.net wrote: > From: Michael Rasmussen > > This is a patch to be added to v5 of the patch series. > sorry - but like I said this is not how patches are supposed to be sent. please split up your patch series into sensible patches based on wha

Re: [pve-devel] cloudinit for proxmox 5 v2

> BTW, great work for new storage replication code, I will try to finish this this week. > I'm going to test it soon, and maybe try to implement ceph rbd import/export > on top of it) great! ___ pve-devel mailing list pve-devel@pve.proxmox.com https:

Re: [pve-devel] cloudinit for proxmox 5 v2

>>AFAIR I already mentioned that we have no spare time to do it >>for the 5.0 release... Ok thanks Dietmar. could wait for 5.1 ;) (BTW, great work for new storage replication code, I'm going to test it soon, and maybe try to implement ceph rbd import/export on top of it) - Mail original -

Re: [pve-devel] cloudinit for proxmox 5 v2

> Any comments to include cloudinit for proxmox5 ? > (I didn't have any comments on my last month patches serie) AFAIR I already mentioned that we have no spare time to do it for the 5.0 release... ___ pve-devel mailing list pve-devel@pve.proxmox.com ht

[pve-devel] [PATCH 01/20] implement cloudinit v2

Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 155 -- debian/control| 1 + 2 files changed, 153 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1a4860e..5ec5df8 100644 --- a/PVE/QemuServe

[pve-devel] [PATCH 17/20] cloudinit: limit sshkey to 1024 bytes

From: Wolfgang Bumiller Also allowing multiple keys since with some key types and lengths 1024 would fit quite a number of them... Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE

[pve-devel] [PATCH 11/20] delete cloudinit discs instead of adding them as unused

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1a36eb0..c6a0698 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2014,7 +2014,10 @@ s

[pve-devel] [PATCH 02/20] cloud-init changes

From: Wolfgang Bumiller * Add ipconfigX for all netX configuration options and using ip=CIDR, gw=IP, ip6=CIDR, gw6=IP as option names like in LXC. * Adding explicit ip=dhcp and ip6=dhcp options. * Removing the config-update code and instead generating the ide3 commandline in config_to

[pve-devel] [PATCH 10/20] cloudinit: turn ipconfig into a property string

From: Wolfgang Bumiller and don't map ip/gw to address/gateway in the resulting hash. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 110 +- 1 file changed, 59 insertions(+), 51 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/Qe

[pve-devel] [PATCH 07/20] remove FIXME from next_free_nbd_dev

From: Wolfgang Bumiller It's being removed from LXCCreate.pm so it won't be moved to pve-common as qemu-server is then the only place using it. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index

[pve-devel] [PATCH 13/20] cloudinit: use correct dns-search/nameserver config keys

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index df2ba69..b79a1e0 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6789,8 +6789,8 @@ sub g

[pve-devel] [PATCH 12/20] cloudinit: whitespace cleanup

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c6a0698..df2ba69 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -510,19 +

[pve-devel] [PATCH 18/20] cloudinit: parse_volume_id can fail (eg on 'none')

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2ac98ba..084b86a 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6692,7 +6692,7 @@ sub gener

[pve-devel] [PATCH 04/20] cloudinit: use qcow2 for future snapshot support

From: Wolfgang Bumiller The config-disk is now generated into a qcow2 located on a configured storage. It is now also storage-managed and so live-migration and live-snapshotting should work as they do for regular hard drives. Config drives are recognized by their storage name of the form: VMID/vm

[pve-devel] [PATCH 09/20] cloudinit 'hotplug'

From: Wolfgang Bumiller *) always replace old cloudinit images *) apply pending cloudinit changes when generating a new image For cloudinit we now always use vdisk_free before vdisk_alloc in order to always replace old images, this allows us to hotplug a new drive by setting it to `none,media=cd

[pve-devel] [PATCH 20/20] fix sshkeys verification

use same verification than lxc also rename sshkey param to sshkeys (as we can define multiple ssh keys) Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 7 +++ PVE/QemuServer.pm | 10 +- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE

[pve-devel] [PATCH 19/20] modules load : add nbd

Signed-off-by: Alexandre Derumier --- Makefile | 2 ++ debian/rules | 2 ++ modules-load.conf| 1 + nbd-modules-load.conf| 1 + nbd-modules-options.conf | 1 + 5 files changed, 7 insertions(+) create mode 100644 nbd-modules-load.conf create mode 100644 nb

[pve-devel] [PATCH 06/20] delete cloudinit images as if they weren't cdroms

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index fda5640..e0001bb 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -45,6 +45,8 @@

[pve-devel] [PATCH 08/20] check_vm_modify_config_perm: include ipconfig

From: Wolfgang Bumiller include ipconfig in VM.Config.Network Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 8c35c3f..15fbe6d 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.

[pve-devel] cloudinit for proxmox 5 v2

Hi, Any comments to include cloudinit for proxmox5 ? (I didn't have any comments on my last month patches serie) To enable cloudinit, we setup a special cdrom with: qm set vmid -(ide|sata)X storeid:cloudinit then for configuration: ipconfigX: ip=192.168.0.124/24,gw=192.168.0.1 searchdomain:

[pve-devel] [PATCH 03/20] cloud-init : force ifdown ifup at boot

when we change ip address, network configuration is correctly writen in guest, but cloud-init don't apply it and keep previous ip address. workaround with forcing ifdown ifup Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuS

[pve-devel] [PATCH 05/20] cloudinit : support any storeid for configdrive

- changelog: - support any storage and not only qcow2 - cloudinit drive volume no more generated at start. we can now enable|disable cloudinit with qm set vmid -(ide|sata)x storeid:cloudinit qm set vmid -delete (ide|sata)x Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.p

[pve-devel] [PATCH 16/20] parse_vm_config: allow spaces in values

From: Wolfgang Bumiller This time we can't avoid it: nameservers are listed with separating spaces in LXC and we want to stay consistent and use the same format in qemu. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[pve-devel] [PATCH 15/20] cloudinit: nameserver: match lxc format

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8698b8c..98f034c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -516,7 +516,7 @@ my $confdes

[pve-devel] [PATCH 14/20] cloudinit: allow a different hostname

From: Wolfgang Bumiller Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b79a1e0..8698b8c 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -524,6 +524,1