[pve-devel] [PATCH qemu-server] change from dpkg-deb to dpkg-buildpackage

2017-06-09 Thread Thomas Lamprecht
Add debian directory and move the respective files there and add missing (rules, compat, docs). Add a Source section to the control.in file and "build" (sed control.in >control) in the $DEB target as done in most other packages Move the qm verifyapi check to the new "test" target, which gets exec

[pve-devel] [PATCH access-control] change from dpkg-deb to dpkg-buildpackage

2017-06-09 Thread Thomas Lamprecht
add debian directory and move the respective files there and add missing (rules, compat). Add a Source section to the control.in file. Move the verify_api check to the new "test" target, which gets executed before the dh_auto_install target. Cleanup the "clean" target. Signed-off-by: Thomas Lam

[pve-devel] [PATCH storage] change from dpkg-deb to dpkg-buildpackage

2017-06-09 Thread Thomas Lamprecht
add debian directory and move the respective files there and add missing (rules, compat). Move control.in to control as no sed search & replacement must be done. Add a Source section to the control file. Rename the "check" Makefile target to "test" so that the dh_auto_test helper executes it auto

Re: [pve-devel] applied: [PATCH manager 0/5] improve package building

2017-06-09 Thread Dietmar Maurer
> with v2 for #3, and a follow-up commit splitting the Depends: line. > > thanks - IMHO this has been long overdue! Yes, thanks!! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] FreeNAS plugin: Status

2017-06-09 Thread datanom.net
On 2017-06-09 10:03, Fabian Grünbichler wrote: only allowing offline resizing is not possible on a storage plugin level for raw volumes and containers - see PVE::API2::LXC.pm resize_vm API end point and the comment there. you either need to wait for the FreeNAS bug fix or special case your s

[pve-devel] applied: [PATCH manager 0/5] improve package building

2017-06-09 Thread Fabian Grünbichler
with v2 for #3, and a follow-up commit splitting the Depends: line. thanks - IMHO this has been long overdue! On Fri, Jun 09, 2017 at 09:55:23AM +0200, Dominik Csapak wrote: > this series improves the package building: > * makes timestamps/files more consistent > * better file mode/owner > * use

Re: [pve-devel] [PATCH common v3 1/2] Document current handling of reading and updating resolv.conf

2017-06-09 Thread Wolfgang Bumiller
Tests should also be executed from test/Makefile more comments inline On Thu, Apr 13, 2017 at 11:21:49AM +0200, Emmanuel Kasper wrote: > also add unit tests for the two subroutines > --- > src/PVE/INotify.pm| 3 + > test/inotify/resolv.conf_empty_search

Re: [pve-devel] [RFC cluster] factor out corosync methods to own module

2017-06-09 Thread Thomas Lamprecht
On 06/09/2017 01:06 PM, Fabian Grünbichler wrote: Thomas Lamprecht hat am 9. Juni 2017 um 12:56 geschrieben: PVE::Cluster is already quite big, the corosync part is ~250 lines long of 1900 total. Further the corosync part is only needed in a few specialised places (API2/ClusterConfig and CLI/

Re: [pve-devel] [PATCH common v3 2/2] Fix #1234: allows multiple search domains to be set

2017-06-09 Thread Wolfgang Bumiller
Isn't this #1270? Also I think this should be patch 1 - as it looks like the tests from patch 1 assume this patch to be applied? On Thu, Apr 13, 2017 at 11:21:50AM +0200, Emmanuel Kasper wrote: > Changes: > * multiple 'search' entries (up to 6) can be now read and added like the > libc resolver

[pve-devel] [PATCH cluster] pvecm delnode: prevent deleting current node

2017-06-09 Thread Thomas Lamprecht
Else corosync really delete himself from the cluster which pmxcfs cannot really handle and this is a bad idea in general. Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/pvecm.pm index d8ce424..

Re: [pve-devel] [RFC cluster] factor out corosync methods to own module

2017-06-09 Thread Fabian Grünbichler
> Thomas Lamprecht hat am 9. Juni 2017 um 12:56 > geschrieben: > > > PVE::Cluster is already quite big, the corosync part is ~250 lines > long of 1900 total. Further the corosync part is only needed in a few > specialised places (API2/ClusterConfig and CLI/pvecm). > This speaks for factoring o

[pve-devel] [RFC cluster] factor out corosync methods to own module

2017-06-09 Thread Thomas Lamprecht
PVE::Cluster is already quite big, the corosync part is ~250 lines long of 1900 total. Further the corosync part is only needed in a few specialised places (API2/ClusterConfig and CLI/pvecm). This speaks for factoring out this part in a separate perl module as most modules which use Cluster load th

Re: [pve-devel] [pve-guest-common 1/2] get_jobid

2017-06-09 Thread Dietmar Maurer
> > > doesn't this return the first job which has this target node? and not > > > the only job which has this guest ID and target node? > > > > We may also have different replication job types in future, and not all > > of them have a 'target' property... > > hmm.. maybe a more abstract method to

[pve-devel] applied: [PATCH qemu-server] fix #1405: sort pci ids by functions

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH storage 3/3] migrate: insecure: untaint the received ip/port

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH storage 2/3] migrate: don't include the hostname in rsync's rsh command

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH storage 1/3] migrate: use the correct IP with rsync

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] migrate: migration_type setting moved to pve-guest-common

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container] migrate: implement insecure storage migration

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH guest-common] migrate: set migration_type

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH cluster] add sshinfo_to_command_base

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [pve-guest-common 1/2] get_jobid

2017-06-09 Thread Fabian Grünbichler
On Fri, Jun 09, 2017 at 11:43:34AM +0200, Dietmar Maurer wrote: > > > > On June 9, 2017 at 11:17 AM Fabian Grünbichler > > wrote: > > > > > > On Fri, Jun 09, 2017 at 08:19:47AM +0200, Wolfgang Link wrote: > > > --- > > > PVE/ReplicationConfig.pm | 14 ++ > > > 1 file changed, 14 i

[pve-devel] applied: [PATCH manager] tests: override GuestHelper's lockdir

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager] pvereport: improve output and add timeouts to commands

2017-06-09 Thread Thomas Lamprecht
Each command may not run longer than 10 seconds. This avoids situations where no output gets generated because of a infinitely hanging command (e.g. check for dead NFS storage) Also ensure that commands are separated with a new line from each other to improve readability. Signed-off-by: Thomas Lam

[pve-devel] applied: [PATCH guest-common] GuestHelpers: allow overriding $lockdir in test environments

2017-06-09 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [pve-guest-common 1/2] get_jobid

2017-06-09 Thread Dietmar Maurer
> On June 9, 2017 at 11:17 AM Fabian Grünbichler > wrote: > > > On Fri, Jun 09, 2017 at 08:19:47AM +0200, Wolfgang Link wrote: > > --- > > PVE/ReplicationConfig.pm | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.

Re: [pve-devel] [PATCH guest-common] GuestHelpers: allow overriding $lockdir in test environments

2017-06-09 Thread Dietmar Maurer
No, I don't want to generate multiple lock directories ... AFAIK pve-storage also create locks there. > On June 9, 2017 at 10:51 AM Fabian Grünbichler > wrote: > > > On Fri, Jun 09, 2017 at 09:55:58AM +0200, Wolfgang Bumiller wrote: > > --- > > PVE/GuestHelpers.pm | 3 ++- > > 1 file changed,

Re: [pve-devel] [pve-guest-common 1/2] get_jobid

2017-06-09 Thread Fabian Grünbichler
On Fri, Jun 09, 2017 at 08:19:47AM +0200, Wolfgang Link wrote: > --- > PVE/ReplicationConfig.pm | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm > index 01e7206..b4f0fe9 100644 > --- a/PVE/ReplicationConfig.pm > +++ b/PVE

Re: [pve-devel] [pve-guest-common 2/2] set_remote_state

2017-06-09 Thread Fabian Grünbichler
why not use PVE::ReplicatioNState::write_job_state() ? On Fri, Jun 09, 2017 at 08:19:48AM +0200, Wolfgang Link wrote: > --- > PVE/ReplicationState.pm | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm > index be5cf5f..0

Re: [pve-devel] [qemu-server] Qemu implement migration on replicated storage.

2017-06-09 Thread Fabian Grünbichler
same comments as for LXC apply On Fri, Jun 09, 2017 at 08:19:50AM +0200, Wolfgang Link wrote: > --- > PVE/QemuMigrate.pm | 77 > -- > 1 file changed, 69 insertions(+), 8 deletions(-) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > i

Re: [pve-devel] [pve-manager] pvesr set_state

2017-06-09 Thread Thomas Lamprecht
On 06/09/2017 09:59 AM, Thomas Lamprecht wrote: On 06/09/2017 08:19 AM, Wolfgang Link wrote: --- PVE/CLI/pvesr.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index f64a3103..ca8cd59c 100644 --- a/PVE/CLI/pvesr.pm

Re: [pve-devel] [pve-container] LXC implement migration on replicated storage

2017-06-09 Thread Fabian Grünbichler
On Fri, Jun 09, 2017 at 08:19:51AM +0200, Wolfgang Link wrote: > --- > src/PVE/LXC/Migrate.pm | 76 > ++ > 1 file changed, 70 insertions(+), 6 deletions(-) > > diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm > index 2f0244b..cfca82c 10

[pve-devel] [PATCH manager v2 3/5] make language js files consistent

2017-06-09 Thread Dominik Csapak
else every package we build has different orderings for the translated strings Signed-off-by: Dominik Csapak --- changes from v1: * use to_json instead of object * enable utf8 po/po2js.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/po2js.pl b/po/po2js.pl index 6941f5c0

Re: [pve-devel] [PATCH guest-common] GuestHelpers: allow overriding $lockdir in test environments

2017-06-09 Thread Fabian Grünbichler
On Fri, Jun 09, 2017 at 09:55:58AM +0200, Wolfgang Bumiller wrote: > --- > PVE/GuestHelpers.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/PVE/GuestHelpers.pm b/PVE/GuestHelpers.pm > index d066527..16e27a9 100644 > --- a/PVE/GuestHelpers.pm > +++ b/PVE/GuestHelpers.

Re: [pve-devel] FreeNAS plugin: Status

2017-06-09 Thread Fabian Grünbichler
On Thu, Jun 08, 2017 at 08:35:31PM +0200, Michael Rasmussen wrote: > On Thu, 8 Jun 2017 19:38:23 +0200 > Michael Rasmussen wrote: > > > On Thu, 8 Jun 2017 19:21:50 +0200 > > Michael Rasmussen wrote: > > > > > I seem to have found a bug in the API because changing the size through > > > the API

Re: [pve-devel] [PATCH manager 3/5] make language js files consistent

2017-06-09 Thread Dietmar Maurer
> diff --git a/po/po2js.pl b/po/po2js.pl > index 6941f5c0..76a84695 100755 > --- a/po/po2js.pl > +++ b/po/po2js.pl > @@ -67,7 +67,8 @@ foreach my $k (keys %$href) { > #use Data::Dumper; > #print STDERR Dumper(encode_json({test => decode('UTF-8', "müssen")})); > > -my $json = encode_json($catalo

Re: [pve-devel] [pve-manager] pvesr set_state

2017-06-09 Thread Thomas Lamprecht
On 06/09/2017 08:19 AM, Wolfgang Link wrote: --- PVE/CLI/pvesr.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index f64a3103..ca8cd59c 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -288,6 +288,38 @@ __PA

[pve-devel] [RFC pve-manager 1/2] PVE::Replication - pass guest_class to run_replication

2017-06-09 Thread Dietmar Maurer
So that we can (re)use methods from PVE::AbstractConfig. Signed-off-by: Dietmar Maurer --- PVE/Replication.pm| 62 +-- bin/test/replication_test2.pl | 7 - 2 files changed, 36 insertions(+), 33 deletions(-) diff --git a/PVE/Replication.pm

[pve-devel] [PATCH manager] tests: override GuestHelper's lockdir

2017-06-09 Thread Wolfgang Bumiller
Otherwise the user running the tests may either create (and end up being the ownderof) the system wide /var/lock/pve-manager/* files, or the tests will fail (or loop endlessly) if the user doesn't have access to them. --- bin/test/ReplicationTestEnv.pm | 7 +++ 1 file changed, 7 insertions(+)

[pve-devel] [PATCH guest-common] GuestHelpers: allow overriding $lockdir in test environments

2017-06-09 Thread Wolfgang Bumiller
--- PVE/GuestHelpers.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/GuestHelpers.pm b/PVE/GuestHelpers.pm index d066527..16e27a9 100644 --- a/PVE/GuestHelpers.pm +++ b/PVE/GuestHelpers.pm @@ -8,11 +8,12 @@ use PVE::Tools; # We use a separate lock to block migration w

[pve-devel] [RFC pve-manager 2/2] PVE::Replication - remove dependency to PVE::LXC/PVE::QemuServer

2017-06-09 Thread Dietmar Maurer
So that we can move the whole class to package pve-guest-common. Signed-off-by: Dietmar Maurer --- PVE/API2/Replication.pm| 78 PVE/CLI/pvesr.pm | 4 +-- PVE/Replication.pm | 81 ++

[pve-devel] [PATCH manager 4/5] do not let www-data own the static js/html files

2017-06-09 Thread Dominik Csapak
this is neither necessary, nor useful those files are meant to be read only anyway, so there is no gain in them being owned by www-data Signed-off-by: Dominik Csapak --- po/Makefile| 2 +- www/Makefile | 2 +- www/css/Makefile | 2 +- www/css/fonts/Makefile | 2 +- ww

[pve-devel] [PATCH manager 5/5] change from dpkg-deb to dpkg-buildpackage

2017-06-09 Thread Dominik Csapak
for better building pve-manager this moves the copyright file to debian/ the debian/changelog.Debian to debian/changelog we do not need the debian/conffiles anymore (gets autogenerated from files in ./etc/) Signed-off-by: Dominik Csapak --- note that the control.in files still generates a few w

[pve-devel] [PATCH manager 2/5] fix wrong variable syntax

2017-06-09 Thread Dominik Csapak
{$PACKAGE} expands to '{ACKAGE}', meaning we shipped a dir: /usr/share/doc/{ACKAGE}/examples Signed-off-by: Dominik Csapak --- bin/init.d/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/init.d/Makefile b/bin/init.d/Makefile index f984fe13..ed396d4e 100644 --- a/b

[pve-devel] [PATCH manager 3/5] make language js files consistent

2017-06-09 Thread Dominik Csapak
else every package we build has different orderings for the translated strings Signed-off-by: Dominik Csapak --- po/po2js.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/po/po2js.pl b/po/po2js.pl index 6941f5c0..76a84695 100755 --- a/po/po2js.pl +++ b/po/po2js.pl @@ -67,

[pve-devel] [PATCH manager 0/5] improve package building

2017-06-09 Thread Dominik Csapak
this series improves the package building: * makes timestamps/files more consistent * better file mode/owner * use dpkg-buildpackage instead of dpkg-deb after this gets applied, please split the 'Depends:' line in debian/control.in so that one can send patches with those lines in a hunk Dominik C

[pve-devel] [PATCH manager 1/5] add SOURCE_DATE_EPOCH to Makefile

2017-06-09 Thread Dominik Csapak
to get consistent timestamps for most files in the package Signed-off-by: Dominik Csapak --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 00341827..0b7cf3e1 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,7 @@ include defines.mk +export SOURCE_DATE_