[pve-devel] [PATCH common] fix #1388: cpuset: sort members numerically

--- For: master, stable-4 src/PVE/CpuSet.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/CpuSet.pm b/src/PVE/CpuSet.pm index eaa4e3c..92fd18f 100644 --- a/src/PVE/CpuSet.pm +++ b/src/PVE/CpuSet.pm @@ -106,7 +106,7 @@ sub has { sub members { my ($self) = @_;

Re: [pve-devel] Custom Storage Plugin

> However when going to the Summary page for a lizardfs storage Instance > it shows the usages details etc correctly, but the Type comes up as > "Unknown" > > > Is this normal? You need to patch the GUI code to display something else. https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/ma

[pve-devel] Custom Storage Plugin

I've been playing with a Custom Plugin for lizardfs and go the basics working, it mounts and is accessible. Is based off the GlusterfsPlugin. However when going to the Summary page for a lizardfs storage Instance it shows the usages details etc correctly, but the Type comes up as "Unknown"

Re: [pve-devel] [PATCH novnc v2 0/7] upgrade novnc

please disregard this series, i think i found a better solution for the nodejs problem v3 coming tomorrow ;) ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] qemu-img iscsi initiator name

Sorry, i totally missed that this was discussed in Feb. 2016 on the list. Now there should be support in qemu, not only for passing an initiator-name but also CHAP Authentification: https://patchwork.kernel.org/patch/9466379/ If there is an interest to get this sorted-out i can figure out how

[pve-devel] applied: [PATCH qemu-server 1/4] tests: exit with -1 in case of failures

applied to master & stable-4 (and rebased patch 4 for stable-4) On Wed, May 17, 2017 at 12:40:55PM +0200, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > test/run_snapshot_tests.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/run_snapshot

[pve-devel] applied: [PATCH container 1/4] tests: use all target to run tests

applied whole series On Wed, May 17, 2017 at 12:14:12PM +0200, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > src/test/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/test/Makefile b/src/test/Makefile > index 491863d..fdd0271 100644

Re: [pve-devel] [PATCH manager] Fix #1386: track postfix daemon status via postfix@-

On Wed, May 17, 2017 at 11:54:12AM +0200, Emmanuel Kasper wrote: > --- > PVE/API2/Services.pm | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm > index 3ddf5f56..1cbfe2c5 100644 > --- a/PVE/API2/Services.pm > +++ b/PVE/API

[pve-devel] applied: [PATCH 2/2] test/calendar_event_test.pl: regression tests for PVE::CalendarEvent

applied with cleanups (removed duplicate dow) ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] use ReuseAddr for vncproxy

applied to master and stable-4 On Tue, May 16, 2017 at 04:21:01PM +0200, Dominik Csapak wrote: > to avoid "Socket already in use" errors, when quickly opening/closing > console sessions on the webinterface > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 1 + > 1 file changed, 1 ins

[pve-devel] applied: [PATCH 1/2] CalendarEvent.pm: implement parser/utils for systemd like calender exents

thanks for the review - fixed and applied with suggested changes ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server 2/2] fix #1384: fix cpu socket id calculation for hotplug

On Wed, May 17, 2017 at 12:50:08PM +0200, Tobias Böhm wrote: > Am 17.05.2017 um 11:44 schrieb Thomas Lamprecht: > > On 05/17/2017 09:47 AM, Fabian Grünbichler wrote: > > > the case of multiple single-core vcpus was not handled > > > properly > > > > > > Signed-off-by: Fabian Grünbichler > > > ---

Re: [pve-devel] [PATCH qemu-server] Fix #1384: add missing decrement to calculation of socket-id

On Wed, May 17, 2017 at 11:47:10AM +0200, Tobias Böhm wrote: > Am 17.05.2017 um 10:55 schrieb Fabian Grünbichler: > > On Mon, May 15, 2017 at 04:16:12PM +0200, Tobias Böhm wrote: > > > For calculation of "current_core" the input variable id is decremented. > > > For calculation of "current_socket"

[pve-devel] [PATCH manager v2] explicit set button focus respecting the 'dangerous' option

The line: > Ext.MessageBox.defaultButton = me.dangerous ? 2 : 1; just set the button which should get triggered on an keyboard "Enter" if no button is focused currently. But often the 'Yes' buttons is focused so an enter press would trigger it, even on a as 'dangerous' marked option. Fix this, a

Re: [pve-devel] [PATCH qemu-server 2/2] fix #1384: fix cpu socket id calculation for hotplug

Am 17.05.2017 um 11:44 schrieb Thomas Lamprecht: > On 05/17/2017 09:47 AM, Fabian Grünbichler wrote: > > the case of multiple single-core vcpus was not handled > > properly > > > > Signed-off-by: Fabian Grünbichler > > --- > > PVE/QemuServer.pm | 9 +++-- > > 1 file changed, 7 insertions(+

[pve-devel] [PATCH qemu-server 2/4] tests: fix broken snapshot delete tests

these broke when the additional "snapshot-delete" lock was introduced Signed-off-by: Fabian Grünbichler --- test/snapshot-expected/delete/qemu-server/201.conf | 1 + test/snapshot-expected/delete/qemu-server/202.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/test/snapshot-expected/de

[pve-devel] [PATCH qemu-server 3/4] tests: fix broken snapshot create tests

by mocking de/activate vmstate volumes. these were broken by 3a8deb551f2c7648865437961b3593d11bf0591b, which introduced activating/deactivating vmstate volumes for KRBD Signed-off-by: Fabian Grünbichler --- test/snapshot-test.pm | 20 1 file changed, 20 insertions(+) diff -

[pve-devel] [PATCH qemu-server 1/4] tests: exit with -1 in case of failures

Signed-off-by: Fabian Grünbichler --- test/run_snapshot_tests.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/run_snapshot_tests.pl b/test/run_snapshot_tests.pl index 6def87f..38c74f9 100755 --- a/test/run_snapshot_tests.pl +++ b/test/run_snapshot_tests.pl @@ -6,5 +6

[pve-devel] [PATCH qemu-server 4/4] build: run tests on build

Signed-off-by: Fabian Grünbichler --- Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index e3df3e3..7d89454 100644 --- a/Makefile +++ b/Makefile @@ -90,7 +90,7 @@ install: ${PKGSOURCES} .PHONY: deb deb: ${DEB} -${DEB}: ${PKGSOURCES} +${DE

[pve-devel] [PATCH manager] OSD: rename 'remove' to 'destroy'

To have consistency with the CLI tools `pveceph destroyosd` command. This is also more clear about the resulting action, as 'Remove' could also just mean 'Remove from Config', for example. Signed-off-by: Thomas Lamprecht --- www/manager6/ceph/OSD.js | 4 ++-- 1 file changed, 2 insertions(+), 2 d

Re: [pve-devel] ha-manager: add ignore state v2

some comments would be appreciated :-) On 01/24/2017 06:37 PM, Thomas Lamprecht wrote: V2 of this series is a refactored version of v1, the implementation behaves the same. The ignore state is the state where a service has a HA configuration but wants to be unmanaged for a temporary time. Delet

Re: [pve-devel] [PATCH manager v3 0/7] improve tree icons

any comments on this series? ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container 3/4] tests: exit with -1 in case of failures

Signed-off-by: Fabian Grünbichler --- src/test/run_snapshot_tests.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/run_snapshot_tests.pl b/src/test/run_snapshot_tests.pl index 6def87f..38c74f9 100755 --- a/src/test/run_snapshot_tests.pl +++ b/src/test/run_snapshot

[pve-devel] [PATCH container 4/4] build: run tests when building

Signed-off-by: Fabian Grünbichler --- src/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/src/Makefile b/src/Makefile index 928db5e..19931e5 100644 --- a/src/Makefile +++ b/src/Makefile @@ -27,6 +27,10 @@ pct.bash-completion: PVE_GENERATING_DOCS=1 perl -I. -T -e "use PVE:

[pve-devel] [PATCH container 1/4] tests: use all target to run tests

Signed-off-by: Fabian Grünbichler --- src/test/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/test/Makefile b/src/test/Makefile index 491863d..fdd0271 100644 --- a/src/test/Makefile +++ b/src/test/Makefile @@ -1,7 +1,6 @@ RUN_USERNS := lxc-usernsexec -m "b:0:`

[pve-devel] [PATCH container 2/4] tests: fix broken snapshot delete tests

these broke when the additonal "snapshot-delete" lock was introduced. Signed-off-by: Fabian Grünbichler --- src/test/snapshot-expected/delete/lxc/201.conf | 1 + src/test/snapshot-expected/delete/lxc/203.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/src/test/snapshot-expected/delete

Re: [pve-devel] [PATCH 1/2] CalendarEvent.pm: implement parser/utils for systemd like calender exents

Minor inline notes. As for compute_next_events: I like its structure and the looping makes it robust (at least it's harder to forget to update time-piece variables if we add dates etc. when sticking to this style), but it still makes me want to shorten a bit. Wouldn't really make it more readable

[pve-devel] [PATCH manager] Fix #1386: track postfix daemon status via postfix@-

--- PVE/API2/Services.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm index 3ddf5f56..1cbfe2c5 100644 --- a/PVE/API2/Services.pm +++ b/PVE/API2/Services.pm @@ -35,9 +35,16 @@ my $service_name_list = [ 'systemd-timesync

Re: [pve-devel] [PATCH qemu-server 2/2] fix #1384: fix cpu socket id calculation for hotplug

On 05/17/2017 09:47 AM, Fabian Grünbichler wrote: the case of multiple single-core vcpus was not handled properly Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e

[pve-devel] [PATCH storage 10/11] disktest: exit with -1 in case of failures

Signed-off-by: Fabian Grünbichler --- test/run_disk_tests.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/run_disk_tests.pl b/test/run_disk_tests.pl index e50c6f2..d955a02 100755 --- a/test/run_disk_tests.pl +++ b/test/run_disk_tests.pl @@ -6,5 +6,7 @@ use warnings;

[pve-devel] [PATCH storage 04/11] zfstest: improve reset behaviour

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index 5c1120f..4a01bf7 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_te

[pve-devel] [PATCH storage 05/11] zfstest: use truncate instead of dd

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index 4a01bf7..63b2e5a 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolpl

[pve-devel] [PATCH storage 07/11] zfstest: remove unused variable

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index c295e9f..f07eacc 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolplugin.pl @@ -258

[pve-devel] [PATCH storage 08/11] zfstest: skip tests if ZFS is not available

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 5 + 1 file changed, 5 insertions(+) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index f07eacc..b70aad8 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolplugin.pl @@

[pve-devel] [PATCH storage 01/11] zfstest: fix test 17 to actually deactivate storage

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index 53d4a15..263c3be 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolplugin.pl @@ -279,

[pve-devel] [PATCH storage 02/11] zfstest: fix test description

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index 263c3be..fad021b 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolpl

[pve-devel] [PATCH storage 00/11] clean up pve-storage tests

the zfstests could benefit from further reworking/speedup, but this should allow us to run them at build for now (~10s seems acceptable to me). Fabian Grünbichler (11): zfstest: fix test 17 to actually deactivate storage zfstest: fix test description zfstest: wait for devices to settle after

[pve-devel] [PATCH storage 03/11] zfstest: wait for devices to settle after creation

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index fad021b..5c1120f 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolplugin.pl @@ -26

[pve-devel] [PATCH storage 11/11] build: run tests when building deb

Signed-off-by: Fabian Grünbichler --- Makefile | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 386fea6..23a9605 100644 --- a/Makefile +++ b/Makefile @@ -45,7 +45,7 @@ install: pvesm.1 pvesm.bash-completion .PHONY: deb deb: ${DEB} -${DEB}: +${D

[pve-devel] [PATCH storage 06/11] zfstest: fix typos

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index 63b2e5a..c295e9f 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_z

[pve-devel] [PATCH storage 09/11] zfstest: exit with -1 in case of failures

Signed-off-by: Fabian Grünbichler --- test/run_test_zfspoolplugin.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl index b70aad8..bda8348 100755 --- a/test/run_test_zfspoolplugin.pl +++ b/test/run_test_zfspoolplugin.pl @@ -27

Re: [pve-devel] [PATCH qemu-server 1/2] print_cpu_device: cleanup default values

On 05/17/2017 09:47 AM, Fabian Grünbichler wrote: for consistency's sake Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2fb419d..ed6c598 100644 --- a/PVE/QemuServer

Re: [pve-devel] [PATCH qemu-server 1/2] print_cpu_device: cleanup default values

On 05/17/2017 09:47 AM, Fabian Grünbichler wrote: for consistency's sake Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2fb419d..ed6c598 100644 --- a/PVE/QemuServer.p

Re: [pve-devel] [PATCH qemu-server] Fix #1384: add missing decrement to calculation of socket-id

On Mon, May 15, 2017 at 04:16:12PM +0200, Tobias Böhm wrote: > For calculation of "current_core" the input variable id is decremented. > For calculation of "current_socket" this decrement was missing resulting > in a wrong value when "cores" is set to 1. > > Signed-off-by: Tobias Böhm > --- > PV

[pve-devel] [PATCH qemu-server 1/2] print_cpu_device: cleanup default values

for consistency's sake Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2fb419d..ed6c598 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1720,9 +1720,8 @@ sub pr

[pve-devel] [PATCH qemu-server 2/2] fix #1384: fix cpu socket id calculation for hotplug

the case of multiple single-core vcpus was not handled properly Signed-off-by: Fabian Grünbichler --- PVE/QemuServer.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ed6c598..d480d55 100644 --- a/PVE/QemuServer.pm +++ b/P

[pve-devel] [PATCH novnc v2 7/7] build from prebuilt app.js and add 'from-source' make target

this patch changes the 'deb' target so that it builds the package from the included, prebuilt app.js, and it adds a new target 'from-source' which uses npm/node to build the app.js (using the build script from novnc; it also autobuilds the package when using this) when npm is not installed, you ge

[pve-devel] [PATCH novnc v2 2/7] change from tgz to submodule

Signed-off-by: Dominik Csapak --- .gitmodules | 3 +++ Makefile| 50 ++ novnc | 1 + 3 files changed, 30 insertions(+), 24 deletions(-) create mode 100644 .gitmodules create mode 16 novnc diff --git a/.gitmodules b/.gitmodules new

[pve-devel] [PATCH novnc v2 5/7] remove old unused patches

Signed-off-by: Dominik Csapak --- debian/patches/customize-html-tpl.diff | 207 - debian/patches/fix-CtrlAltDel-button-mobile.patch | 18 - debian/patches/fix-base-css.patch | 195 - debian/patches/fix-ie11-resize.patch | 11 - .../fix-websock

[pve-devel] [PATCH novnc v2 3/7] add new rebased patches

adds the new rebased patches, based on current novnc master notable changes: * (most of) our code is in an es6 module, opposed to patching the ui.js * removed our sendkeys menu in favor of the novnc one * you can now enter fullscreen from a popup console * when a vm resizes its resolution, the canv

[pve-devel] [PATCH novnc v2 4/7] upgrade novnc to commit b0061a3c49dc25a71f7b0a9a1f31a8befe787cb4

novnc changed quiet a bit, so we have to update the Makefile, add a line to the debian rules file, and to adjust the install file Signed-off-by: Dominik Csapak --- Makefile | 8 ++-- debian/changelog | 6 ++ debian/install| 30 +++--- d

[pve-devel] [PATCH novnc v2 6/7] add prebuilt app.js

this patch includes a prebuilt app.js for the novnc code, since using the babel-module loader shim is not suited for production use sadly on stretch npm is only available from nodejs.org (and not from the debian repositories) and not all needed dependencies are available as debian packages (e.g. b

[pve-devel] [PATCH novnc v2 1/7] delete novnc.tgz

Signed-off-by: Dominik Csapak --- novnc.tgz | Bin 12153984 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 novnc.tgz diff --git a/novnc.tgz b/novnc.tgz deleted file mode 100644 index f997566..000 Binary files a/novnc.tgz and /dev/null differ -- 2.11.0 _

[pve-devel] [PATCH novnc v2 0/7] upgrade novnc

this series upgrades novnc, our patches, and the git structure changes from v1: * change to use submodule (we have to create a mirror_novnc repo under git.proxmox.com/git/mirror_novnc when this patch gets applied) * use prebuilt app.js instead of babel-shim (because using the shim is not recom