Re: [pve-devel] [PATCH manager 2/2] Fix #1048: vzdump: include job-* hook logs in email

2016-07-06 Thread Fabian Grünbichler
this is missing the HTML mail part and there is a newline before the "post" part.. also, the layout is kinda wonky, but not sure how/whether to fix that: Jul 07 08:25:01 INFO: HOOK: job-start Jul 07 08:25:01 INFO: HOOK-ENV: dumpdir=/backups/dump;storeid=backups 100: Jul 07 08:25:01 INFO: St

Re: [pve-devel] [PATCH manager] fix surviving update store

2016-07-06 Thread Fabian Grünbichler
applied On Mon, Jul 04, 2016 at 01:16:10PM +0200, Dominik Csapak wrote: > when a load of an update store was ongoing and stopUpdate > was called, the task could not be canceled, and the store > would remain indefinitely > > this patch sets 'isStopped' of the store on stopUpdate > and checks it on

Re: [pve-devel] [PATCH manager] fix undefined value warning in resources api call

2016-07-06 Thread Fabian Grünbichler
applied On Tue, Jul 05, 2016 at 02:45:35PM +0200, Wolfgang Bumiller wrote: > With the new calculation $pe->{maxcpu} was used before being > initialized to zero. Moving the initialization up. > Additionally setting $pe->{cpu} to $entry->{cpu} if maxcpu > is not set seems pointless as with its facto

Re: [pve-devel] [PATCH manager 2/4] fix lxc hostname editing

2016-07-06 Thread Fabian Grünbichler
applied patches 1, 3 and 4 On Wed, Jul 06, 2016 at 01:54:49PM +0200, Dominik Csapak wrote: > >>> > >>>not sure if localhost itself is not a particulary good placeholder, as > >>>it is not unique, and will create a duplicate entry in the /etc/hosts > >>>container > >> > >>The issue was that on the

Re: [pve-devel] pve-kernel-4.4.10-1-pve woes

2016-07-06 Thread Michael Rasmussen
On Wed, 6 Jul 2016 12:46:30 -0400 Eric Blevins wrote: > Might not be your problem but there is a known issue with IPoIB and NFS > resulting in a deadlock. > > > Originally only the mlx4 driver was fixed: > https://lkml.org/lkml/2014/5/11/50 > I noticed qib was patched earlier this year: > http:

Re: [pve-devel] pve-kernel-4.4.10-1-pve woes

2016-07-06 Thread Eric Blevins
Might not be your problem but there is a known issue with IPoIB and NFS resulting in a deadlock. Originally only the mlx4 driver was fixed: https://lkml.org/lkml/2014/5/11/50 I noticed qib was patched earlier this year: http://comments.gmane.org/gmane.linux.drivers.rdma/32914 On Mon, Jul 4, 20

Re: [pve-devel] [PATCHv2] Add support for multipath-backed direct attached storage

2016-07-06 Thread Dmitry Petuhov
Thanks for feedback! Using file is just single use case, to show idea. I'm currently working on Netapp-specific extension to fully control its LUNs from PVE and to get wwn-name associations from there. I think, it will take couple weeks (it was hard to find API for "7-mode" Netapp SANs, but I d

Re: [pve-devel] [PATCH storage 2/3] rbd: use address-list for monhost

2016-07-06 Thread Wolfgang Bumiller
I meant to Cc Alwin Antreich on this patch but forgot, so there. (Not sure if you're watching the pve-devel list.) Note that while this is a backend patch it'll also show an error on the GUI when clicking OK. A GUI update to mark the field as red while typing still has to be made. On Wed, Jul 06,

[pve-devel] [PATCH storage 2/3] rbd: use address-list for monhost

2016-07-06 Thread Wolfgang Bumiller
This way we get parameter verification on monitor addresses as well as the ability to pass multiple `--monhost` arguments to `pvesm add`. Since our '-list' schemas default to using commas we now need to properly support these, so all uses of the monhost property now replace all of semicolon, space

[pve-devel] [PATCH storage 3/3] Remove unused pve-storage-monhost format

2016-07-06 Thread Wolfgang Bumiller
--- PVE/Storage/RBDPlugin.pm | 12 1 file changed, 12 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 55c307b..d189fe3 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -222,18 +222,6 @@ sub rbd_volume_info { # Configuratio

[pve-devel] [PATCH storage 1/3] rbd: path: don't build the entire path if we don't use it

2016-07-06 Thread Wolfgang Bumiller
--- PVE/Storage/RBDPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 2ef7573..ced9af0 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -299,10 +299,12 @@ sub path { my ($vtype, $

Re: [pve-devel] [PVE-User] Proxmox storage -> adding ceph storage monhost issue

2016-07-06 Thread Dominik Csapak
On 07/06/2016 03:03 PM, Wolfgang Bumiller wrote: On Wed, Jul 06, 2016 at 02:16:41PM +0200, Alwin Antreich wrote: Hi all, there is an issue when adding IPs in the storage.cfg file at the line monhost, when formatted with commas as opposed to spaces as separator between IPs. We expect semicolo

Re: [pve-devel] [PATCHV2 4/4] Use git archive instead of rsync to build tarball.

2016-07-06 Thread Wolfgang Bumiller
On Wed, Jul 06, 2016 at 10:21:19AM +0200, Wolfgang Link wrote: > --- > Makefile | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Makefile b/Makefile > index f4eae05..edf2cc2 100644 > --- a/Makefile > +++ b/Makefile > @@ -16,7 +16,8 @@ all: ${DEB} > > ${DEB} deb:

Re: [pve-devel] [PATCHV2 2/4] Revert commit 18335ece8876f7ef0b745c37de555646314c1943

2016-07-06 Thread Wolfgang Bumiller
On Wed, Jul 06, 2016 at 10:21:17AM +0200, Wolfgang Link wrote: > We like to have the dog binaries in /usr/sbin and not in /usr/bin It would also be nice if the filename hinted at that and followed the naming convention (.patch suffix) ;-) Ideally you'd use `git revert` and `git format-patch` on a

Re: [pve-devel] [PATCHV2 3/4] Fix systemd start condition

2016-07-06 Thread Wolfgang Bumiller
On Wed, Jul 06, 2016 at 10:21:18AM +0200, Wolfgang Link wrote: > Sheepdog requires on corosync to start successfully. > In Proxmox VE there is no syslog.target so remove it to avoid warnings. > --- > debian/patches/series | 3 ++- > debian/patches/systemd-adaptation.patch | 13 +

Re: [pve-devel] [pve-manager 4/4] Set VirtIO drivers as default when using the Qemu Wizard and the OS Type is Linux

2016-07-06 Thread Emmanuel Kasper
On 07/06/2016 02:15 PM, Dominik Csapak wrote: > a very good idea, but i would like to have a more general approach > > instead of listening to each radiobutton, > > maybe we can listen to the whole group, then create an instance of the > corresponding class and set the value in the target yes th

Re: [pve-devel] [pve-manager 4/4] Set VirtIO drivers as default when using the Qemu Wizard and the OS Type is Linux

2016-07-06 Thread Dominik Csapak
a very good idea, but i would like to have a more general approach instead of listening to each radiobutton, maybe we can listen to the whole group, then create an instance of the corresponding class and set the value in the target with this approach we would have to do either: write a class

Re: [pve-devel] [pve-manager 3/4] USe PVE.qemu.OSDefaults statics to get defaults for NIC and Storage Controller

2016-07-06 Thread Dominik Csapak
comment inline On 07/06/2016 10:32 AM, Emmanuel Kasper wrote: --- www/manager6/form/ControllerSelector.js | 2 +- www/manager6/qemu/NetworkEdit.js| 2 +- www/manager6/qemu/OSDefaults.js | 8 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/www/manager6/fo

Re: [pve-devel] [pve-manager 1/4] Rename Wizard Component aliases using camelCase

2016-07-06 Thread Dominik Csapak
looks good, but i think we can also drop the [] On 07/06/2016 10:32 AM, Emmanuel Kasper wrote: this is ExtJS recommended practise, follows most of our conventions and is necessary for querying components with Ext.ComponentQuery.query() without escaping the dots in the component widget name. ---

Re: [pve-devel] [PATCH manager 2/4] fix lxc hostname editing

2016-07-06 Thread Dominik Csapak
not sure if localhost itself is not a particulary good placeholder, as it is not unique, and will create a duplicate entry in the /etc/hosts container The issue was that on the backend side if no hostname is set we do use 'localhost' rather than 'ct$vmid' as the gui suggested. it seems the be

[pve-devel] [PATCH manager 1/2] vzdump: safer cp call

2016-07-06 Thread Wolfgang Bumiller
--- PVE/VZDump.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 1e00c2d..45baca6 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -1067,7 +1067,7 @@ sub exec_backup_task { close ($logfd) if $logfd; if ($task->{tmplog} && $t

[pve-devel] [PATCH manager 2/2] Fix #1048: vzdump: include job-* hook logs in email

2016-07-06 Thread Wolfgang Bumiller
--- PVE/VZDump.pm | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 45baca6..8216ce4 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -363,7 +363,7 @@ sub read_vzdump_defaults { } sub sendmail { -my ($self,

Re: [pve-devel] [PATCH manager 2/4] fix lxc hostname editing

2016-07-06 Thread Emmanuel Kasper
On 07/06/2016 12:39 PM, Wolfgang Bumiller wrote: > On Wed, Jul 06, 2016 at 12:05:44PM +0200, Emmanuel Kasper wrote: >> Hi >> I put the comments inline >> >>> also instead of simply setting the emptyText to the name on >>> tab creation, we load the window, which then gets the actual value >> acked >

Re: [pve-devel] [PATCH manager 2/4] fix lxc hostname editing

2016-07-06 Thread Wolfgang Bumiller
On Wed, Jul 06, 2016 at 12:05:44PM +0200, Emmanuel Kasper wrote: > Hi > I put the comments inline > > > also instead of simply setting the emptyText to the name on > > tab creation, we load the window, which then gets the actual value > acked > > > > Signed-off-by: Dominik Csapak > > --- > > w

Re: [pve-devel] [PATCH manager 2/4] fix lxc hostname editing

2016-07-06 Thread Emmanuel Kasper
Hi I put the comments inline > also instead of simply setting the emptyText to the name on > tab creation, we load the window, which then gets the actual value acked > Signed-off-by: Dominik Csapak > --- > www/manager6/lxc/DNS.js | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-)

Re: [pve-devel] [PATCH manager 4/4] reload lxc resources also on activate

2016-07-06 Thread Emmanuel Kasper
Reviewed-By: Emmanuel Kasper On 07/05/2016 05:06 PM, Dominik Csapak wrote: > in a previous commit (829ded13) we changed the reload > from the activate event to afterrender, because > activate will not be fired as a lazyitem > > but this only fires once, so we also reload on activate. > with the

Re: [pve-devel] [PATCH manager 3/4] fire activate event for lazyitems in tabpanels

2016-07-06 Thread Emmanuel Kasper
Reviewed-By: Emmanuel Kasper On 07/05/2016 05:06 PM, Dominik Csapak wrote: > when changing tabs which are lazyitems, > there will be no activate event for the content of the tab > > so we fire it manually on tabchange (if the new card has the > lazyitems plugin activated) as we do it for the hid

Re: [pve-devel] [PATCH manager 1/4] correctly delete name of a qemu vm

2016-07-06 Thread Emmanuel Kasper
Reviewed-by: Emmanuel Kasper On 07/05/2016 05:06 PM, Dominik Csapak wrote: > we mistakenly sent > 'name:' > instead of: > 'delete:name' > > in case of an empty name of qemu guest > which lead to an error message that it is > not a valid dns name > > Signed-off-by: Dominik Csapak > --- > www/m

[pve-devel] [pve-manager 1/4] Rename Wizard Component aliases using camelCase

2016-07-06 Thread Emmanuel Kasper
this is ExtJS recommended practise, follows most of our conventions and is necessary for querying components with Ext.ComponentQuery.query() without escaping the dots in the component widget name. --- www/manager6/form/BusTypeSelector.js | 2 +- www/manager6/form/ControllerSelector.js | 4 ++-

[pve-devel] [pve-manager 4/4] Set VirtIO drivers as default when using the Qemu Wizard and the OS Type is Linux

2016-07-06 Thread Emmanuel Kasper
virtio-blk and virtio-net have been in the kernel since 2.6.25 released in 2008, so it safe to assume distributions using the l26 type will have these drivers. --- www/manager6/qemu/CreateWizard.js | 3 ++- www/manager6/qemu/OSTypeEdit.js | 36 2 files chan

[pve-devel] [pve-manager 2/4] Add new ExtJS class to hold OS-dependant wizard defaults

2016-07-06 Thread Emmanuel Kasper
--- www/manager6/Makefile | 1 + www/manager6/qemu/OSDefaults.js | 21 + 2 files changed, 22 insertions(+) create mode 100644 www/manager6/qemu/OSDefaults.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 92969b3..e5b3667 100644 --- a/www/manager6

[pve-devel] [pve-manager 3/4] USe PVE.qemu.OSDefaults statics to get defaults for NIC and Storage Controller

2016-07-06 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 2 +- www/manager6/qemu/NetworkEdit.js| 2 +- www/manager6/qemu/OSDefaults.js | 8 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.

[pve-devel] Pre select virtio-blk and virtio-net when creating a VM and the Os Type is a modern Linux

2016-07-06 Thread Emmanuel Kasper
Hi This patch series adds capabilities to store Qemu Wizard Defaults, and use these capabilities to set virtio by default for Linux machines. Implementation: We listen for the 'change' event sent by the 'l26' ( Linux 2.6+ ) radio box, and changes the value of the target controller. Deselecting '

[pve-devel] [PATCHV2 3/4] Fix systemd start condition

2016-07-06 Thread Wolfgang Link
Sheepdog requires on corosync to start successfully. In Proxmox VE there is no syslog.target so remove it to avoid warnings. --- debian/patches/series | 3 ++- debian/patches/systemd-adaptation.patch | 13 + 2 files changed, 15 insertions(+), 1 deletion(-) create mo

[pve-devel] [PATCHV2 4/4] Use git archive instead of rsync to build tarball.

2016-07-06 Thread Wolfgang Link
--- Makefile | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index f4eae05..edf2cc2 100644 --- a/Makefile +++ b/Makefile @@ -16,7 +16,8 @@ all: ${DEB} ${DEB} deb: ${SDSRC} rm -rf ${SDDIR} - tar xf ${SDSRC} + mkdir ${SDDIR} +

[pve-devel] [PATCHV2 1/4] Upgrade to Sheepdog Version 1.0.0

2016-07-06 Thread Wolfgang Link
--- Makefile | 8 debian/changelog | 6 ++ debian/copyright | 10 +- debian/patches/cleanup-systemd-service.patch | 2 +- debian/postinst | 5 + deb

[pve-devel] [PATCHV2] Upgrade to Sheepdog V1.0

2016-07-06 Thread Wolfgang Link
Upgrade to version 1.0. Change the systemd start-up condition wait until corosync is up. Rework of the tarball build-system. Changes PATCHV2: PATCH1 download only current git brache to minimize download time. PATCH2 convert the git revert to quilt patch. PATCH3 also remove syslog.target __

[pve-devel] [PATCHV2 2/4] Revert commit 18335ece8876f7ef0b745c37de555646314c1943

2016-07-06 Thread Wolfgang Link
We like to have the dog binaries in /usr/sbin and not in /usr/bin --- debian/patches/revert_commit | 26 ++ debian/patches/series| 1 + 2 files changed, 27 insertions(+) create mode 100644 debian/patches/revert_commit diff --git a/debian/patches/revert_commit b/d