Re: [pve-devel] [RFC v2 container] added 'pct df'

2016-07-05 Thread Wolfgang Bumiller
> On July 5, 2016 at 7:24 PM Dietmar Maurer wrote: > > > > This works on both online and offline containers. Offline > > containers get mounted (with a 'mounted' lock) during the > > operation. > > Mounting a container can take a lone time, and can hang completely. > I am quit unsure if we wan

Re: [pve-devel] [PATCH V2] Add some extra debug information to the report.

2016-07-05 Thread Dietmar Maurer
It would be helpful if you include changelogs when you send several versions of the same patch... > On July 5, 2016 at 12:21 PM Wolfgang Link wrote: > > > There were no useful information about block device. > ___ pve-devel mailing list pve-devel@pve

Re: [pve-devel] [RFC v2 container] added 'pct df'

2016-07-05 Thread Dietmar Maurer
> This works on both online and offline containers. Offline > containers get mounted (with a 'mounted' lock) during the > operation. Mounting a container can take a lone time, and can hang completely. I am quit unsure if we want that with a synchronous API call? __

[pve-devel] [PATCH manager 4/4] reload lxc resources also on activate

2016-07-05 Thread Dominik Csapak
in a previous commit (829ded13) we changed the reload from the activate event to afterrender, because activate will not be fired as a lazyitem but this only fires once, so we also reload on activate. with the lazyitem/tabchange fix from a previous commit, this has now the correct behaviour Signed

[pve-devel] [PATCH manager 1/4] correctly delete name of a qemu vm

2016-07-05 Thread Dominik Csapak
we mistakenly sent 'name:' instead of: 'delete:name' in case of an empty name of qemu guest which lead to an error message that it is not a valid dns name Signed-off-by: Dominik Csapak --- www/manager6/qemu/Options.js | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(

[pve-devel] [PATCH manager 2/4] fix lxc hostname editing

2016-07-05 Thread Dominik Csapak
we showed 'CT' (for example CT100) as hostname when we did not have one, but we set it to 'localhost' on starting the container also instead of simply setting the emptyText to the name on tab creation, we load the window, which then gets the actual value Signed-off-by: Dominik Csapak --- www/ma

[pve-devel] [PATCH manager 3/4] fire activate event for lazyitems in tabpanels

2016-07-05 Thread Dominik Csapak
when changing tabs which are lazyitems, there will be no activate event for the content of the tab so we fire it manually on tabchange (if the new card has the lazyitems plugin activated) as we do it for the hide event Signed-off-by: Dominik Csapak --- www/manager6/panel/ConfigPanel.js | 5

Re: [pve-devel] [PATCHv2] Add support for multipath-backed direct attached storage

2016-07-05 Thread Wolfgang Bumiller
We're still unsure about the real use case. If you can add a device to a list manually then it's also not much more work to add a raw device to a VM via the commandline. In both cases you need to access the console, and you typically don't add/remove/move disks around constantly, so it's just a set

Re: [pve-devel] [PATCH manager] fix surviving update store

2016-07-05 Thread Dominik Csapak
What I am wondering is why do we treat the UpdateStore requests serially in the first place ? i think the intention was that if you have multiple updatestores, we do not want to bombard the backend with api requests, but send them one after another ___

Re: [pve-devel] [PATCH manager] fix surviving update store

2016-07-05 Thread Emmanuel Kasper
On 07/04/2016 01:16 PM, Dominik Csapak wrote: > when a load of an update store was ongoing and stopUpdate > was called, the task could not be canceled, and the store > would remain indefinitely I can reproduce the problem you mention here ( when a node in a cluster becomes unavailable in the netw

[pve-devel] [PATCH manager] fix undefined value warning in resources api call

2016-07-05 Thread Wolfgang Bumiller
With the new calculation $pe->{maxcpu} was used before being initialized to zero. Moving the initialization up. Additionally setting $pe->{cpu} to $entry->{cpu} if maxcpu is not set seems pointless as with its factor (maxcpu) initialized to zero it is cancelled out anyway. --- PVE/API2/Cluster.pm

Re: [pve-devel] [PATCH common] fix mac address generation limitation

2016-07-05 Thread Fabian Grünbichler
applied On Tue, Jul 05, 2016 at 12:40:23PM +0200, Wolfgang Bumiller wrote: > Commit de9a267 introduced vec() to optimize the generation > by using binary operations instead of converting back and > forth between hex and strings, but forgot to switch over to > the binary sha1 method. This resulted

[pve-devel] [PATCH common] fix mac address generation limitation

2016-07-05 Thread Wolfgang Bumiller
Commit de9a267 introduced vec() to optimize the generation by using binary operations instead of converting back and forth between hex and strings, but forgot to switch over to the binary sha1 method. This resulted in only the first 6 hex digits of the output string making up the address. --- src/

Re: [pve-devel] [PATCH V2] Add some extra debug information to the report.

2016-07-05 Thread Fabian Grünbichler
applied, thanks On Tue, Jul 05, 2016 at 12:21:31PM +0200, Wolfgang Link wrote: > There were no useful information about block device. > --- > PVE/Report.pm | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 4d15ef5..8

[pve-devel] [PATCH V2] Add some extra debug information to the report.

2016-07-05 Thread Wolfgang Link
There were no useful information about block device. --- PVE/Report.pm | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 4d15ef5..89714b8 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -12,7 +12,9 @@ my @general = ('hostna

Re: [pve-devel] [PATCH] Add some extra debug information to the report.

2016-07-05 Thread Wolfgang Bumiller
On Tue, Jul 05, 2016 at 11:20:02AM +0200, Wolfgang Link wrote: > There were no useful information about block device. > --- > PVE/Report.pm | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 4d15ef5..99beca2 100644 > -

Re: [pve-devel] [PATCH] Add some extra debug information to the report.

2016-07-05 Thread Fabian Grünbichler
comments inline On Tue, Jul 05, 2016 at 11:20:02AM +0200, Wolfgang Link wrote: > There were no useful information about block device. > --- > PVE/Report.pm | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 4d15ef5..9

Re: [pve-devel] [PATCH v3 container] include custom lxc options when displaying config

2016-07-05 Thread Wolfgang Bumiller
applied On Tue, Jul 05, 2016 at 10:30:10AM +0200, Fabian Grünbichler wrote: > this makes the "pct config" output more complete, the object > returned by the API path contains the lxc options as parsed > by our config parser, e.g.: > >"lxc" : [ > [ > "lxc.cap.keep", > "

[pve-devel] [PATCH] Add some extra debug information to the report.

2016-07-05 Thread Wolfgang Link
There were no useful information about block device. --- PVE/Report.pm | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 4d15ef5..99beca2 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -12,7 +12,9 @@ my @general = ('hostna

[pve-devel] [PATCH 2/4] Revert commit 18335ece8876f7ef0b745c37de555646314c1943

2016-07-05 Thread Wolfgang Link
We like to have the dog binaries in /usr/sbin and not in /usr/bin --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 147dc5c..39baf35 100644 --- a/Makefile +++ b/Makefile @@ -27,7 +27,9 @@ ${DEB} deb: ${SDSRC} ${SDSRC} download: r

[pve-devel] [PATCH 4/4] Use git archive instead of rsync to build tarball.

2016-07-05 Thread Wolfgang Link
--- Makefile | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 39baf35..57a8e9d 100644 --- a/Makefile +++ b/Makefile @@ -16,7 +16,8 @@ all: ${DEB} ${DEB} deb: ${SDSRC} rm -rf ${SDDIR} - tar xf ${SDSRC} + mkdir ${SDDIR} +

[pve-devel] Upgrade to Sheepdog V1.0

2016-07-05 Thread Wolfgang Link
Upgrade to version 1.0. Change the systemd start-up condition wait until corosync is up. Rework of the tarball build-system. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 1/4] Upgrade to Sheepdog Version 1.0.0

2016-07-05 Thread Wolfgang Link
--- Makefile | 8 debian/changelog | 6 ++ debian/copyright | 10 +- debian/patches/cleanup-systemd-service.patch | 2 +- debian/postinst | 5 + deb

[pve-devel] [PATCH 3/4] Fix systemd start condition

2016-07-05 Thread Wolfgang Link
Sheepdog requires on corosync to start successfully. --- debian/patches/series | 3 ++- debian/patches/systemd-adaptation.patch | 12 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 debian/patches/systemd-adaptation.patch diff --git a/debian/pa

[pve-devel] [PATCH v3 container] include custom lxc options when displaying config

2016-07-05 Thread Fabian Grünbichler
this makes the "pct config" output more complete, the object returned by the API path contains the lxc options as parsed by our config parser, e.g.: "lxc" : [ [ "lxc.cap.keep", "sys_time" ], [ "lxc.cap.drop", "abc" ], [

Re: [pve-devel] [PATCH storage 1/2] add tagged_only option to LVM storage

2016-07-05 Thread Wolfgang Bumiller
applied both patches On Tue, Jun 21, 2016 at 03:13:45PM +0200, Fabian Grünbichler wrote: > to filter volumes by the 'pve-vm-ID' tag, which is set on > all volumes created via the PVE storage layer. > --- > Note: this should fix setups like that described in > https://forum.proxmox.com/threads/unab

Re: [pve-devel] [PATCH common] fix 1046: add non-snapshotted disks as unused

2016-07-05 Thread Wolfgang Bumiller
applied all 3 patches On Mon, Jul 04, 2016 at 01:04:12PM +0200, Fabian Grünbichler wrote: > --- > Note: abstract part, apply together with container and qemu-server patch > > src/PVE/AbstractConfig.pm | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/src/PVE/AbstractConfig

Re: [pve-devel] [PATCH manager] build-depends: add liblocale-po-perl

2016-07-05 Thread Wolfgang Bumiller
On Tue, Jul 05, 2016 at 09:44:24AM +0200, Fabian Grünbichler wrote: > On Wed, Jun 29, 2016 at 02:49:18PM +0200, Wolfgang Bumiller wrote: > > applied > > > > and cherry-picked for stable-3 as well ;) Ah yes, thanks. > > > On Tue, Jun 28, 2016 at 02:54:36PM +0200, Wolfgang Bumiller wrote: > > >

Re: [pve-devel] [PATCH manager] build-depends: add liblocale-po-perl

2016-07-05 Thread Fabian Grünbichler
On Wed, Jun 29, 2016 at 02:49:18PM +0200, Wolfgang Bumiller wrote: > applied > and cherry-picked for stable-3 as well ;) > On Tue, Jun 28, 2016 at 02:54:36PM +0200, Wolfgang Bumiller wrote: > > --- > > debian/control.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/debian/cont

Re: [pve-devel] [pve-manager] add ca-certificates as required depency

2016-07-05 Thread Fabian Grünbichler
applied (and backported to stable-3 as well) On Mon, Jul 04, 2016 at 02:52:59PM +0200, Emmanuel Kasper wrote: > ca-certificates provides the necessary root ca certificates > to connect to the PVE enterprise repositories > The package was always installed since pve-manager 3.1-13 as an indirect > '

Re: [pve-devel] [PATCH qemu-server] buildsys: only deb should be phony; start by removing debs

2016-07-05 Thread Fabian Grünbichler
applied On Mon, Jul 04, 2016 at 08:33:57AM +0200, Wolfgang Bumiller wrote: > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 1502cce..4984e4b 100644 > --- a/Makefile > +++ b/Makefile > @@ -89,8 +89,9 @@ install: ${PKGSOURCES}

Re: [pve-devel] [PATCH qemu-server v2] disable usb hotplug for now

2016-07-05 Thread Fabian Grünbichler
applied On Mon, Jul 04, 2016 at 03:24:20PM +0200, Dominik Csapak wrote: > we have a few problems with hotplug at the moment: > qemu may add usb hubs when adding usb devices but fails to remove them > when removing the usb device (this is a qemu bug) > > also when starting a guest with a usb devic