Adressed comments by Wolfgang B.
changes since v2:
* fix patch 0015-backup-modify-job-api.patch and
0049-backup-bdrv_set_enable_write_cache-is-no-more.patch where I missed two
checks if target is NULL, this fixes backup creation which was broken in v2
* add patch 0053-vma-use-BlockBackend-on-e
Signed-off-by: Thomas Lamprecht
Cc: Wolfgang Bumiller
---
changes since v1:
* fixed issues with a possible null pointer dereference, mentioned by wolfgang
* added patch which uses the BlockBackend to reference the BlockDeviceState
and thus fixes a failing assert caused by the unreferenced BDS
They were remove from patches/series in the previous commit.
Signed-off-by: Thomas Lamprecht
---
...move-the-unused-request-cancellation-code.patch | 98 ---
...-do-not-read-write-MSR_TSC_AUX-from-KVM-i.patch | 38 -
...nc-clear-vs-tlscreds-after-unparenting-it.patch | 38 -
.
One minor remark: I find error messages should get to the point early
and think a simple "can't delete [source] disks with snapshots" would be
sufficient. Personally I parse messages by looking for keywords first
making "you can't move a disk with snapshots" a confusing first half of
a sentence.
O
die if "delete source disk" is enabled, because a disk that
is referenced by snapshots must not be deleted.
---
PVE/API2/Qemu.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index c0a72c0..6a1a459 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.
this is no longer needed, if the moved disk was referenced
by a snapshot we have already died early, and the config is
locked.
---
PVE/API2/Qemu.pm | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 6a1a459..e6c082e 10064
verified and applied.
> Dominik Csapak hat am 20. Juni 2016 um 12:36
> geschrieben:
>
>
> we only added the % of the vms in a pool
> which lead to wrong results
> e.g. having a pool with 3 vms with 4 cores each and a
> cpu usage of 50% each (2 cores at 100%)
> lead to :
>
> vm1 50%
> vm2
They were remove from patches/series in the previous commit.
Signed-off-by: Thomas Lamprecht
---
...move-the-unused-request-cancellation-code.patch | 98 ---
...-do-not-read-write-MSR_TSC_AUX-from-KVM-i.patch | 38 -
...nc-clear-vs-tlscreds-after-unparenting-it.patch | 38 -
.
Signed-off-by: Thomas Lamprecht
CC: Wolfgang Bumiller
---
Makefile | 6 +-
debian/changelog | 6 +
...-return-success-on-info-without-snapshots.patch | 4 +-
.../0011-introduce-new-vma-archive-format.patch| 14
v2 with minor changes:
* keep formating in the "vnc: refactor to QIOChannelSocket" patch to avoid
to much noise and allow better reviewing
I did not convert the "pve_auth_verify" function from ui/vnc.c to
QIOSocketChannel
yet, as it does not has any benefit for us there - we do all in sync and
applied both patches
> Wolfgang Bumiller hat am 1. Juli 2016 um 10:15
> geschrieben:
>
>
> Its functionality is provided by perl core's Digest::SHA
> module now.
> ---
> PVE/AccessControl.pm | 6 +++---
> control.in | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> dif
Generate hotp/totp in perl directly, also support keys in
hex notation (this is how eg. the
yubikey-personalization-gui displays them, but without the
whitespaces).
---
Changes since v1:
added else branch to the key type check
PVE/AccessControl.pm | 45 +-
Its functionality is provided by perl core's Digest::SHA
module now.
---
PVE/AccessControl.pm | 6 +++---
control.in | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm
index 6023285..de2908e 100644
--- a/PVE/AccessControl.pm
13 matches
Mail list logo
