Re: [pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Dietmar Maurer
> On March 2, 2016 at 8:45 PM Wolfgang Link wrote: > > > syscmd use run_command with noout what return the only exitcode. OK, but why do you use > eval { syscmd ("/sbin/vgcreate pve $lvmdev") }; then? I am confused now. > > Dietmar Maurer hat am 2. März 2016 um 17:11 > > geschrieben: >

Re: [pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Wolfgang Link
syscmd use run_command with noout what return the only exitcode. > Dietmar Maurer hat am 2. März 2016 um 17:11 geschrieben: > > > comments inline: > > > diff --git a/proxinstall b/proxinstall > > index ec15477..7a67623 100755 > > --- a/proxinstall > > +++ b/proxinstall > > @@ -834,8 +834,11 @@

[pve-devel] vzdump.conf exclude-path parsing

2016-03-02 Thread Jean-Francois Dagenais
Hi all, First time poster. I've been digging into a problem I am getting with Proxmox VE 4.1-15. I am specifying a pattern in "exclude-path" and am getting a perl error: Can't use string (""/dir1/.+" "/dir2/.+"") as an ARRAY ref while "strict refs" in use at /usr/share/perl5/PVE/VZDump.pm line 5

Re: [pve-devel] [PATCH] Remove content type Container from GlusterFS

2016-03-02 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] Remove content type container from GlusterFS.

2016-03-02 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Dietmar Maurer
comments inline: > diff --git a/proxinstall b/proxinstall > index ec15477..7a67623 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -834,8 +834,11 @@ sub create_lvm_volumes { > # so pe_start is aligned on a 128k boundary (advantage for SSDs) > syscmd ("/sbin/pvcreate --metadatasize 25

Re: [pve-devel] [PATCH kvm] Fix CVE-2015-8817 and CVE-2015-8818

2016-03-02 Thread Dietmar Maurer
applied on stable-3 branch ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] Remove content type Container from GlusterFS

2016-03-02 Thread Wolfgang Link
--- www/manager/storage/GlusterFsEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager/storage/GlusterFsEdit.js b/www/manager/storage/GlusterFsEdit.js index f0d3b4f..0b43b94 100644 --- a/www/manager/storage/GlusterFsEdit.js +++ b/www/manager/storage/GlusterFsEdit.js @@ -130,6 +1

[pve-devel] [PATCH] Remove content type container from GlusterFS.

2016-03-02 Thread Wolfgang Link
--- PVE/Storage/GlusterfsPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin.pm index 315c5a6..951db50 100644 --- a/PVE/Storage/GlusterfsPlugin.pm +++ b/PVE/Storage/GlusterfsPlugin.pm @@ -98,7 +98,7 @@ sub type

[pve-devel] [PATCH] Catch error from vgcreate.

2016-03-02 Thread Wolfgang Link
This is necessary, if the volume group "pve" exists, say from a previous installation. But whitout printing the reason no user will understand why this happens. --- proxinstall | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/proxinstall b/proxinstall index ec15477..7a67

Re: [pve-devel] Speed up PVE Backup

2016-03-02 Thread Alexandre DERUMIER
>>We're currently implementing our own backup system which uses the >>drive-backup qmp routine to dump qcow2. We don't need the config files. >>And this works with ceph and 4MB cluster size. How about speed performance (64K,4MB) and stability vs proxmox vma format ? I'm curious, because I sti

[pve-devel] [PATCH manager] firewall: add ipfilter option

2016-03-02 Thread Wolfgang Bumiller
--- www/manager/grid/FirewallOptions.js | 1 + www/manager6/grid/FirewallOptions.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager/grid/FirewallOptions.js b/www/manager/grid/FirewallOptions.js index 24c7870..08fa288 100644 --- a/www/manager/grid/FirewallOptions.js +++ b/www/ma

[pve-devel] [PATCH container 4/4] Move JSONFormat code to PVE::LXC::Config

2016-03-02 Thread Fabian Grünbichler
Some of this should move into PVE::AbstractConfig soon. --- src/PVE/API2/LXC.pm | 16 +- src/PVE/API2/LXC/Config.pm | 6 +- src/PVE/CLI/pct.pm | 4 +- src/PVE/LXC.pm | 890 +--- src/PVE/LXC/Config.pm | 871 ++

[pve-devel] [PATCH container 2/4] Rework snapshot code, has_feature

2016-03-02 Thread Fabian Grünbichler
Move snapshot_create, snapshot_delete and snapshot_rollback into abstract pve-common/src/PVE/AbstractConfig.pm, splitting LXC-specific parts into __snapshot_XX methods in src/PVE/LXC/Config.pm. check_freeze_needed, snapshot_prepare and snapshot_commit are downgraded to private __snapshot_XX method

[pve-devel] [PATCH container 1/4] Refactor config-related methods into AbstractConfig

2016-03-02 Thread Fabian Grünbichler
Move load_config, write_config, lock_config[_xx], check_lock, has_lock, set_lock, remove_lock, is_template, check_protection and config_file to pve-common/src/PVE/ AbstractConfig.pm since they are identical for LXC and Qemu. Move cfs_config_path and config_file_lock to implementation of PVE::Abstr

[pve-devel] [PATCH container 0/4] Config and snapshot refactoring

2016-03-02 Thread Fabian Grünbichler
This patch series moves a lot of common code shared with QemuServer.pm into a new abstract class AbstractConfig in pve-common. Furthermore, most other code that is only related to the PVE config files for an LXC guest is moved to PVE::LXC::Config, which implements PVE::AbstractConfig. All of the

[pve-devel] [PATCH container 3/4] Refactor mountpoint and general conf methods

2016-03-02 Thread Fabian Grünbichler
Move add_unused_volume into abstract pve-common/src/PVE/AbstractConfig.pm, because it is identical for LXC and Qemu. Move classify_mountpoint, is_volume_in_use, has_dev_console, mountpoint_names, foreach_mountpoint_XX and get_vm_volumes to PVE::LXC::Config because they only deal with config relate

[pve-devel] [PATCH common] Add AbstractConfig base class

2016-03-02 Thread Fabian Grünbichler
This class contains common code formerly duplicated in PVE::LXC and PVE::QemuServer, as well as abstract methods that must be implemented for LXC and Qemu seperately. Currently implemented in PVE::LXC::Config, Qemu refactoring will follow. --- This patch only takes effect when the related patch se

[pve-devel] [PATCH firewall] LXC refactoring

2016-03-02 Thread Fabian Grünbichler
call cfs_config_path and parse_lxc_network in PVE::LXC::Config instead of PVE::LXC --- Note: this depends on the patch series against pve-container and the single patch against pve-common. src/PVE/Firewall.pm | 6 +++--- src/PVE/FirewallSimulator.pm | 2 +- 2 files changed, 4 insertions(

[pve-devel] [PATCH manager] LXC refactoring

2016-03-02 Thread Fabian Grünbichler
call load_config in PVE::LXC::Config instead of PVE::LXC --- Note: this depends on the patch series against pve-container and the single patch against pve-common. PVE/API2/Nodes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 68f6

[pve-devel] [PATCH ha-manager] LXC refactoring

2016-03-02 Thread Fabian Grünbichler
call config_file in PVE::LXC::Config instead of PVE::LXC --- Note: this depends on the patch series against pve-container and the single patch against pve-common. src/PVE/HA/Resources/PVECT.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/HA/Resources/PVECT.pm b/src/

[pve-devel] [PATCH firewall 1/4] added the 'ipfilter' option

2016-03-02 Thread Wolfgang Bumiller
This effectively acts like adding an emtpy 'ipfilter-netX' ipset for every firewall-enabled interface. --- src/PVE/API2/Firewall/VM.pm | 9 + src/PVE/Firewall.pm | 42 ++ 2 files changed, 43 insertions(+), 8 deletions(-) diff --git a/src/PV

[pve-devel] [PATCH firewall 2/4] ipfilter: include configured container IPs by default

2016-03-02 Thread Wolfgang Bumiller
--- src/PVE/API2/Firewall/VM.pm | 3 ++- src/PVE/Firewall.pm | 11 +-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Firewall/VM.pm b/src/PVE/API2/Firewall/VM.pm index 192737a..4fdf3da 100644 --- a/src/PVE/API2/Firewall/VM.pm +++ b/src/PVE/API2/Firew

[pve-devel] [PATCH firewall 4/4] whitespace cleanup

2016-03-02 Thread Wolfgang Bumiller
--- src/PVE/Firewall.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 7dbe13d..dad259e 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -3348,10 +3348,10 @@ sub compile_ipsets { # generate firewa

[pve-devel] [PATCH firewall 3/4] test: add test for implicitly allowed container IP

2016-03-02 Thread Wolfgang Bumiller
--- test/test-vm-ipfilter2/200.fw | 4 test/test-vm-ipfilter2/cluster.fw | 7 +++ test/test-vm-ipfilter2/tests | 3 +++ 3 files changed, 14 insertions(+) create mode 100644 test/test-vm-ipfilter2/200.fw create mode 100644 test/test-vm-ipfilter2/cluster.fw create mode 100644 te

Re: [pve-devel] [PATCH pve-manager 1/2] fix Timezones window

2016-03-02 Thread Dietmar Maurer
applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager] simulator: install all virtual resources

2016-03-02 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 1/2] fix Timezones window

2016-03-02 Thread Emmanuel Kasper
Ext.regModel() was removed from the framework rewrite the store in declarative style with inline data --- www/manager6/data/TimezoneStore.js | 34 -- www/manager6/node/TimeEdit.js | 2 +- 2 files changed, 9 insertions(+), 27 deletions(-) diff --git a/www/mana

[pve-devel] [PATCH pve-manager 2/2] fix display cluster status in Datacenter Panel

2016-03-02 Thread Emmanuel Kasper
use getData() instead of accessing the intern raw value --- www/manager6/dc/Summary.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js index e6d8236..ba9f774 100644 --- a/www/manager6/dc/Summary.js +++ b/www/manage

[pve-devel] [PATCH ha-manager] simulator: install all virtual resources

2016-03-02 Thread Thomas Lamprecht
we include it in the source and we also want to allow to use it Signed-off-by: Thomas Lamprecht --- I was so free to increase the version number as this allows the pve-ha-simulator to start again. No semantic changes in anyway (as can be seen obviously) Makefile | 2 +-

Re: [pve-devel] [PATCH kvm] Fix CVE-2015-8817 and CVE-2015-8818

2016-03-02 Thread Wolfgang Bumiller
This is for the stable-3 branch. Sorry I forgot to change the [PATCH] prefix... > On March 2, 2016 at 9:03 AM Wolfgang Bumiller wrote: > > > And two non-security relevant functionality fixes from the > same series: > > CVE-2015-8817: exec: Respect as_tranlsate_internal length clamp > exec: do

[pve-devel] [PATCH kvm] Fix CVE-2015-8817 and CVE-2015-8818

2016-03-02 Thread Wolfgang Bumiller
And two non-security relevant functionality fixes from the same series: CVE-2015-8817: exec: Respect as_tranlsate_internal length clamp exec: do not clamp accesses to MMIO regions CVE-2015-8818: exec: skip MMIO regions correctly in cpu_physical_memory_write_rom_internal exec: clamp accesses again