Re: [pve-devel] [PATCH] clone_vm : only deactivate sources volume if source vm if offline

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] virtual scsi disk passed with scsi-block with lvm host storage (wrong)

2016-02-24 Thread Wolfgang Bumiller
On Thu, Feb 25, 2016 at 07:48:41AM +0100, Dietmar Maurer wrote: > I just found package liblinux-prctl-perl, which can do > > Linux::Prctl::capbset_drop(CAP_SYS_RAWIO); > > That way we could do it inside perl before the SCSI INQUIRY syscall. > Would that solve the problem? > > But we would need

Re: [pve-devel] virtual scsi disk passed with scsi-block with lvm host storage (wrong)

2016-02-24 Thread Michael Rasmussen
On Thu, 25 Feb 2016 06:54:22 +0100 (CET) Dietmar Maurer wrote: > > Why --drop=cap_sys_rawio ? Does kvm drop this when starting? > My understanding is that dropping cap_sys_rawio means disallow low level disk access - eg. no auto discover possible. -- Hilsen/Regards Michael Rasmussen Get my p

Re: [pve-devel] virtual scsi disk passed with scsi-block with lvm host storage (wrong)

2016-02-24 Thread Alexandre DERUMIER
>>Why --drop=cap_sys_rawio. To be honest, I don't known. >>Does kvm drop this when starting? no, it's need it for scsi-block passthrough http://www.linux-kvm.org/images/7/77/2012-forum-thin-provisioning.pdf from slides 10, scsi passthrough need it. The problem seem to be that lvm allow it, so

Re: [pve-devel] virtual scsi disk passed with scsi-block with lvm host storage (wrong)

2016-02-24 Thread Dietmar Maurer
I just found package liblinux-prctl-perl, which can do Linux::Prctl::capbset_drop(CAP_SYS_RAWIO); That way we could do it inside perl before the SCSI INQUIRY syscall. Would that solve the problem? But we would need to fork before calling capbset_drop ... > On February 25, 2016 at 6:54 AM Dietm

Re: [pve-devel] virtual scsi disk passed with scsi-block with lvm host storage (wrong)

2016-02-24 Thread Dietmar Maurer
> #capsh --drop=cap_sys_rawio -- -c 'sg_inq /dev/pve/vm-115-disk-2' > Both SCSI INQUIRY and fetching ATA information failed on > /dev/pve/vm-115-disk-2 Why --drop=cap_sys_rawio ? Does kvm drop this when starting? ___ pve-devel mailing list pve-devel@pve

Re: [pve-devel] [PATCH qemu-server] change check for write-zeros

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 storage] add sparseinit to has_feature

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [stable-3 kvm] Fix CVE-2016-2538

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] jslint...

2016-02-24 Thread Dietmar Maurer
applied, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH kvm] Fix CVE-2016-2538

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 kvm] vma: better driver guessing for bdrv_open

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager] jslint...

2016-02-24 Thread Wolfgang Bumiller
*sigh* --- www/manager/lxc/CreateWizard.js | 4 +-- www/manager/lxc/ResourceEdit.js | 66 - www/manager/lxc/Resources.js| 13 3 files changed, 47 insertions(+), 36 deletions(-) diff --git a/www/manager/lxc/CreateWizard.js b/www/manager/lxc/Cre

[pve-devel] [stable-3 kvm] Fix CVE-2016-2538

2016-02-24 Thread Wolfgang Bumiller
usb: check RNDIS message length usb: check RNDIS buffer offsets & length --- ...-2016-2538-usb-check-RNDIS-message-length.patch | 111 + debian/patches/series | 1 + 2 files changed, 112 insertions(+) create mode 100644 debian/patches/CVE-2016-2

[pve-devel] [PATCH v2 kvm] vma: better driver guessing for bdrv_open

2016-02-24 Thread Wolfgang Bumiller
--- Changes: Need to set the BDRV_O_PROTOCOL flag to make bdrv_open look at protocols in the filenames (like 'rbd:...') ...-vma-better-driver-guessing-for-bdrv_open.patch | 42 ++ debian/patches/series | 1 + 2 files changed, 43 insertions(+) cre

[pve-devel] [PATCH kvm] Fix CVE-2016-2538

2016-02-24 Thread Wolfgang Bumiller
usb: check RNDIS message length usb: check RNDIS buffer offsets & length --- ...-2016-2538-usb-check-RNDIS-message-length.patch | 111 + debian/patches/series | 1 + 2 files changed, 112 insertions(+) create mode 100644 debian/patches/extra/CVE-

Re: [pve-devel] [PATCH 1/4] refactor pveam to use it with our CLI Handler.

2016-02-24 Thread Dietmar Maurer
> On February 24, 2016 at 12:27 PM Emmanuel Kasper wrote: > > > By the way what do pveam stand for ? Is that for pve appliance manager ? yes ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-de

[pve-devel] [PATCH qemu-server] Refactor snapshot_create to match LXC.pm

2016-02-24 Thread Fabian Grünbichler
--- further preparation to merge the common code base of LXC and Qemu PVE/QemuServer.pm | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c199437..3217af5 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServe

[pve-devel] [PATCH container 0/3] mountpoint support for snapshots

2016-02-24 Thread Fabian Grünbichler
This patch series adds mountpoint support for snapshots and fixes an issue when deleting unused volumes. Tested using ZFS and Ceph, including all three backup modes. Fabian Grünbichler (3): Check volume usage in snapshots before deleting Add mp support to snapshots Adapt and add testcases f

[pve-devel] [PATCH container 1/3] Check volume usage in snapshots before deleting

2016-02-24 Thread Fabian Grünbichler
--- src/PVE/LXC.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 4ba9125..6046c46 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1199,7 +1199,7 @@ sub verify_searchdomain_list { } sub is_volume_in_use { -my ($con

[pve-devel] [PATCH container 2/3] Add mp support to snapshots

2016-02-24 Thread Fabian Grünbichler
Modelled after QemuServer's way of handling multiple drives. --- src/PVE/LXC.pm| 97 +++ src/PVE/VZDump/LXC.pm | 20 +++ 2 files changed, 73 insertions(+), 44 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 6046c46..d

[pve-devel] [PATCH container 3/3] Adapt and add testcases for mp support

2016-02-24 Thread Fabian Grünbichler
--- src/test/snapshot-expected/create/lxc/103.conf | 27 +++ src/test/snapshot-expected/create/lxc/203.conf | 10 +++ src/test/snapshot-expected/delete/lxc/105.conf | 1 + src/test/snapshot-expected/delete/lxc/106.conf | 10 +++ src/test/snapshot-expected/delete/lx

Re: [pve-devel] [PATCH 1/4] refactor pveam to use it with our CLI Handler.

2016-02-24 Thread Emmanuel Kasper
By the way what do pveam stand for ? Is that for pve appliance manager ? ( helps to remember purpose of command) On 02/24/2016 12:10 PM, Wolfgang Link wrote: > --- > PVE/CLI/Makefile | 2 +- > PVE/CLI/pveam.pm | 88 > > bin/Makefile |

Re: [pve-devel] [PATCH ha-manager] add test for infinite started <=> migrate cycle

2016-02-24 Thread Dietmar Maurer
applied (with fix). ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 1/4] refactor pveam to use it with our CLI Handler.

2016-02-24 Thread Wolfgang Link
--- PVE/CLI/Makefile | 2 +- PVE/CLI/pveam.pm | 88 bin/Makefile | 7 ++--- bin/pveam| 21 ++ 4 files changed, 95 insertions(+), 23 deletions(-) create mode 100644 PVE/CLI/pveam.pm diff --git a/PVE/CLI/Makefile b/

[pve-devel] [PATCH 3/4] add list to pveam

2016-02-24 Thread Wolfgang Link
This function list all the templates off a specified storage. It also gives the size of the template. --- PVE/CLI/pveam.pm | 65 1 file changed, 65 insertions(+) diff --git a/PVE/CLI/pveam.pm b/PVE/CLI/pveam.pm index e90a7d7..b6adfc4 100644

[pve-devel] [PATCH 2/4] add pveam download

2016-02-24 Thread Wolfgang Link
With this function you can download templates from the repositories. --- PVE/API2/Nodes.pm | 26 -- PVE/CLI/pveam.pm | 2 ++ 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index aa1fa0b..434b936 100644 --- a/PVE/API2/

[pve-devel] [PATCH 4/4] add function destroy to pveam

2016-02-24 Thread Wolfgang Link
now it is possible to erase templates with pveam --- PVE/CLI/pveam.pm | 45 + 1 file changed, 45 insertions(+) diff --git a/PVE/CLI/pveam.pm b/PVE/CLI/pveam.pm index b6adfc4..0f907cf 100644 --- a/PVE/CLI/pveam.pm +++ b/PVE/CLI/pveam.pm @@ -14,6 +14,7 @@

[pve-devel] [PATCH 1/4] refactor pveam to use it with our CLI Handler.

2016-02-24 Thread Wolfgang Link
--- PVE/CLI/Makefile | 2 +- PVE/CLI/pveam.pm | 88 bin/Makefile | 7 ++--- bin/pveam| 21 ++ 4 files changed, 95 insertions(+), 23 deletions(-) create mode 100644 PVE/CLI/pveam.pm diff --git a/PVE/CLI/Makefile b/

[pve-devel] [PATCH] clone_vm : only deactivate sources volume if source vm if offline

2016-02-24 Thread Alexandre Derumier
We can clone online a running vm, we don't have to deactive source vm volume if the source vm is running Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 226e597..bf6f6fd 100644 --

[pve-devel] [PATCH ha-manager] add test for infinite started <=> migrate cycle

2016-02-24 Thread Thomas Lamprecht
--- *NOTE:* I did not add the log.excpect explicitly, test without and with the 'fix infinite started <=> migrate cycle' patch src/test/test-service-command7/README | 6 ++ src/test/test-service-command7/cmdlist | 4 src/test/test-service-command7/hardware_st

Re: [pve-devel] [PATCH pve-manager 1/2] Add documentation header for ObjectGrid.js

2016-02-24 Thread Dietmar Maurer
applied both patches. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 1/2] Add documentation header for ObjectGrid.js

2016-02-24 Thread Emmanuel Kasper
also enhance the documentation header for DiffStore and UpdateStore --- www/manager6/data/DiffStore.js | 12 +++- www/manager6/data/UpdateStore.js | 3 +++ www/manager6/grid/ObjectGrid.js | 14 ++ 3 files changed, 24 insertions(+), 5 deletions(-) diff --git a/www/manager6/

[pve-devel] [PATCH pve-manager 2/2] Revert "ext5migrate: do not set a custome idProperty for the KeyValue model"

2016-02-24 Thread Emmanuel Kasper
This reverts commit 3150236aa5ebed6565c6eaf64126bb1195693396. Without using an idProperty in the KeyValue model, the id of each store item is autogenerated, and the DiffStore always recreate the whole store content every second instead of updating the fields where values have changed. Recreating t

Re: [pve-devel] [PATCH ha-manager v5 3/3] fix infinite started <=> migrate cycle

2016-02-24 Thread Thomas Lamprecht
On 02/24/2016 10:34 AM, Dietmar Maurer wrote: >> If we get an 'EWRONG_NODE' error from the migration we have no sane >> way out. If we place it then in the started state we also get the >> 'EWRONG_NODE' error again and it even will place the service in >> the migration state again (when it's not

Re: [pve-devel] [PATCH container] pct enter: check if container runs before lxc-attach

2016-02-24 Thread Dietmar Maurer
applied, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager v5 3/3] fix infinite started <=> migrate cycle

2016-02-24 Thread Dietmar Maurer
> If we get an 'EWRONG_NODE' error from the migration we have no sane > way out. If we place it then in the started state we also get the > 'EWRONG_NODE' error again and it even will place the service in > the migration state again (when it's not restricted by a group) and > thus result in an infin

Re: [pve-devel] [PATCH ha-manager v5 2/3] exec_resource_agent: process error state early

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH ha-manager v6] avoid out of sync command execution in LRM

2016-02-24 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Proxmox VE 3.4 - Support Lifecycle

2016-02-24 Thread Martin Maurer
- Mainstream support The end date of Proxmox VE 3.4 mainstream support is April 30, 2016. On this date, also the Debian Wheezy security support is ending. - Extended Support Proxmox VE 3.4 will get security updates until February 28, 2017. This is only for security fixes. No new features wil

[pve-devel] [PATCH 2/2] change turnkey URL to https version to permit a redirection.

2016-02-24 Thread Wolfgang Link
--- PVE/APLInfo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm index ec49088..f4ad617 100644 --- a/PVE/APLInfo.pm +++ b/PVE/APLInfo.pm @@ -265,7 +265,7 @@ sub get_apl_sources { my $urls = []; push @$urls, "http://download.proxmox

[pve-devel] [PATCH 1/2] When we use LWP::UserAgent always use IO::Socket::SSL and set it up in a proper way.

2016-02-24 Thread Wolfgang Link
This patch set up the IO::Socket::SSL that all proxy(transparent, https and http) and non proxy settings will work. Now the server will also be verified. --- PVE/API2/Subscription.pm | 22 +++--- PVE/APLInfo.pm | 35 --- 2 files changed, 3

[pve-devel] [PATCH ha-manager v6] avoid out of sync command execution in LRM

2016-02-24 Thread Thomas Lamprecht
We are only allowed to execute any command once as else we may disturb the synchrony between CRM and LRM. The following scenario could happen: schedule CRM: deploy task 'migrate' for service vm:100 with UID 1234 schedule LRM: fork task wit UID 123 schedule CRM: idle as no result available yet sche

[pve-devel] [PATCH container] pct enter: check if container runs before lxc-attach

2016-02-24 Thread Thomas Lamprecht
else we get: > > lxc-attach: attach.c: lxc_attach: 710 failed to get the init pid which an arbitrary user could misunderstand. --- src/PVE/CLI/pct.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index b2bc361..432da39 100755