[pve-devel] [PATCH 1/2] Fix indentation.

2013-10-23 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- www/manager/storage/ZFSEdit.js | 242 - 1 file changed, 121 insertions(+), 121 deletions(-) diff --git a/www/manager/storage/ZFSEdit.js b/www/manager/storage/ZFSEdit.js index 2a5a042..5dd5329 1

[pve-devel] [PATCH 2/2] Change isci provider field from text input to drop-down list

2013-10-23 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- www/manager/storage/ZFSEdit.js | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/www/manager/storage/ZFSEdit.js b/www/manager/storage/ZFSEdit.js index 5dd5329..dc6b906 100644 --- a/www/manag

[pve-devel] Change isci provider field from text input to drop-down list

2013-10-23 Thread mir
Disregard last patch. Patches fix indentation and change text field for iscsi provider input to use a combobox instead since user in its present state would need to know in advance the available iscsi providers which proxmox supports. Instead show the available providers for the user in a drop-dow

[pve-devel] [PATCH] Fix indentation.

2013-10-23 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- www/manager/storage/ZFSEdit.js | 242 - 1 file changed, 121 insertions(+), 121 deletions(-) diff --git a/www/manager/storage/ZFSEdit.js b/www/manager/storage/ZFSEdit.js index 2a5a042..5dd5329 1

Re: [pve-devel] [PATCH] Change iscsi provider to drop-down box Available isci providers are listed in a drop-down box for the user to choose. Fix some indentation problems as well.

2013-10-23 Thread Michael Rasmussen
On Thu, 24 Oct 2013 05:57:36 + Dietmar Maurer wrote: > > I would prefer if you send white-space/indentation cleanups using a separate > patch. > Please can you split the patch? > Sure, I will do it later today. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael rasm

Re: [pve-devel] [PATCH] Change iscsi provider to drop-down box Available isci providers are listed in a drop-down box for the user to choose. Fix some indentation problems as well.

2013-10-23 Thread Dietmar Maurer
> > > onGetValues: function(values) { > > > - var me = this; > > > +var me = this; > > > > > > - if (me.create) { > > > - values.type = 'zfs'; > > > - values.content = 'images'; > > > - } else { > > > - delete values.storage; > > > - } > > > +if (me.create) { > > > +

Re: [pve-devel] [PATCH] Change iscsi provider to drop-down box Available isci providers are listed in a drop-down box for the user to choose. Fix some indentation problems as well.

2013-10-23 Thread Michael Rasmussen
On Thu, 24 Oct 2013 04:09:31 + Dietmar Maurer wrote: > > onGetValues: function(values) { > > - var me = this; > > +var me = this; > > > > - if (me.create) { > > - values.type = 'zfs'; > > - values.content = 'images'; > > - } else { > > - delete values.storage

Re: [pve-devel] [PATCH] Change iscsi provider to drop-down box Available isci providers are listed in a drop-down box for the user to choose. Fix some indentation problems as well.

2013-10-23 Thread Dietmar Maurer
> onGetValues: function(values) { > - var me = this; > +var me = this; > > - if (me.create) { > - values.type = 'zfs'; > - values.content = 'images'; > - } else { > - delete values.storage; > - } > +if (me.create) { > +values.type = 'zfs

[pve-devel] [PATCH] Change iscsi provider to drop-down box Available isci providers are listed in a drop-down box for the user to choose. Fix some indentation problems as well.

2013-10-23 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- www/manager/storage/ZFSEdit.js | 256 ++--- 1 file changed, 135 insertions(+), 121 deletions(-) diff --git a/www/manager/storage/ZFSEdit.js b/www/manager/storage/ZFSEdit.js index 2a5a042..dc6b906 1

[pve-devel] Change isci provider field from text input to drop-down list

2013-10-23 Thread mir
User would in its present state need to know in advance the available iscsi providers which proxmox support. Instead show the available providers for the user in a drop-down box. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com