Re: [pve-devel] ZFSPlugin et al: use ssh key from pmxcfs

2013-10-22 Thread Dietmar Maurer
applied, thanks. > -Original Message- > From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel- > boun...@pve.proxmox.com] On Behalf Of m...@datanom.net > Sent: Mittwoch, 23. Oktober 2013 02:53 > To: pve-devel@pve.proxmox.com > Subject: [pve-devel] ZFSPlugin et al: use ssh key from pmxc

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Dietmar Maurer
> > so maybe something similar: > > > > my $id_rsa_path = "/etc/pve/priv/zfs/${storeid}_id_rsa"; > > > A slight change. > > Since a storage can contain several storage pools and/or targets it would be > foolish to have several keys installed on the same host. So instead of > storeid I > will u

Re: [pve-devel] ZFSPlugin et al: use ssh key from pmxcfs

2013-10-22 Thread Michael Rasmussen
On Wed, 23 Oct 2013 02:53:07 +0200 m...@datanom.net wrote: > This patch implements support for cluster wide usage of a single > ssh key. The key is stored in /etc/pve/priv/zfs and distributed > through pmxcfs. One key is create for each storage and used for > all pools and targets on the storage.

[pve-devel] [PATCH 1/1] Use ssh key stored in pmxcfg. Use ssh -i /etc/pve/priv/zfs/portal_id_rsa for remote commands

2013-10-22 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/LunCmd/Comstar.pm | 141 +++ PVE/Storage/LunCmd/Iet.pm | 7 +- PVE/Storage/LunCmd/Istgt.pm | 861 +- PVE/Storage/ZFSPlugin.pm | 335 4 files changed

[pve-devel] ZFSPlugin et al: use ssh key from pmxcfs

2013-10-22 Thread mir
This patch implements support for cluster wide usage of a single ssh key. The key is stored in /etc/pve/priv/zfs and distributed through pmxcfs. One key is create for each storage and used for all pools and targets on the storage. Naming convention: _id_rsa

[pve-devel] Iet.pm: Correct wrong indentation

2013-10-22 Thread mir
Patch to correct indentation to use 4 spaces consistently. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] Code clean up. Fix wrong indentation.

2013-10-22 Thread mir
From: Michael Rasmussen Signed-off-by: Michael Rasmussen --- PVE/Storage/LunCmd/Iet.pm | 710 +++--- 1 file changed, 355 insertions(+), 355 deletions(-) diff --git a/PVE/Storage/LunCmd/Iet.pm b/PVE/Storage/LunCmd/Iet.pm index 654ddcf..e378b9f 100644 ---

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Michael Rasmussen
On Tue, 22 Oct 2013 08:31:47 + Dietmar Maurer wrote: > > so maybe something similar: > > my $id_rsa_path = "/etc/pve/priv/zfs/${storeid}_id_rsa"; > A slight change. Since a storage can contain several storage pools and/or targets it would be foolish to have several keys installed on the

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Michael Rasmussen
On 10-22-2013 10:31, Dietmar Maurer wrote: No problem. What name will you give the key?, and where can the key be found? For ceph keyring, we use: my $keyring = "/etc/pve/priv/ceph/${storeid}.keyring"; so maybe something similar: my $id_rsa_path = "/etc/pve/priv/zfs/${storeid}_id_rsa";

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Dietmar Maurer
> No problem. What name will you give the key?, and where can the key be > found? For ceph keyring, we use: my $keyring = "/etc/pve/priv/ceph/${storeid}.keyring"; so maybe something similar: my $id_rsa_path = "/etc/pve/priv/zfs/${storeid}_id_rsa"; ___

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Michael Rasmussen
On 10-22-2013 10:20, Dietmar Maurer wrote: All required in the source is to add "'-i', '/path/to/key'" to @SSH_OPT and @SCP_OPT. Will you add that? I am currently busy with other things, but maybe you can assemble a patch? No problem. What name will you give the key?, and where can the key

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Dietmar Maurer
> All required in the source is to add "'-i', '/path/to/key'" to @SSH_OPT and > @SCP_OPT. > > Will you add that? I am currently busy with other things, but maybe you can assemble a patch? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.p

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Michael Rasmussen
On 10-22-2013 09:50, Dietmar Maurer wrote: > This is option '-i' of ssh. What do you think? > And distribute it through pmxcfs? yes Sounds like the ideal solution. All required in the source is to add "'-i', '/path/to/key'" to @SSH_OPT and @SCP_OPT. Will you add that? -- Hilsen/regards M

Re: [pve-devel] wiki: Adding a page

2013-10-22 Thread Dietmar Maurer
> > This is option '-i' of ssh. What do you think? > > > And distribute it through pmxcfs? yes ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel