>>I thought we assume a shared storage is always available (unless disabled)?
It's possible that a shared can be assigned to specific nodes only. (nodes
in storage.cfg).
I have some shared storage in production not shared on all servers in same
cluster. (because of differents networks)
But
>>I thought we assume a shared storage is always available (unless disabled)?
It's possible that a shared can be assigned to specific nodes only. (nodes
in storage.cfg).
I have some shared storage in production not shared on all servers in same
cluster. (because of differents networks)
But
Oh, yes, I thinked also about that yesterday.
I think clone is better for users as "full clone" && "linked clone" is used by
vmware,virtualbox,openstack,
- Mail original -
De: "Dietmar Maurer"
À: "Alexandre DERUMIER (aderum...@odiso.com)"
Cc: pve-devel@pve.proxmox.com
Envoyé:
Just applied a slightly modified version.
Should we also test volume_has_feature() for linked clones?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
I still use the term 'copy' inside the code.
I guess it would be better to rename that to 'clone' (full clone, linked clone).
Any objections?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
wait, I guess I have an idea how to fix that cleanly.
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Donnerstag, 02. Mai 2013 06:09
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [
applied
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Donnerstag, 02. Mai 2013 06:44
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] qemu-server : copy_vm : fix : signal interrupt
Currently we push newvolid to newvollist after qemu-img convert,
so if signal interrupt occur during qemu-img convert, the newvollist is empty
and we can't free the volume
Instead, We need to push newvolid to newvollist just after volume creation
Signed-off-by: Alexandre Derumier
---
PVE/API2
Currently we push newvolid to newvollist after qemu-img convert,
so if signal interrupt occur during qemu-img convert, the newvollist is empty
and we can't free the volume
Instead, We need to push newvolid to newvollist just after volume creation
___
> + die "Full copy feature is not available" if $param->{full} &&
> +!PVE::QemuServer::has_feature('copy', $oldconf, $storecfg, $snapname);
> +
I guess testing 'if $param->{full}' is not good enough, because later on we do:
if (!$param->{full} && PVE::Storage::volume_is_base($storecfg,
applied, thanks.
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Donnerstag, 02. Mai 2013 06:34
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] qemu-server : copy_vm : fix "Use of un
applied, thanks!
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Donnerstag, 02. Mai 2013 05:52
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] pve-storage : add snapsname parameter
Signed-off-by: Alexandre Derumier
---
PVE/API2/Qemu.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 9baa16e..dedb9ad 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1886,7 +1886,7 @@ __PACKAGE__->register_method({
fix Use of uninitialized value $target in string eq at
/usr/share/perl5/PVE/API2/Qemu.pm line 1889.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
works with or without snapname.
Signed-off-by: Alexandre Derumier
---
PVE/API2/Qemu.pm |2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 93458b0..9baa16e 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1923,6 +1923,8 @@ __PACKAGE__->regis
not all storage support full clone from snapshots, so we need to if it's
available.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
needed for qemu-img convert from src snapshot
Signed-off-by: Alexandre Derumier
---
PVE/Storage/SheepdogPlugin.pm |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/SheepdogPlugin.pm b/PVE/Storage/SheepdogPlugin.pm
index d14cf5b..1262186 100644
--- a/PVE/Storage
needed for qemu-img convert from src snapshot
Signed-off-by: Alexandre Derumier
---
PVE/Storage/RBDPlugin.pm |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index 3340195..81a7b98 100644
--- a/PVE/Storage/RBDPlugin.pm
+
Signed-off-by: Alexandre Derumier
---
PVE/Storage.pm |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 36d4cb3..c6d9d12 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -348,14 +348,14 @@ sub path_to_volume_id {
}
sub path {
-
This is required for qemu-img convert, for rbd & sheepdog currently.
(qemu-img convert qcow2 snap use another syntax not using path)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
20 matches
Mail list logo
