>>Btw, your clone patches have the feature to set the format for each drive.
>>Do we really need that?
Yes, because we create the volume before using qemu-img convert.
But we also need to specify it to qemu-img convert, as auto-detection of the
target volume format don't work.
(I have tried, c
> Also, if name is not provided,
> maybe can we add a default name : " Copy of".$orignalname ?
>
> To avoid duplicate name ?
Yes. will do that.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-dev
> I think it could be great to add a "name" parameter
>>yes, and a 'description'
Also, if name is not provided,
maybe can we add a default name : " Copy of".$orignalname ?
To avoid duplicate name ?
- Mail original -
De: "Dietmar Maurer"
À: "Alexandre DERUMIER"
Cc: pve-devel@pv
applied, thanks.
I will add a JSON schema requirement for option 'full':
storage => get_standard_option('pve-storage-id', {
description => "Target storage for full copy.",
requires => 'full',
optional => 1,
}),
> -Origi
Optionnal target storage for full copy
Signed-off-by: Alexandre Derumier
---
PVE/API2/Qemu.pm | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 8a15abc..0fe0045 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -60
this is usefull for full copy on different target storage
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> I think it could be great to add a "name" parameter
yes, and a 'description'
> For full clone, we should add a target storage and output format options.
> (I think that only 1 target storage/output format for all disks is enough)
OK for me.
___
pve-d
applied, thanks.
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Montag, 29. April 2013 14:14
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH] don't send qmp balloon commands
applied.
Btw, your clone patches have the feature to set the format for each drive.
Do we really need that?
I mean, we want to be able to copy a single disk from one location to another,
and change the disk format on that action.
But is this related to VM copy.
Maybe it is enough to have an ext
applied - thanks!
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier
> Sent: Dienstag, 30. April 2013 06:18
> To: pve-devel@pve.proxmox.com
> Subject: [pve-devel] [PATCH 1/2] vm_copy : fix typo in des
Currently format is always empty, we need to parse file extension
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm |4
1 file changed, 4 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 1e2a97e..3725807 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
Signed-off-by: Alexandre Derumier
---
PVE/API2/Qemu.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 04106b8..8a15abc 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1779,7 +1779,7 @@ __PACKAGE__->register_method({
2 small fixes
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >>My plan was to get this basic functionality stable so that we can
> >>include this with 3.0?
>
> Yes, I think it could be a start, we can add features step by step.
Yes (will try to do that asap).
> When do you plan to release 3.0 ?
AFAIK Debian Wheeze is planned this weekend. We want RC1 s
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index f478892..1e2a97e 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3008,7 +3008,7 @@ sub vm_start {
}
tested and works fine
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
some first notes :
I think it could be great to add a "name" parameter
For full clone, we should add a target storage and output format options.
(I think that only 1 target storage/output format for all disks is enough)
Also , currently when I do a full clone of a vm with qcow2 disk, I have a
>>I think create_vm is already too complex to add more functionality.
>>What do you think?
Yes, I also was unhappy with extending qm create
>>My plan was to get this basic functionality stable so
>>that we can include this with 3.0?
Yes, I think it could be a start, we can add features step by
I finally applied this one and a first version of copy_vm.
I moved the code into an extra API call, because copy/clone has
different locking requirements than create_vm. We now create
a shared lock on the source VM. Also, permission checks are slightly
different, and I think create_vm is already
> -Original Message-
> From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel-
> boun...@pve.proxmox.com] On Behalf Of Alexandre DERUMIER
> Sent: Montag, 29. April 2013 10:53
> To: pve-devel@pve.proxmox.com
> Subject: Re: [pve-devel] bug : balloon qom-set error on snapshot rollback
>
>>Maybe an eval could help ?
Better :
I think we don't need to send balloon qmp commands if we load a statefile.
(As balloon service is already working in saved memory)
if (!defined($conf->{balloon}) || $conf->{balloon}) {
vm_mon_cmd_nocheck($vmid, "balloon", value
Hi,
I have had an error on rollback of a snapshot with memory saved,
seem to be related to balloon qom-set pooling interval
VM 114 qmp command 'qom-set' failed - unable to connect to VM 114 socket -
timeout after 31 retries
I think I have see a bug report about this on the forum.
Maybe an e
> Fixed - i can resend them all until you had a look at them.
>
> Am 25.04.2013 10:22, schrieb Dietmar Maurer:
> > Note: This patch breaks lint:
> >
> > [form/NodeSelector.js] Lint at line 29 character 2: Unexpected ','.
> > },
I already cvommited a fix for that.
23 matches
Mail list logo
