Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-26 Thread Alexandre DERUMIER
>>Why do you suppress messages to stderr, No reason, I think we can remove errfunc=> sub {} >>and why do we need a $parser here?  I' don't remember exactly, but I think that without outfunc, run_command display the full output result when finished, and not progressivly. also , currently it's on

Re: [pve-devel] [PATCH 1/5] add qemu_img_convert

2013-04-26 Thread Dietmar Maurer
> + my $parser = sub { > + my $line = shift; > + print $line."\n"; > + }; > + > + eval { run_command($cmd, timeout => undef, errfunc => sub {}, outfunc > => $parser); }; Why do you suppress messages to stderr, and why do we need a $parser here? ___