[pve-devel] [PATCH qemu-server v2] cdrom handling: default to "none" if no physical drive is available

2022-12-19 Thread Stefan Sterz
sing "none" as media instead. note that the error was basically cosmetic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/119592/ Signed-off-by: Stefan Sterz --- changes from v1: make the error message more concise. use shorter forum link for better

Re: [pve-devel] [PATCH qemu-server] cdrom handling: default to "none" if no physical drive is available

2022-12-19 Thread Stefan Sterz
On 12/19/22 10:23, Fiona Ebner wrote: > Am 16.12.22 um 16:08 schrieb Stefan Sterz: >> when a vm is configured to use the physical cd rom drive but there is >> no such drive a cryptic "uninitialized value" error is thrown. this >> is due to the `$

Re: [pve-devel] [PATCH qemu-server v2] cdrom handling: default to "none" if no physical drive is available

2022-12-19 Thread Stefan Sterz
On 12/19/22 12:23, Fiona Ebner wrote: > Am 19.12.22 um 12:14 schrieb Stefan Sterz: >> when a vm is configured to use the physical cd rom drive but there is >> no such drive a cryptic "uninitialized value" error is thrown. this >> is due to `$

[pve-devel] [PATCH qemu-server v3] cd rom handling: return a clearer error when there is no cd rom drive

2022-12-19 Thread Stefan Sterz
error was basically cosmetic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/119592/ Signed-off-by: Stefan Sterz --- changes from v2 (thanks @ Fiona Ebner): * added newline to message * cache the fact that no drive is available so we warn only once * adjusted err

[pve-devel] [PATCH qemu-server v4 2/2] cd rom handling: refactor cd rom path helper function

2022-12-20 Thread Stefan Sterz
to stop returning results of assignments Signed-off-by: Stefan Sterz --- drop this if unwanted/unneeded PVE/QemuServer.pm | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 3837bd9..8d8252d 100644 --- a/PVE

[pve-devel] [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive

2022-12-20 Thread Stefan Sterz
tic as the vm would start just fine. forum thread: https://forum.proxmox.com/threads/119592/ Signed-off-by: Stefan Sterz --- changes from v3 (thanks @ Thomas Lamprecht): * use `log_warn` instead of `warn` * dont return results of assignments changes from v2 (thanks @ Fiona Ebner): * added

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-28 Thread Stefan Sterz
On 12/16/22 13:15, Fiona Ebner wrote: > Am 15.12.22 um 17:57 schrieb Mira Limbeck: >> diff --git a/PVE/Report.pm b/PVE/Report.pm >> index 90b7cb1c..7ebe98f7 100644 >> --- a/PVE/Report.pm >> +++ b/PVE/Report.pm >> @@ -5,16 +5,34 @@ use warnings; >> >> use PVE::Tools; >> >> +my sub file2text { >

Re: [pve-devel] [PATCH manager v5 1/3] make task log downloadable in the PVE manager backend

2023-01-04 Thread Stefan Sterz
small nit in-line On 12/1/22 13:50, Daniel Tschlatscher wrote: > The read_tasklog API call now stream the whole log file if the query > parameter 'download' is set to true. > This is done in preparation for the task log download button to be > added in the TaskViewer. > > Signed-off-by: Daniel Ts

Re: [pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button

2023-01-04 Thread Stefan Sterz
series lgtm now and seems to work as intended across pmg/pve/pbs so consider this: Tested-by: Stefan Sterz Reviewed-by: Stefan Sterz On 1/4/23 13:56, Daniel Tschlatscher wrote: > This patch series' aim is to add a download button in the tasklog- > viewer GUI so that users may

[pve-devel] [PATCH manager] fix #4521: api/tasks: replace upid as filename for task log downloads

2023-02-09 Thread Stefan Sterz
. also add the ".log" file extension to indicate that these files contain logs. Signed-off-by: Stefan Sterz --- PVE/API2/Tasks.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm index 9c8de324..98cecf01 100644 --- a/PVE/API2/Task

[pve-devel] [PATCH widget-toolkit] ui: remove extra parenthesis from check to avoid eslint error

2023-02-15 Thread Stefan Sterz
with the additional parenthesis eslint throws an error due to the "no-extra-parens" rule that avoids unnecessary parenthesis. remove them to get rid of the error. Signed-off-by: Stefan Sterz --- i am personally not too happy with this eslint requirement here, but the widget toolkit w

Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section

2023-02-23 Thread Stefan Sterz
On 2/23/23 16:25, Lukas Wagner wrote: > Sometimes it can be quite useful to know when exactly a system report > was generated. Adds the following output quite prominently in the > general system info section: > While I agree that this can be useful sometimes, just as a heads-up, iptables-save prov

[pve-devel] [PATCH widget-toolkit v1] Proxmox Dark Theme

2023-03-08 Thread Stefan Sterz
ndle a dark theme. this would have the added benefit of also working in the mobile quarantine. the last commit for the mail gateway enables the dark theme in the api viewer. Daniel Tschlatscher (2): dark-theme: add initial version of the proxmox-dark theme util/window/form: add a theme selec

[pve-devel] [PATCH widget-toolkit v1] Proxmox Dark Theme

2023-03-08 Thread Stefan Sterz
ndle a dark theme. this would have the added benefit of also working in the mobile quarantine. the last commit for the mail gateway enables the dark theme in the api viewer. Daniel Tschlatscher (2): dark-theme: add initial version of the proxmox-dark theme util/window/form: add a theme selec

[pve-devel] [PATCH widget-toolkit v1 1/6] dark-theme: add initial version of the proxmox-dark theme

2023-03-08 Thread Stefan Sterz
spam score grid * style tracking center rows * add appropriate colors to buttons in the quarantine * style mail-info element in the quarantine Co-authored-by: Daniel Tschlatscher Co-authored-by: Stefan Sterz Signed-off-by: Daniel Tschlatscher Signed-off-by: Stefan

[pve-devel] [PATCH widget-toolkit v1 4/6] rrd chart: add support for the dark theme and dynamic theme switching

2023-03-08 Thread Stefan Sterz
by integrating the theme switching logic into the chart panel itself, themes can be switched more responsively based on css variables. Signed-off-by: Stefan Sterz --- src/panel/RRDChart.js | 37 + 1 file changed, 37 insertions(+) diff --git a/src/panel

[pve-devel] [PATCH widget-toolkit v1 2/6] subscription/summary/backup: stop setting the background color

2023-03-08 Thread Stefan Sterz
just remove them here. Signed-off-by: Stefan Sterz --- src/node/APT.js | 1 - src/window/AddTotp.js | 1 - src/window/DiskSmart.js | 1 - src/window/PackageVersions.js | 1 - 4 files changed, 4 deletions(-) diff --git a/src/node/APT.js b/src/node/APT.js index 2e5a776

[pve-devel] [PATCH widget-toolkit v1 3/6] gauge widget: add support for a dark theme and dynamic theme switching

2023-03-08 Thread Stefan Sterz
the gauges in the data center overview should use a dark style if the relevant css variables are set. this also makes it possible to switch the colors dynamically by adding an event listener Signed-off-by: Stefan Sterz --- src/panel/GaugeWidget.js | 45

[pve-devel] [PATCH widget-toolkit v1 5/6] util/window/form: add a theme selector

2023-03-08 Thread Stefan Sterz
From: Daniel Tschlatscher add a widget that implements a theme selector and sets a cookie to load the appropriate theme. Co-authored-by: Daniel Tschlatscher Co-authored-by: Stefan Sterz Signed-off-by: Daniel Tschlatscher Signed-off-by: Stefan Sterz --- src/Makefile | 2

[pve-devel] [PATCH widget-toolkit v1 6/6] dark-theme: add support for the pmg quarantine theme toggle

2023-03-08 Thread Stefan Sterz
allows using the theme toggle in the pmg quarantine properly. adds a filter over the iframes in the quarantine to make them appear properly in a dark environment. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/proxmox/_quarantine.scss | 6 ++ 1 file changed, 6 insertions(+) diff

[pve-devel] [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme

2023-03-08 Thread Stefan Sterz
From: Daniel Tschlatscher this requires a bump of the widget toolkit so the version includes the necessary widgets. Signed-off-by: Daniel Tschlatscher Signed-off-by: Stefan Sterz --- www/manager6/Workspace.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6

[pve-devel] [PATCH manager v1 4/4] ui: make ceph charts change color more dynamically

2023-03-08 Thread Stefan Sterz
add support for setting the background and text color via css. also allows for dynamically switching the color when a theme change is detected. Signed-off-by: Stefan Sterz --- www/manager6/ceph/StatusDetail.js | 35 +- www/manager6/panel/RunningChart.js | 29

[pve-devel] [PATCH docs v1] docs: add dark mode support to the api viewer

2023-03-08 Thread Stefan Sterz
adds dark mode support to the api viewer that is activated depending on the users theme preference. similar to the main gui's "auto" theme. this requires a bumps of the widget toolkit so the loaded css file is present Signed-off-by: Stefan Sterz --- api-viewer/index.html | 1 +

[pve-devel] [PATCH manager v1 3/4] subscription/summary/backup: stop setting the background color

2023-03-08 Thread Stefan Sterz
just remove them here. Signed-off-by: Stefan Sterz --- www/manager6/node/Subscription.js | 1 - www/manager6/node/Summary.js| 1 - www/manager6/window/BackupConfig.js | 1 - 3 files changed, 3 deletions(-) diff --git a/www/manager6/node/Subscription.js b/www/manager6/node

[pve-devel] [PATCH manager v1 2/4] pveproxy/template: add support for switching themes

2023-03-08 Thread Stefan Sterz
load the dark theme only if requested through a cookie, also adds support for the "auto" theme that uses the dark theme based on a media query. this requires a bump of the widget toolkit so the dark-theme css file is available. Signed-off-by: Stefan Sterz --- PVE/Service/pvepro

Re: [pve-devel] Shell command and Emacs Lisp code injection in emacsclient-mail.desktop

2023-03-09 Thread Stefan Sterz
On 3/8/23 18:05, Thomas Lamprecht wrote: > Am 08/03/2023 um 17:40 schrieb Stefan Sterz: >> From: Daniel Tschlatscher >> >> this requires a bump of the widget toolkit so the version includes the >> necessary widgets. >> >> Signed-off-by: Daniel Tschl

Re: [pve-devel] applied-series: [PATCH manager v1 1/4] gui: create user info menu intro for selecting the theme

2023-03-09 Thread Stefan Sterz
On 3/9/23 09:16, Thomas Lamprecht wrote: > Am 09/03/2023 um 09:07 schrieb Stefan Sterz: >> On 3/8/23 18:05, Thomas Lamprecht wrote: >>> we might want to make auto default rather quickly ;-) >> >> yes that might make sense. my intention was to not "surprise&qu

[pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons

2023-03-10 Thread Stefan Sterz
to them more easily. removing the class here doesn't change anything for "crisp", but makes the dark theme appear more consistent. also fixes up an unnecessary space. Signed-off-by: Stefan Sterz --- www/manager6/Workspace.js | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[pve-devel] [PATCH widget-toolkit 2/6] dark-theme: make windows stand out more against the background mask

2023-03-10 Thread Stefan Sterz
makes the background mask darker so windows stand out a bit more Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_presentation.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/extjs/_presentation.scss b/src/proxmox-dark/scss/extjs

[pve-devel] [PATCH widget-toolkit 3/6] dark-theme: re-work buttons colors to appear dimmer

2023-03-10 Thread Stefan Sterz
this dims buttons further by removing pure white text color and adjusting backgrounds and border accordingly. it also keeps the help buttons brighter than other buttons to draw (possibly confused) users to them. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/abstracts/_variables.scss

[pve-devel] [PATCH widget-toolkit 4/6] dark-theme: remove thicker borders around content

2023-03-10 Thread Stefan Sterz
previously the dark theme used thicker borders in certain places to space out the content a bit more. this removes them again to make the appearance more consistent with "crisp". Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/abstracts/_mixins.scss | 7 --- src/proxmox

[pve-devel] [PATCH widget-toolkit 5/6] dark-theme: visually remove the border around the pve resource tree

2023-03-10 Thread Stefan Sterz
by setting the color of the border of the resource tree to the panel background color, it doesn't appear visually anymore while keeping alignments in place. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_panel.scss | 6 ++ 1 file changed, 6 insertions(+) diff --git

[pve-devel] [PATCH widget-toolkit 0/6] Proxmox Dark Theme Fix-ups Round 1

2023-03-10 Thread Stefan Sterz
the pve resource tree. the last commit concerns the pve-manager. it removes a class from the "tree settings" button that made it appear like a help button. this doesn't change its appearance in crisp, but makes it stand out more in the dark theme. Stefan Sterz (5): dark-theme:

[pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background

2023-03-10 Thread Stefan Sterz
previously an "!important" was missing from the `background-color` property. this meant that the background color wasn't properly overridden. the "!important" is necessary as it is also used in the light theme. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/ext

[pve-devel] [PATCH widget-toolkit 2/2] dark-theme: increase contrast on check-boxes

2023-03-14 Thread Stefan Sterz
by adding a bit of brightness to the icons they stand out a bit more, especially when selected but not active (grey check-mark) Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/other

[pve-devel] [PATCH widget-toolkit 1/2] utils: move to using the auto theme per default

2023-03-14 Thread Stefan Sterz
make the new default theme the "auto" theme that uses media queries to detect a users preferred theme. Signed-off-by: Stefan Sterz --- src/Utils.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Utils.js b/src/Utils.js index 2ab1d0a..c9c00a9 100644

[pve-devel] [PATCH manager] pveproxy/template: switch to using the "auto" theme per default

2023-03-14 Thread Stefan Sterz
the auto theme uses media queries to detect a users preferred theme, switch to using it per default instead of the light theme. Signed-off-by: Stefan Sterz --- PVE/Service/pveproxy.pm | 5 - www/index.html.tpl | 8 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a

[pve-devel] [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups Round 2

2023-03-14 Thread Stefan Sterz
note that the patches for pbs and pmg are meant as fix-ups for the yet to be applied patches from the initial dark theme series. if this is too inconvenient ill re-submit these patches once they are applied. if they are applied, squashing these into the previous commits might make sense, though. St

[pve-devel] [PATCH widget-toolkit 0/1] Proxmox Dark Theme - AsciiDoc

2023-03-15 Thread Stefan Sterz
behaves like the api viewer or the gui's 'auto' theme (that is to say, the dark theme is used based on a user's preference). Stefan Sterz (1): dark-theme: add a dark theme for the asciidoc-based documentation debian/proxmox-widget-toolkit-dev.install| 1 + src/p

[pve-devel] [PATCH widget-toolkit 1/1] dark-theme: add a dark theme for the asciidoc-based documentation

2023-03-15 Thread Stefan Sterz
this commit adds a css file to the proxmox-widget-toolkit-dev package that makes it possible for pve and pmg docs to use a dark theme Signed-off-by: Stefan Sterz --- debian/proxmox-widget-toolkit-dev.install| 1 + src/proxmox-dark/Makefile| 12 +- src/proxmox-dark

[pve-devel] [PATCH docs] html conf: add support for a dark mode in the documentation

2023-03-15 Thread Stefan Sterz
this commit adds support for a dark theme that behaves similarly to that one used by the api viewer. Signed-off-by: Stefan Sterz --- asciidoc/pve-html.conf | 4 1 file changed, 4 insertions(+) diff --git a/asciidoc/pve-html.conf b/asciidoc/pve-html.conf index 8a089d3..99b767d 100644 --- a

[pve-devel] [PATCH docs v2] conf: add support for a dark mode in the documentation

2023-03-16 Thread Stefan Sterz
this commit adds support for a dark theme that behaves similarly to that one used by the api viewer. Signed-off-by: Stefan Sterz --- asciidoc/pve-docs.css | 168 + asciidoc/pve-html.conf | 4 + 2 files changed, 172 insertions(+) create mode 100644

[pve-devel] [PATCH widget-toolkit 4/4] dark-theme: let the background "shine through" mask more

2023-03-20 Thread Stefan Sterz
this makes the background mask a bit brighter and more see-through to make it possible to read values from behind the mask, if needed. it also adds a more visible shadow to windows so that the stand out more at the same time. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs

[pve-devel] [PATCH widget-toolkit 0/4] Dark Theme Fix-ups Round 3

2023-03-20 Thread Stefan Sterz
* dim the color of "sorted-by" headers * make the background mask more see-through while also letting windows stand out more Stefan Sterz (4): dark-theme: improve help button contrast ratios in focused state dark-theme: make "sorted-by" header highlight more subtle dark-th

[pve-devel] [PATCH widget-toolkit 2/4] dark-theme: make "sorted-by" header highlight more subtle

2023-03-20 Thread Stefan Sterz
by making the highlight more subtle, the theme is more consistent with the look of crisp. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_grid.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/extjs/_grid.scss b/src/proxmox-dark/scss

[pve-devel] [PATCH widget-toolkit 1/4] dark-theme: improve help button contrast ratios in focused state

2023-03-20 Thread Stefan Sterz
also improves the hovered/focused state and makes it more consistent with other buttons by making it brighter than the default state. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/abstracts/_variables.scss | 2 +- src/proxmox-dark/scss/proxmox/_helpbutton.scss | 3 ++- 2 files changed

[pve-devel] [PATCH widget-toolkit 3/4] dark-theme: dim warning and invalid colors more

2023-03-20 Thread Stefan Sterz
this brings them more in-line with the appearance of crisp. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/abstracts/_variables.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/proxmox-dark/scss/abstracts/_variables.scss b/src/proxmox-dark/scss/abstracts

Re: [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more"

2023-03-21 Thread Stefan Sterz
On 3/21/23 14:05, Thomas Lamprecht wrote: > Am 21/03/2023 um 11:04 schrieb Wolfgang Bumiller: >> This looks horrible. >> >> A *much* *much* better way to improve readability is to >> simply set the opacity down to 0.5. >> >> This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0. >> --- >> I

[pve-devel] [PATCH widget-toolkit] dark-mode: set the background mask to `background-darker` again

2023-03-21 Thread Stefan Sterz
this removes an issue where the mask would look awkward and inconsistent (e.g., in the quarantine view, the retention tab of a zfs storage etc). also makes the shadow a big bigger to be closer to crisp and also to improve contrast ratios Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss

[pve-devel] [PATCH widget-toolkit 2/3] dark-mode: set the icon color of filtered column headers properly

2023-03-22 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss index b4443ee..aa36b54 100644 --- a/src/proxmox-dark/scss/other

[pve-devel] [PATCH widget-toolkit 1/3] dark-mode: fix highlighting of active elements in drop down menus

2023-03-22 Thread Stefan Sterz
e.g.,: the filter menu item in the backup job creation window Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_menu.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/extjs/_menu.scss b/src/proxmox-dark/scss/extjs/_menu.scss index

[pve-devel] [PATCH widget-toolkit 3/3] dark-mode: style checkboxes that don't use blueish active states

2023-03-22 Thread Stefan Sterz
e.g., in the backup job creation window the filter column checkmark Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss

[pve-devel] [PATCH widget-toolkit] dark-mode: style locked guest icons properly

2023-03-22 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 4 1 file changed, 4 insertions(+) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss index d492e2e..164cd35 100644 --- a/src/proxmox-dark/scss/other/_icons.scss +++ b/src

[pve-devel] [PATCH widget-toolkit 3/5] dark-mode: set boundlist background

2023-03-23 Thread Stefan Sterz
this is only visible when no boundlist items are present, which only occurs when loading elements for the boundlist (e.g., when adding a nfs storage) Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/form/_combobox.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/proxmox

[pve-devel] [PATCH widget-toolkit 4/5] dark-mode: improve contrast ratios on the mask message

2023-03-23 Thread Stefan Sterz
this removes the transparent background of the masks message box. this should help improve the contrast between the background and text. also sets an appropriate border color to make it stand out more. Signed-off-by: Stefan Sterz --- interestingly, sassc removes the alpha value from something

[pve-devel] [PATCH widget-toolkit 2/5] dark-mode: color the custom grid and tree icons

2023-03-23 Thread Stefan Sterz
this wasn't noticed before because usually vms would either be running or stopped/offline/unknown etc. and there the colors are set separately. however, in e.g., the backup view's missing backups window these weren't colored properly. so this commit sets a default color. Signed

[pve-devel] [PATCH widget-toolkit 1/5] dark-mode: improve contrast on split buttons

2023-03-23 Thread Stefan Sterz
this improves the contrast of the little triangle in split buttons, making it stand out more especially when focused. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/form/_button.scss | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/proxmox-dark

[pve-devel] [PATCH widget-toolkit 0/5] Proxmox Dark Theme Fixups - Round 4

2023-03-23 Thread Stefan Sterz
can scan it again. Stefan Sterz (5): dark-mode: improve contrast on split buttons dark-mode: color the custom grid and tree icons dark-mode: set boundlist background dark-mode: improve contrast ratios on the mask message fix #4610: add a small white padding to the totp qr code src

[pve-devel] [PATCH widget-toolkit 5/5] fix #4610: add a small white padding to the totp qr code

2023-03-23 Thread Stefan Sterz
some qr code readers need a white "quiet zone" around the main qr code. otherwise, they won't be able to scan it at all which made it impossible to scan the totp qr code on certain devices. Signed-off-by: Stefan Sterz --- src/window/AddTotp.js | 4 ++-- 1 file changed, 2 i

[pve-devel] [PATCH widget-toolkit 0/4] Proxmox Dark Theme Fix-ups - Round 5

2023-04-05 Thread Stefan Sterz
this series fixes some more icons (e.g., the maintenance mode icon in pbs), sets appropriates styles for tabs in focus and focus-over states, fixes focused states for grid elements and improves contrats for the apt group headers. Stefan Sterz (4): dark-mode: fix focus and focus-over states for

[pve-devel] [PATCH widget-toolkit 1/4] dark-mode: fix focus and focus-over states for tabs

2023-04-05 Thread Stefan Sterz
previously the focus and focus-over states weren't styled so the crisp styling was used, which made them appear too brightly. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_tabbar.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/proxmox-dark/scss/extjs/_tabbar

[pve-devel] [PATCH widget-toolkit 2/4] dark-mode: fix the focused state for background image grid icons

2023-04-05 Thread Stefan Sterz
when inverted again. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 16 ++-- .../scss/proxmox/_loadingindicator.scss | 8 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src

[pve-devel] [PATCH widget-toolkit 3/4] dark-mode: style the icon for the maintenance mode in pbs

2023-04-05 Thread Stefan Sterz
Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/other/_icons.scss | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss index df81969..d4dc316 100644 --- a/src/proxmox-dark/scss/other

[pve-devel] [PATCH widget-toolkit 4/4] dark-mode: improve apt repo group header contrast ratios

2023-04-05 Thread Stefan Sterz
make the group headers darker, so that they have some contrast with the surrounding rows. also add back the border at the bottom. both changes improve the legibility of the table. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/proxmox/_nodes.scss | 4 ++-- 1 file changed, 2 insertions

Re: [pve-devel] [PATCH v2 widget-toolkit] fix #1454: InfoWidget for Memory

2023-04-13 Thread Stefan Sterz
On 28.03.23 14:49, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > > I'm a bit unsure about the color. If clashes a bit with the red when the > RAM is near full in light mode. Open for better suggestions, but > should work for now. > > changes from v1: > ignore arcsize when n

[pve-devel] [PATCH widget-toolkit 1/2] dark-mode: adjust panel header tool icons

2023-04-14 Thread Stefan Sterz
by brigthenening the icons on a more individual basis some darker ones can now feature higher contrasts while others won't be too bright. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_panel.scss | 37 + 1 file changed, 32 insertions(+), 5 dele

[pve-devel] [PATCH widget-toolkit 0/2] Proxmox Dark Theme Fix-ups - Round 6

2023-04-14 Thread Stefan Sterz
the theme switcher menu item is renamed to "color theme" to match promox ve. the final patch also renames this menu item for the mail gateway. Stefan Sterz (2) @ widget-toolkit: dark-mode: adjust panel header tool icons fix #4618: dark-mode: lighten critical/warning charts/gauges co

[pve-devel] [PATCH widget-toolkit 2/2] fix #4618: dark-mode: lighten critical/warning charts/gauges colors

2023-04-14 Thread Stefan Sterz
by increasing the lightness of these colors to to make them have the same amount of lightness as the primary color. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_progress.scss | 4 ++-- src/proxmox-dark/scss/other/_charts.scss | 4 ++-- 2 files changed, 4 insertions(+), 4

[pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex

2023-05-17 Thread Stefan Sterz
//git.proxmox.com/?p=pve-access-control.git;h=1aa2355a Signed-off-by: Stefan Sterz --- would really appreciate another pair of eyes here. given the recent churn related to this regex. it's very likely i missed something too. src/PVE/Auth/LDAP.pm | 9 +-- src/test/Makef

Re: [pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex

2023-05-17 Thread Stefan Sterz
sorry just noticed i forgot: adding tests for this was Suggested-by: Dominik Csapak On 17.05.23 15:39, Stefan Sterz wrote: > according to the current specification of the string representation of > ldap distinguished names (DN) presented by RFC 4514 [1] the current > regex checking

Re: [pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex

2023-05-23 Thread Stefan Sterz
On 23.05.23 08:58, Christoph Heiss wrote: > On Wed, May 17, 2023 at 03:39:31PM +0200, Stefan Sterz wrote: >> [..] >> >> this commit also adds a test file that tests the regex against a >> number of common pitfalls. including distinguished names that are >> structur

Re: [pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex

2023-05-23 Thread Stefan Sterz
On 23.05.23 12:12, Christoph Heiss wrote: > On Tue, May 23, 2023 at 10:56:24AM +0200, Stefan Sterz wrote: >> On 23.05.23 08:58, Christoph Heiss wrote: >>> On Wed, May 17, 2023 at 03:39:31PM +0200, Stefan Sterz wrote: >>>> [..] >>> While reviewing that, I had

[pve-devel] [PATCH installer] tui: multiply the disk size back into bytes

2023-06-21 Thread Stefan Sterz
previously the installer correctly divided the value when using them for the `FloatEditView`, but forgot to multiply the value again when retrieving it after editing. this commit fixes that Signed-off-by: Stefan Sterz --- tested this only locally and didn't build the installer completelly.

Re: [pve-devel] [PATCH installer] tui: multiply the disk size back into bytes

2023-06-21 Thread Stefan Sterz
On 21.06.23 16:36, Thomas Lamprecht wrote: > Am 21/06/2023 um 16:00 schrieb Stefan Sterz: >> previously the installer correctly divided the value when using them >> for the `FloatEditView`, but forgot to multiply the value again when >> retrieving it after editing. t

[pve-devel] [PATCH installer] tui: switch to `f64` for disk sizes

2023-06-22 Thread Stefan Sterz
persisted, even though the sizes were correctly set. this commit refactors the installer to convert the size once in the beginning and then stick to `f64`. Signed-off-by: Stefan Sterz --- proxmox-tui-installer/src/options.rs | 26 -- proxmox-tui-installer/src/setup.rs

[pve-devel] [PATCH installer] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Stefan Sterz
previously the disk selection was reset if the advanced options dialogue was re-opened. this commit adapts the behavior to restore the previous selection. Signed-off-by: Stefan Sterz --- proxmox-tui-installer/src/options.rs| 11 +-- proxmox-tui-installer/src/views/bootdisk.rs | 36

Re: [pve-devel] [PATCH installer] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Stefan Sterz
On 27.06.23 15:57, Lukas Wagner wrote: > > > On 6/27/23 15:34, Maximiliano Sandoval wrote: >>>     impl BtrfsBootdiskOptions { >>> -    pub fn defaults_from(disk: &Disk) -> Self { >>> +    pub fn defaults_from(disks: &[Disk]) -> Self { >>> +    let disk = &disks[0]; >>>   Self { >>>  

[pve-devel] [PATCH installer v2] tui: persist disk selection for zfs and btrfs

2023-06-27 Thread Stefan Sterz
previously the disk selection was reset if the advanced options dialogue was re-opened. this commit adapts the behavior to restore the previous selection. Signed-off-by: Stefan Sterz --- changes since v2 (thanks @Maximiliano Sandoval): * added a comment that the updated `change_default

[pve-devel] [PATCH pve-eslint] switch to using `Command.opts()` to access options

2023-08-30 Thread Stefan Sterz
this fixes an issue where the options where not properly passed to eslint, which rendered them useless. uses the `opts()` function to access them. see [1] for more on info on option parsing with commander. [1]: https://www.npmjs.com/package/commander#user-content-options Signed-off-by: Stefan

Re: [pve-devel] [PATCH pve-zsync] parse disks: improve error messages

2023-09-12 Thread Stefan Sterz
On Tue Sep 12, 2023 at 11:31 AM CEST, Fiona Ebner wrote: > The one with the backup flag was reported in the community forum: > https://forum.proxmox.com/threads/77254/ > > Signed-off-by: Fiona Ebner > --- > pve-zsync | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/pv

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-10-06 Thread Stefan Sterz
On Fri Oct 6, 2023 at 3:16 PM CEST, Lukas Wagner wrote: -- snip 8< -- > > +$background-hint: hsl(233deg, 99%, 60%); > > That particular color tone looks pretty out of place to me in dark mode. > In light mode, you use the same hue as other interface elements, is > there a reason why you use a diff

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI

2023-10-06 Thread Stefan Sterz
On Fri Sep 22, 2023 at 4:36 PM CEST, Philipp Hufnagl wrote: -- snip 8< -- > +$text-color-warning: hsl(48deg, 100%, 50%); > > // Borders > $border-color: hsl(0deg, 0%, 40%); > diff --git a/src/proxmox-dark/scss/extjs/_menu.scss > b/src/proxmox-dark/scss/extjs/_menu.scss > index 2983f60..aa51260

Re: [pve-devel] [PATCH qemu-server v8 1/3] add C program to get hardware capabilities from CPUID

2024-04-25 Thread Stefan Sterz
On Thu Apr 25, 2024 at 1:24 PM CEST, Markus Frank wrote: > Implement a systemd service that runs a C program that extracts AMD > SEV hardware information such as reduced-phys-bios and cbitpos from > CPUID at boot time, looks if SEV, SEV-ES & SEV-SNP are enabled, and > outputs these details as JSON

Re: [pve-devel] [PATCH 1/2] assistant: keep prepared iso bootable on uefi with flash drives

2024-04-30 Thread Stefan Sterz
On Tue Apr 30, 2024 at 10:54 AM CEST, Aaron Lauterer wrote: > By mapping files into the ISO, the UUID for the partitions change as > they depend on the timestamp. The result is, that grub cannot find its > partition anymore and the user ends up on the grub shell. > > This only happens when booting

<    1   2