On Thu Jan 2, 2025 at 2:53 PM CET, Fiona Ebner wrote:
> Am 02.01.25 um 14:46 schrieb Fiona Ebner:
> > Am 20.12.24 um 19:51 schrieb Max Carrara:
> >> Introduce and Package PVE::Path & PVE::Filesystem - v2
> >> ==
while
PVE::Path doesn't ever alter the filesystem, PVE::Filesystem does, as
the name implies. This is done in order to clearly separate concerns.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* None
src/Makefile | 1 +
src/P
Add these tests solely to ensure that the behaviour of path_normalize
stays consistent / stable in case we ever decide to provide our own
implementation instead of wrapping File::Spec->canonpath().
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* NEW: S
of suffixes.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* Adapt code accordingly since path_file_suffixes and path_file_parts
don't return a list ref in scalar context anymore
Changes v1 --> v2:
* NEW: Split from patch 02
test/Path/Makefile |1 +
t
.. of PVE::Path.
Each function has its test cases defined separately to avoid running
unnecessary tests / repeating equivalent tests for certain things.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* NEW: Split from patch 02
test/Path/Ma
mox.com/
v2:
https://lore.proxmox.com/pve-devel/20241220185207.519912-1-m.carr...@proxmox.com/
Summary of Changes
----------
Max Carrara (12):
introduce PVE::Path
test: add directory for tests of PVE::Path module
test: add tests for path_is_absolute and path_is_relative of PVE::Path
regards to storage.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* Don't return a reference to a list anymore when path_components,
path_file_suffixes, path_file_parts are called in scalar context
* Mention '/' being added at the start of the components bei
t and joined a second time (it only has to be *logically*),
normalize both the re-joined and the expected path before comparison.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* NEW: Split from patch 02
test/Path/Makefile | 1 +
test/Path/path_jo
Add the test/Path directory as well as test/Path/Makefile, containing
the scaffolding for tests regarding PVE::Path.
Include test/Path as subdirectory in test/Makefile, so
test/Path/Makefile runs when the other tests run, too.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Chan
ze, which
wraps canonpath).
The path_parent function should otherwise work the same as Rust's
std::path::Path::parent [1]. The discrepancies as mentioned above are
checked for by the tests introduced here.
[1]: https://doc.rust-lang.org/std/path/struct.Path.html#method.parent
Signed-off-by: Ma
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* NEW: Split from patch 02
test/Path/Makefile | 1 +
test/Path/path_push_tests.pl | 159 +++
2 files changed, 160 insertions(+)
create mode 100755 tes
other module
too. Their functionality goes hand-in-hand.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* None
debian/control | 6
debian/libproxmox-fs-path-utils-perl.install | 2 ++
debian/libpve-common-perl.install
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* Adapt code accordingly since path_components doesn't return a list
ref in scalar context anymore
Changes v1 --> v2:
* NEW: Split from patch 02
test/Path/Makefile | 1 +
test/Path/path_components_tes
Add cases for both functions, as they're each other's opposite.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* None
Changes v1 --> v2:
* NEW: Split from patch 02
test/Path/Makefile | 1 +
test/Path/path_is_absolute_relativ
On Wed Jan 8, 2025 at 3:05 PM CET, Wolfgang Bumiller wrote:
> On Fri, Dec 20, 2024 at 07:51:56PM +0100, Max Carrara wrote:
> > The PVE::Path module concerns itself with file / directory path
> > operations, like getting the parent directory of a path, extracting
> > th
On Thu Jan 9, 2025 at 12:06 PM CET, Wolfgang Bumiller wrote:
> On Thu, Jan 09, 2025 at 10:56:16AM +0100, Max Carrara wrote:
> > On Wed Jan 8, 2025 at 3:05 PM CET, Wolfgang Bumiller wrote:
> > > On Fri, Dec 20, 2024 at 07:51:56PM +0100, Max Carrara wrote:
> > > &g
On Fri Feb 7, 2025 at 1:34 PM CET, Roland Kammerer wrote:
> On Fri, Feb 07, 2025 at 10:18:42AM +0100, Fabian Grünbichler wrote:
> >
> > > Roland Kammerer via pve-devel hat am
> > > 07.02.2025 10:02 CET geschrieben:
> > > Hi all,
> > >
> > > rather simple question I guess, but I could not find t
On Mon Feb 24, 2025 at 7:41 PM CET, Seth Cagampang wrote:
> To Whom It May Concern,
>
> My name is Seth, I am a Sr. Engineer at OSNEXUS. We have a storage solution
> called QuantaStor that we are developing a storage plug-in for proxmox PVE.
> The idea is to serve ZFS volumes from a QuantaStor node
On Fri Mar 7, 2025 at 9:24 AM CET, Roland Kammerer wrote:
> Hi Max,
>
> took me a bit longer than expected, but here we go...
>
Thanks a lot for your detailed feedback, it's highly appreciated!
You'll probably be delighted that a couple of the things you mentioned
are already in progress:
- We'r
401 - 419 of 419 matches
Mail list logo
