Tested-by: Matthias Heiserer
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 02.02.2022 14:17, Matthias Heiserer wrote:
Tested-by: Matthias Heiserer
Sorry for a second mail.
I tested against the issue mentioned in the original mail. Without the
patch I'm blocked, with the patch it works.
___
pve-devel mailing
Signed-off-by: Matthias Heiserer
---
src/window/Edit.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/window/Edit.js b/src/window/Edit.js
index afbffaa..264b1ca 100644
--- a/src/window/Edit.js
+++ b/src/window/Edit.js
@@ -13,7 +13,7 @@ Ext.define
Makes creation of comment fields centralized and simple
Signed-off-by: Matthias Heiserer
---
PVE/QemuServer/Helpers.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
index c10d842..b753b1c 100644
--- a/PVE/QemuServer
Adds a column in which comments can be displayed.
This column is to the right of the values column.
Signed-off-by: Matthias Heiserer
---
www/manager6/qemu/HardwareView.js | 23 +++
1 file changed, 23 insertions(+)
diff --git a/www/manager6/qemu/HardwareView.js
b/www
Comments are automatically (en|de)coded in QemuNetwork,
PropertyString or QemuDrive. For fields not using these,
(en|de)coding utility functions are provided.
Signed-off-by: Matthias Heiserer
---
www/manager6/Parser.js | 22 ++
1 file changed, 22 insertions(+)
diff --git a
Values in multikey need to be explicitly set `visible: false`,
otherwise they are not found.
Signed-off-by: Matthias Heiserer
---
www/manager6/qemu/HardwareView.js | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www
use of the variations in the original code.
Matthias Heiserer (5):
GUI: Parser: add comment support
GUI: Utils: add comment renderer and field provider
GUI: QEMU Hardware: add comment column
GUI: QEMU Hardware: multikey support for comments
GUI: QEMU Hardware: add comment fields to rows
ww
the various files differ to some extent in how comments are
implemented (e.g. USBEdit). Streamlining them might be a good idea.
Signed-off-by: Matthias Heiserer
---
www/manager6/qemu/AudioEdit.js | 3 ++-
www/manager6/qemu/CDEdit.js| 7 ---
www/manager6/qemu/CIDriveEdit.js | 2
These render functions are used when displaying comments in a
separate column.
The `commentField` utility simplifies creation of comments.
Signed-off-by: Matthias Heiserer
---
www/manager6/Utils.js | 39 +++
1 file changed, 39 insertions(+)
diff --git a/www
onfig.
Changing this seems to require some more rewriting.
Signed-off-by: Matthias Heiserer
---
PVE/QemuServer.pm | 49 ++---
PVE/QemuServer/CPUConfig.pm | 7 --
PVE/QemuServer/Drive.pm | 6 -
PVE/QemuServer/PCI.pm | 4 ++-
4 files ch
When restoring a backup and the storage the disks would be created on
doesn't allow 'images', the process errors without cleanup.
This is the same behaviour we currently have when the storage is
disabled.
Signed-off-by: Matthias Heiserer
---
PVE/QemuServer.pm | 4
1
UI, and only 'Date' displayed a sorting arrow.
Signed-off-by: Matthias Heiserer
---
www/manager6/storage/BackupView.js | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/www/manager6/storage/BackupView.js
b/www/manager6/storage/BackupView.js
index 2328c0fc..f02944c9 10
Sorry, wrong bug. Should be 3886.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
When restoring a backup and the storage the disks would be created on
doesn't allow 'images', the process errors without cleanup.
This is the same behaviour we currently have when the storage is
disabled.
Signed-off-by: Matthias Heiserer
---
PVE/QemuServer.pm | 5 +
1
When restoring a backup and the storage the disks would be created on
doesn't allow 'images', the process errors without cleanup.
This is the same behaviour we currently have when the storage is
disabled.
Adds the Datastore.AllocateSpace check to cloudinit drives.
Signed-o
When restoring a backup and the storage the disks would be created on
doesn't allow 'images', the process errors without cleanup.
This is the same behaviour we currently have when the storage is
disabled.
Adds the Datastore.AllocateSpace check to cloudinit drives.
Signed-o
Signed-off-by: Matthias Heiserer
---
www/manager6/Utils.js | 20
1 file changed, 20 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..6509 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1803,6 +1803,26
Signed-off-by: Matthias Heiserer
---
www/manager6/window/BackupConfig.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/BackupConfig.js
b/www/manager6/window/BackupConfig.js
index ca61b1e4..9609fe34 100644
--- a/www/manager6/window/BackupConfig.js
+++ b
Verify State stay as default
value empty, empty, No, and None, respectively.
Code adapted from the existing backup view and the pbs
datastore content, where appropriate.
Signed-off-by: Matthias Heiserer
---
www/manager6/storage/BackupView.js | 620 -
1 file changed, 433
Previously, deselecting and reselecting the input field
led to the previous filter still being applied, although the
input field was cleared.
Signed-off-by: Matthias Heiserer
---
src/form/ComboGrid.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/form/ComboGrid.js b/src/form
When clicking on a column to sort it, the filter doesn't reset.
Previously, it forgot the filter until the value was changed.
Signed-off-by: Matthias Heiserer
---
src/form/ComboGrid.js | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
On 10.03.2022 15:31, Dominik Csapak wrote:
Sometimes, total can be zero (e.g. for swap when it's not used), which
leads to the usage being NaN. This led to the progressbar not being
updated for InfoWidgets, leaving a spurious '0%' as text.
Signed-off-by: Dominik Csapak
---
src/panel/StatusVie
On 15.03.2022 11:06, Dominik Csapak wrote:
On 3/9/22 15:18, Matthias Heiserer wrote:
When clicking on a column to sort it, the filter doesn't reset.
Previously, it forgot the filter until the value was changed.
Signed-off-by: Matthias Heiserer
---
src/form/ComboGrid.js | 7 +++
1
When clicking on a column to sort it, the filter doesn't reset.
Previously, it forgot the filter until the value was changed.
Signed-off-by: Matthias Heiserer
---
Changes from v1:
Introduce a config property to (en|dis)disable clearing the filter
src/form/ComboGrid.js | 11 +++
1
On 17.03.2022 11:15, Daniel Tschlatscher wrote:
Signed-off-by: Daniel Tschlatscher
---
src/PVE/API2/LXC/Status.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm
index f7e3128..f414f7a 100644
--- a/src/PVE/API
cleanup
- group unknown/renamed backups in the folder "Other"
- remember expanded nodes and selection
Matthias Heiserer (5):
Storage GUI: Rewrite backup content view as TreePanel.
GUI: Utils: Helpers for backup type and icon
Backup GUI: Use the new storage/BackupView inste
These lines were only used by grid/BackupView, which gets deleted in
this series.
Signed-off-by: Matthias Heiserer
---
www/manager6/storage/ContentView.js | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/www/manager6/storage/ContentView.js
b/www
Signed-off-by: Matthias Heiserer
---
www/manager6/grid/BackupView.js | 388
1 file changed, 388 deletions(-)
delete mode 100644 www/manager6/grid/BackupView.js
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
deleted file mode
Verify State stay as default
value empty, empty, No, and None, respectively.
Code adapted from the existing backup view and the pbs
datastore content, where appropriate.
Signed-off-by: Matthias Heiserer
---
Changes from v1:
-add BackupNow button to create backups when not used for storage
-Display
Signed-off-by: Matthias Heiserer
---
changes from v1:
add "backup" to name
return empty string instead of throwing
www/manager6/Utils.js | 20
1 file changed, 20 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..337ccfae 10
Signed-off-by: Matthias Heiserer
---
www/manager6/lxc/Config.js | 2 +-
www/manager6/qemu/Config.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js
index 89b59c9b..242780c8 100644
--- a/www/manager6/lxc/Config.js
Signed-off-by: Matthias Heiserer
---
www/manager6/lxc/Resources.js | 14 +-
www/manager6/qemu/HardwareView.js | 14 +-
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
index 15ee3c67
The same code is used once in widget toolkit and twice in PVE already,
so it makes sense to add it as a separate function.
Signed-off-by: Matthias Heiserer
---
src/Utils.js | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/Utils.js b/src/Utils.js
index 6a03057..27fcd1d 100644
Signed-off-by: Matthias Heiserer
---
src/node/APTRepositories.js | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 09ed0be..d63a569 100644
--- a/src/node/APTRepositories.js
+++ b/src/node
On 25.03.2022 09:47, Thomas Lamprecht wrote:
On 24.03.22 12:33, Matthias Heiserer wrote:
The same code is used once in widget toolkit and twice in PVE already,
so it makes sense to add it as a separate function.
FWIW, there'd be also the possibility of adding a new button class, derived
On 28.03.2022 11:44, Thomas Lamprecht wrote:
On 28.03.22 11:43, Matthias Heiserer wrote:
On 25.03.2022 09:47, Thomas Lamprecht wrote:
On 24.03.22 12:33, Matthias Heiserer wrote:
The same code is used once in widget toolkit and twice in PVE already,
so it makes sense to add it as a separate
The same code is used once in widget toolkit and twice in PVE already,
so it makes sense to add it as a separate button.
Signed-off-by: Matthias Heiserer
---
changes from v1:
move into separate class
rename vars to something a little bit nicer
move comment above function
reorder some statements
Signed-off-by: Matthias Heiserer
---
src/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/Makefile b/src/Makefile
index abafc2c..76dc012 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -45,6 +45,7 @@ JSSRC=\
form/ACME.js
text is not needed with the AltText button.
Signed-off-by: Matthias Heiserer
---
src/node/APTRepositories.js | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 09ed0be..ce8f718 100644
--- a/src/node
text is not needed with the AltText button.
Signed-off-by: Matthias Heiserer
---
www/manager6/lxc/Resources.js | 18 +-
www/manager6/qemu/HardwareView.js | 18 +-
2 files changed, 2 insertions(+), 34 deletions(-)
diff --git a/www/manager6/lxc/Resources.js b
8<
+ onLoad: function(store, records, success, operation) {
+ let me = this;
+ let view = me.getView();
+ let selection = view.getSelection()?.[0];
+ selection = selection?.parentNode?.data?.text
+selection?.data?.volid;
Style nit: missing space a
Signed-off-by: Matthias Heiserer
---
changes from v2:
return in else branch
changes from v1:
add "backup" to name
www/manager6/Utils.js | 20
1 file changed, 20 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..1f067088 10
These lines were only used by grid/BackupView, which gets deleted in
this series.
Signed-off-by: Matthias Heiserer
---
www/manager6/storage/ContentView.js | 43 ++---
1 file changed, 8 insertions(+), 35 deletions(-)
diff --git a/www/manager6/storage/ContentView.js
b
Signed-off-by: Matthias Heiserer
---
www/manager6/Makefile | 1 -
www/manager6/grid/BackupView.js | 388
www/manager6/lxc/Config.js | 2 +-
www/manager6/qemu/Config.js | 2 +-
4 files changed, 2 insertions(+), 391 deletions(-)
delete
Verify State stay as default
value empty, empty, No, and None, respectively.
Code adapted from the existing backup view and the pbs
datastore content, where appropriate.
Signed-off-by: Matthias Heiserer
---
changes from v2:
expand/collapse button
start with all groups expanded
allow restoring into
Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
Matthias Heiserer (4):
ui: Utils: Helpers for backup type and icon
ui: storage: Rewrite backup content view as TreePanel.
ui: delete BackupView and replace it with the new Tree BackupView
ui: content view
On 31.03.2022 12:47, Matthias Heiserer wrote:
Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
Matthias Heiserer (4):
ui: Utils: Helpers for backup type and icon
ui: storage: Rewrite backup content view as TreePanel.
ui: delete BackupView and replace it
Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
Matthias Heiserer (4):
ui: Utils: Helpers for backup type and icon
ui: storage: Rewrite backup content view as TreePanel.
ui: delete BackupView and replace it with the new Tree BackupView
ui: content view
Signed-off-by: Matthias Heiserer
---
no changes from v3.
changes from v2:
return in else branch
changes from v1:
add "backup" to name
www/manager6/Utils.js | 20
1 file changed, 20 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
inde
These lines were only used by grid/BackupView, which gets deleted in
this series.
Signed-off-by: Matthias Heiserer
---
No changes from v2/v3
www/manager6/storage/ContentView.js | 43 ++---
1 file changed, 8 insertions(+), 35 deletions(-)
diff --git a/www/manager6
Signed-off-by: Matthias Heiserer
---
No changes from v2/v3
www/manager6/Makefile | 1 -
www/manager6/grid/BackupView.js | 388
www/manager6/lxc/Config.js | 2 +-
www/manager6/qemu/Config.js | 2 +-
4 files changed, 2 insertions(+), 391
Verify State stay as default
value empty, empty, No, and None, respectively.
Code adapted from the existing backup view and the pbs
datastore content, where appropriate.
Signed-off-by: Matthias Heiserer
---
changes from v3:
when guest backup is PBS, show encrypted and verify state columns
and the
These lines were only used by grid/BackupView, which gets deleted in
this series.
Signed-off-by: Matthias Heiserer
---
No changes from v2/v3/v4
www/manager6/storage/ContentView.js | 43 ++---
1 file changed, 8 insertions(+), 35 deletions(-)
diff --git a/www/manager6
Signed-off-by: Matthias Heiserer
---
No changes from v2/v3/v4
www/manager6/Makefile | 1 -
www/manager6/grid/BackupView.js | 388
www/manager6/lxc/Config.js | 2 +-
www/manager6/qemu/Config.js | 2 +-
4 files changed, 2 insertions
Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html
I hope I didn't miss anything this time :)
Reviewed-by: Fabian Ebner
Matthias Heiserer (4):
ui: Utils: Helpers for backup type and icon
ui: storage: Rewrite backup content view as TreePanel.
ui: d
Signed-off-by: Matthias Heiserer
---
no changes from v3/v4
changes from v2:
return in else branch
changes from v1:
add "backup" to name
www/manager6/Utils.js | 20
1 file changed, 20 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
inde
Verify State stay as default
value empty, empty, No, and None, respectively.
Code adapted from the existing backup view and the pbs
datastore content, where appropriate.
Signed-off-by: Matthias Heiserer
---
changes from v4:
always filter by type in guests
for guests, never display backups of
On 08.04.2022 09:45, Dominik Csapak wrote:
8<
+// checks the conf for lines starting with the given props and
+// writes the pointers into the correct positions into the 'found' array
+// afterwards, whithout initial whitespace(s), we only deal with the format
whithout -> without
_
On 08.04.2022 09:45, Dominik Csapak wrote:
8<
+
+setValue: function(value) {
+ let me = this;
+ me.setColor(value);
+ if (value && value.length === 6) {
+ me.picker.value = value[0] !== '#' ? `#${value}` : value;
+ }
+},
+
+setColor: function(value) {
s the overrides
* (mentioned in mail to commit) In "Edit Tag colors", the default color
should be something different from the background. E.g. red line from
bottom left to top right, or use the autogenerated color
Tested-by: Matthias Heiserer
__
Hi,
please take a look at our developer documentation.
https://pve.proxmox.com/wiki/Developer_Documentation
Using `git format-patch` makes applying the changes a whole lot easier :)
As far as I can tell from a quick test, your changes seem to work.
Would you mind using `pvesh create` to test?
: Matthias Heiserer
---
src/PVE/APIServer/AnyEvent.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
index ade3c05..c143fb4 100644
--- a/src/PVE/APIServer/AnyEvent.pm
+++ b/src/PVE/APIServer/AnyEvent.pm
@@ -1500,6 +1500,7 @@ sub
Uploading of files of arbitrary size is now possible.
Some (regex) lines are long, but imo more readable than splitting them
up into multiple lines, as that's how they look in the HTTP request.
Signed-off-by: Matthias Heiserer
---
src/PVE/APIServer/AnyEvent.pm
still
be changed independantly.
Signed-off-by: Matthias Heiserer
---
www/manager6/qemu/HDEdit.js | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c643ee73..9dea9984 100644
--- a/www/manager6
Existing installs are not changed by this.
Especially in benchmarks, SCSI with iothreads is significantly faster
than normal SCSI.
Signed-off-by: Matthias Heiserer
---
www/manager6/qemu/OSDefaults.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu
Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.
Signed-off-by: Matthias Heiserer
---
PVE/QemuServer.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5366df2
On 27.04.2022 14:33, Matthias Heiserer wrote:
Previously, it was in the advanced section.
In the qemu wizard, bind iothread to the SCSI controller, so that
the unlikely/impossible combination of anything other than SCSI-single
with iothread can't be accidentally selected.
However, in the
That's the SCSI controller the wizard selects by default.
Existing installs are not changed by this.
Signed-off-by: Matthias Heiserer
---
No changes from v1
www/manager6/qemu/OSDefaults.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/OSDefaults
Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.
Signed-off-by: Matthias Heiserer
---
No changes from v1
PVE/QemuServer.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE
And move it from the advanced section to the always shown area.
Because of the propertyStringSet call in onGetValues, existing VM
show the correct iothread value.
Especially in benchmarks, iothreads significantly improve IO performance.
Signed-off-by: Matthias Heiserer
---
Changes from v1
On 27.04.2022 12:01, Thomas Lamprecht wrote:
nit, ant I don't want to be annoying, but can you please add a empty line
below, and maybe even above the series-change log for easier visibility?
I'd at least appreciate that quite a bit, thx!
Sure!
src/form/ComboGrid.js | 11 +++
1 file
Signed-off-by: Matthias Heiserer
---
pve-storage-pbs.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pve-storage-pbs.adoc b/pve-storage-pbs.adoc
index 0ec93de..4b94ffd 100644
--- a/pve-storage-pbs.adoc
+++ b/pve-storage-pbs.adoc
@@ -82,7 +82,7 @@ Proxmox Backup Server
They are not used anywhere else, so I assume they were left over from
an earlier version.
Also, sometimes "[object object] flashes in the Target Guest field when
opening the reassign window, with this removed it doesn't occur.
Signed-off-by: Matthias Heiserer
---
www/manag
l
the monitor on the first node, although ceph was installed on the current
node.
With this patch, the current node is preselected.
This has no effect when installing ceph on a specific node, as the node
selector overwrites the preferred value in that case.
Signed-off-by: Matthias Heiserer
--
On 06.05.2022 10:00, Thomas Lamprecht wrote:
Am 5/5/22 um 16:27 schrieb Matthias Heiserer:
www/manager6/ceph/CephInstallWizard.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index 59458b0d..ebdc7f1d
On 22.04.2022 18:54, Thomas Lamprecht wrote:
On 22.04.22 16:43, Matthias Heiserer wrote:
During some testing, I had various requests time out.
Bug reports describing that behaviour include #795 from 2015
and #66 from 2011.
While disabling the timeout is certainly not ideal, it should fix this
Signed-off-by: Matthias Heiserer
---
Required so log_warn can be used by the other patch
Changes from v1/v2:
new patch
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 7de9e84..2fdc529 100644
--- a/debian/control
+++ b
Existing installs are not changed by this.
Signed-off-by: Matthias Heiserer
---
No changes from v1/v2
www/manager6/qemu/OSDefaults.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index eed9eebc..5e588a58
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.
Signed-off-by: Matthias Heiserer
---
Changes from v2:
* also check iothread when adding a disk to an existing VM and
scsi single
* use bind instead of hardcoded true
www
Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.
Signed-off-by: Matthias Heiserer
---
Changes from v2:
* locally import PVE::RestEnv log_warn
No changes from v1
PVE/QemuServer.pm | 5 -
1 file changed, 4 insertions(+), 1
es requries modifying this file
== does not fix
* upload can still time out
Signed-off-by: Matthias Heiserer
---
Note:
Regarding trim, I forgot to answer the mail.
Trim is imo a good name, as several languagues (e.g. rust, javascript)
use trim to mean mean "remove all whitespace, including
and remove unnecessary parentheses.
Signed-off-by: Matthias Heiserer
---
Changes from v1:
new patch
src/PVE/APIServer/AnyEvent.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
index 7dd7d2d..b8bc35d 100644
On 18.05.2022 11:40, Fabian Ebner wrote:
Am 12.05.22 um 11:24 schrieb Matthias Heiserer:
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.
Signed-off-by: Matthias Heiserer
---
Changes from v2:
* also check iothread when adding
They have been commented with //fixme for more than 11 years
and contain little information, so at least make them debug logs.
Signed-off-by: Matthias Heiserer
---
data/src/logger.c | 2 +-
data/src/status.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/src
Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.
Signed-off-by: Matthias Heiserer
---
Changes from v3:
None
Changes from v2:
locally import PVE::RestEnv log_warn
No changes from v1
PVE/QemuServer.pm | 5 -
1 file
Worked before because if SCSI should be a value, that's set in init.
isScsi is never used.
Signed-off-by: Matthias Heiserer
---
Changes from v3:
New patch
www/manager6/qemu/HDEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/man
Signed-off-by: Matthias Heiserer
---
Changes from v3:
None
Changes from v1/v2:
new patch
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index af258db..2898593 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.
Signed-off-by: Matthias Heiserer
---
Changes from v3:
* remove automatically switching to/from SCSI single when iothread is
(un)checked
* iothread will be initially set on
Existing installs are not changed by this.
Signed-off-by: Matthias Heiserer
---
No changes from v1/v2/v3
www/manager6/qemu/OSDefaults.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index eed9eebc
On 20.05.2022 08:52, Fabian Ebner wrote:
Am 19.05.22 um 15:35 schrieb Matthias Heiserer:
On 18.05.2022 11:40, Fabian Ebner wrote:
Am 12.05.22 um 11:24 schrieb Matthias Heiserer:
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO
performance
On 28.05.2022 09:22, Thomas Lamprecht wrote:
On 27/05/2022 11:37, Matthias Heiserer wrote:
They have been commented with //fixme for more than 11 years
and contain little information, so at least make them debug logs.
not really that of a good reason? Was there some actual event from a
user
I found a few typos :)
8<---
+ZFS dRAID
+~
+
+In a ZFS dRAID (declustered RAID) the hot spare drive(s) participate in the
RAID.
+Their spare capacity is reservered and used for rebuilding when one drive
fails.
typo: reservered -> reserved
+This provides depending on the configuration
On 08.06.2022 13:54, Daniel Bowder wrote:
These five patches add the ability to pin a QEMU VMs processes to a defined set of CPU
cores. The changes required spanned multiple repos and have all been included in these
five patches. The patches add "cpuset" as an option in the qm configuration
fi
ls so see how it is done:
https://lists.proxmox.com/pipermail/pve-devel/, and in the Developer
Documentation in the section "Preparing Patches".
I suggest you wait a bit before sending in a v2, I'll first test your patch.
On Wed, Jun 8, 2022 at 6:00 AM Matthias Heiserer
wrote
On 08.06.2022 13:54, Daniel Bowder wrote:
Signed-off-by: Daniel Bowder
---
The first patch adds an entry to the qm conf adding a new option: cpuset. The
cpuset here is the same cpuset used by the taskset application for pinning a
process to a cpu core. This can be found in `man cpuset`, or
On 08.06.2022 13:54, Daniel Bowder wrote:
Signed-off-by: Daniel Bowder
---
The fifth patch adds the cpuset value to the GUI under the VM.Config.Options panel. The cpuset is set as a vtype of CPUSet so that it can be checked by the regex match in the fouth patch. This was modeled after the exis
I'm not sure where it comes from, but when starting a VM, the task log
receives a bunch of messages on changed affinity:
pid 95121's current affinity list: 0-7
pid 95121's new affinity list: 2,3
pid 95122's current affinity list: 0-7
pid 95122's new affinity list: 2,3
pid 95123's current affinit
On 08.06.2022 17:34, Stefan Hrdlicka wrote:
8<--
+In a ZFS dRAID (declustered RAID) the hot spare drive(s) participate in the
RAID.
+Their spare capacity is reserved and used for rebuilding when one drive fails.
+This provides, depending on the configuration, faster rebuilding compared to a
+RA
On 10.06.2022 11:20, Fabian Ebner wrote:
Am 27.05.22 um 13:48 schrieb Matthias Heiserer:
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.
Signed-off-by: Matthias Heiserer
Reviewed-by: Fabian Ebner
---
Changes from v3
1 - 100 of 199 matches
Mail list logo
