[pve-devel] [PATCH qemu-server 0/1] Fix #5033: Add target-filename parameter in move_disk endpoint

2023-11-09 Thread Markus Ebner via pve-devel
--- Begin Message --- When using the POST endpoint at /node//storage//content a filename can be specified that will be used for the created image. If said image is then moved from one vm to another vm, the target disk-image has an automatically generated filename with the vm--disk- schema. This pa

[pve-devel] [PATCH qemu-server 1/1] fix #5033: api: Add target-filename option to move_disk reassign

2023-11-09 Thread Markus Ebner via pve-devel
--- Begin Message --- When the move_disk endpoint is used to reassign a disk image from one vm to another, the target-filename of the image is typically chosen automatically with the known naming schema. This patch adds the optional parameter target-filename, allowing to manually specify a filenam

Re: [pve-devel] [PATCH qemu-server 1/1] fix #5033: api: Add target-filename option to move_disk reassign

2023-11-10 Thread Markus Ebner via pve-devel
--- Begin Message --- > But I do have another suggestion too: Should we rather automatically > preserve the current volume name (just replacing the VM ID) if there is > no other volume with that name and choose a new name if there is? For > offline storage migration, we also do it like that (sans r

Re: [pve-devel] [PATCH qemu-server 1/1] fix #5033: api: Add target-filename option to move_disk reassign

2023-11-13 Thread Markus Ebner via pve-devel
--- Begin Message --- > But I do have another suggestion too: Should we rather automatically > preserve the current volume name (just replacing the VM ID) if there is > no other volume with that name and choose a new name if there is? For > offline storage migration, we also do it like that (sans r