Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use items/advancedItems instead of columns
src/Makefile | 1 +
src/Schema.js| 5
src/panel/GotifyEditPanel.js | 44
3 files changed, 50 insertions
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 271 ++
1 file changed, 271 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index aea571f0..8f0b6429 100644
--- a/PVE/API2/Cluster/Notifications.pm
#x27; channel with a temporary
sendmail endpoint, sending mails to `root`
- Added new options for backup jobs
- Reworked git history
Versions of this patch series:
v3: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058158.html
v2: https://lists.proxmox.com/pipermail/pve-devel/2023-Ma
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/form/NotificationFilterSelector.js | 58 +
src/panel/GotifyEditPanel.js| 9
src/panel/NotificationConfigView.js | 4 ++
src/panel/NotificationGroupEditPanel.js | 9
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 263 ++
1 file changed, 263 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 8f0b6429..e358573c 100644
--- a/PVE/API2/Cluster/Notifications.pm
Signed-off-by: Lukas Wagner
---
notifications.adoc | 159 +++
pve-admin-guide.adoc | 2 +
pve-gui.adoc | 2 +
vzdump.adoc | 5 ++
4 files changed, 168 insertions(+)
create mode 100644 notifications.adoc
diff --git a
end_notification`
- Breaking out some of the code into helper subs, hopefully
reducing the spaghetti factor a bit
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 10 +-
PVE/VZDump.pm | 335 +
test/mail_test.pl | 36 ++---
3 files c
Add an endpoint for Gotify [1], showing the how easy it is to add new
endpoint implementations.
[1] https://gotify.net/
Signed-off-by: Lukas Wagner
---
proxmox-notify/Cargo.toml | 6 +-
proxmox-notify/src/config.rs | 23 +
proxmox-notify/src/endpoints/gotify.rs
rbatim-monospaced}}{{#verbatim-monospaced}}
Do not reflow text. NOP for plain text, but for HTML output the text
will be contained in a with a monospaced font.
Signed-off-by: Lukas Wagner
---
Cargo.toml | 1 +
proxmox-notify/Cargo.toml| 6 +-
Suggested-by: Dominik Csapak
Signed-off-by: Lukas Wagner
---
Notes:
In future, we could create a new API endpoint that returns all possible ACL
and then use a normal store for the perm path combobox?
Changes since v3:
- Removed API calls that fetch targets/filters
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 40 +++
1 file changed, 40 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 32a873a7..fa2c1d9d 100644
--- a/PVE/API2/Cluster/Notifications.pm
Since `proxmox-notify` is intended to be used by multiple products,
there needs to be a way to inject product-specific behavior.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use OnceCell instead of Mutex
proxmox-notify/Cargo.toml | 1 +
proxmox-notify/src
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 315 ++
1 file changed, 315 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index b1971911..aea571f0 100644
--- a/PVE/API2/Cluster/Notifications.pm
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context.rs| 2 ++
proxmox-notify/src/endpoints/sendmail.rs | 18 +-
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/proxmox-notify/src/context.rs b/proxmox-notify/src/context.rs
index c31a243b
The proxy configuration will be read from datacenter.cfg via
a new method of the `Context` trait.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/context.rs | 1 +
proxmox-notify/src/endpoints/gotify.rs | 22 --
2 files changed, 17 insertions(+), 6 deletions
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- lookup_datacenter_config_key: move string formatting outside the
loop
pve-rs/src/notify.rs | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/pve-rs/src
Otherwise, a filter with the same name as an already existing
endpoint or group can overwrite it.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/filter.rs | 7 +
proxmox-notify/src/api/gotify.rs | 10 +--
proxmox-notify/src/api/group.rs| 24 ++-
proxmox
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Show warnings only if 'never' is selected
- Also show a warning for disabled package update notifications
- Some code style touch ups
- Added some comments
www/manager6/Makefile |
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Config.js | 16
1 file changed, 16 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index aa025c8d..9ba7b301 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -329,6 +329,22
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/lib.rs | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs
index 0059e44b..6a52db06 100644
--- a/proxmox-notify/src/lib.rs
+++ b/proxmox-notify/src
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 83
1 file changed, 83 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 2f8c9b6..1d612f1 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -5,6 +5,10
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- parse_config now takes a &[u8] instead of a &str
in order to avoid encoding issues
pve-rs/Cargo.toml| 1 +
pve-rs/Makefile | 1 +
pve-rs/src/lib.rs| 1 +
pve-rs/src/notify
This commit adds a way to filter notifications based on severity. The
filter module also has the necessary foundation work for more complex
filters, e.g. matching on properties or for creating arbitarily complex
filter structures using nested sub-filters.
Signed-off-by: Lukas Wagner
---
proxmox
This introduces a new configuration parameter `mailto-user`.
A user's email address will be looked up in the product-specific
user database.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/sendmail.rs | 32 ---
proxmox-notify/src/context.rs
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/gotify.rs | 284 +++
proxmox-notify/src/api/mod.rs| 6 +
2 files changed, 290 insertions(+)
create mode 100644 proxmox-notify/src/api/gotify.rs
diff --git a/proxmox-notify/src/api/gotify.rs b/proxmox
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 70
1 file changed, 70 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index cff1b44..8014e6d 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -5,6 +5,7
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Derive Clone for Config
- Remove private_digest from Config
- Add explanatory comment on why Rc>> is
needed in the test code
- Avoid linear search in Vec for private_configs
- Minor sty
Signed-off-by: Lukas Wagner
---
src/PVE/Cluster.pm | 2 ++
src/pmxcfs/status.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index c310a67..e3705b6 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -55,6 +55,8 @@ my $observed
The function returns all other entities referenced by a filter/target.
This is useful for permission checks, where the user must have the
appropriate permissions for all entities.
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 9 +
1 file changed, 9 insertions(+)
diff --git a
Signed-off-by: Lukas Wagner
---
pve-rs/src/notify.rs | 88
1 file changed, 88 insertions(+)
diff --git a/pve-rs/src/notify.rs b/pve-rs/src/notify.rs
index 8014e6d..2f8c9b6 100644
--- a/pve-rs/src/notify.rs
+++ b/pve-rs/src/notify.rs
@@ -5,6 +5,9
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/filter.rs | 231 +
proxmox-notify/src/api/gotify.rs | 12 ++
proxmox-notify/src/api/group.rs| 7 +
proxmox-notify/src/api/mod.rs | 1 +
proxmox-notify/src/api/sendmail.rs | 10 ++
5 files
The new notification backend is implemented in Rust where we use SHA256
for config digests.
Signed-off-by: Lukas Wagner
---
src/PVE/JSONSchema.pm | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 7589bba..49e0d7a
dds the 'never' option.
- Mark 'mailnotification' as deprecated in favor of 'notification-policy'
- Clarify that 'mailto' is ignored if 'notification-target' is set
Signed-off-by: Lukas Wagner
---
src/PVE/VZDump/Common.pm | 21 +++-
This parameter allows to send mails to the email address configured
for users from the product's user database.
`proxmox-notify` now has a `Context` that must be set via
`proxmox_notify::context::set_context` before the crate is used.
Signed-off-by: Lukas Wagner
---
pve-rs/Cargo.toml
These options allow setting the notification target for package update
notifications, node fencing notifications and replication notifications.
Also, fencing and replication has now new options that allow disabling
notifications altogether.
Signed-off-by: Lukas Wagner
---
src/PVE
The package contains the PVE::Notify. It is a very thin wrapper
around the Proxmox::RS::Notify module, feeding the configuration
from the new 'notifications.cfg' and 'priv/notifications.cfg' files
into it.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since
#x27; paramter which controls if
notifications should be sent at all. If it is not set, we
default to the old behavior, which is to send.
Also add dependency to the `libpve-notify-perl` package to d/control.
Signed-off-by: Lukas Wagner
---
debian/control | 2 ++
src/PVE/HA/Env.pm|
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use items/advancedItems instead of columns
- Call initField in EndpointSelector
- Minor code style improvements
src/Makefile| 1 +
src/Schema.js | 5 +
src
backup jobs. Some logic which automatically migrates from
'mailnotification' has been added.
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 4 +-
www/manager6/dc/Backup.js | 84 +--
www/manager6/form/Notifica
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- extracted validator function
- use items/advancedItems instead of columns
src/Makefile | 4 +
src/Schema.js| 8 ++
src/data/model/NotificationConfig.js | 8 ++
src
... instead of using sendmail directly
If the new 'target-package-updates' is set, we send a
notification to this target. If not, we continue to send
a mail to root@pam (if the mail address is configured)
Signed-off-by: Lukas Wagner
---
PVE/API2/A
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- get_referrers: minor stylistic touchups
proxmox-notify/src/api/filter.rs | 1 +
proxmox-notify/src/api/gotify.rs | 1 +
proxmox-notify/src/api/mod.rs | 111 ++---
proxmox-notify/src/api
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- use items/advancedItems instead of columns
src/Makefile | 3 +-
src/data/model/NotificationConfig.js | 9 ++
src/panel/NotificationConfigView.js | 119 +++
src/window
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 254 ++
1 file changed, 254 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index 1efebbc1..b1971911 100644
--- a/PVE/API2/Cluster/Notifications.pm
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- update d/copyright to new format
proxmox-notify/debian/changelog | 5 ++
proxmox-notify/debian/control | 112
proxmox-notify/debian/copyright | 18 +
proxmox-notify/debian
Signed-off-by: Lukas Wagner
---
test/Makefile | 8
test/{mail_test.pl => vzdump_notification_test.pl} | 0
2 files changed, 4 insertions(+), 4 deletions(-)
rename test/{mail_test.pl => vzdump_notification_test.pl} (100%)
diff --git a/test/Ma
Also adding a minWidth/maxWidth so that it doesn't become comically
large or small. The minimum size is roughly the same size as the
search bar was before. The maxmium size is the same size as the
results grid, making them align nicely.
Signed-off-by: Lukas Wagner
---
Notes:
Played aro
The shortcut is not really documented anywhere, so I think it make it a
bit more obvious to the user.
Signed-off-by: Lukas Wagner
---
www/manager6/form/GlobalSearchField.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/GlobalSearchField.js
b/www/manager6
This makes the header bar look a bit less cramped and ensures consistency
if web interfaces are used side-by-side, e.g. on an ultrawide screen.
Signed-off-by: Lukas Wagner
---
Notes:
Disadvantage: We loose 8px of vertical space. However, I really think
this is negligible.
www/manager6
On 7/21/23 15:31, Thomas Lamprecht wrote:
On 21/07/2023 11:39, Lukas Wagner wrote:
The shortcut is not really documented anywhere, so I think it make it a
bit more obvious to the user.
style not: commit message should wrap text at 70 character columns.
https://pve.proxmox.com/wiki
nd a few people quite liked it, so
I thought I'd give it a shot.
On 21/07/2023 11:39, Lukas Wagner wrote:
Also adding a minWidth/maxWidth so that it doesn't become comically
large or small. The minimum size is roughly the same size as the
you can use numbers here, IMO 168 px and 200 p
On 7/21/23 16:04, Thomas Lamprecht wrote:
well we could also meed in the middle, if having 32, 34 or 36 px is
enough to make it "less cramped"?
Yeah, the main reason for 38px was the consistency to other products.
Now that I play around a bit with different heights, I feel like the
major visua
Virtual (or anonymous) endpoints/groups are used for sending
one-off notifications to a target that does not exist in the
config.
VZDump uses this to send out notification mails to those addresses
configured by the `mailto` parameter.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
Suggested-by: Wolfgang Bugmiller
Signed-off-by: Lukas Wagner
---
src/PVE/Notify.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Notify.pm b/src/PVE/Notify.pm
index 48ef772..0464362 100644
--- a/src/PVE/Notify.pm
+++ b/src/PVE/Notify.pm
@@ -4,7 +4,7 @@ use
Also splitting PVE-specific context into its own file.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
---
common/pkg/Makefile | 1 +
common/src/mod.rs| 1 +
{pve-rs => common}/src/notify.rs | 123 +--
pve-rs/src/lib
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 3 ++-
proxmox-notify/src/config.rs | 1 +
proxmox-notify/src/context.rs | 1 +
proxmox-notify/src/lib.rs | 1 +
4 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify/src
Some tests are now disabled if not all required features are enabled.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify/src/api/mod.rs
index a4e0e40f..9372443a 100644
Signed-off-by: Lukas Wagner
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 3c4ecec..8b2259c 100644
--- a/Makefile
+++ b/Makefile
@@ -9,6 +9,7 @@ GITVERSION:=$(shell git rev-parse HEAD)
DEB=$(PACKAGE)_$(DEB_VERSION)_$(DEB_BUILD_ARCH).deb
LIB_DEB
On 7/24/23 15:50, Wolfgang Bumiller wrote:
+sub target_used_by {
+my ($target) = @_;
+
+my $used_by = [];
+
+# Check keys in datacenter.cfg
+my $dc_conf = PVE::Cluster::cfs_read_file('datacenter.cfg');
+for my $key (qw(target-package-updates target-replication target-fencin
Signed-off-by: Lukas Wagner
---
Notes:
Did not add version number since I do not know which it will be yet.
debian/control | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/control b/debian/control
index 3206b514..b807dbfe 100644
--- a/debian/control
+++ b/debian/control
... instead of using sendmail directly
If the new 'target-package-updates' is set, we send a
notification to this target. If not, we continue to send
a mail to root@pam (if the mail address is configured)
Signed-off-by: Lukas Wagner
---
PVE/API2/A
Signed-off-by: Lukas Wagner
---
www/manager6/dc/BackupJobDetail.js | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/BackupJobDetail.js
b/www/manager6/dc/BackupJobDetail.js
index 880784a2..e154fec1 100644
--- a/www/manager6/dc
This API call allows the user to test a notification target.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 40 +++
1 file changed, 40 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 263 ++
1
The API call returns all entities that can be used as notification
targets (endpoints, groups). Only targets for which the user has
appropriate permissions are returned.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 81 +++
1 file changed, 81
Check notification targets configured in datacenter.cfg and jobs.cfg,
failing if the group/endpoint to be removed is still in use there.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff
a temporary
sendmail endpoint, sending mails to `root`
- Added new options for backup jobs
- Reworked git history
Versions of this patch series:
v4: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058315.html
v3: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058
ACL paths for notification targets can become quite long, e.g.:
/mappings/notifications/
Signed-off-by: Lukas Wagner
---
www/manager6/form/PermPathSelector.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/form/PermPathSelector.js
b/www/manager6/form/PermPathSelector.js
index
Signed-off-by: Lukas Wagner
---
test/Makefile | 8
test/{mail_test.pl => vzdump_notification_test.pl} | 0
2 files changed, 4 insertions(+), 4 deletions(-)
rename test/{mail_test.pl => vzdump_notification_test.pl} (100%)
diff --git a/test/Ma
In essence the same change as for backup jobs.
Signed-off-by: Lukas Wagner
---
www/manager6/window/Backup.js | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 4b21c746
Settings for notifications have been moved to their own view.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- New in v4
www/manager6/dc/OptionView.js | 20
1 file changed, 20 deletions(-)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 255 ++
1
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use items/advancedItems instead of columns
- Call initField in EndpointSelector
- Minor code style improvements
src/Makefile| 1 +
src/Schema.js | 5 +
src
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- use items/advancedItems instead of columns
src/Makefile | 3 +-
src/data/model/NotificationConfig.js | 9 ++
src/panel/NotificationConfigView.js | 119 +++
src/window
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 305 ++
1
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- extracted validator function
- use items/advancedItems instead of columns
src/Makefile | 4 +
src/Schema.js| 8 ++
src/data/model/NotificationConfig.js | 8 ++
src
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/form/NotificationFilterSelector.js | 58 +
src/panel/GotifyEditPanel.js| 9
src/panel/NotificationConfigView.js | 4 ++
src/panel/NotificationGroupEditPanel.js | 9
This commit adds a new Perl module, PVE::API2::Cluster::Notification.
The module will contain all API handlers for the new notification
subsystem.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster.pm | 7 +++
PVE/API2/Cluster/Makefile | 1 +
PVE/API2/Cluster
ls whether
to send a notification at all.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 63 -
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index 89c5a802..d61518ba 100644
--- a/PVE/API2/
#x27; paramter which controls if
notifications should be sent at all. If it is not set, we
default to the old behavior, which is to send.
Also add dependency to the `libpve-notify-perl` package to d/control.
Signed-off-by: Lukas Wagner
---
debian/control | 2 ++
src/PVE/HA/Env.pm|
Suggested-by: Dominik Csapak
Signed-off-by: Lukas Wagner
---
Notes:
In future, we could create a new API endpoint that returns all possible ACL
and then use a normal store for the perm path combobox?
Changes since v3:
- Removed API calls that fetch targets/filters
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Config.js | 16
1 file changed, 16 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index aa025c8d..9ba7b301 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -329,6 +329,22
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use items/advancedItems instead of columns
src/Makefile | 1 +
src/Schema.js| 5
src/panel/GotifyEditPanel.js | 44
3 files changed, 50 insertions
Virtual (or anonymous) endpoints/groups are used for sending
one-off notifications to a target that does not exist in the
config.
VZDump uses this to send out notification mails to those addresses
configured by the `mailto` parameter.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 262 ++
1
update API
compat in the case that a notification shall be sent, but without
any configured notification target (which will then default to
'mail-to-root').
Signed-off-by: Lukas Wagner
---
Notes:
New in v5
PVE/API2/Cluster/Notifications.pm | 31 ++-
1 fil
end_notification`
- Breaking out some of the code into helper subs, hopefully
reducing the spaghetti factor a bit
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 10 +-
PVE/VZDump.pm | 335 +
test/mail_test.pl | 36 ++---
3 files c
backup jobs. Some logic which automatically migrates from
'mailnotification' has been added.
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 4 +-
www/manager6/dc/Backup.js | 84 +--
www/manager6/form/Notifica
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Show warnings only if 'never' is selected
- Also show a warning for disabled package update notifications
- Some code style touch ups
- Added some comments
www/manager6/Makefile |
Signed-off-by: Lukas Wagner
---
notifications.adoc | 159 +++
pve-admin-guide.adoc | 2 +
pve-gui.adoc | 2 +
vzdump.adoc | 5 ++
4 files changed, 168 insertions(+)
create mode 100644 notifications.adoc
diff --git a
Note, this commit has now been included in v5 of the original patch series.
On 7/24/23 13:26, Lukas Wagner wrote:
Virtual (or anonymous) endpoints/groups are used for sending
one-off notifications to a target that does not exist in the
config.
VZDump uses this to send out notification mails
age.
Also add some smoke-tests to make sure that the `http_bail` and
`http_err` macros actually produce valid code.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
---
Cargo.toml| 2 +
proxmox-http-error/Cargo.toml | 16 +++
proxmox-http-error/src/l
previously used it's own error type, is now also using
the new crate.
proxmox:
Lukas Wagner (3):
http-error: add new http-error crate
router: rest-server: auth-api: use new http-error crate
notify: use HttpError from proxmox-http-error
Cargo.toml | 2 +
pr
Also improve API documentation in terms of which HttpError is
returned when.
Signed-off-by: Lukas Wagner
---
Notes:
Assumes that the following two patches have been applied before,
otherwise there will be a conflict (which is trivial to resolve,
though)
1: "notify
Signed-off-by: Lukas Wagner
---
proxmox-auth-api/Cargo.toml | 2 ++
proxmox-auth-api/src/api/access.rs | 3 +-
proxmox-rest-server/Cargo.toml | 1 +
proxmox-rest-server/src/h2service.rs | 2 +-
proxmox-rest-server/src/rest.rs | 2 +-
proxmox-router/Cargo.toml
Use `proxmox-http-error::HttpError` instead of
`proxmox-notify::api::ApiError`.
Signed-off-by: Lukas Wagner
---
common/src/notify.rs | 77 +++-
pve-rs/Cargo.toml| 1 +
2 files changed, 42 insertions(+), 36 deletions(-)
diff --git a/common/src
The `HttpError` type from `proxmox-router` has been moved into its
own crate.
Signed-off-by: Lukas Wagner
---
Cargo.toml | 3 +++
src/api2/access/openid.rs | 5 ++---
src/api2/access/tfa.rs | 3 ++-
src/api2/admin/datastore.rs
hough, since we do not know if
the token has separated privileges enable or not.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/ACLView.js | 14 ++
1 file changed, 14 insertions(+)
diff --git a/www/manager6/dc/ACLView.js b/www/manager6/dc/ACLView.js
index 79f900cd..ec81a487 100644
--
On 7/26/23 15:41, Wolfgang Bumiller wrote:
I'd like `proxmox-router` to keep re-exporting both the `http_bail/err`
macros and the `HttpError` type. This would require much fewer changes
at all the call sites, and we don't need to explicitly depend on the new
crate everywhere. Its point is mostly
Signed-off-by: Lukas Wagner
---
proxmox-router/Cargo.toml | 1 +
proxmox-router/src/error.rs | 42 +
proxmox-router/src/lib.rs | 2 +-
3 files changed, 3 insertions(+), 42 deletions(-)
diff --git a/proxmox-router/Cargo.toml b/proxmox-router/Cargo.toml
601 - 700 of 1023 matches
Mail list logo
