patch v2 available:
https://lists.proxmox.com/pipermail/pve-devel/2023-October/059450.html
On 11/10/2023 17:20, Filip Schauer wrote:
On 11/10/2023 12:58, Thomas Lamprecht wrote:
Am 11/10/2023 um 11:54 schrieb Filip Schauer:
The green circle is not displayed correctly by the PVE installer as
. This causes the code to skip
fs-freeze even if the VM has woken up, potentially leaving the file
system in an inconsistent state.
To prevent this, do not treat the suspended runstate as paused when
migrating or archiving a VM.
Signed-off-by: Filip Schauer
---
PVE/API2/Qemu.pm | 4
Signed-off-by: Filip Schauer
---
proxinstall | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxinstall b/proxinstall
index d5b2565..764187f 100755
--- a/proxinstall
+++ b/proxinstall
@@ -481,8 +481,8 @@ sub create_ipconf_view {
$text = $ipconf_entry_dns
On 13/10/2023 12:36, Christoph Heiss wrote:
See inline comments. Also, `cargo fmt` please :^)
On Thu, Oct 12, 2023 at 03:02:08PM +0200, Filip Schauer wrote:
[..]
diff --git a/proxinstall b/proxinstall
index d5b2565..51170cd 100755
--- a/proxinstall
+++ b/proxinstall
@@ -347,7 +347,9 @@ sub
Tested this in the installer and it looks good to me.
Tested-by: Filip Schauer
On 17/10/2023 15:57, Maximiliano Sandoval R wrote:
From: Maximiliano Sandoval
This is a continuation of
https://lists.proxmox.com/pipermail/pve-devel/2023-August/058639.html.
Signed-off-by: Maximiliano Sandoval
Signed-off-by: Filip Schauer
---
Is it reasonable to add a "dev[n]" argument to the pct.conf, given that
device mount points only allow passing through block devices?
src/PVE/LXC.pm| 14 ++
src/PVE/LXC/Config.pm | 32
2 files c
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Alternatively a mapped
USB device can be passed through with usbmapping=.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 34 +++-
src/PVE/LXC
Changes since v2:
* mknod the devices in /var/lib/lxc/$vmid/passthrough and setup proper
permissions instead of bind mounting the devices from /dev directly
* Add support for USB mapping
* Add foreach_passthrough_device helper function
pve-container:
Filip Schauer (1):
Add device passthrough
Add a function to iterate over passthrough devices of a provided
container config.
Signed-off-by: Filip Schauer
---
src/PVE/AbstractConfig.pm | 44 +++
1 file changed, 44 insertions(+)
diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
index
A patch v2 is available:
https://lists.proxmox.com/pipermail/pve-devel/2023-October/059617.html
On 20/10/2023 10:39, Dominik Csapak wrote:
On 10/20/23 10:29, Thomas Lamprecht wrote:
Am 20/10/2023 um 09:51 schrieb Dominik Csapak:
On 10/20/23 09:08, Wolfgang Bumiller wrote:
Also, Dominik recen
Signed-off-by: Filip Schauer
---
Depends on:
https://lists.proxmox.com/pipermail/pve-devel/2023-October/059616.html
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 11 +++
www/manager6/lxc/DeviceEdit.js | 158 +
www/manager6/lxc
On 30/10/2023 14:34, Wolfgang Bumiller wrote:
On Tue, Oct 24, 2023 at 02:55:53PM +0200, Filip Schauer wrote:
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Alternatively a mapped
USB device can be passed through with
Signed-off-by: Filip Schauer
---
src/PVE/Syscall.pm | 1 +
src/PVE/Tools.pm | 5 +
2 files changed, 6 insertions(+)
diff --git a/src/PVE/Syscall.pm b/src/PVE/Syscall.pm
index 4c0b9cf..2a423e8 100644
--- a/src/PVE/Syscall.pm
+++ b/src/PVE/Syscall.pm
@@ -16,6 +16,7 @@ BEGIN {
openat
passthrough device config
pve-common:
Filip Schauer (1):
tools: add mknod syscall
src/PVE/Syscall.pm | 1 +
src/PVE/Tools.pm | 5 +
2 files changed, 6 insertions(+)
pve-container:
Filip Schauer (1):
Add device passthrough
src/PVE/LXC.pm| 29 +-
src/PVE/LXC
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Additionally the access
mode, uid and gid can be specified through their respective properties.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 29
Patch v3 available:
https://lists.proxmox.com/pipermail/pve-devel/2023-November/059844.html
On 03/11/2023 09:14, Wolfgang Bumiller wrote:
On Thu, Nov 02, 2023 at 03:28:22PM +0100, Filip Schauer wrote:
On 30/10/2023 14:34, Wolfgang Bumiller wrote:
On Tue, Oct 24, 2023 at 02:55:53PM +0200
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Additionally the access
mode, uid and gid can be specified through their respective properties.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 57
Signed-off-by: Filip Schauer
---
src/PVE/Syscall.pm | 1 +
src/PVE/Tools.pm | 5 +
2 files changed, 6 insertions(+)
diff --git a/src/PVE/Syscall.pm b/src/PVE/Syscall.pm
index 4c0b9cf..2a423e8 100644
--- a/src/PVE/Syscall.pm
+++ b/src/PVE/Syscall.pm
@@ -16,6 +16,7 @@ BEGIN {
openat
handle id mapping with multiple ranges
pve-common:
Filip Schauer (2):
tools: Add mknod syscall
tools: Add mount flag constants
src/PVE/Syscall.pm | 1 +
src/PVE/Tools.pm | 36
2 files changed, 37 insertions(+)
pve-container:
Filip Schauer (1):
Add
Signed-off-by: Filip Schauer
---
src/PVE/Tools.pm | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index fbb6773..b3af2c6 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -62,6 +62,20 @@ CLONE_NEWIPC
CLONE_NEWUSER
Patch v4 available:
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060022.html
On 10/11/2023 11:44, Wolfgang Bumiller wrote:
On Tue, Nov 07, 2023 at 02:46:42PM +0100, Filip Schauer wrote:
Add a dev[n] argument to the container config to pass devices through to
a container. A
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Additionally the access
mode, uid and gid can be specified through their respective properties.
Signed-off-by: Filip Schauer
---
Changes since v4:
* Rename device lists to
Am 13/11/2023 um 11:30 schrieb Filip Schauer:
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 56e1f10..9f325f2 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -29,6 +29,7 @@ mkdir $lockdir;
mkdir "/etc/pve/nodes/$nodename/lxc";
my $MAX_MOUNT_POINTS =
Add a dev[n] argument to the container config to pass devices through to
a container. A device can be passed by its path. Additionally the access
mode, uid and gid can be specified through their respective properties.
Signed-off-by: Filip Schauer
---
Changes since v5:
* Add error message for
Patch v6 available
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060367.html
On 16/11/2023 14:35, Wolfgang Bumiller wrote:
On Thu, Nov 16, 2023 at 12:50:44PM +0100, Filip Schauer wrote:
Add a dev[n] argument to the container config to pass devices through to
a container. A
Signed-off-by: Filip Schauer
---
proxmox-compression/src/zip.rs | 46 ++
1 file changed, 35 insertions(+), 11 deletions(-)
diff --git a/proxmox-compression/src/zip.rs b/proxmox-compression/src/zip.rs
index d2d3fd8..89b079b 100644
--- a/proxmox-compression/src
Include symlinks when restoring files from a backup as a zip file.
proxmox:
Filip Schauer (1):
fix #4995: compression: Include symlinks in zip file restore
proxmox-compression/src/zip.rs | 46 ++
1 file changed, 35 insertions(+), 11 deletions(-)
proxmox
Signed-off-by: Filip Schauer
---
pbs-client/src/pxar/extract.rs | 18 ++
1 file changed, 18 insertions(+)
diff --git a/pbs-client/src/pxar/extract.rs b/pbs-client/src/pxar/extract.rs
index f78e06c2..6f23c144 100644
--- a/pbs-client/src/pxar/extract.rs
+++ b/pbs-client/src/pxar
Wrong mailing list, please ignore
On 20/11/2023 12:54, Filip Schauer wrote:
Include symlinks when restoring files from a backup as a zip file.
proxmox:
Filip Schauer (1):
fix #4995: compression: Include symlinks in zip file restore
proxmox-compression/src/zip.rs | 46
Signed-off-by: Filip Schauer
---
Changes since v1:
* Remove usb mapping
* Add mode, uid and gid fields
To get this to build on top of the current master cd731902b7a7,
comment out the call to $notification_config->add_matcher
in PVE/VZDump.pm for now.
www/manager6/Makefile | 1 +
Patch v2 available:
https://lists.proxmox.com/pipermail/pve-devel/2023-November/060583.html
On 30/10/2023 12:27, Filip Schauer wrote:
Signed-off-by: Filip Schauer
---
Depends on:
https://lists.proxmox.com/pipermail/pve-devel/2023-October/059616.html
www/manager6/Makefile | 1
Include symlinks when restoring files from a backup as a zip file.
Changes since v1:
* Use P instead of &Path
* Fix compile error due to misplaced comma
* Check content before symlink_target, since regular files are more
common than symlinks
proxmox:
Filip Schauer (1):
fix #
Please ignore
On 23/11/2023 14:05, Filip Schauer wrote:
Include symlinks when restoring files from a backup as a zip file.
Changes since v1:
* Use P instead of &Path
* Fix compile error due to misplaced comma
* Check content before symlink_target, since regular files are more
common
nded since we do not
support 32 bit OVMF images.
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 8 +---
PVE/QemuServer/CPUConfig.pm | 28
2 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 206
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM telling the user that OVMF is not
supported on 32-bit CPU types.
Signed-off-by: Filip Schauer
---
PVE/API2/Qemu.pm | 2 +-
PVE/QemuServer.pm | 27 ---
2 files
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061034.html
On 11/12/2023 15:37, Fiona Ebner wrote:
Am 11.12.23 um 15:12 schrieb Filip Schauer:
@@ -3293,11 +3293,12 @@ sub is_native($) {
sub get_vm_arch {
my ($conf) = @_;
-return $conf->{arch} // get_host_arch();
+retu
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM telling the user that OVMF is not
supported on 32-bit CPU types.
Signed-off-by: Filip Schauer
---
Changes since v2:
* Simplify the check whether a 32-bit CPU type is used in combination
A much simpler patch v3 is available:
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061036.html
On 12/12/2023 11:37, Filip Schauer wrote:
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM telling the user that OVMF is
have the long mode
feature (CPUID_EXT2_LM).
Signed-off-by: Filip Schauer
---
Changes since v2:
* Simplify the check whether a 32-bit CPU type is used in combination
with OVMF
Changes since v3:
* Move the cputypes_32bit list from QemuServer.pm to CPUConfig.pm
* Turn cputypes_32bit into a hash for
have the long mode
feature (CPUID_EXT2_LM).
Signed-off-by: Filip Schauer
---
Changes since v2:
* Simplify the check whether a 32-bit CPU type is used in combination
with OVMF
Changes since v3:
* Move the cputypes_32bit list from QemuServer.pm to CPUConfig.pm
* Turn cputypes_32bit into a hash for
Patch v5 is available:
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061079.html
On 12/12/2023 12:12, Fiona Ebner wrote:
Am 12.12.23 um 11:58 schrieb Filip Schauer:
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM
Patch v5 is available:
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061079.html
On 13/12/2023 17:53, Filip Schauer wrote:
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM telling the user that OVMF is not
supported on
On 12/12/2023 12:48, Fiona Ebner wrote:
Am 12.12.23 um 11:39 schrieb Filip Schauer:
It's actually not a different binary. qemu-system-i386 is a symlink that
points to qemu-system-x86_64. But still this does indeed break migration
between a node that has this patch applied and another
that have the long mode
feature (CPUID_EXT2_LM).
Signed-off-by: Filip Schauer
---
Changes since v3:
* Move the cputypes_32bit list from QemuServer.pm to CPUConfig.pm
* Turn cputypes_32bit into a hash for lookup
* Create a helper get_cpu_bitness function in CPUConfig.pm
* Describe how the list of 32
Patch v6 available:
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061097.html
On 14/12/2023 10:46, Fiona Ebner wrote:
Am 13.12.23 um 17:58 schrieb Filip Schauer:
@@ -719,6 +731,26 @@ sub get_cpu_from_running_vm {
return $1;
}
+sub get_cpu_bitness {
Learned a new word
I think it makes sense to make the default for $kvm consistent and take
is_native($arch) into account. Since it is not officially supported to
run Proxmox VE on different architectures this breaking change would
likely not hurt.
On 15/12/2023 11:08, Fiona Ebner wrote:
so we only need to care abo
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a7b237e..1a1080d 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -45,7 +45,7 @@ use PVE::RPCEnvironment;
use PVE
Add an is_native($arch) subroutine to compare a CPU architecture to the
host CPU architecture. This is brought in from PVE::QemuServer.
Signed-off-by: Filip Schauer
---
src/PVE/Tools.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 766c809
cpu_bitness function in CPUConfig.pm
* Describe how the list of 32-bit CPU types was obtained
qemu-server:
Filip Schauer (4):
cpu config: Add helper to get the default CPU type
Prevent starting a 32-bit VM using a 64-bit OVMF BIOS
Move is_native from PVE::QemuServer to PVE::Tools
Unify t
that have the long mode
feature (CPUID_EXT2_LM).
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 5 -
PVE/QemuServer/CPUConfig.pm | 39 +
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index
Signed-off-by: Filip Schauer
---
PVE/QemuServer/CPUConfig.pm | 9 +++--
PVE/QemuServer/Helpers.pm | 10 ++
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
index ca2946b..c25c2c8 100644
--- a/PVE/QemuServer
tches from 'kvm64' to 'qemu64'.
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 6 --
PVE/QemuServer/CPUConfig.pm | 5 +++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 1a1080d..b2d71e1 100644
---
Patch series v7 is available:
https://lists.proxmox.com/pipermail/pve-devel/2023-December/061147.html
On 14/12/2023 12:09, Filip Schauer wrote:
Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image,
throw an error before starting the VM telling the user that OVMF is not
Decode non-ASCII character when syncing user attributes, since those
will be encoded later on. Without this fix the attributes where encoded
twice, resulting in cases such as 'ü' turning into 'ü'.
Signed-off-by: Filip Schauer
---
src/PVE/Auth/LDAP.pm | 2 +-
1 file change
w Apparmor profile to allow move_mount on
every mount, specifically for mount point hotplug.
Signed-off-by: Filip Schauer
---
debian/rules | 3 +++
src/Makefile | 3 +++
src/PVE/LXC.pm | 2 +-
src/pve-container-debug@.service | 1 +
src/pve
UTF8 decode non-ASCII characters when syncing user attributes, since
those will be encoded later on. Without this fix the attributes were
encoded twice, resulting in cases such as 'ü' turning into 'ü'.
Signed-off-by: Filip Schauer
---
Changes since v1:
* Do not try to U
Patch v2 is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061273.html
On 08/01/2024 10:26, Wolfgang Bumiller wrote:
On Wed, Dec 20, 2023 at 03:37:03PM +0100, Filip Schauer wrote:
Decode non-ASCII character when syncing user attributes, since those
decode *how*?
will
I just tried your patch, but it did not fix this specific issue.
On 09/01/2024 14:38, Fiona Ebner wrote:
Am 09.01.24 um 14:35 schrieb Filip Schauer:
UTF8 decode non-ASCII characters when syncing user attributes, since
those will be encoded later on. Without this fix the attributes were
encoded
Repeatedly creating users no longer re-encodes non-ASCII characters with
this patch applied.
Tested-by: Filip Schauer
On 09/01/2024 12:55, Fiona Ebner wrote:
by correclty passing the $force_utf8 flag to
PVE::Tools::file_set_contents(). The idea was that only callers that
are ready will opt-in
from update_lxc_config to update_pct_config, which is
run before the entry is written to the config file.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 8
src/PVE/LXC/Config.pm | 19 ++-
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/src/PVE
This is a bug in pve-container. I sent a patch for it:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061513.html
On 26/01/2024 16:23, Fiona Ebner wrote:
- if I add /dev/doesnotexist I'll get an error but it'll still be added
to the configuration
Clarify the naming of mount point utils to clearly indicate their
relation to LXC containers.
Signed-off-by: Filip Schauer
---
www/manager6/Utils.js| 12 ++--
www/manager6/lxc/MPEdit.js | 4 ++--
www/manager6/lxc/MultiMPEdit.js | 4 ++--
www
non-root users
* Change var to let
* Minor code cleanup of DeviceEdit.js
Changes since v1:
* Remove usb mapping
* Add mode, uid and gid fields
Filip Schauer (2):
utils: clarify naming of LXC mount point utils
ui: lxc: add edit window for device passthrough
www/manager6/Makefile
Signed-off-by: Filip Schauer
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 11 ++
www/manager6/lxc/DeviceEdit.js | 190 +
www/manager6/lxc/Resources.js | 31 +-
4 files changed, 232 insertions(+), 1 deletion(-)
create mode
On 26/01/2024 16:23, Fiona Ebner wrote:
I might be missing something, but isn't this a normal ExtJS text field?
Does this cbind have any actual consequences? Same for the others.
This cbind is indeed not needed here.
A patch v3 that incorporates your feedback is available:
https://lists.proxm
Tested with ipset, alias and direct IPv4 addresses as source and
destination. It all works for me.
Tested-by: Filip Schauer
On 16/01/2024 15:30, Stefan Hanreich wrote:
fall back to using v.ref as value when we do not have an alias or ipset
since scope and name are not set for ips / cidrs
bump
On 01/09/2023 11:05, Filip Schauer wrote:
Do not use the 'noacl' mount option when mounting a container disk with
an ext4 file system. The option was removed from the kernel in commit
2d544ec923db
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm | 10 +++---
1 file
Signed-off-by: Filip Schauer
---
www/manager6/qemu/HardwareView.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 5b33b1e2..672a7e1a 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu
Allow moving unused/detached disks to another storage.
Signed-off-by: Filip Schauer
---
PVE/API2/Qemu.pm | 3 ---
PVE/QemuServer.pm | 5 +++--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 69c5896..97216a3 100644
--- a/PVE/API2/Qemu.pm
Allow moving unused/detached disks to another storage.
qemu-server:
Filip Schauer (1):
fix #1905: Allow moving unused disks
PVE/API2/Qemu.pm | 3 ---
PVE/QemuServer.pm | 5 +++--
2 files changed, 3 insertions(+), 5 deletions(-)
pve-manager:
Filip Schauer (1):
Allow moving unused disks
Config.pm
* Describe how the list of 32-bit CPU types was obtained
common:
Filip Schauer (1):
tools: add is_native_arch to compare the CPU architecture
src/PVE/Tools.pm | 6 ++
1 file changed, 6 insertions(+)
qemu-server:
Filip Schauer (5):
cpu config: Add helper to get the defaul
Signed-off-by: Filip Schauer
---
PVE/QemuServer/CPUConfig.pm | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
index ca2946b..4be5262 100644
--- a/PVE/QemuServer/CPUConfig.pm
+++ b/PVE/QemuServer
Add an is_native_arch($arch) subroutine to compare a CPU architecture to
the host CPU architecture. This is brought in from PVE::QemuServer.
Signed-off-by: Filip Schauer
---
src/PVE/Tools.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index
that have the long mode
feature (CPUID_EXT2_LM).
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 5 -
PVE/QemuServer/CPUConfig.pm | 39 +
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 5 +++--
PVE/QemuServer/CPUConfig.pm | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7600939..6055d40 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
Move is_native from PVE::QemuServer to PVE::Tools and rename it to
is_native_arch to be more descriptive.
Signed-off-by: Filip Schauer
---
PVE/QemuServer.pm | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 33c374c
When attempting a CPU hotplug on an architecture other than x86_64, die
with a clean error instead of attempting a hotplug with a known
non-working device command line. Also move the corresponding FIXME up to
the error.
Signed-off-by: Filip Schauer
---
PVE/QemuServer/CPUConfig.pm | 4 +++-
1
Patch v8 available:
https://lists.proxmox.com/pipermail/pve-devel/2024-February/061899.html
On 19/02/2024 15:46, Fiona Ebner wrote:
Am 19.12.23 um 10:40 schrieb Filip Schauer:
Add an is_native($arch) subroutine to compare a CPU architecture to the
host CPU architecture. This is brought in
On 19/02/2024 15:47, Fiona Ebner wrote:
On an x86_64 host, for guests using a different architecture (i.e.
aarch64), hot-plugging is already broken, because we try to hotplug a
CPU of type "$cpu-x86_64-cpu,XYZ" which won't work anyways:
vcpus: hotplug problem - VM 130 qmp command 'device_add' fa
Do not use the 'noacl' mount option when mounting a container disk with
an ext4 file system. The option was removed from the kernel in commit
2d544ec923db
The ext4 detection is based on $do_format in alloc_disk.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm | 22 +++
A v2 of this patch is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-February/061932.html
On 16/02/2024 14:59, Fiona Ebner wrote:
Am 01.09.23 um 11:05 schrieb Filip Schauer:
Do not use the 'noacl' mount option when mounting a container disk with
an ext4 file system.
ectures is not supported anyway, so this is
not a breaking change after all.
It should be noted that this change does alter the CPU hotplug behaviour
when emulating an x86_64 CPU on a non-x86_64 host. This is however not
officially supported in Proxmox VE.
On 21/02/2024 15:33, Filip Schauer wrote:
On 22/02/2024 10:35, Fiona Ebner wrote:
Yes, I also think the change is fine. But breaking ARM64 guests on a
x86_64 host would not be fine. The point is CPU hotplug already doesn't
work here, so the commit message should be adapted to mention that.
I saw you completely removed the commit message
schrieb Filip Schauer:
Allow moving unused/detached disks to another storage.
this is a repetition of the commit subject, while that is on it's
own OK, I'd rather see a description about why this is OK to do, i.e.,
why was the original check added, what changed since then, what are
the
When attempting a CPU hotplug on an architecture other than x86_64, die
with a clean error instead of attempting a hotplug with a known
non-working device command line. Also move the corresponding FIXME up to
the error.
Signed-off-by: Filip Schauer
---
PVE/QemuServer/CPUConfig.pm | 4 +++-
1
Here is a fixed patch v2:
https://lists.proxmox.com/pipermail/pve-devel/2024-March/062153.html
On 08/03/2024 14:53, Fiona Ebner wrote:
Am 08.03.24 um 14:34 schrieb Thomas Lamprecht:
Am 21/02/2024 um 15:33 schrieb Filip Schauer:
When attempting a CPU hotplug on an architecture other than
public functions,
therefore it makes sense to have them public as well.
Signed-off-by: Filip Schauer
---
src/lib.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib.rs b/src/lib.rs
index 02e74f7..9067fc5 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -11,7 +11,7 @@ use
Changes since v1:
* Fix loading of apparmor profile not working in postinst, since the
profile is not found by dh_apparmor. This is fixed by moving
pve-container-mounthotplug out of the pve subdirectory.
* Fix a perl undef warning when apparmor changeprofile fails.
Filip Schauer (2):
fix
w Apparmor profile to allow move_mount on
every mount, specifically for mount point hotplug.
Signed-off-by: Filip Schauer
---
debian/rules | 3 +++
src/Makefile | 3 +++
src/PVE/LXC.pm | 2 +-
src/pve-container-debug@.service | 1 +
src/pve
Fix a "Use of uninitialized value in numeric ne (!=)" warning when
syswrite returns undef when trying to change the apparmor profile.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LX
On 25/03/2024 11:29, Fiona Ebner wrote:
Am 08.01.24 um 14:54 schrieb Filip Schauer:
Set up an Apparmor profile to allow moving mounts for mount point
hotplug.
This fixes a regression caused by
kernel commit 157a3537d6 ("apparmor: Fix regression in mount mediation")
The commit
Patch v2 is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-March/062390.html
On 08/01/2024 14:54, Filip Schauer wrote:
Set up an Apparmor profile to allow moving mounts for mount point
hotplug.
This fixes a regression caused by
kernel commit 157a3537d6 ("apparmor: Fix regre
subdirectory.
* Fix a perl undef warning when apparmor changeprofile fails.
Filip Schauer (2):
fix #5160: fix move_mount regression for mount point hotplug
fix undef warning when apparmor changeprofile fails
debian/rules | 3 +++
src/Makefile | 3 +++
src/PVE
Fix a "Use of uninitialized value in numeric ne (!=)" warning when
syswrite returns undef when trying to change the apparmor profile.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LX
w Apparmor profile to allow move_mount on
every mount, specifically for mount point hotplug.
Signed-off-by: Filip Schauer
---
debian/rules | 3 +++
src/Makefile | 3 +++
src/PVE/LXC.pm | 2 +-
src/pve-container-mounthotplug | 7 +++
4 files c
Agreed. This appear to be a leftover from testing. A patch v3 with this
removed is available:
https://lists.proxmox.com/pipermail/pve-devel/2024-April/062693.html
On 09/04/2024 10:23, Wolfgang Bumiller wrote:
diff --gita/src/pve-container-debug@.service b/src/pve-container-debug@.service
index
The get_device_stat subroutine gets a device path, validates it, and
returns the file mode and the device identifier.
Signed-off-by: Filip Schauer
---
src/PVE/Tools.pm | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
from update_lxc_config to update_pct_config, which is
run before the entry is written to the config file.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 18 --
src/PVE/LXC/Config.pm | 11 ++-
2 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/src
from update_lxc_config to update_pct_config, which is
run before the entry is written to the config file.
Changes since v1:
* Use "if" instead of "unless"
* Move device path validation and stat to seperate helper function
pve-common:
Filip Schauer (1):
add get_device_st
On 11/04/2024 14:18, Fiona Ebner wrote:
-
my $absolute_path = $device->{path};
my ($mode, $rdev) = (stat($absolute_path))[2, 6];
- die "Device $absolute_path does not exist\n" if $! == ENOENT;
-
die "Error accessing device $absolute_path\n"
if (!defined($mo
1 - 100 of 371 matches
Mail list logo
