Am 31.01.22 um 13:34 schrieb Fabian Grünbichler:
> On January 27, 2022 3:01 pm, Fabian Ebner wrote:
>> using the familiar early+repeated checks pattern from other API calls.
>> Only intended functional changes are with regard to locking/forking.
>
> two questions:
>
://forum.proxmox.com/threads/103413/
Signed-off-by: Fabian Ebner
---
Note for testers: the API call uses a cache.
PVE/API2/APT.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 5344f5e8..dcd87c37 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler:
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index 837df1b..682dd38 100755
> --- a/PVE/Storage.pm
> +++ b/PVE/Storage.pm
> @@ -1833,6 +1833,72 @@ sub volume_imported_message {
> }
> }
>
> +# $format and $volname are requests and might be
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler:
> +if ($cpid) {
> + $writer->writer();
> + $reader->reader();
> + my $tunnel = {
> + writer => $writer,
> + reader => $reader,
> + pid => $cpid,
> + log => $log,
> + };
> +
> + eval {
> +
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler:
> +sub storage_migrate {
> +my ($tunnel, $storecfg, $volid, $local_vmid, $remote_vmid, $opts, $log)
> = @_;
> +
> +my $targetsid = $opts->{targetsid};
> +my $bwlimit = $opts->{bwlimit};
> +
> +# JSONSchema and get_bandwidth_limit use
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler:
> @@ -251,22 +311,30 @@ sub scan_local_volumes {
> next if @{$dl->{$storeid}} == 0;
>
> my $targetsid =
> PVE::QemuServer::map_id($self->{opts}->{storagemap}, $storeid);
> - # check if storage is available on target nod
Am 03.02.22 um 13:41 schrieb Fabian Grünbichler:
> @@ -900,6 +1017,7 @@ our $cmddef = {
> clone => [ "PVE::API2::Qemu", 'clone_vm', ['vmid', 'newid'], { node =>
> $nodename }, $upid_exit ],
>
> migrate => [ "PVE::API2::Qemu", 'migrate_vm', ['vmid', 'target'], { node
> => $nodename },
es storage 4/4 and guest-common 3/3 (I also didn't look
at the already applied proxmox-websocket-tunnel):
Reviewed-by: Fabian Ebner
This time, I essentially focused on the changed bits and didn't re-read
all patches from scratch, but everything where I didn't complain in v3
already l
Signed-off-by: Fabian Ebner
---
pvesm.adoc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/pvesm.adoc b/pvesm.adoc
index 98c8c44..76992dd 100644
--- a/pvesm.adoc
+++ b/pvesm.adoc
@@ -239,6 +239,12 @@ format::
Default image format (`raw|qcow2|vmdk`)
+preallocation
Am 03.02.22 um 12:32 schrieb Fabian Ebner:
> A virtual package does not have SelectedState Install, but the
> dependency will still be satisfied if a package providing it has.
>
> Fixes a bug, wrongly showing that postfix will be installed, when a
> different mail-transport-agent i
Am 09.02.22 um 14:07 schrieb Fabian Grünbichler:
> re-using helpers that already exist for qemu-server. this is a
> pre-requisite for extending remote migration support to containers.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> new in v5, no GUI yet until possible wrinkles are i
Will be used when cloning from a qcow2 efidisk.
Signed-off-by: Fabian Ebner
---
New in v2.
...-add-l-option-for-loading-a-snapshot.patch | 129 ++
debian/patches/series | 1 +
2 files changed, 130 insertions(+)
create mode 100644
debian/patches/pve
The colon after U is wrong, because it doesn't take an argument.
Signed-off-by: Fabian Ebner
---
New in v2.
...PVE-Up-qemu-img-dd-add-n-skip_create.patch | 64 +--
1 file changed, 60 insertions(+), 4 deletions(-)
diff --git a/debian/patches/pve/0012-PVE-Up-qemu-img-dd-
Am 11.02.22 um 11:38 schrieb Fabian Grünbichler:
> for proper re-use in pve-container.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> requires dependency on bumped libpve-common-perl
>
Tricky to build, but FWIW, both patches:
Reviewed-by: Fabian Ebner
Am 11.02.22 um 11:29 schrieb Fabian Grünbichler:
> the 'pve-targetstorage' standard option will be moved in a follow-up to
> the remote migration series (with patches in qemu-server/pve-common
> only, as pve-container picks up the option via pve-ha-manager anyway).
>
> th
Am 09.02.22 um 14:07 schrieb Fabian Grünbichler:
> @@ -4016,6 +4016,206 @@ __PACKAGE__->register_method({
>
> }});
>
> +__PACKAGE__->register_method({
> +name => 'remote_migrate_vm',
> +path => '{vmid}/remote_migrate',
> +method => 'POST',
> +protected => 1,
> +proxyto
Am 09.02.22 um 14:07 schrieb Fabian Grünbichler:
> + PVE::Cluster::check_cfs_quorum();
> +
> + my $socket_addr = "/run/qemu-server/$vmid.mtunnel";
Nit: since there is another variable with the same name inside $realcmd
below, and this one is not used until the end, it could be moved furthe
Am 09.02.22 um 14:07 schrieb Fabian Grünbichler:
> no semantic changes intended, except for:
> - no longer passing the main migration UNIX socket to SSH twice for
> forwarding
> - dropping the 'unix:' prefix in start_remote_tunnel's timeout error message
>
> Signed-off-by: Fabian Grünbichler
> --
needs a rebase, because of conflicts in debian/control ;)
For the remaining qemu-server patches, once the $tunnel_info->{rport}
typo (and any subset of my other nits) is addressed:
Reviewed-by: Fabian Ebner
___
pve-devel mailing list
pve-devel@lists
rchive_path -v";
> for (my $i = 0; $i < 30; $i++) {
> system("truncate -s 1M $dir/drive-virtio$i.img");
> $cmd .= " drive-virtio$i=$dir/drive-virtio$i.img";
> }
> system($cmd);
Signed-off-by: Fabian Ebner
---
A late addition to v2.
...VE-Backup-add-vma-
Ping for this series
Am 29.10.21 um 13:16 schrieb Fabian Ebner:
> which avoids the need for the caller to check whether the environment
> was initialized or not.
>
> Signed-off-by: Fabian Ebner
> ---
>
> Changes from v1:
> * The static function now calls the class
Ping
Am 16.07.21 um 15:27 schrieb Fabian Ebner:
> Using
> pvesh create /nodes/pve701/apt/repositories --path
> "/etc/apt/sources.list" --index 0 --enabled 1
> reliably leads to
> error: invalid type: string "0", expected usize
>
> Coerc
The format can't be qcow2 for TPM state, because swtpm reads the file
directly expecting raw data.
Signed-off-by: Fabian Ebner
---
The DiskStorageSelector in the UI hides the format for TPM state, but
still sends along format=qcow2 triggering this bug. Still, the fix
should be in the ba
the buffer still contains data from the previous
iteration.
Signed-off-by: Fabian Ebner
---
RFC, because I'm no vma expert :)
...VE-Backup-add-vma-backup-format-code.patch | 21 ---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git
a/debian/patches/pve/0025-PVE
Am 17.02.22 um 13:55 schrieb Mira Limbeck:
> 'qemu-img info' with output format 'json' returns the size and used values as
> integers, but the regex match converts them to strings.
> As we know they only contain digits, we can simply cast them back to integers
> after the regex.
>
> The API requir
Am 17.02.22 um 14:33 schrieb Thomas Lamprecht:
> On 16.02.22 11:47, Fabian Ebner wrote:
>> The format can't be qcow2 for TPM state, because swtpm reads the file
>> directly expecting raw data.
>>
>> Signed-off-by: Fabian Ebner
>> ---
>>
>> The
Am 17.02.22 um 14:33 schrieb Mira Limbeck:
> On 2/17/22 14:24, Fabian Ebner wrote:
>> Am 17.02.22 um 13:55 schrieb Mira Limbeck:
>>> 'qemu-img info' with output format 'json' returns the size and used
>>> values as
>>> integers, but the r
integer in case it was changed to a
> string previously
> +used => int($used),
Style nit: please fix the pre-existing white-space error while modifying
the line
> format => $format,
> };
>
Just minor nits, so both patches:
Reviewed-by: Fabian Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 17.02.22 um 15:54 schrieb Mira Limbeck:
> `qemu-img info --output=json` returns the size and used values as integers in
> the JSON format, but the regex match converts them to strings.
> As we know they only contain digits, we can simply cast them back to integers
> after the regex.
>
> The API
Am 18.02.22 um 11:42 schrieb Matthias Heiserer:
> The backups in the 'Backups' table in Storages are now initially
> sorted by column 'Name' ascending.
>
> Previously, they were first sorted by 'vmid' descending, then by date
> descending. This was unintuitive as 'vmid' doesn't exist as column
> i
Can only happen by manually editing AFAICT, but cron does execute the
jobs, so just be a bit less restrictive when parsing.
Reported in the community forum:
https://forum.proxmox.com/threads/105254/
Signed-off-by: Fabian Ebner
---
pve-zsync | 3 +--
1 file changed, 1 insertion(+), 2 deletions
The old name is confusing, because "encode" is usually not used when
converting from text to a data structure.
Signed-off-by: Fabian Ebner
---
pve-zsync | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pve-zsync b/pve-zsync
index b466076..7246336 100755
--- a
A to-be-deleted snapshot might be actively used by replication,
resulting in a not (or only partially) removed snapshot and locked
(snapshot-delete) VM. Simply wait a few seconds for any ongoing
replication.
Signed-off-by: Fabian Ebner
---
Dependency bump for guest-common needed.
New in v3
used for obtaining the lock.
Changes from v2:
* Also check upon manual snapshot removal, not just for vzdump.
* Add common helper.
guest-common:
Fabian Ebner (1):
guest helpers: add run_with_replication_guard
src/PVE/GuestHelpers.pm | 15 ++-
1 file changed, 14 insertions(
rage layer, because the replication really should be done by then
(subsequent replications shouldn't matter as they don't need to
re-transfer the vzdump snapshot).
Suggested-by: Fabian Grünbichler
Signed-off-by: Fabian Ebner
---
Dependency bump for guest-common needed.
Changes from v2:
Signed-off-by: Fabian Ebner
---
New in v3.
src/PVE/GuestHelpers.pm | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm
index 970c460..1183819 100644
--- a/src/PVE/GuestHelpers.pm
+++ b/src/PVE/GuestHelpers.pm
A to-be-deleted snapshot might be actively used by replication,
resulting in a not (or only partially) removed snapshot and locked
(snapshot-delete) container. Simply wait a few seconds for any ongoing
replication.
Signed-off-by: Fabian Ebner
---
New in v3.
src/PVE/API2/LXC/Snapshot.pm | 12
Reported in the community forum:
https://forum.proxmox.com/threads/105254/
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Use shellwords().
pve-zsync | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pve-zsync b/pve-zsync
index 7246336..46b0ba7 100755
--- a/pve
Am 21.02.22 um 12:58 schrieb Fabian Ebner:
> Signed-off-by: Fabian Ebner
> ---
>
> New in v3.
>
> src/PVE/GuestHelpers.pm | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm
>
Am 13.01.22 um 11:08 schrieb Fabian Ebner:
> @@ -89,6 +90,10 @@ my $check_storage_access = sub {
> } else {
> PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg,
> $vmid, $volid);
> }
> +
> + if (my $source_image = $drive->{'imp
Am 22.02.22 um 11:27 schrieb Fabian Grünbichler:
> On February 22, 2022 10:41 am, Fabian Ebner wrote:
>> Am 21.02.22 um 12:58 schrieb Fabian Ebner:
>>> @@ -82,6 +83,18 @@ sub guest_migration_lock {
>>> return $res;
>>> }
>>>
>>>
Am 17.02.22 um 15:12 schrieb Matthias Heiserer:
> When restoring a backup and the storage the disks would be created on
> doesn't allow 'images', the process errors without cleanup.
> This is the same behaviour we currently have when the storage is
> disabled.
>
> Signed-off-by: Matthias Heiserer
A to-be-deleted snapshot might be actively used by replication,
resulting in a not (or only partially) removed snapshot and locked
(snapshot-delete) VM. Simply wait a few seconds for any ongoing
replication.
Signed-off-by: Fabian Ebner
---
Changes from v3:
* Use guest_migration_lock
A to-be-deleted snapshot might be actively used by replication,
resulting in a not (or only partially) removed snapshot and locked
(snapshot-delete) container. Simply wait a few seconds for any ongoing
replication.
Signed-off-by: Fabian Ebner
---
Changes from v3:
* Use guest_migration_lock
be another snapshot
removal operation holding the lock.
container:
Fabian Ebner (2):
partially fix #3424: vzdump: cleanup: wait for active replication
fix #3424: api: snapshot delete: wait for active replication
src/PVE/API2/LXC/Snapshot.pm | 11 ++-
src/PVE/VZDump/LXC.pm
rage layer, because the replication really should be done by then
(subsequent replications shouldn't matter as they don't need to
re-transfer the vzdump snapshot).
Suggested-by: Fabian Grünbichler
Co-developed-by: Fabian Grünbichler
Signed-off-by: Fabian Ebner
---
Changes from v3:
Am 23.02.22 um 12:15 schrieb Matthias Heiserer:
> When restoring a backup and the storage the disks would be created on
> doesn't allow 'images', the process errors without cleanup.
> This is the same behaviour we currently have when the storage is
> disabled.
>
> Signed-off-by: Matthias Heiserer
} elsif (!$storeid) {
> }
> $storeid = 'local';
Something happened here, making the patch not apply.
When fixed to apply,
Reviewed-by: Fabian Ebner
Tested-by: Fabian Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https:/
r the MIRROR_SYNC_MODE_BITMAP case which is used
for PBS.
Signed-off-by: Fabian Ebner
---
...e-bcs-bitmap-initialization-to-job-c.patch | 58 +++
...E-Backup-add-vma-backup-format-code.patch} | 0
...Backup-add-backup-dump-block-driver.patch} | 4 +-
...kup-proxmox-backup-patche
Am 01.03.22 um 09:51 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer
> ---
> PVE/Jobs/Plugin.pm | 19 ++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Jobs/Plugin.pm b/PVE/Jobs/Plugin.pm
> index 6098360b..4883a193 100644
> --- a/PVE/Jobs/Plugin.pm
Am 01.03.22 um 09:51 schrieb Hannes Laimer:
> ... on destroy if 'purge' is selected
>
> Signed-off-by: Hannes Laimer
> ---
> src/PVE/API2/LXC.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 84712f7..2e4146e 100644
> --- a/src/PVE/API
enough.
And there can be hookscripts executed upon thaw, which might also not
complete instantly.
Signed-off-by: Fabian Ebner
---
PVE/QMPClient.pm | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index ea4dc0b..8af28e8 100644
--- a/PVE
Am 02.03.22 um 15:28 schrieb Hannes Laimer:
> Am 02.03.22 um 11:16 schrieb Fabian Ebner:
>> Am 01.03.22 um 09:51 schrieb Hannes Laimer:
>>> ... on destroy if 'purge' is selected
>>>
>>> Signed-off-by: Hannes Laimer
>>> ---
>>&g
Previously, the transport format (which currently is always 'zfs') was
passed in, resulting in subvol-disks not to be renamed correctly.
Fixes: a97d3ee ("Introduce allow_rename parameter for pvesm import and
storage_migrate")
Signed-off-by: Fabian Ebner
---
PVE/Storage/
In particular, fixes migration with an unused disk, where calling
update_volume_ids() failed previously.
Signed-off-by: Fabian Ebner
---
src/PVE/LXC/Config.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 0ed7bd2..d5b49d3 100644
It's expected to be set further below. Reported in the community
forum: https://forum.proxmox.com/threads/105685
Fixes: e90ddc4 ("fix #1532: add target-storage support to migration")
Signed-off-by: Fabian Ebner
---
src/PVE/LXC/Migrate.pm | 1 +
1 file changed, 1 insertion(+)
d
The recent changes to support setting target storage and allow
renaming led to two problems with unused and unreferenced disks, as
well as exposing a bug in ZFSPoolPlugin.pm's volume_import.
container:
Fabian Ebner (2):
migrate: also set targetsid for unreferenced disks
config: print v
Am 03.03.22 um 18:10 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer
> ---
> FIXUP: sort was not needed and should not have been there
>
> PVE/Jobs.pm | 18 +-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Jobs.pm b/PVE/Jobs.pm
> index ba3685ec..ea
Am 04.03.22 um 11:25 schrieb Thomas Lamprecht:
> On 29/10/2021 13:16, Fabian Ebner wrote:
>> No functional change is intended.
>>
>> Signed-off-by: Fabian Ebner
>> ---
>>
>> No changes from v1.
>>
>> Dependency bump for pve-common is needed.
]: https://forum.proxmox.com/threads/105904/
Fixes: 86ed64f9 ("api: ceph: mon: fix handling of IPv6 addresses in
assert_mon_prerequisites")
Signed-off-by: Fabian Ebner
---
PVE/API2/Ceph/MON.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2
Avoids the error
adding drive failed: Duplicate ID 'drive-scsi1' for drive
that could happen when switching over to a new disk (e.g. via qm set),
if unplugging wasn't fast enough.
Signed-off-by: Fabian Ebner
---
New in v11.
PVE/QemuServer.pm | 1 +
1 file changed, 1 insertion
Upgrading a cluster node entails re-starting or migrating VMs and even
PVE 6.0 already had QEMU 4.0.
Signed-off-by: Fabian Ebner
---
New in v11.
PVE/QemuServer.pm | 7 ---
1 file changed, 7 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b7e6a8e..c0fca49 100644
Necessary to import from an existing storage using block-device
volumes like ZFS.
Signed-off-by: Dominic Jäger
[split into its own patch]
Signed-off-by: Fabian Ebner
---
No changes from v10.
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE
vation and size update nearly always triggered,
because only the pending changes are passed in as $conf. The case
where it didn't trigger is when the same pending change was made twice
(there are cases where hotplug isn't done, but makes it even more
unlikely).
Signed-off-by: Fabian Eb
In the spirit of c75bf16 ("qm importdisk: tell user to what VM disk we
actually imported"), and so that the information is not lost once qm
importdisk switches to re-using the API call.
Added for cloudinit too, because a new disk is allocated.
Signed-off-by: Fabian Ebner
---
New in
g GUI integration for import from ovf, but that will be it's
own series.
Previous discussion:
https://lists.proxmox.com/pipermail/pve-devel/2022-January/051379.html
qemu-server:
Dominic Jäger (1):
api: support VM disk import
Fabian Ebner (13):
device unplug: verify that unplugging scsi disk compl
Signed-off-by: Fabian Ebner
---
New in v11.
PVE/API2/Qemu.pm | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 01321c8..791a23f 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -63,6
and also when source and target drivename are different. In those
cases, it is done via qemu-img convert/dd.
In preparation to allow import from existing PVE-managed disks.
Signed-off-by: Fabian Ebner
---
New in v11.
PVE/API2/Qemu.pm | 2 ++
PVE/QemuServer.pm | 29
Co-developed-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
[split into its own patch + minor improvements/style fixes]
Signed-off-by: Fabian Ebner
---
Changes from v10:
* Add "Path to" to 'manifest' parameter description.
PVE/API2/Qemu/Makefile | 2 +-
PVE/API
From: Dominic Jäger
Extend qm importdisk functionality to the API.
Co-authored-by: Fabian Grünbichler
Co-authored-by: Dominic Jäger
Signed-off-by: Fabian Ebner
---
Changes from v10:
* Switch to using clone_disk for PVE-managed volumes and check for
VM.Clone in the permission check
Prepare for calling parse_ovf via API, where the -T switch is used.
Signed-off-by: Fabian Ebner
---
Changes from v10:
* Move untaint to outside of the function call.
PVE/QemuServer/OVF.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer/OVF.pm b
Signed-off-by: Dominic Jäger
[split into its own patch + style fixes]
Signed-off-by: Fabian Ebner
---
No changes from v10.
PVE/QemuServer.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 0217d16..b5fb457 100644
ly of $smm.
The correct config is also needed to determine the correct size for
the EFI disk for the upcoming import-from feature.
Signed-off-by: Fabian Ebner
---
New in v11.
PVE/API2/Qemu.pm | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git
to make the interface more digestible.
Signed-off-by: Fabian Ebner
---
New in v11.
PVE/API2/Qemu.pm | 52 +++
PVE/QemuServer.pm | 9 ++--
2 files changed, 41 insertions(+), 20 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
to its own patch + add to index]
Signed-off-by: Fabian Ebner
---
Needs dependency bump for qemu-server.
Changes from v10:
* Add reason for placing it directly under /nodes/{node} to commit
message.
PVE/API2/Nodes.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/PVE/API2/
via the special syntax :.
Not worth it by itself, but this is anticipating a new 'import-from'
parameter which is only used upon import/allocation, but shouldn't be
part of the schema for the config or other API enpoints.
Signed-off-by: Fabian Ebner
---
Changes from v10:
Am 07.03.22 um 07:43 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer
> ---
> changed back to v1, but without the unnecessary stuff. Thanks for the
> feedback @Fabian Ebner
>
> PVE/Jobs.pm | 17 -
> 1 file changed, 16 insertions(+), 1 deletion(-)
Am 07.03.22 um 15:51 schrieb Mark Schouten:
> Hi,
>
> Sorry for getting back on this thread after a few months, but is the
> Windows-case mentioned here the case that is discussed in this forum-thread:
> https://forum.proxmox.com/threads/windows-vms-stuck-on-boot-after-proxmox-upgrade-to-7-0.1007
access.
> —
> Mark Schouten, CTO
> Tuxis B.V.
> m...@tuxis.nl
>
>
>
>> On 8 Mar 2022, at 10:12, Fabian Ebner wrote:
>>
>> Am 07.03.22 um 15:51 schrieb Mark Schouten:
>>> Hi,
>>>
>>> Sorry for getting back on this thread after a
Upgrading a cluster node entails re-starting or migrating VMs and even
PVE 6.0 already had QEMU 4.0.
Signed-off-by: Fabian Ebner
---
PVE/QemuServer.pm | 7 ---
1 file changed, 7 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b7e6a8e..c0fca49 100644
--- a/PVE
ly of $smm.
The correct config is also needed to determine the correct size for
the EFI disk for the upcoming import-from feature.
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/PVE/API2/Qemu
vation and size update nearly always triggered,
because only the pending changes are passed in as $conf. The case
where it didn't trigger is when the same pending change was made twice
(there are cases where hotplug isn't done, but makes it even more
unlikely).
Signed-off-by: Fabian Ebner
-
to make the interface more digestible.
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 52 +++
PVE/QemuServer.pm | 9 ++--
2 files changed, 41 insertions(+), 20 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index c6587ef
Signed-off-by: Dominic Jäger
[split into its own patch + style fixes]
Signed-off-by: Fabian Ebner
---
PVE/QemuServer.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b246602..33f226e 100644
--- a/PVE/QemuServer.pm
Prepare for calling parse_ovf via API, where the -T switch is used.
Signed-off-by: Fabian Ebner
---
PVE/QemuServer/OVF.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm
index 0376cbf..b97b052 100644
--- a/PVE/QemuServer
In the spirit of c75bf16 ("qm importdisk: tell user to what VM disk we
actually imported"), and so that the information is not lost once qm
importdisk switches to re-using the API call.
Added for cloudinit too, because a new disk is allocated.
Signed-off-by: Fabian Ebner
---
Th
t too.
Signed-off-by: Fabian Ebner
---
New in v12.
PVE/API2/Qemu.pm | 8 ++--
PVE/QemuServer.pm | 4 ++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 14cac5b..9b8eb88 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -32
to its own patch + add to index]
Signed-off-by: Fabian Ebner
---
Needs dependency bump for qemu-server.
PVE/API2/Nodes.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 655493a3..f595808a 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.p
Co-developed-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
[split into its own patch + minor improvements/style fixes]
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu/Makefile | 2 +-
PVE/API2/Qemu/OVF.pm | 55 ++
PVE/QemuServer.pm | 32
and also when source and target drivename are different. In those
cases, it is done via qemu-img convert/dd.
In preparation to allow import from existing PVE-managed disks.
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 2 ++
PVE/QemuServer.pm | 29 +++--
2 files
Avoids the error
adding drive failed: Duplicate ID 'drive-scsi1' for drive
that could happen when switching over to a new disk (e.g. via qm set),
if unplugging wasn't fast enough.
Signed-off-by: Fabian Ebner
---
PVE/QemuServer.pm | 1 +
1 file changed, 1 insertion(+)
d
via the special syntax :.
Not worth it by itself, but this is anticipating a new 'import-from'
parameter which is only used upon import/allocation, but shouldn't be
part of the schema for the config or other API enpoints.
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu
For disk import, it should be based on the disk properties that are
passed in rather than on those of a possibly pre-existing disk in the
config.
Signed-off-by: Fabian Ebner
---
New in v12.
PVE/QemuServer.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/PVE
Necessary to import from an existing storage using block-device
volumes like ZFS.
Signed-off-by: Dominic Jäger
[split into its own patch]
Signed-off-by: Fabian Ebner
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
hat will be it's
own series.
Older discussion:
https://lists.proxmox.com/pipermail/pve-devel/2022-January/051379.html
qemu-server:
Dominic Jäger (1):
api: support VM disk import
Fabian Ebner (15):
device unplug: verify that unplugging scsi disk completed
api: create disks: always ac
Signed-off-by: Fabian Ebner
---
PVE/API2/Qemu.pm | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 3b86034..7c3bb91 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -63,6 +63,23 @@ my
From: Dominic Jäger
Extend qm importdisk functionality to the API.
Co-authored-by: Fabian Grünbichler
Co-authored-by: Dominic Jäger
Signed-off-by: Fabian Ebner
---
Changes from v11:
* Require relevant parameters to be set explicitly for EFI/TPM
disk import.
* Base calculation
Am 04.03.22 um 12:52 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer
> ---
Some rationale for the change would be nice to have in the commit
message. Is there a scenario where me.pveSelNode is not the correct node?
> www/manager6/window/BackupConfig.js | 2 +-
> 1 file changed, 1
Am 04.03.22 um 12:52 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer
> ---
> www/manager6/Utils.js | 20
> 1 file changed, 20 insertions(+)
>
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index aafe359a..6509 100644
> --- a/www/manager6/Uti
Am 04.03.22 um 12:52 schrieb Matthias Heiserer:
> Should be easier to read/use than the current flat list.
> Backups are grouped by ID and type, so in case there are backups
> with ID 100 for both CT and VM, this would create two separate
> groups in the UI.
It might make sense to include qemu/lxc
1 - 100 of 1506 matches
Mail list logo
