Signed-off-by: Dominic Jäger
---
www/manager6/storage/GlusterFsEdit.js | 1 +
www/manager6/storage/IScsiEdit.js | 1 +
www/manager6/storage/LvmThinEdit.js | 1 +
www/manager6/storage/NFSEdit.js | 1 +
www/manager6/storage/StatusView.js| 2 +-
5 files changed, 5 insertions(+), 1
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/FeaturesEdit.js | 2 +-
www/manager6/lxc/Resources.js | 2 +-
www/manager6/qemu/AgentIPView.js | 4 ++--
www/manager6/qemu/BootOrderEdit.js | 4 ++--
www/manager6/qemu/OSTypeEdit.js| 2 +-
www/manager6/qemu/RNGEdit.js | 2
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/CreateWizard.js | 1 -
www/manager6/lxc/DNS.js | 5 ++---
www/manager6/lxc/Options.js | 5 ++---
www/manager6/lxc/Resources.js| 2 +-
www/manager6/qemu/AgentIPView.js | 1 -
www/manager6/qemu/HDEdit.js
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/DNS.js| 2 +-
www/manager6/qemu/CloudInit.js | 2 +-
www/manager6/qemu/USBEdit.js | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/lxc/DNS.js b/www/manager6/lxc/DNS.js
index f277370c..6c519023 100644
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/MPEdit.js | 6 ++---
www/manager6/qemu/AgentIPView.js | 4 +--
www/manager6/qemu/CloudInit.js | 44
www/manager6/qemu/DisplayEdit.js | 4 +--
www/manager6/qemu/SSHKey.js | 4 +--
www/manager6/qemu
Reduce eslint problems in qemu/lxc/storage to 3 Errors and 2 Warnings.
Those are a little trickier, I'll fix them tomorrow.
I clicked through a couple of wizards to test, but not yet every single
possible window.
Dominic Jäger (6):
Fix usage of 'me'
No unused or dupl
Function syntax, raw words, string templates, no prototype builtins
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/MPResize.js | 5 -
www/manager6/qemu/HDResize.js | 4
www/manager6/qemu/OSDefaults.js | 2 +-
www/manager6/storage/Base.js | 2 +-
www/manager6/storage
Signed-off-by: Dominic Jäger
---
These 2 patches fix the remaining errors for manager6/qemu and manager6/storage
(manager6/lxc is already OK)
www/manager6/qemu/CmdMenu.js | 2 +-
www/manager6/qemu/PCIEdit.js | 7 +--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/www
Signed-off-by: Dominic Jäger
---
www/manager6/storage/PBSEdit.js | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index 2479304a..773d41e8 100644
--- a/www/manager6/storage/PBSEdit.js
+++ b/www
Signed-off-by: Dominic Jäger
---
www/manager6/panel/NotesView.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/panel/NotesView.js b/www/manager6/panel/NotesView.js
index 18dd8876..a40cb7d5 100644
--- a/www/manager6/panel/NotesView.js
+++ b/www/manager6
Signed-off-by: Dominic Jäger
---
www/manager6/panel/StatusPanel.js | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/www/manager6/panel/StatusPanel.js
b/www/manager6/panel/StatusPanel.js
index f7bb4a91..f9e3537b 100644
--- a/www/manager6/panel/StatusPanel.js
+++ b
Signed-off-by: Dominic Jäger
---
www/manager6/panel/RunningChart.js | 43 +++---
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/www/manager6/panel/RunningChart.js
b/www/manager6/panel/RunningChart.js
index ab4c9039..19db8b50 100644
--- a/www/manager6
Signed-off-by: Dominic Jäger
---
www/manager6/panel/IPSet.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 303e518a..94117789 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
Signed-off-by: Dominic Jäger
---
www/manager6/panel/ConfigPanel.js | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/www/manager6/panel/ConfigPanel.js
b/www/manager6/panel/ConfigPanel.js
index 23a6ee58..788615aa 100644
--- a/www/manager6/panel/ConfigPanel.js
Users are repeatedly left with entries in Disks->Directory, most recently
https://forum.proxmox.com/threads/how-to-remove-local-directory-storage-properly.89504/
Signed-off-by: Dominic Jäger
---
pve-storage-dir.adoc | 13 +
1 file changed, 13 insertions(+)
diff --git a/pve-stor
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
v9: Use Tabpanel instead of Advanced Checkbox for disk options
PVE/API2/Nodes.pm| 7 +
www/manager6/Makefile| 4 +
www
Extend qm importdisk/importovf functionality to the API.
Co-authored-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
---
v9: unchanged
PVE/API2/Qemu.pm | 175 +++--
PVE/API2/Qemu/Makefile | 2 +-
PVE/API2/Qemu/OVF.pm | 68
{
> + xtype: 'proxmoxcheckbox',
> + name: 'verify-certificates',
> + fieldLabel: gettext('Verify certificates'),
> + uncheckedValue: 0,
> +
-1.iso"; modification-date="Tue, 27 Apr 2021 15:25:15 +0200";
> size=928993280;
and it gets directly into the GUI like that.
It did work for a Debian image.
https://cdimage.debian.org/debian-cd/current/amd64/iso-dvd/debian-10.9.0-amd64-DVD-1.iso
Tested-by: Dominic Jäger
___
Enable adding multiple disks in VM create wizard.
This is a first step for future import features.
Split disk edit panel into multiple tabbed panels to make it less cluttered.
This affects the create wizard & the HD edit windows in the VM hardware view.
Signed-off-by: Dominic Jäger
---
On Fri, Jun 18, 2021 at 06:31:51PM +0200, Thomas Lamprecht wrote:
> On 21.05.21 12:44, Dominic Jäger wrote:
> > Users are repeatedly left with entries in Disks->Directory, most recently
> > https://forum.proxmox.com/threads/how-to-remove-local-directory-storage-properly.89504/
&
Signed-off-by: Dominic Jäger
Here two inputpanels
1. diskData with volid, storage...
2. diskBasicOptions with the checkboxes
are on the first tab. This required the least changes to get a working version
so that we can quickly get on the same page about what we want it to look like.
I can also
Like notes for nodes.
Signed-off-by: Dominic Jäger
---
Depends on the pve-cluster patch.
www/manager6/dc/Config.js | 6
www/manager6/panel/NotesView.js | 49 +
2 files changed, 32 insertions(+), 23 deletions(-)
diff --git a/www/manager6/dc/Config.js
Similar to notes for nodes.
datacenter.cfg normally uses key-value pairs defined in the schema.
We bypass this to allow potentially long comments at the top.
Signed-off-by: Dominic Jäger
---
data/PVE/DataCenterConfig.pm | 34 +-
1 file changed, 33 insertions
Permits controlling email notifications about package updates.
Use property string for extensibility to more notification types.
Signed-off-by: Dominic Jäger
---
v2: Use property string
data/PVE/DataCenterConfig.pm | 24
1 file changed, 24 insertions(+)
diff --git a
Users may want turn off update notifications.
Depends on pve-cluster patch.
Signed-off-by: Dominic Jäger
---
v2: Keep defaults. I hope that I understood the idea correctly.
bin/pveupdate | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/bin/pveupdate b/bin
When opened for the first time (undefined value in datacenter.cfg) we should
allow setting both options yes and no for the package_update checkbox.
Signed-off-by: Dominic Jäger
---
v2: new
www/manager6/dc/OptionView.js | 11 +++
1 file changed, 11 insertions(+)
diff --git a/www
Default value like pveupdate: Assume users with subscriptions want
notifications
Signed-off-by: Dominic Jäger
---
v2: default depends on subscription status
www/manager6/dc/OptionView.js | 37 +++
1 file changed, 37 insertions(+)
diff --git a/www/manager6/dc
We assume that users want update notifications for production systems.
Those systems should also have an active subscription.
Signed-off-by: Dominic Jäger
---
v2: new
PVE/API2/APT.pm | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2
Dots are allow in PVE VM names, so they should not be dropped during import.
Signed-off-by: Dominic Jäger
---
PVE/QemuServer/OVF.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm
index c76c199..0376cbf 100644
--- a/PVE
Signed-off-by: Dominic Jäger
---
src/window/Edit.js | 4
1 file changed, 4 insertions(+)
diff --git a/src/window/Edit.js b/src/window/Edit.js
index c165141..816d68f 100644
--- a/src/window/Edit.js
+++ b/src/window/Edit.js
@@ -134,6 +134,10 @@ Ext.define('Proxmox.window
This series makes importing disks possible via GUI which is one step to make
migrating from other hypervisors easier.
Dominic Jäger (1):
EditWindow: Change url to 'importdisk' for import
src/window/Edit.js | 4
1 file changed, 4 insertions(+)
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
www/manager6/qemu/HDEdit.js | 80 ++-
www/manager6/qemu/HardwareView.js | 18 +++
2 files changed, 76 insertions(+), 22 deletions(-)
diff --git a
Additionally, add parameters that enable directly (avoiding the intermediate
step as unused disk) attaching the disk to a bus/device with all known disk
options.
Required to create a GUI for importdisk.
Signed-off-by: Dominic Jäger
---
PVE/API2/Qemu.pm | 113
The output of "pvecm delnode someNode" is "Killing node X". Even though this
only says something about an attempt and not about success, it is not "no
output is returned".
Signed-off-by: Dominic Jäger
---
pvecm.adoc | 6 +++---
1 file changed, 3 insertions(+)
/etc/corosync/* includes the directory uidgid.d.
Consequentlly, a correct rm call requires -r.
Signed-off-by: Dominic Jäger
---
pvecm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index 4bf2f59..9207571 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
On Wed, Jul 22, 2020 at 12:31:53PM +0200, Thomas Lamprecht wrote:
> On 22.07.20 12:20, Dominic Jäger wrote:
> > /etc/corosync/* includes the directory uidgid.d.
> > Consequentlly, a correct rm call requires -r.
>
> Does leaving this directory left-over causes any issues?
When
firewall for that level is not.
Signed-off-by: Dominic Jäger
---
v2->v3:
- rebased
- squashed both commits to make review easier
- one whitespace error
www/manager6/grid/FirewallRules.js | 43 --
1 file changed, 41 insertions(+), 2 deletions(-)
diff --gi
We mention Debian as external server before. On Debian it is easily possible
that SSH root login via password is prohibited.
Signed-off-by: Dominic Jäger
---
pvecm.adoc | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index 390fb4b..47916fa
Third person plural does not require -s form.
Signed-off-by: Dominic Jäger
---
pvecm.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index 4bf2f59..e7b36c5 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -952,7 +952,7 @@ QDevice-Net Setup
Comma after sequence words like first, next, then, or last.
Signed-off-by: Dominic Jäger
---
pvecm.adoc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index e7b36c5..390fb4b 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -397,7 +397,7 @@ node from
I overlooked the different package names myself. Writing out the two commands
makes this more difficult to overlook.
Signed-off-by: Dominic Jäger
---
pvecm.adoc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/pvecm.adoc b/pvecm.adoc
index 47916fa..cf5f052
Signed-off-by: Dominic Jäger
---
v1->v2: unchanged
src/window/Edit.js | 4
1 file changed, 4 insertions(+)
diff --git a/src/window/Edit.js b/src/window/Edit.js
index d7972b6..2dfab19 100644
--- a/src/window/Edit.js
+++ b/src/window/Edit.js
@@ -134,6 +134,10 @@ Ext.def
This series makes importing disks possible via GUI which is one step to make
migrating from other hypervisors easier.
Dominic Jäger (1):
EditWindow: Change url to 'importdisk' for import
Dominic Jäger (1):
Hardware View: Add GUI for importdisk
Dominic Jäger (1):
Move importdisk
Additionally, add parameters that enable directly (avoiding the intermediate
step as unused disk) attaching the disk to a bus/device with all known disk
options.
Required to create a GUI for importdisk.
Signed-off-by: Dominic Jäger
---
v1->v2:
- dot for multi-line string at end of line
-
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
v1->v2:
- Newlines for better blocks
- Use gettext
- Use subject instead of title
www/manager6/qemu/HDEdit.js | 83 +++
www/manager6/q
Thank you for taking a look!
> > + if (me.isImport) {
> > + // These keys & values are accepted by the API as they are
> > + let simple = ['backup', 'ssd', 'iothread', 'cache'];
> > + let burst = ['mbps_rd', 'mbps_wr', 'iops_rd', 'iops_wr'];
> > + burst = burst.concat(bur
On Wed, Jul 29, 2020 at 03:00:41PM +0200, Aaron Lauterer wrote:
> Some small nits inline, mainly regarding the wording of descriptions and
> messages.
>
> One thing I noticed is with multi line strings.
> The concat `.` should probably be at the end of the previous line if you
> split it up
I i
Dashes --- put the "Install PVE on Debian Buster" link into a code segment on
pve.proxmox.com/wiki/Installation.
Additionally, the both links are not ZFS performance tips => Move them further
below.
Signed-off-by: Dominic Jäger
---
This is still untested because I am struggling a
On Thu, Aug 20, 2020 at 05:36:52PM +0200, Thomas Lamprecht wrote:
> On 30.07.20 12:18, Dominic Jäger wrote:
> > --- a/src/window/Edit.js
> > +++ b/src/window/Edit.js
> > @@ -134,6 +134,10 @@ Ext.define('Proxmox.window.Edit', {
> > + if (me.isImport) {
Signed-off-by: Dominic Jäger
---
v2->v3:
- Use a more general approach in the shared code base instead of coding
specifically for importdisk
src/window/Edit.js | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/window/Edit.js b/src/window/Edit.js
in
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
v2->v3: Use the new submitUrl parameter from widget-tookit
Depends on both other patches
www/manager6/qemu/HDEdit.js | 83 +++
www/manager6/q
This series makes importing disks possible via GUI which is one step to make
migrating from other hypervisors easier.
proxmox-widget-toolkit: Dominic Jäger (1):
Proxmox.window.Edit: Introduce separate submitUrl
qemu-server: Dominic Jäger (1):
Move importdisk from qm to API
pve-manager
Additionally, add parameters that enable directly (avoiding the intermediate
step as unused disk) attaching the disk to a bus/device with all known disk
options.
Required to create a GUI for importdisk.
Signed-off-by: Dominic Jäger
---
v2->v3: unchanged
PVE/API2/Qemu.pm |
ermail/pve-devel/2020-August/044807.html
On Mon, Aug 24, 2020 at 10:42:02AM +0200, Dominic Jäger wrote:
> On Thu, Aug 20, 2020 at 05:36:52PM +0200, Thomas Lamprecht wrote:
> > On 30.07.20 12:18, Dominic Jäger wrote:
> > > --- a/src/window/Edit.js
> > > +++ b/src/w
The only place where I have found a description about what "full status" (in
contrast to default) means has been the git log and I don't think the average
user looks there.
Signed-off-by: Dominic Jäger
---
PVE/API2/Qemu.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-
Not 100% sure if I currently have the right eslint version
On Tue, Aug 25, 2020 at 05:14:25PM +0200, Aaron Lauterer wrote:
> +getNodeVMs: function(nodename) {
> + let rstore = PVE.data.ResourceStore;
> + let vms = {}
WARN: line 1573 col 14: semi - Missing semicolon. (*)
> + rstore.
Somehow my eslint complains about undefined variables?
Maybe the "const" from the example [0] is required?
On Tue, Aug 25, 2020 at 05:14:26PM +0200, Aaron Lauterer wrote:
> + let dropdownData = [];
> + for ([vmid, data] of Object.entries(vms)) {
> + if (vmid === me.vmid
I reassigned some disks and it seemed to work nice for me :)
Error messages about unavailable disks for running VMs and equal source and
target VM made sense to me, correct possible targets were displayed, multiple
storages worked.
One thing that came to my mind: It might make sense to display wha
This series makes importing disks possible via GUI which is one step to make
migrating from other hypervisors easier.
qemu-server: Dominic Jäger (1):
Move importdisk from qm to API
pve-manager: Dominic Jäger (1):
Hardware View: Add GUI for importdisk
--
2.20.1
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
v3->v4:
* Reuse propertyStringSet instead of building it myself
* More detailed permissions
* Reorder GUI elements such that source is first
* Assemble importdisk URL here instead
ned-off-by: Dominic Jäger
---
v3->v4:
* More detailed permissions
* Solve race conditions and code reuse questions by completely moving do_import
to PVE/API2/Qemu.pm; lock the whole procedure
* As I found both discussed approaches
- Image selector (Thomas)
- Paths (Dominik)
useful I inc
If you only want to take a quick lock, I put a screenshot in Bugzilla
https://bugzilla.proxmox.com/show_bug.cgi?id=2886#c2
On Tue, Sep 15, 2020 at 01:33:24PM +0200, Dominic Jäger wrote:
> Make importing single disks easier.
> Required to import a whole VM via GUI.
>
> Signed-off
Signed-off-by: Dominic Jäger
---
PVE/VZDump.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 6e0d3dbf..aea7389b 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -522,7 +522,7 @@ sub getlock {
my $maxwait = $self->{opts}->{lo
As explained by Dominik and Fabian [0].
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=2827
Signed-off-by: Dominic Jäger
---
pveum.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/pveum.adoc b/pveum.adoc
index 4fbaa86..57e1b37 100644
--- a/pveum.adoc
+++ b/pveum.adoc
@@ -163,6
Because the option is too important to be hidden in CLI.
Signed-off-by: Dominic Jäger
---
I haven't managed to test this against an LDAP server yet, but the GUI elements
go on and off as I had it in mind and the options in /etc/pve/domains.cfg
change as expected.
www/manage
We allow snapshot names that match pve-configid but during qm destroy we have
not removed all snapshots that match pve-configid so far. For example, the name
x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not removed.
Reported-by: Hannes Laimer
Signed-off-by: Dominic Jäger
Like for LDAP, the option is too important to be hidden in CLI.
Signed-off-by: Dominic Jäger
---
The verify parameter seems to be implemented in the LDAP code [0] as well
as in the AD code [1]
[0]
https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=PVE/Auth/LDAP.pm;h
Signed-off-by: Dominic Jäger
---
v1->v2: Didn't exist
src/PVE/JSONSchema.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index e8d7395..29ada5b 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -21
Signed-off-by: Dominic Jäger
---
v1->v2: Didn't exist
test/Makefile | 2 +-
test/format_test.pl | 27 +++
2 files changed, 28 insertions(+), 1 deletion(-)
create mode 100755 test/format_test.pl
diff --git a/test/Makefile b/test/Makefile
index b8118c7.
We allow snapshot names that match pve-configid but during qm destroy we have
not removed all snapshots that match pve-configid so far. For example, the name
x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not removed.
Reported-by: Hannes Laimer
Signed-off-by: Dominic Jäger
Split into less and more disputable parts. Feel free to squash.
Dominic Jäger (4):
de: Add missing and outdated translation
de: Add translation for "Task"
de: Add translation for "Service"
de: Add translation for "tra
Signed-off-by: Dominic Jäger
---
de.po | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/de.po b/de.po
index fffa3cc..7d14761 100644
--- a/de.po
+++ b/de.po
@@ -5195,7 +5195,7 @@ msgstr ""
#: proxmox-backup/www/ServerStatus.js:158
msgid "Root Disk Trans
Signed-off-by: Dominic Jäger
---
de.po | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/de.po b/de.po
index 9df3cd4..e3f7e6e 100644
--- a/de.po
+++ b/de.po
@@ -3256,9 +3256,8 @@ msgstr "Logs"
#: proxmox-backup/www/Dashboard.js:316
#: prox
Signed-off-by: Dominic Jäger
---
de.po | 91 +--
1 file changed, 45 insertions(+), 46 deletions(-)
diff --git a/de.po b/de.po
index a9a65df..9df3cd4 100644
--- a/de.po
+++ b/de.po
@@ -267,7 +267,7 @@ msgstr "Alle Funktionen"
Signed-off-by: Dominic Jäger
---
de.po | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/de.po b/de.po
index e3f7e6e..fffa3cc 100644
--- a/de.po
+++ b/de.po
@@ -3990,7 +3990,7 @@ msgstr "Keine laufenden Aufgaben"
#: pve-manager/www/manager6/ceph/Service
this only works with
monospaced fonts.
Signed-off-by: Dominic Jäger
---
Unfortunately, I had no idea for non-monospaced fonts yet.
PVE/VZDump.pm | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 517becb1..1096d594 100644
--- a/PVE
Less lines, less nesting, less duplicate code, less magic numbers.
Signed-off-by: Dominic Jäger
---
Depends on the previous patch for #3136.
Admittedly, using a sub and ternary operator might be seen as more complex than
just the if-statements. So I'm not mad if we leave it as it is
On Mon, Nov 16, 2020 at 06:12:37PM +0100, Thomas Lamprecht wrote:
>
> Or move out even more than just the format string generation out, so that it
> becomes a simple loop calling
>
> $text .= render_task_plain($vmid, $task);
>
> or something similar to that.
my $namelength = 20;
$text .= sprint
Less lines exeeding the character limit, less nesting, less duplicate code,
more readable sprintf arguments.
Co-authored-by: Thomas Lamprecht
Signed-off-by: Dominic Jäger
---
Middle ground sounds good to me :) And separate lines for arguments look nice.
PVE/VZDump.pm | 36
---
www/manager6/Workspace.js| 15 +++
www/manager6/node/CmdMenu.js | 12
2 files changed, 27 insertions(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 3d0f3fec..6ee7c957 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.
e a VM
- that actually starts
- has all the disks automatically attached, converted etc.
- has hostname, cores, RAM like in the .ovf
so that's something, I think.
Dominic Jäger (1):
Move importdisk from qm to API
PVE/API2/Qemu.pm | 209 ++-
PVE/
ned-off-by: Dominic Jäger
---
This already had some versions. Fabian G already left some feedback (e.g.
permissions)
for the last one the mailing list which I haven't been able to address yet.
PVE/API2/Qemu.pm | 209 ++-
PVE/API2/Qemu/Impor
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
www/manager6/qemu/HDEdit.js | 134 ++
www/manager6/qemu/HardwareView.js | 24 ++
2 files changed, 141 insertions(+), 17 deletions(-)
diff --git a
Signed-off-by: Dominic Jäger
---
Somehow selecting storages is not possible anymore. It was at some point.
You can add disks that are not in the OVF in the importwizard at the moment.
PVE/API2/Nodes.pm | 48 +++
www/manager6/Makefile | 2 +
www
e first half is controller and the integer is
deviceid
And for me it would make sense to minimize those differences.
Tested-by: Dominic Jäger
On Fri, Oct 30, 2020 at 11:42:23AM +0100, Aaron Lauterer wrote:
> Does anyone have time to take a look at the latest iteration of these patches?
>
This is actually broken, sorry. I'm just fixing it. But clicking through the
wizard should work.
On Thu, Nov 19, 2020 at 10:46:18AM +0100, Dominic Jäger wrote:
> Make importing single disks easier.
> Required to import a whole VM via GUI.
>
> Signed-off-by: Dominic Jäger
>
As we've dropped the idea of using a single tab for each disk
---
v2: Added
www/manager6/qemu/ImportWizard.js | 42 +--
www/manager6/qemu/MultiHDEdit.js | 27 ++--
www/manager6/window/Wizard.js | 14 ---
3 files changed, 26 insertions(+),
ned-off-by: Dominic Jäger
---
v2: unchanged
This already had some versions. Fabian G already left some feedback (e.g.
permissions) for the last one the mailing list which I haven't been able to
address yet.
PVE/API2/Qemu.pm | 209 ++-
PVE/API2
Signed-off-by: Dominic Jäger
---
v2: This patch is unchanged, but the lines are changed by patch 6. I'll rebase
that soon.
PVE/API2/Nodes.pm | 48 +++
www/manager6/Makefile | 2 +
www/manager6/form/ControllerSelector.js | 26 +-
www/manager6
---
v2: unchanged
www/manager6/Workspace.js| 15 +++
www/manager6/node/CmdMenu.js | 12
2 files changed, 27 insertions(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 3d0f3fec..6ee7c957 100644
--- a/www/manager6/Workspace.js
+++ b/www/mana
And fix parameters for the API
Signed-off-by: Dominic Jäger
---
v2: Added
www/manager6/qemu/HDEdit.js | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index f8e811e1..0c5603ab 100644
--- a/www/manager6/qemu
and will have a VM
- that actually starts
- has all the disks automatically attached, converted etc.
- has hostname, cores, RAM like in the .ovf
so that's something, I think.
qemu-server:
Dominic Jäger (1):
Move importdisk from qm to
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
v2: This patch is unchanged, but the lines are changed by some subsequent
patches. I'll rebase that soon.
www/manager6/qemu/HDEdit.js | 134 ++
Fixes the issue for me.
Tested-by: Dominic Jäger
On Mon, Nov 23, 2020 at 11:12:29AM +0100, Stoiko Ivanov wrote:
> fix #3161
>
> When considering mountpoints for running 'fsfreeze' before snapshot creation,
> commit 8463099d99273561c46398bf02206b4d9d431bc5 did not o
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).
Signed-off-by: Dominic Jäger
---
www/manager6/storage/Base.js | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a
... instead of generic PVE admin guide.
Signed-off-by: Dominic Jäger
---
www/manager6/dc/Config.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 2fdba743..92b94afc 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc
on edit" is now
clearly visible even without comment.
Signed-off-by: Dominic Jäger
---
www/manager6/storage/Base.js | 34 --
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 80b
ionary/unusable
[1] https://www.merriam-webster.com/dictionary/loose
[2] https://www.merriam-webster.com/dictionary/lose
Signed-off-by: Dominic Jäger
---
www/manager6/storage/PBSEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6
... if the user hasn't seen the prune panel yet.
The GUI has as default value a ticked keep-all checkbox => keep-all=1.
Previously we sent nothing in this case which led to the no-keeps default of
keep-last=1.
Signed-off-by: Dominic Jäger
---
v2: Move the keep-all=1 default up
@Thomas
1 - 100 of 152 matches
Mail list logo
