Re: [pve-devel] [PATCH qemu-server] fix #3324: clone disk: use larger blocksize for EFI disk when possible

2021-03-01 Thread Dietmar Maurer
> >>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > >>> index f401baf..e579cdf 100644 > >>> --- a/PVE/QemuServer.pm > >>> +++ b/PVE/QemuServer.pm > >>> @@ -6991,7 +6991,15 @@ sub clone_disk { > >>>   # that is given by the OVMF_VARS.fd > >>>   my $src_path = PVE::Storage::pa

Re: [pve-devel] [PATCH storage] fix #3203: report smart status correctly

2021-03-01 Thread Dietmar Maurer
This code is quite strange. Please can you use a normal: if .. then .. else .. > +push @$cmd, '-H' if $healthonly; > +push @$cmd, '-a', '-A', '-f', 'brief' if !$healthonly; ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

Re: [pve-devel] [pbs-devel] [PATCH v2 proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader

2021-03-17 Thread Dietmar Maurer
What about using a memory mapped files as cache. That way, you do not need to care about available memory? > >> Maybe we could get the available memory and use that as hint, I mean as > >> memory > >> usage can be highly dynamic it will never be perfect, but better than just > >> ignoring > >> i

Re: [pve-devel] [PATCH manager 2/2] Close #1295: Make apt notifications configurable

2021-04-08 Thread Dietmar Maurer
> Is there a reason why we assume that users without subscription do not want > such notifications? > > As far as I see it, if we change it to > > $dccfg->{notify_updates} // 1 > Then (until they change something) > - users with active subscription should _continue_ to get notifications > - enterp

Re: [pve-devel] [PATCH v2 pve-access-control] fix #1500: permission path syntax check for access control

2021-04-19 Thread Dietmar Maurer
FYI, I do it without any regex in rust: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=src/config/acl.rs;h=61e507ec42bf5a30f64f56564a1fb107d148fb7b;hb=HEAD#l272 I guess this is faster (at least in rust). > On 04/19/2021 9:16 AM Lorenz Stechauner wrote: > > > Syntax for permission pa

Re: [pve-devel] Proposal: support for atomic snapshot of all VM disks at once

2024-10-04 Thread Dietmar Maurer
> I am the maintainer of StorPool’s external storage plugin for PVE[0] > which integrates our storage solution as a backend for VM disks. Our > software has the ability to create atomic (crash-consistent) snapshots > of a group of storage volumes. We already make sure that shaphots of a group

Re: [pve-devel] [PATCH manager 1/2] close #4369: api: optionally only suggest unique IDs

2024-09-30 Thread Dietmar Maurer
> This approach would also use more storage as you now have the overhead > of FS metadata for every single ID you have marked as used. > > Dietmar, what do you think is the best option here? I'm personally > leaning towards using the list with your run-length encoding suggestion, > but I'm open to

Re: [pve-devel] [RFC PATCH pve-cluster] fix #5728: pmxcfs: allow bigger writes than 4k for fuse

2024-09-22 Thread Dietmar Maurer
> > [...] > > so a factor of 32 less calls to cfs_fuse_write (including memdb_pwrite) > > That can be huge or not so big at all, i.e. as mentioned above, it would we > good to > measure the impact through some other metrics. > > And FWIW, I used bpftrace to count [0] with an unpatched pmxcfs, t

Re: [pve-devel] [PATCH manager 1/2] close #4369: api: optionally only suggest unique IDs

2024-09-26 Thread Dietmar Maurer
The format of the used_vmids.list is simply, but can lead to a very large file over time (we want to avoid large files on /etc/pev/). >PVE::Cluster::cfs_write_file('used_vmids.list', join("\n", @$vmid_list)); A future version could compress that list, by using integer ranges, for example: --

Re: [pve-devel] [PATCH common] tools: file_set_contents: use syswrite instead of print

2024-09-25 Thread Dietmar Maurer
Please can you add the column showing write amplification using dd instead of file_set_contents, so that we can also see the minimal write amplf. from sqlite. > The table below illustrates the drastic reduction in write > amplification when writing files of different sizes to `/etc/pve/` using >

Re: [pve-devel] [PATCH qemu/qemu-server/docs 00/19] adapt to changes in QEMU machine version deprecation/removal

2025-01-03 Thread Dietmar Maurer
19 patches for this seems to be too much. Maybe we can try to cleanup the qemu code for those checks and send those patches upstream (In order to make this series shorter)? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.c

Re: [pve-devel] [PATCH qemu/qemu-server/docs 00/19] adapt to changes in QEMU machine version deprecation/removal

2025-01-04 Thread Dietmar Maurer
Sorry, please ignore me. I now see that most patches are for qemu-server (not qemu) ... > On 4.1.2025 08:58 CET Dietmar Maurer wrote: > > > 19 patches for this seems to be too much. Maybe we can try to cleanup the > qemu code for those checks and send those patches upstre

Re: [pve-devel] Strategy for Active Directory and OpenID Connect groups and usernames with spaces and other special characters

2025-03-09 Thread Dietmar Maurer
> 1. Do we want to allow spaces in groups and/or usernames, or should we > prefer replacement characters (e.g. mapping space(s) to _ or some other > character)? My feeling is that we need to allow all characters - else this will be an endless issue ... > 2. In case we want to allow spaces in

<    1   2