Re: [pve-devel] Discussion of major PBS restore speedup in proxmox-backup-qemu

2025-06-24 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi Alexandre, yes, having configurable CONCURRENT_REQUESTS and max_blocking_threads would be great. However we would need to wire it up all the way to qmrestore or similar or ensure it is read from some env vars. I didn't feel confident to introduce this kind of infrastructur

[pve-devel] Discussion of major PBS restore speedup in proxmox-backup-qemu

2025-06-23 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi list, before I go through all the hoops to submit a patch I wanted to discuss the current form of the patch that can be found here: https://github.com/NOT-NULL-Makers/proxmox-backup-qemu/commit/e91f09cfd1654010d6205d8330d9cca71358e030 The speedup process was discussed he

Re: [pve-devel] applied: [PATCH proxmox-backup-qemu 1/1] restore: make chunk loading more parallel

2025-07-16 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi Thomas, would you please consider applying it also to the bookworm branch? Thank you Adam On Tue, 2025-07-15 at 21:18 +0200, Thomas Lamprecht wrote: > On Mon, 14 Jul 2025 10:34:38 +0200, Dominik Csapak wrote: > > by using async futures to load chunks and stream::buffer_u

Re: [pve-devel] [RFC PATCH proxmox-backup-qemu] restore: make chunk loading more parallel

2025-07-07 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi Dominik, seems like a more elegant solution. In my testing on the Ryzen system: progress 100% (read 53624176640 bytes, zeroes = 5% (2776629248 bytes), duration 52 sec) progress 96% (read 53628370944 bytes, zeroes = 5% (2776629248 bytes), duration 52 sec) progress 97% (r

Re: [pve-devel] [RFC PATCH v2 proxmox-backup-qemu] restore: make chunk loading more parallel

2025-07-08 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi Dominik, this is a big improvement, I have done some performance measurements again: Ryzen: 4 worker threads: restore image complete (bytes=53687091200, duration=52.06s, speed=983.47MB/s) 8 worker threads: restore image complete (bytes=53687091200, duration=50.12s, speed=

Re: [pve-devel] [RFC PATCH v2 proxmox-backup-qemu] restore: make chunk loading more parallel

2025-07-09 Thread Adam Kalisz via pve-devel
--- Begin Message --- On Tue, 2025-07-08 at 12:58 +0200, Dominik Csapak wrote: > On 7/8/25 12:04, Adam Kalisz wrote: > > Hi Dominik, > > > > Hi, > > > this is a big improvement, I have done some performance > > measurements > > again: > > > > Ryzen: > > 4 worker threads: > > restore image compl

Re: [pve-devel] [PATCH proxmox-backup-qemu 1/1] restore: make chunk loading more parallel

2025-07-14 Thread Adam Kalisz via pve-devel
--- Begin Message --- Looks good to me. On the Ryzen setup with 10G network between PVE and PBS, NVMe storage and default settings (50G image with 95% random): default (4 threads, 16 futures): 995 MB/s 8 threads, 16 futures: 1023 MB/s 8 threads, 32 futures: 989 MB/s This link has a lower latency

Re: [pve-devel] Discussion of major PBS restore speedup in proxmox-backup-qemu

2025-07-03 Thread Adam Kalisz via pve-devel
s://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright I have cleared the CLA with the Proxmox office last week. > Fabian Adam > > On Tue, 2025-06-24 at 09:28 +0200, Fabian Grünbichler wrote: > > > > > > > Adam Kalisz via pve-devel hat am &

Re: [pve-devel] Discussion of major PBS restore speedup in proxmox-backup-qemu

2025-07-03 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi, On Thu, 2025-07-03 at 10:57 +0200, Dominik Csapak wrote: > Hi, > > On 7/3/25 10:29, Adam Kalisz via pve-devel wrote: > > Hi, > > > > On Friday I have submitted the patch with a slight edit to allow > > setting the number of thr

[pve-devel] [PATCH PBS restore 1/1] Speedup PBS restore with concurrent fetching of chunks

2025-06-27 Thread Adam Kalisz via pve-devel
--- Begin Message --- Speedup PBS restore by fetching chunks concurrently using a configurable number of threads. 4 threads are used by default, the environment variable PBS_RESTORE_CONCURRENCY should be between 1 and 32 inclusive. The upper limit is max_blocking_threads in BackupClient. Signed-of

Re: [pve-devel] [PATCH PBS restore 1/1] Sorry about the first submission with the "cover letter"

2025-06-27 Thread Adam Kalisz via pve-devel
--- Begin Message --- On Fri, 2025-06-27 at 21:24 +0200, Adam Kalisz wrote: > Co-authored-by: Daniel Škarda > Tested-by: Matt Neuforth > Financed-by: Václav Svátek > --- >  src/restore.rs | 101 --- > -- >  1 file changed, 84 insertions(+), 17 deletions

[pve-devel] [PATCH PBS restore 1/1] Make retrieval of chunks concurrent when restoring backup, add more statistics on chunk fetching and writing to storage. Allow configuring the number of threads fet

2025-06-27 Thread Adam Kalisz via pve-devel
--- Begin Message --- Co-authored-by: Daniel Škarda Tested-by: Matt Neuforth Financed-by: Václav Svátek --- src/restore.rs | 101 - 1 file changed, 84 insertions(+), 17 deletions(-) diff --git a/src/restore.rs b/src/restore.rs index 5a5a398..c75b

[pve-devel] [PATCH PBS restore 0/1] Speedup PBS restore with concurrent

2025-06-27 Thread Adam Kalisz via pve-devel
--- Begin Message --- Speedup PBS restore by fetching chunks concurrently using a configurable number of threads. 4 threads are used by default, the environment variable PBS_RESTORE_CONCURRENCY should be between 1 and 32 inclusive. The upper limit is max_blocking_threads in BackupClient. Adam Kali

Re: [pve-devel] [pbs-devel] Chunk verification speedup discussion, similar speedup opportunities elsewhere

2025-07-28 Thread Adam Kalisz via pve-devel
--- Begin Message --- On Fri, 2025-07-25 at 14:46 +0200, Fabian Grünbichler wrote: > On July 25, 2025 1:23 pm, Adam Kalisz wrote: > > Hi list, > > > > I missed whether the chunk verification speedup when loading chunks > > got > > applied or whether it was somehow included in the S3-like storage >

[pve-devel] Chunk verification speedup discussion, similar speedup opportunities elsewhere

2025-07-25 Thread Adam Kalisz via pve-devel
--- Begin Message --- Hi list, I missed whether the chunk verification speedup when loading chunks got applied or whether it was somehow included in the S3-like storage option change set. In https://forum.proxmox.com/threads/abysmally-slow-restore-from-backup.133602/page-7 we have discussed some