[pve-devel] [PATCH 04/12] common: make InstallZfsOption public

2023-10-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index a4947f1..a55f059 100644 --- a/proxmox-installer-common/src/setup.rs

[pve-devel] [PATCH 06/12] tui-installer: add dependency for new common crate

2023-10-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-tui-installer/Cargo.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml index 8a6eba8..fc653f0 100644 --- a/proxmox-tui-installer/Cargo.toml +++ b/proxmox-tui-installer/Cargo.toml

[pve-devel] [PATCH 12/12] tui: remove unused read_json function

2023-10-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-tui-installer/src/setup.rs | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/proxmox-tui-installer/src/setup.rs b/proxmox-tui-installer/src/setup.rs index 211a96b..efcabed 100644 --- a/proxmox-tui-installer/src/setup.rs

[pve-devel] [PATCH 09/12] common: add installer_setup method

2023-10-25 Thread Aaron Lauterer
moved over from the TUI installer Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 37 +++ 1 file changed, 37 insertions(+) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index a55f059..34b00cb 100644

[pve-devel] [PATCH 08/12] tui: remove now unused utils.rs

2023-10-25 Thread Aaron Lauterer
all it did moved to the common crate Signed-off-by: Aaron Lauterer --- proxmox-tui-installer/src/utils.rs | 268 - 1 file changed, 268 deletions(-) delete mode 100644 proxmox-tui-installer/src/utils.rs diff --git a/proxmox-tui-installer/src/utils.rs b/proxmox-tui

[pve-devel] [PATCH 03/12] common: utils: add dependency for doc test

2023-10-25 Thread Aaron Lauterer
Was probably missed because it used to be in a binary crate where doc tests aren't run automatically. Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/utils.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-installer-common/src/utils.rs b/proxmox-installer-commo

[pve-devel] [PATCH 01/12] add proxmox-installer-common crate

2023-10-25 Thread Aaron Lauterer
It will be used for code shared among the different crates in the installer. For now between the TUI installer and the upcoming auto installer. Signed-off-by: Aaron Lauterer --- Cargo.toml | 1 + proxmox-installer-common/Cargo.toml | 10 ++ proxmox-installer

[pve-devel] [PATCH 10/12] common: document installer_setup method

2023-10-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index 34b00cb..3ef05ae 100644 --- a/proxmox-installer-common/src/setup.rs +++ b/proxmox

[pve-devel] [PATCH 00/12] installer: add crate for common code

2023-10-25 Thread Aaron Lauterer
the crate where the struct lives IIUC. This series depends on the patches by Christoph to remove the global unsafe setup info, version 2 [0]. Without those patches applied first, this series will not apply. [0] https://lists.proxmox.com/pipermail/pve-devel/2023-October/059628.html Aaron Lauterer (

[pve-devel] [PATCH 11/12] tui: use installer_setup from common cate

2023-10-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-tui-installer/src/main.rs | 40 +-- 1 file changed, 1 insertion(+), 39 deletions(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 875a33a..3216868 100644 --- a/proxmox-tui-installer

[pve-devel] [PATCH 05/12] common: disk_checks: make functions public

2023-10-25 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/disk_checks.rs | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/proxmox-installer-common/src/disk_checks.rs b/proxmox-installer-common/src/disk_checks.rs index 15b5928..bcf2e21 100644 --- a/proxmox

[pve-devel] [PATCH 02/12] common: copy common code from tui-installer

2023-10-25 Thread Aaron Lauterer
Copy code that is common to its own crate. Signed-off-by: Aaron Lauterer --- proxmox-installer-common/Cargo.toml | 2 + proxmox-installer-common/src/disk_checks.rs | 237 proxmox-installer-common/src/lib.rs | 4 + proxmox-installer-common/src/options.rs

[pve-devel] [PATCH 07/12] tui: switch to common crate

2023-10-25 Thread Aaron Lauterer
by switching dependencies and deleting doubled code to avoid ambiguities within the same scope. Signed-off-by: Aaron Lauterer --- proxmox-tui-installer/src/main.rs | 13 +- proxmox-tui-installer/src/options.rs| 403 +--- proxmox-tui-installer/src/setup.rs

Re: [pve-devel] [PATCH 00/12] installer: add crate for common code

2023-10-30 Thread Aaron Lauterer
st for a single, trivial line. LGTM; thus please consider the whole series: Reviewed-by: Christoph Heiss Tested-by: Christoph Heiss On Wed, Oct 25, 2023 at 05:59:59PM +0200, Aaron Lauterer wrote: since work on the auto installer is happenning in parallel, now would be a good point to move commonly

[pve-devel] [PATCH manager 3/3] pvereport: add sdn config directory

2023-10-31 Thread Aaron Lauterer
the /etc/pve/sdn directory contains the config files, not just what they translate to in interface configs (/etc/network/interfaces.d/snd). The current way will also include dotifiles that may contain the current/running state. Which can be useful to troubleshoot. Signed-off-by: Aaron Lauterer

[pve-devel] [PATCH manager] api: osd: destroy: remove mclock max iops settings

2023-11-08 Thread Aaron Lauterer
and ends up getting the same OSD ID. Therefore, we remove these settings ourselves when destroying an OSD. Removing both variants, hdd and ssd should be fine, as the MON does not complain if the setting does not exist. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/OSD.pm | 4 1 file

[pve-devel] [PATCH docs 1/3] pvecm: fix qnetd typo

2023-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pvecm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvecm.adoc b/pvecm.adoc index d595ac5..1f78585 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -1090,7 +1090,7 @@ The status output of the QDevice, as seen above, will usually contain

[pve-devel] [PATCH docs 2/3] pveceph: fix typo

2023-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index 361e7c7..56d745a 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -134,7 +134,7 @@ That means that you should avoid maxing out your available

[pve-devel] [PATCH docs 3/3] pvecm: expand on public/cluster networks

2023-11-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pveceph.adoc | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 56d745a..0720941 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -241,22 +241,26 @@ The configuration step includes the

[pve-devel] [PATCH manager] pveceph: install: set default to reef

2023-11-23 Thread Aaron Lauterer
to align it with the default in the web UI Signed-off-by: Aaron Lauterer --- PVE/CLI/pveceph.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm index 5f45610b..68b93b89 100755 --- a/PVE/CLI/pveceph.pm +++ b/PVE/CLI/pveceph.pm @@ -115,7

Re: [pve-devel] [PATCH manager] ui: ceph installer: Run ceph/init if joining a cluster

2023-12-19 Thread Aaron Lauterer
The commit message doesn't explain the actual issue that it is trying to solve. AFAICT we do not need the ceph.conf symlinked right away for normal PVE operations. If it is not present in /etc/ceph/ceph.conf, the RBD and CephFS connections will use the dedicated parameters to connect and authent

[pve-devel] [PATCH docs] qm-cloud-init: make install inside VM more obvious

2023-12-29 Thread Aaron Lauterer
by making that part bold. While there is already a big note where cloudinit needs to be installed, it is after the actual command. Making it more obvious right before the command will hopefully reduce confusion for more users. Signed-off-by: Aaron Lauterer --- I am aware that we will never get

Re: [pve-devel] [PATCH manager] api: osd: destroy: remove mclock max iops settings

2024-01-03 Thread Aaron Lauterer
ping? On 11/8/23 13:10, Aaron Lauterer wrote: When destroying the OSD, Ceph does not automatically remove these ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs] local-zfs: use correct man page for vdev infos

2024-01-05 Thread Aaron Lauterer
ZFS did split up their man pages a while ago Signed-off-by: Aaron Lauterer --- local-zfs.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index 63de884..58726a7 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -157,7 +157,7 @@ ZFS RAID

[pve-devel] [PATCH v1 installer 04/18] Makefile: fix handling of multiple usr_bin files

2024-01-23 Thread Aaron Lauterer
Otherwise the build will fail once we define more than one USR_BIN file. Signed-off-by: Aaron Lauterer --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 601c836..f0c361b 100644 --- a/Makefile +++ b/Makefile @@ -104,7 +104,7 @@ install

[pve-devel] [PATCH v1 installer 03/18] common: tui: use BTreeMap for predictable ordering

2024-01-23 Thread Aaron Lauterer
necessary for the disk selection and network interfaces maps to have tests with results that can be compared without much additional effort. Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 8 proxmox-tui-installer/src/options.rs | 4 ++-- proxmox-tui

[pve-devel] [PATCH v1 installer 09/18] auto-installer: add struct to hold udev info

2024-01-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/lib.rs | 1 + proxmox-auto-installer/src/udevinfo.rs | 9 + 2 files changed, 10 insertions(+) create mode 100644 proxmox-auto-installer/src/udevinfo.rs diff --git a/proxmox-auto-installer/src/lib.rs b/proxmox-auto

[pve-devel] [PATCH v1 installer 06/18] add auto-installer crate

2024-01-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Cargo.toml| 1 + Makefile | 1 + proxmox-auto-installer/Cargo.toml | 10 ++ proxmox-auto-installer/src/lib.rs | 0 4 files changed, 12 insertions(+) create mode 100644 proxmox-auto-installer/Cargo.toml

[pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation

2024-01-23 Thread Aaron Lauterer
ts.proxmox.com/pipermail/pve-devel/2023-December/060961.html installer: Aaron Lauterer (17): tui: common: move InstallConfig struct to common crate common: make InstallZfsOption members public common: tui: use BTreeMap for predictable ordering Makefile: fix handling of multiple usr_bin files

[pve-devel] [PATCH v1 installer 07/18] auto-installer: add dependencies

2024-01-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/Cargo.toml | 4 1 file changed, 4 insertions(+) diff --git a/proxmox-auto-installer/Cargo.toml b/proxmox-auto-installer/Cargo.toml index 75cfb2c..211c605 100644 --- a/proxmox-auto-installer/Cargo.toml +++ b/proxmox-auto-installer

[pve-devel] [PATCH v1 installer 16/18] auto-installer: utils: make get_udev_index functions public

2024-01-23 Thread Aaron Lauterer
because we will need to access them directly in the future from a separate binary Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/utils.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src

[pve-devel] [PATCH v1 installer 05/18] low-level: add dump-udev command

2024-01-23 Thread Aaron Lauterer
Fetches UDEV device properties prepended with 'E:' for NICs and disks. The result is stored in its own JSON file. This information is needed to filter for specific devices. Mainly for the auto-installer for now. Signed-off-by: Aaron Lauterer --- Proxmox/Makefile| 1 + P

[pve-devel] [PATCH v1 installer 11/18] auto-installer: add simple logging

2024-01-23 Thread Aaron Lauterer
Log to stdout and the file the binary needs to set up. This is a first variant. By using the log crate macros we can change that in the future without too much effort. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/Cargo.toml | 2 ++ proxmox-auto-installer/src/lib.rs | 1 + proxmox

[pve-devel] [PATCH v1 installer 13/18] auto-installer: add auto-installer binary

2024-01-23 Thread Aaron Lauterer
be run pre and post the low level installer. It also logs everything to the logfile, currently '/tmp/auto_installer.log'. Signed-off-by: Aaron Lauterer --- Makefile | 4 +- .../src/bin/proxmox-auto-installer.rs | 192 +

[pve-devel] [PATCH v1 installer 14/18] auto-installer: add fetch answer binary

2024-01-23 Thread Aaron Lauterer
mox-auto-installer' and pipe in the contents via stdin. Signed-off-by: Aaron Lauterer --- Makefile | 1 + .../src/bin/proxmox-fetch-answer.rs | 73 + .../src/fetch_plugins/mod.rs | 1 + .../src/fet

[pve-devel] [PATCH v1 docs 18/18] installation: add unattended documentation

2024-01-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Once we have defined the process on how it can be started, what the ISO is called and so forth, we can include that in the documentation. We should also add an example section to showcase the possibilities better. Maybe also explain how the post/pre commands can

[pve-devel] [PATCH v1 installer 08/18] auto-installer: add answer file definition

2024-01-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/answer.rs | 147 +++ proxmox-auto-installer/src/lib.rs| 1 + 2 files changed, 148 insertions(+) create mode 100644 proxmox-auto-installer/src/answer.rs diff --git a/proxmox-auto-installer/src/answer.rs

[pve-devel] [PATCH v1 installer 01/18] tui: common: move InstallConfig struct to common crate

2024-01-23 Thread Aaron Lauterer
It describes the data structure expected by the low-level-installer. We do this so we can use it in more than the TUI installer, for example the planned auto installer. Make the members public so we can easily implement a custom From method for each dependent crate. Signed-off-by: Aaron Lauterer

[pve-devel] [PATCH v1 installer 15/18] auto-installer: use glob crate for pattern matching

2024-01-23 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/Cargo.toml | 1 + proxmox-auto-installer/src/utils.rs | 48 +++-- 2 files changed, 19 insertions(+), 30 deletions(-) diff --git a/proxmox-auto-installer/Cargo.toml b/proxmox-auto-installer/Cargo.toml index

[pve-devel] [PATCH v1 installer 02/18] common: make InstallZfsOption members public

2024-01-23 Thread Aaron Lauterer
as they will be used directly by the auto installer Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index 03beb77

[pve-devel] [PATCH v1 installer 17/18] auto-installer: add proxmox-installer-filter helper tool

2024-01-23 Thread Aaron Lauterer
installer environment, it does not rely on the device information provided by the low-level installer. It instead fetches the list of disks and NICs by itself. The rules when a device is ignored, should match how the low-level installer handles it. Signed-off-by: Aaron Lauterer --- Makefile

[pve-devel] [PATCH v1 installer 10/18] auto-installer: add utils

2024-01-23 Thread Aaron Lauterer
the source data is spread over several other structs in comparison to one in the TUI installer. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/lib.rs | 1 + proxmox-auto-installer/src/utils.rs | 473 2 files changed, 474 insertions(+) create mode

[pve-devel] [PATCH v1 installer 12/18] auto-installer: add tests for answer file parsing

2024-01-23 Thread Aaron Lauterer
By matching the resulting json to be passed to the low level installer against known good ones. The environment info was gathered from one of our AMD Epyc Rome test servers to have a realistic starting point. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/tests/parse-answer.rs | 102

[pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k

2024-01-29 Thread Aaron Lauterer
to reflect current ZFS defaults. Signed-off-by: Aaron Lauterer --- unless I have missed it, we currently still show the old default as placeholder www/manager6/storage/ZFSPoolEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www

Re: [pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation

2024-02-08 Thread Aaron Lauterer
small tool similar to "arch-chroot" to easily chroot into the installation. So please consider this: Tested-by: Christoph Heiss Also, already left some review comments on the individual patches, but nothing too major. On Tue, Jan 23, 2024 at 06:00:35PM +0100, Aaron Laut

Re: [pve-devel] [PATCH v1 installer 14/18] auto-installer: add fetch answer binary

2024-02-08 Thread Aaron Lauterer
On 2/8/24 15:18, Christoph Heiss wrote: Sorry for not including this in the first email. On Tue, Jan 23, 2024 at 06:00:49PM +0100, Aaron Lauterer wrote: [..] diff --git a/proxmox-auto-installer/src/fetch_plugins/partition.rs b/proxmox-auto-installer/src/fetch_plugins/partition.rs new file

Re: [pve-devel] [PATCH installer 1/4] low-level: initialize UI backend for 'dump-env' subcommand too

2024-02-09 Thread Aaron Lauterer
Is this something I should consider for the new dump-udev subcommand as well? https://lists.proxmox.com/pipermail/pve-devel/2024-January/061433.html On 2/9/24 11:55, Christoph Heiss wrote: Some detection routines might try to log things and call some Proxmox::Ui functions all the way down, so j

Re: [pve-devel] [PATCH v1 installer 14/18] auto-installer: add fetch answer binary

2024-02-16 Thread Aaron Lauterer
On 2/8/24 17:46, Aaron Lauterer wrote: On 2/8/24 15:18, Christoph Heiss wrote: Sorry for not including this in the first email. On Tue, Jan 23, 2024 at 06:00:49PM +0100, Aaron Lauterer wrote: [..] diff --git a/proxmox-auto-installer/src/fetch_plugins/partition.rs b/proxmox-auto-installer

[pve-devel] [PATCH v2 02/22] common: make InstallZfsOption members public

2024-02-21 Thread Aaron Lauterer
as they will be used directly by the auto installer Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index 03beb77

[pve-devel] [PATCH v2 03/22] common: tui: use BTreeMap for predictable ordering

2024-02-21 Thread Aaron Lauterer
necessary for the disk selection and network interfaces maps to have tests with results that can be compared without much additional effort. Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 8 proxmox-tui-installer/src/options.rs | 4 ++-- proxmox-tui

[pve-devel] [PATCH v2 05/22] add auto-installer crate

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Cargo.toml| 1 + Makefile | 1 + proxmox-auto-installer/Cargo.toml | 10 ++ proxmox-auto-installer/src/lib.rs | 0 4 files changed, 12 insertions(+) create mode 100644 proxmox-auto-installer/Cargo.toml

[pve-devel] [PATCH v2 08/22] auto-installer: add struct to hold udev info

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/lib.rs | 1 + proxmox-auto-installer/src/udevinfo.rs | 9 + 2 files changed, 10 insertions(+) create mode 100644 proxmox-auto-installer/src/udevinfo.rs diff --git a/proxmox-auto-installer/src/lib.rs b/proxmox-auto

[pve-devel] [PATCH v2 01/22] tui: common: move InstallConfig struct to common crate

2024-02-21 Thread Aaron Lauterer
It describes the data structure expected by the low-level-installer. We do this so we can use it in more than the TUI installer, for example the planned auto installer. Make the members public so we can easily implement a custom From method for each dependent crate. Signed-off-by: Aaron Lauterer

[pve-devel] [PATCH v2 10/22] auto-installer: add simple logging

2024-02-21 Thread Aaron Lauterer
Log to stdout and the file the binary needs to set up. This is a first variant. By using the log crate macros we can change that in the future without too much effort. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/Cargo.toml | 2 ++ proxmox-auto-installer/src/lib.rs | 1 + proxmox

[pve-devel] [PATCH v2 14/22] unconfigured: add proxauto as option to start auto installer

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- unconfigured.sh | 8 1 file changed, 8 insertions(+) diff --git a/unconfigured.sh b/unconfigured.sh index cf7de83..f668be4 100755 --- a/unconfigured.sh +++ b/unconfigured.sh @@ -5,6 +5,7 @@ trap "err_reboot" ERR # NOTE: we nowadays get exe

[pve-devel] [PATCH v2 22/22] control: update build depends for auto installer

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- debian/control | 10 ++ 1 file changed, 10 insertions(+) diff --git a/debian/control b/debian/control index 9057f59..72a5657 100644 --- a/debian/control +++ b/debian/control @@ -8,10 +8,20 @@ Build-Depends: cargo:native, libgtk3-perl

[pve-devel] [PATCH v2 07/22] auto-installer: add answer file definition

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v1: * added default traits and switched to them proxmox-auto-installer/src/answer.rs | 132 +++ proxmox-auto-installer/src/lib.rs| 1 + 2 files changed, 133 insertions(+) create mode 100644 proxmox-auto-installer/src

[pve-devel] [PATCH v2 19/22] auto-installer: helper: add subcommand to view indentifiers

2024-02-21 Thread Aaron Lauterer
It will collect the information from the current system and show the payload of identifiers that will be send. To avoid confusion, the subcommands for the device info and filter matching have been renamed. Signed-off-by: Aaron Lauterer --- .../src/bin/proxmox-autoinst-helper.rs| 54

[pve-devel] [PATCH v2 20/22] auto-installer: fetch: add http post utility module

2024-02-21 Thread Aaron Lauterer
certificate explicitly, even if it would be in the trust chain. A custom cert verifier for ureq / rustl was necessary to get cert fingerprint matching to work. If no fingerprint is proviced, we switch rustls to native-certs and native-tls. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer

[pve-devel] [PATCH v2 13/22] auto-installer: add fetch answer binary

2024-02-21 Thread Aaron Lauterer
mox-auto-installer' and pipe in the contents via stdin. Signed-off-by: Aaron Lauterer --- changes since v1: * removed hard coded paths to binaries * create mount dir with fs::create_dir_all Makefile | 1 + .../src/bin/proxmox-fetch-answer.rs | 7

[pve-devel] [PATCH v2 12/22] auto-installer: add auto-installer binary

2024-02-21 Thread Aaron Lauterer
be run pre and post the low level installer. It also logs everything to the logfile, currently '/tmp/auto_installer.log'. Signed-off-by: Aaron Lauterer --- Makefile | 4 +- .../src/bin/proxmox-auto-installer.rs | 193 +

[pve-devel] [PATCH v2 04/22] low-level: add dump-udev command

2024-02-21 Thread Aaron Lauterer
Fetches UDEV device properties prepended with 'E:' for NICs and disks. The result is stored in its own JSON file. This information is needed to filter for specific devices. Mainly for the auto-installer for now. Signed-off-by: Aaron Lauterer --- Proxmox/Makefile| 1 + P

[pve-devel] [PATCH v2 06/22] auto-installer: add dependencies

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- changes since v1: * toml switched from 0.5 to 0.7 proxmox-auto-installer/Cargo.toml | 4 1 file changed, 4 insertions(+) diff --git a/proxmox-auto-installer/Cargo.toml b/proxmox-auto-installer/Cargo.toml index 75cfb2c..67218dd 100644 --- a/proxmox-auto

[pve-devel] [PATCH v2 16/22] auto-installer: utils: make get_udev_index functions public

2024-02-21 Thread Aaron Lauterer
because we will need to access them directly in the future from a separate binary Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/utils.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src

[pve-devel] [PATCH v2 00/22] add automated/unattended installation

2024-02-21 Thread Aaron Lauterer
nto its own subdirectory as it grew quite a bit * added builddeps [0] https://lists.proxmox.com/pipermail/pve-devel/2023-September/059020.html [1] https://lists.proxmox.com/pipermail/pve-devel/2023-December/060961.html Aaron Lauterer (22): tui: common: move InstallConfig struct to common cr

[pve-devel] [PATCH v2 15/22] auto-installer: use glob crate for pattern matching

2024-02-21 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/Cargo.toml | 1 + proxmox-auto-installer/src/utils.rs | 48 +++-- 2 files changed, 19 insertions(+), 30 deletions(-) diff --git a/proxmox-auto-installer/Cargo.toml b/proxmox-auto-installer/Cargo.toml index

[pve-devel] [PATCH v2 21/22] auto-installer: fetch: add http plugin to fetch answer

2024-02-21 Thread Aaron Lauterer
this specific certificate. The certificate fingerprint can either be placed on the `proxmoxinst` partition and needs to be called `cert_fingerprint.txt`, or it can be provided in a second custom DHCP option or a TXT record. Signed-off-by: Aaron Lauterer --- .../src/bin/proxmox-fetch-answer.rs

[pve-devel] [PATCH v2 18/22] auto-installer: fetch: add gathering of system identifiers and restructure code

2024-02-21 Thread Aaron Lauterer
the fetch plugins, it, and the additional fetch plugin utilities are placed in their own directory. Signed-off-by: Aaron Lauterer --- .../src/fetch_plugins/mod.rs | 2 +- .../src/fetch_plugins/utils.rs| 90 .../src/fetch_plugins/utils/mod.rs

[pve-devel] [PATCH v2 09/22] auto-installer: add utils

2024-02-21 Thread Aaron Lauterer
the source data is spread over several other structs in comparison to one in the TUI installer. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/lib.rs | 1 + proxmox-auto-installer/src/utils.rs | 471 2 files changed, 472 insertions(+) create mode

[pve-devel] [PATCH v2 17/22] auto-installer: add proxmox-autoinst-helper tool

2024-02-21 Thread Aaron Lauterer
by the low-level installer. It instead fetches the list of disks and NICs by itself. The rules when a device is ignored, should match how the low-level installer handles it. Signed-off-by: Aaron Lauterer --- Makefile | 1 + proxmox-auto-installer/Cargo.toml

[pve-devel] [PATCH v2 11/22] auto-installer: add tests for answer file parsing

2024-02-21 Thread Aaron Lauterer
By matching the resulting json to be passed to the low level installer against known good ones. The environment info was gathered from one of our AMD Epyc Rome test servers to have a realistic starting point. Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/tests/parse-answer.rs | 102

Re: [pve-devel] [PATCH v2 18/22] auto-installer: fetch: add gathering of system identifiers and restructure code

2024-02-21 Thread Aaron Lauterer
On 2/21/24 15:09, Christoph Heiss wrote: While looking at this and reading the `dmidecode` manpage a bit, it looks like everything collected here is also available under /sys/devices/virtual/dmi/id as separate files, e.g. # ls /sys/devices/virtual/dmi/id/ bios_datechassis_as

Re: [pve-devel] [PATCH v2 00/22] add automated/unattended installation

2024-02-23 Thread Aaron Lauterer
On 2/23/24 11:19, Friedrich Weber wrote: On 21/02/2024 12:07, Aaron Lauterer wrote: This patch series adds the possibility to do an automated / unattended installation of Proxmox VE. Gave this a quick spin installing some virtual PVE hosts with a simple static IP + ext4 setup. Generated an

Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Aaron Lauterer
Overall good idea :) On 2/23/24 12:45, Hannes Laimer wrote: Signed-off-by: Hannes Laimer --- came up in enterprise support, and I don't think there is a reason to not have it in the UI, while having it in the API www/manager6/storage/DirEdit.js | 12 1 file changed, 12 inserti

Re: [pve-devel] [PATCH v1 installer 08/18] auto-installer: add answer file definition

2024-02-27 Thread Aaron Lauterer
On 2/23/24 15:27, Stefan Lendl wrote: Aaron Lauterer writes: +#[derive(Clone, Deserialize, Debug)] +pub struct Disks { +pub filesystem: Option, +pub disk_selection: Option>, +pub filter_match: Option, +// use BTreeMap to have keys sorted +pub filter: Option>, +

[pve-devel] [PATCH docs] pveceph: document cluster shutdown

2024-03-19 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pveceph.adoc | 50 ++ 1 file changed, 50 insertions(+) diff --git a/pveceph.adoc b/pveceph.adoc index 089ac80..7b493c5 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -1080,6 +1080,56 @@ scrubs footnote:[Ceph

[pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index bc3689d..4db5358 100644 --- a/pve-system-requirements.adoc +++ b/pve-system-requirements.adoc @@ -49,6 +49,8

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Aaron Lauterer
On 2024-03-20 10:30, Fiona Ebner wrote: Am 20.03.24 um 09:56 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc index bc3689d..4db5358

[pve-devel] [PATCH docs v2] system-requirements: mention that SSDs with PLP should be used

2024-03-20 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Thanks for the feedback. I think this variant transports the important infomation in simple english. pve-system-requirements.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc

[pve-devel] applied: [PATCH docs] zfs: add a note about dRaid performance

2024-03-20 Thread Aaron Lauterer
On 2024-03-20 16:52, Folke Gleumes wrote: Based on statements from the openZFS documentation where it is described as providing "the same level of redundancy and performance as raidz" [0]. [0] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/dRAID%20Howto.html --- local-zfs.adoc |

[pve-devel] [PATCH manager] ui: agentipview: make text in grid selectable

2024-03-21 Thread Aaron Lauterer
This makes it possible to select any of the IP addresses listed in the full view window to copy & paste it. Signed-off-by: Aaron Lauterer --- Becaue @Folke made a remark that this was a nuisance ;) www/manager6/qemu/AgentIPView.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-21 Thread Aaron Lauterer
v2 is on the list https://lists.proxmox.com/pipermail/pve-devel/2024-March/062296.html On 2024-03-20 09:56, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-system-requirements.adoc b/pve-system

[pve-devel] applied: [PATCH docs 1/2] qm: multiqueue specify that it needs to be vCPUs not cores

2024-03-21 Thread Aaron Lauterer
On 2024-03-21 16:50, Stefan Sterz wrote: total number of cores != vCPUs if there is more than one socket configured. according to the redhat docs it should be vCPUs not cores: Multi-queue virtio-net provides the greatest performance benefit when: [..] - The number of queues is equal to the

Re: [pve-devel] [PATCH manager 7/9] report: add info of the mainboard in use

2024-03-22 Thread Aaron Lauterer
If we add more info, then dmidecode -t {1,2,3} might be interesting as well as those deliver motherboard, system and chassis infos. If you want to see what you get there, run them on some decent servers as most consumer boards and systems will not show useful information here On 2024-03-22

[pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm inde

[pve-devel] [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm inde

[pve-devel] [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index 77fb6c0

Re: [pve-devel] [PATCH storage v2] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
please ignore this one On 2024-03-26 13:04, Aaron Lauterer wrote: static -> defined manually generated -> by ESXi vpx -> generated by vCenter Signed-off-by: Aaron Lauterer --- src/PVE/Storage/ESXiPlugin.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [pve-devel] [PATCH storage] esxi: use mac address when static, generated and vpx

2024-03-26 Thread Aaron Lauterer
sent a v2, unfortunately also one a bit too quickly (with no changes). please ignore that one :) On 2024-03-26 12:36, Thomas Lamprecht wrote: Am 26/03/2024 um 12:03 schrieb Aaron Lauterer: static -> defined manually generated -> by ESXi vpx -> generated by vCenter nice! Sign

[pve-devel] [PATCH manager] ui: guest import: allow setting mac addresses to unique

2024-03-26 Thread Aaron Lauterer
by adding a new checkbox and render the grid accordingly. If unique MAC addresses are enabled, set them to undefined when getting the values from the grid. Signed-off-by: Aaron Lauterer --- not sure if setting `uniqueMac` directly on the component is okay. Though we do that dynamically for the

Re: [pve-devel] applied: [PATCH manager] ui: guest import: allow setting mac addresses to unique

2024-03-27 Thread Aaron Lauterer
On 2024-03-27 11:26, Thomas Lamprecht wrote: Am 26/03/2024 um 14:25 schrieb Aaron Lauterer: by adding a new checkbox and render the grid accordingly. If unique MAC addresses are enabled, set them to undefined when getting the values from the grid. Signed-off-by: Aaron Lauterer --- not

[pve-devel] applied: [PATCH docs] installation: fix volume group name

2024-03-28 Thread Aaron Lauterer
On 2024-03-28 11:45, Christoph Heiss wrote: This slipped through while taking the wording from PMG. Fixes: 67d2d94 ("installation: lvm-options: improve & align wording with pmg-docs") Signed-off-by: Christoph Heiss --- Probably have been staring at the docs too long to not notice this ear

Re: [pve-devel] [PATCH docs] system-requirements: mention that SSDs with PLP should be used

2024-03-28 Thread Aaron Lauterer
+··loss·protection·(PLP)·to·avoid·using·consumer-grade·SSDs,·which·are·not +··recommended. On 2024-03-21 09:06, Thomas Lamprecht wrote: (missed reply-all, so resending) On 20/03/2024 10:30, Fiona Ebner wrote: Am 20.03.24 um 09:56 schrieb Aaron Lauterer: Signed-off-by: Aaron Lauterer --- pve

[pve-devel] [PATCH v3 04/30] common: utils: add deserializer for CidrAddress

2024-03-28 Thread Aaron Lauterer
so it can be deserialized from a string Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/utils.rs | 11 +++ 1 file changed, 11 insertions(+) diff --git a/proxmox-installer-common/src/utils.rs b/proxmox-installer-common/src/utils.rs index 36b1d53..f6521eb 100644 --- a

[pve-devel] [PATCH v3 03/30] common: tui: use BTreeMap for predictable ordering

2024-03-28 Thread Aaron Lauterer
necessary for the disk selection and network interfaces maps to have tests with results that can be compared without much additional effort. Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 8 proxmox-tui-installer/src/options.rs | 4 ++-- proxmox-tui

[pve-devel] [PATCH v3 10/30] auto-installer: add struct to hold udev info

2024-03-28 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-auto-installer/src/lib.rs | 1 + proxmox-auto-installer/src/udevinfo.rs | 9 + 2 files changed, 10 insertions(+) create mode 100644 proxmox-auto-installer/src/udevinfo.rs diff --git a/proxmox-auto-installer/src/lib.rs b/proxmox-auto

[pve-devel] [PATCH v3 07/30] add auto-installer crate

2024-03-28 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- Cargo.toml| 1 + Makefile | 1 + proxmox-auto-installer/Cargo.toml | 10 ++ proxmox-auto-installer/src/lib.rs | 0 4 files changed, 12 insertions(+) create mode 100644 proxmox-auto-installer/Cargo.toml

[pve-devel] [PATCH v3 01/30] tui: common: move InstallConfig struct to common crate

2024-03-28 Thread Aaron Lauterer
It describes the data structure expected by the low-level-installer. We do this so we can use it in more than the TUI installer, for example the planned auto installer. Make the members public so we can easily implement a custom From method for each dependent crate. Signed-off-by: Aaron Lauterer

[pve-devel] [PATCH v3 16/30] unconfigured: add proxauto as option to start auto installer

2024-03-28 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- unconfigured.sh | 8 1 file changed, 8 insertions(+) diff --git a/unconfigured.sh b/unconfigured.sh index 2b371f0..f02336a 100755 --- a/unconfigured.sh +++ b/unconfigured.sh @@ -5,6 +5,7 @@ trap "err_reboot" ERR # NOTE: we nowadays get exe

[pve-devel] [PATCH v3 29/30] common: add Display trait to ProxmoxProduct

2024-03-28 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 10 ++ 1 file changed, 10 insertions(+) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index f9f9e82..19113e1 100644 --- a/proxmox-installer-common/src/setup.rs +++ b

  1   2   3   4   5   6   7   8   9   10   >