ngs)
- json (print a property as json)
In the configuration, the body, header values and secret values
are stored in base64 encoding so that we can store any string we want.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
proxmox-notify/Cargo.toml | 9 +-
proxmox-
Copied and adapted from the Gotify ones.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
src/api2/config/notifications/mod.rs | 2 +
src/api2/config/notifications/webhook.rs | 175 +++
2 files changed, 177 insertions(+)
create mode 100644 src/api2/config
r, it will be
dropped. If 'secret' is present in the 'delete' array, all secrets
will be dropped, apart from those which are also set/preserved in the
same update call.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
proxmox-notify/src/api/mod.rs | 20 +
again")
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/renderer/mod.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-notify/src/renderer/mod.rs
b/proxmox-notify/src/renderer/mod.rs
index 8574a3fb..82473d03 100644
--- a/proxmox-notify/src/renderer/mod.rs
+++
From: Gabriel Goller
Add helper functions to convert from a utf8 string to a base64 string
and vice-versa. Using the TextEncoder/TextDecoder we can support unicode
such as emojis as well [0].
[0]:
https://developer.mozilla.org/en-US/docs/Glossary/Base64#the_unicode_problem
Signed-off-by: Gabri
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
common/src/notify.rs | 63
1 file changed, 63 insertions(+)
diff --git a/common/src/notify.rs b/common/src/notify.rs
index e1b006b..fe192d5 100644
--- a/common/src/notify.rs
+++ b/common/src
The get_targets API endpoint is now implemented in Rust.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
PVE/API2/Cluster/Notifications.pm | 34 +--
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE
n (e.g. target name, URL)
- Code documentation improvments
- Mask secrets in errors returned from the proxmox-notify crate, hopefully
preventing them to be shown in logs or error messages
- Rebased on the latest master branches
proxmox:
Lukas Wagner (3):
notify: renderer: adapt to chan
These just call the API implementation via the perl-rs bindings.
Signed-off-by: Lukas Wagner
Tested-By: Stefan Hanreich
---
PVE/API2/Cluster/Notifications.pm | 263 +-
1 file changed, 262 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Cluster/Notifications.pm
:
- In the UI, checking 'Live Import' does not seem to have any effect
(is live import even available for OVA import?)
Also, the 'Start a previously stopped VM on Proxmox VE' text does
not make much sense in the context of OVAs, FWICT.
- A help button for the dialo
Ping for patches 3-6, these were never applied.
They do not add any functional changes, but only aim to improve
code style and add some tests.
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/
It has been a full year now, so I'd argue it is safe to drop these
safety guards now. On the off chance that there are still systems out
there which still have these entries in their notifications.cfg,
a manual removal from the file will be needed after this commit.
Signed-off-by: Lukas
On 2024-12-02 16:29, Thomas Lamprecht wrote:
> Am 02.12.24 um 14:32 schrieb Lukas Wagner:
>> It has been a full year now, so I'd argue it is safe to drop these
>> safety guards now. On the off chance that there are still systems out
>> there which still h
On 2024-12-05 11:23, Gabriel Goller wrote:
> Add special logger for perlmod. This one will print everything to
> stderr (which will end up in the tasklog) and the errors to journald.
>
> Reported-by: Maximiliano Sandoval
> Reported-by: Lukas Wagner
> Signed-off-
On 2024-12-05 11:16, Gabriel Goller wrote:
> -proxmox-http-error = "0.1.0"
> -proxmox-log = "0.2"
> -proxmox-notify = { version = "0.5", features = ["pve-context"] }
> +proxmox-http-error = { version = "0.1.0",
> path="/home/ggoller/dev/proxmox/perlmod_logger/proxmox-http-error/" }
> +proxmox-
The proxmox-notify crate now uses tracing for logging,
hence we have to switch to proxmox-log (which configures the appropriate
layers/subscribers for tracing).
Signed-off-by: Lukas Wagner
---
Cargo.toml | 5 ++---
src/main.rs | 16 +++-
2 files changed, 9 insertions(+), 12
This section of code is only compiled when the 'mail-forwarder' feature
is enabled, which might have been the reason why this was missed when the
other places where log messages are produced were migrated to 'tracing'.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/e
On 2024-12-06 11:40, Gabriel Goller wrote:
>> fn main() {
>> - if let Err(err) = syslog::init(
>> - syslog::Facility::LOG_DAEMON,
>> - log::LevelFilter::Info,
>> - Some("proxmox-mail-forward"),
>> - ) {
>> + if let Err(err) = proxmox_log::init_logger("PROXMOX_LOG",
O: sample message".
>
> Reported-by: Maximiliano Sandoval
> Reported-by: Lukas Wagner
> Signed-off-by: Gabriel Goller
> ---
>
> I didn't include Lukas's T-b as I changed quite a lot on this
> patch.
>
Gave v3 another quick spin, seems to work as advertis
We use the same icon in other similar buttons already, e.g. for copying the
TLS certificate fingerprint in PBS.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/ClusterEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/dc/ClusterEdit.js b/www/manager6/dc/ClusterEdit.js
On 2024-12-05 14:17, Gabriel Goller wrote:
>> Minor nit: repo in the subject prefix is missing, also the order of patches
>> should probably reversed.
>
> Happens when you don't use murpp, am I right? :)
>
>> Seems to work fine, now messages logged by proxmox-notify while being in
>> task c
n most cases the rules carry even longer text.
>
Tested this quickly on PBS. As discussed off-list this change makes sense to me
and should
help avoid any confusion due to misleading translations as in the referenced BZ
entry.
Tested-by: Lukas Wagner
Reviewed
uster/metrics/export endpoint we want
the second one.
Reported-by: Dominik Csapak
Signed-off-by: Lukas Wagner
---
PVE/PullMetric.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/PullMetric.pm b/PVE/PullMetric.pm
index 92f4daef..954bd604 100644
--- a/PVE/PullMetric.pm
+++
.
While most services seemed to have worked fine without setting
the header, some Microsoft services seem to require it
to accept the webhook request [2].
[1] https://datatracker.ietf.org/doc/html/rfc9110#name-content-length
[2] https://forum.proxmox.com/threads/158827
Signed-off-by: Lukas Wagner
none of the template candidates could be
> used. Using an override template gets not logged.
>
> Signed-off-by: Alexander Zeidler
> ---
>
> Questions:
> - Is there anything against the chosen override path?
IMO they are fine, but somebody else should double-check.
>
ead try to render it nicely, trying
to include all useful info from the former JSON dump
Bumps:
The patches for pve-manager and pve-ha-manager must depend on a bumped
libpve-notify-perl due to the new 'PVE::Notify::common_template_data'
helper.
pve-cluster:
Lukas Wagne
Signed-off-by: Lukas Wagner
---
proxmox-notify/Cargo.toml | 2 +-
proxmox-notify/src/endpoints/gotify.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml
index ddbaacd7..5a54c4a1 100644
--- a/proxmox-notify
The new PVE::Notify::common_template_data helper gives us a hash of
properties which should be available in all notifications (hostname,
fqdn, cluster-name at this moment). This commit makes sure that
replication notifications have these available.
Signed-off-by: Lukas Wagner
---
PVE/API2
On 2025-03-26 11:11, Thomas Lamprecht wrote:
> Am 26.03.25 um 10:54 schrieb Lukas Wagner:
>> On 2025-03-25 19:41, Thomas Lamprecht wrote:
>>> FWIW, as it was already encoded in the commit message for posterity I'd
>>> have been fine with the comment being
On 2025-03-25 19:41, Thomas Lamprecht wrote:
> Am 21.03.25 um 10:56 schrieb Lukas Wagner:
>> To quote from RFC 9110 [1]:
>>
>> A user agent SHOULD send Content-Length in a request when
>> the method defines a meaning for enclosed content and it
>> is n
On 2025-03-27 16:31, Thomas Lamprecht wrote:
> Am 27.03.25 um 15:23 schrieb Lukas Wagner:
>> This commit add the `common_template_data` sub to PVE::Notify,
>> providing a convenient way to get a hash with properties that
>> should be accessible from all templates, namely
; used. Using an override template gets not logged.
>
> Signed-off-by: Alexander Zeidler
> ---
> This patch was previously sent as RFC and has now all suggestions from
> Lukas Wagner implemented:
> https://lore.proxmox.com/pve-devel/20250313151734.258337-1-a.zeid...@proxmox.com/
&
This section is meant to give a basic overview on how to use
custom templates for notifications. It will be expanded in the
future, providing a more detailed view on how templates are resolved,
existing fallback mechanisms, available templates, template
variables and helpers.
Signed-off-by: Lukas
On 2025-04-03 12:34, Markus Frank wrote:
> Virtio-fs is a shared file system that enables sharing a directory
> between host and guest VMs. It takes advantage of the locality of
> virtual machines and the hypervisor to get a higher throughput than
> the 9p remote file system protocol.
>
Some tho
On 2025-03-28 10:38, Thomas Lamprecht wrote:
> Am 28.03.25 um 09:28 schrieb Lukas Wagner:
>> We of course can cache the FQDN, but realistically speaking, this is only
>> called once per
>> notification being sent, thus any real-world performance impact is
>> absolu
This commit add the `common_template_data` sub to PVE::Notify,
providing a convenient way to get a hash with properties that
should be accessible from all templates, namely hostname, fqdn
and cluster-name.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v1:
- use PVE::Tools
::get_fqdn helper to get the FQDN (thx Thomas)
pve-cluster:
Lukas Wagner (1):
notify: add common_template_data
src/PVE/Notify.pm | 27 +++
1 file changed, 27 insertions(+)
pve-manager:
Lukas Wagner (4):
notification templates: vzdump: generate HTML table in template
the style/structure of the table.
Signed-off-by: Lukas Wagner
---
PVE/API2/APT.pm | 27 ---
.../default/package-updates-body.html.hbs | 15 ++-
.../default/package-updates-body.txt.hbs | 2 +-
.../default/package-updates-subje
manner
Signed-off-by: Lukas Wagner
---
src/PVE/HA/NodeStatus.pm | 43 +++
src/PVE/HA/Sim/Env.pm | 8 ++--
src/templates/default/fencing-body.html.hbs | 43 ---
src/templates/default/fencing-body.txt.hbs| 40
he table helper automatically aligns table columns - something that
is not easily possible with native Handlebars syntax.
Signed-off-by: Lukas Wagner
---
PVE/VZDump.pm| 21 +
templates/default/vzdump-body.html.hbs | 24 ++--
te
Other commits introduced a consistent style for handlebars expressions,
this commit applies the same style to test notification templates.
Signed-off-by: Lukas Wagner
---
templates/default/test-body.html.hbs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/templates/default
The new PVE::Notify::common_template_data helper gives us a hash of
properties which should be available in all notifications (hostname,
fqdn, cluster-name at this moment). This commit makes sure that
replication notifications have these available.
Signed-off-by: Lukas Wagner
---
PVE/API2
v2 available!
Superseded-by:
https://lore.proxmox.com/pve-devel/20250328101915.73951-1-l.wag...@proxmox.com/T/#t
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
t_valid for the mappings on the
> current node
> * see individual patches
>
Cool stuff! Tried it out, seems to work as promised (only tested a Linux guest
though)
Tested-by: Lukas Wagner
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
This commit add the `common_template_data` sub to PVE::Notify,
providing a convenient way to get a hash with properties that
should be accessible from all templates, namely hostname, fqdn
and cluster-name.
Signed-off-by: Lukas Wagner
---
src/PVE/Notify.pm | 20
1 file
manner
Signed-off-by: Lukas Wagner
---
src/PVE/HA/NodeStatus.pm | 43 +++
src/PVE/HA/Sim/Env.pm | 8 ++--
src/templates/default/fencing-body.html.hbs | 43 ---
src/templates/default/fencing-body.txt.hbs| 40
the style/structure of the table.
Signed-off-by: Lukas Wagner
---
PVE/API2/APT.pm | 27 ---
.../default/package-updates-body.html.hbs | 15 ++-
.../default/package-updates-body.txt.hbs | 2 +-
.../default/package-updates-subje
he table helper automatically aligns table columns - something that
is not easily possible with native Handlebars syntax.
Signed-off-by: Lukas Wagner
---
PVE/VZDump.pm| 21 +
templates/default/vzdump-body.html.hbs | 24 ++--
te
Other commits introduced a consistent style for handlebars expressions,
this commit applies the same style to test notification templates.
Signed-off-by: Lukas Wagner
---
templates/default/test-body.html.hbs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/templates/default
On 2025-04-03 11:04, Thomas Lamprecht wrote:
> Am 03.04.25 um 10:34 schrieb Maximiliano Sandoval:
>>
>> As per systemd-exec's man page, in total one can pass up to 1MB in
>> system credentials. A VM config file is certainly not the vehicle for
>> such an amount of data and I am also not fully comf
This also fixes any warnings that were shown during compilation because
we were using the deprecated `base64::encode/decode` functions.
Signed-off-by: Lukas Wagner
---
Intended for the trixie bootstrap work on the master branch.
Notes:
Could probably also use the serde helpers from proxmox
This way we can start adding/adapting checks for the major upgrade to
PVE 9.
No changes were done apart from the Perl module name.
Signed-off-by: Lukas Wagner
---
PVE/CLI/Makefile |1 +
PVE/CLI/pve8to9.pm | 1543
bin/Makefile | 10
afterwards.
Signed-off-by: Lukas Wagner
---
PVE/CLI/pve8to9.pm | 37 +
1 file changed, 37 insertions(+)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 42b7073b..9d00e064 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1372,6 +1372,42 @@ sub
file.
With the upcoming release of PVE 9 and PBS 4 we can drop the
schema. The upgrade check scripts (e.g. pve8to9) will
include checks to make sure that no legacy config sections are present
any more.
Signed-off-by: Lukas Wagner
---
Notes:
Intended for the `master` branch.
Ch
from comparisons between
the generated and reference emails.
Signed-off-by: Lukas Wagner
---
proxmox-sendmail/src/lib.rs | 66 +++--
1 file changed, 42 insertions(+), 24 deletions(-)
diff --git a/proxmox-sendmail/src/lib.rs b/proxmox-sendmail/src/lib.rs
index d9c
No major changes were needed, just some minor changes on how we have to
handle errors in helpers.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/endpoints/webhook.rs | 8 +---
proxmox-notify/src/renderer/html.rs | 10 +++---
proxmox-notify/src/renderer/plaintext.rs | 10
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/endpoints/webhook.rs | 8 ++---
proxmox-notify/src/renderer/html.rs | 7 ++--
proxmox-notify/src/renderer/mod.rs | 43 +---
proxmox-notify/src/renderer/plaintext.rs | 7 ++--
4 files changed, 25 insertions
Signed-off-by: Lukas Wagner
---
src/email-encoding/debian/changelog | 13 +
src/email-encoding/debian/copyright | 37
.../debian/copyright.debcargo.hint| 49
src/email-encoding/debian/debcargo.toml | 2 +
.../debian/patches
Signed-off-by: Lukas Wagner
---
src/lettre/debian/changelog | 39 +++
src/lettre/debian/copyright | 38 +++
src/lettre/debian/copyright.debcargo.hint | 52
src/lettre/debian/debcargo.toml | 2 +
src/lettre/debian/patches/relax
Signed-off-by: Lukas Wagner
---
src/lettre/debian/changelog | 8 +
src/lettre/debian/copyright.debcargo.hint | 4 +-
src/lettre/debian/patches/relax-deps.patch| 14 +-
.../patches/remove_unused_features.patch | 284 ++
4 files changed, 177
, quite a few
crates have a dependency on nom.
I double checked lettre's release notes that there were no security
issues fixed in 0.11.14-0.11.16 that would speak against packaging the
slightly older version.
Lukas Wagner (4):
import email-encoding from bookworm
update email-encoding to
Signed-off-by: Lukas Wagner
---
src/email-encoding/debian/changelog | 7 +++
.../debian/copyright.debcargo.hint| 6 +-
.../debian/patches/downgrade_base64.diff | 57 ---
src/email-encoding/debian/patches/series | 1 -
4 files changed, 10
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/endpoints/smtp.rs | 32 ++
proxmox-notify/testdata/test1.msg | 104 ++
.../test_forward_message_from_raw.ref | 95
3 files changed, 231 insertions(+)
create mode 100644 proxmox
Signed-off-by: Lukas Wagner
---
src/mail-parser/debian/changelog | 6 +++
src/mail-parser/debian/copyright | 12 ++---
.../debian/copyright.debcargo.hint| 48 +--
3 files changed, 36 insertions(+), 30 deletions(-)
diff --git a/src/mail
Thanks to the regression tests introduced in the previous commit we can
be certain that everything works as it should.
Signed-off-by: Lukas Wagner
---
Cargo.toml | 2 +-
proxmox-notify/src/endpoints/smtp.rs | 12 ++--
proxmox-notify/src/lib.rs| 3
This series packages the newest version of the `mail-parser` crate along
with its new `hashify` dep for Debian Trixie.
The second part of the series adapts proxmox-notify to the changes in
`mail-parser`'s
API.
debcargo-conf:
Lukas Wagner (3):
import mail-parser from bookworm
pa
Signed-off-by: Lukas Wagner
---
src/hashify/debian/changelog | 6 +++
src/hashify/debian/copyright | 37
src/hashify/debian/copyright.debcargo.hint | 49 ++
src/hashify/debian/debcargo.toml | 2 +
4 files changed, 94
This allows us to write some tests for it.
No behavioral changes intended.
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/endpoints/smtp.rs | 189 ++-
1 file changed, 97 insertions(+), 92 deletions(-)
diff --git a/proxmox-notify/src/endpoints/smtp.rs
b/proxmox
Signed-off-by: Lukas Wagner
---
src/mail-parser/debian/changelog | 11 +++
src/mail-parser/debian/copyright | 49
.../debian/copyright.debcargo.hint| 77 +++
src/mail-parser/debian/debcargo.toml | 2 +
4 files changed
These were briefly used by the first version of the overhauled
notification stack which hit pvetest too soon. They will be dropped from
the schema in the major update.
Signed-off-by: Lukas Wagner
---
PVE/CLI/pve8to9.pm | 35 +++
1 file changed, 35 insertions
script will gain a check to check for any left-over keys.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v1:
- rebase onto latest master
src/PVE/VZDump/Common.pm | 13 -
1 file changed, 13 deletions(-)
diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
afterwards.
Signed-off-by: Lukas Wagner
---
PVE/CLI/pve8to9.pm | 37 +
1 file changed, 37 insertions(+)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 89e2a781..5a80c40f 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1416,6 +1416,42 @@ sub
Superseded-by:
https://lore.proxmox.com/all/20250624112817.132312-1-l.wag...@proxmox.com/T/#t
On 2025-06-12 11:55, Lukas Wagner wrote:
> These were only used in the 'old' revamped notification stack which was
> briefly available on pvetest. With PVE 9 we can finally get completel
pending on whether mailto is set).
The term 'Notification System' is completely dropped from the UI,
instead 'Global Notification Settings' is used.
Signed-off-by: Lukas Wagner
Tested-by: Michael Köppl
Reviewed-by: Michael Köppl
---
Notes:
Changeslog:
v3:
- Rebas
Superseded-by:
https://lore.proxmox.com/all/20250624112817.132312-1-l.wag...@proxmox.com/T/#t
On 2025-06-12 13:06, Lukas Wagner wrote:
> Those were only used in the first iteration of the new notification
> stack, which unfortunately hit pvetest too soon. These two keys have no
> e
These were only used in the 'old' revamped notification stack which was
briefly available on pvetest. With PVE 9 we can finally get completely
rid of these.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v1:
- Rebased onto latest master (PVE 9)
www/manager6/dc/Back
migrate the contents of
/root/.forward if needed.
Signed-off-by: Lukas Wagner
---
Makefile | 2 --
debian/lintian-overrides | 2 +-
debian/proxmox-mail-forward.postinst | 13 ++---
debian/rules | 9 -
4 files
proxmox-mail-forward is not intended to be called by regular users, so
installing it at /usr/libexec/proxmox-mail-forward is a better fit.
pve-manager:
Lukas Wagner (1):
d/postinst: remove old pvemailforward migration logic
debian/postinst | 10 --
1 file changed, 10 deletions
the
contents of /root/.forward.
Signed-off-by: Lukas Wagner
---
debian/postinst | 10 --
1 file changed, 10 deletions(-)
diff --git a/debian/postinst b/debian/postinst
index aba39904..6b706951 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -155,16 +155,6 @@ case "$1" i
On 2025-06-16 21:28, Thomas Lamprecht wrote:
>>
>> [dependencies]
>> anyhow = "1.0"
>> -log = "0.4.17"
>> nix = "0.26"
>> -syslog = "6.0"
>>
>> -proxmox-sys = "0.6"
>> +proxmox-log = "0.2.8"
>> proxmox-notify = {version = "0.5.4", features = ["mail-forwarder",
>> "pve-context", "pbs-conte
e, the UI shifts by a
couple pixels when the additional field is shown.
As a workaround, the checkbox is padded on the bottom by a tiny amount,
stopping the UI from shifting around when the additional field is
shown.
Signed-off-by: Lukas Wagner
---
Notes:
New in v2.
www/manager6/win
also be used to house other controls. For example,
we could display all matchers that could potentially match this backup
job, or maybe even allow to create a new matcher with a pre-populated
match-field rule.
The term 'Notification System' is altogether from the UI. It is not
necessarily
pending on whether mailto is set).
The term 'Notification System' is completely dropped from the UI,
instead 'Global Notification Settings' is used.
Signed-off-by: Lukas Wagner
Tested-by: Michael Köppl
Reviewed-by: Michael Köppl
---
Notes:
Changeslog:
v2:
-
Thanks for testing and the review!
On 2025-06-13 15:51, Michael Köppl wrote:
>> --- a/www/manager6/window/Backup.js
>> +++ b/www/manager6/window/Backup.js
>> @@ -33,22 +33,22 @@ Ext.define('PVE.window.Backup', {
>> let mailtoField = Ext.create('Ext.form.field.Text', {
>> fieldLabel:
Superseded by v2:
https://lore.proxmox.com/all/20250617084448.87536-1-l.wag...@proxmox.com/T/#t
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
ael Köppl
>
> The remaining comments are mostly suggestions, so with the Recipient
> typo addressed, also consider this:
> Reviewed-by: Michael Köppl
>
> On 6/11/25 14:59, Lukas Wagner wrote:
>> The notification settings in the 'General' tab were unfortunately a
&
On 2025-06-12 17:16, Gabriel Goller wrote:
> Printing anyhow errors with "{:#}" would be nice, so that the whole
> context is visible as well.
>
> Otherwise LGTM!
> Consider:
> Reviewed-by: Gabriel Goller
Good point, I'll add the alternative formatter and add your R-b at the same
time for a
-by: Lukas Wagner
Reviewed-by: Gabriel Goller
---
Changes since v1:
- Use :# to print errors with more context
Cargo.toml | 5 ++---
debian/control | 4 ++--
src/main.rs| 20 +++-
3 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/Cargo.toml b/Cargo.toml
Superseded-by:
https://lore.proxmox.com/all/20250613075443.63136-1-l.wag...@proxmox.com/T/#u
On 2025-06-12 14:34, Lukas Wagner wrote:
> The proxmox-notify crate now uses tracing for logging, hence we have to
> set up some tracing logging infrastructure if we want to see any
> messag
-off-by: Lukas Wagner
---
Only intended for PVE 9.
www/manager6/dc/BackupJobDetail.js | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/www/manager6/dc/BackupJobDetail.js
b/www/manager6/dc/BackupJobDetail.js
index 85bb036a..f80d5ef7 100644
--- a
on whether mailto is set).
We also stop using the term 'notification system' in the UI, instead it
is called "Global Notification Settings".
Signed-off-by: Lukas Wagner
---
www/manager6/window/Backup.js | 32 +---
1 file changed, 21 insertions(+),
ogether in the UI.
It is not necessarily clear to a user that this refers to the settings
in Datacenter > Notifications.
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 1 +
www/manager6/dc/Backup.js | 65 ++-
.../panel/BackupNotificatio
.
Signed-off-by: Lukas Wagner
---
Intended for PVE 9
src/PVE/VZDump/Common.pm | 13 -
1 file changed, 13 deletions(-)
diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 8fce316..f816ab0 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -230,19
These were only used in the 'old' revamped notification stack which was
briefly available on pvetest. With PVE 9 we can finally get completely
rid of these.
Signed-off-by: Lukas Wagner
---
Only intended for PVE 9.
www/manager6/dc/Backup.js | 16
1 file changed, 16
-by: Lukas Wagner
---
Cargo.toml | 5 ++---
debian/control | 4 ++--
src/main.rs| 20 +++-
3 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/Cargo.toml b/Cargo.toml
index 8bbd89e..f23fc61 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -15,9 +15,8 @@ exclude
On 2025-07-15 21:59, Thomas Lamprecht wrote:
> Am 14.07.25 um 10:42 schrieb Lukas Wagner:
>> On 2025-07-14 10:30, Gabriel Goller wrote:
>
>>> Make we should change the Makefile to run `proxmox-biome check`?
>>
>> Maybe, but I think a separate make target could m
RFC5322 requires to quote the display name if certain special characters
are used (see diff).
(backported from commit 7262fae25c7cd25df9443158e3542ad58e7c0ebe on
master)
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/endpoints/smtp.rs | 55 +++-
1 file changed, 54
On 2025-07-16 13:36, Lukas Wagner wrote:
>
>
> On 2025-07-04 20:23, Daniel Kral wrote:
>> OpenSSH 10.0 removes support for the DSA signature algorithm [0], which
>> is the base version that will be shipped for Debian 13 trixie. Since it
>> has been marked d
r creation:
Creating SSH host key 'ssh_host_dsa_key' - this may take some time ...
unknown key type dsa
I can confirm that this patch makes it work again, so consider this:
Tested-by: Lukas Wagner
--
- Lukas
___
pve-devel mailing l
On 2025-07-16 00:46, Thomas Lamprecht wrote:
> On Thu, 26 Jun 2025 14:54:29 +0200, Lukas Wagner wrote:
>> RFC5322 requires to quote the display name if certain special characters
>> are used (see diff).
>>
>>
>
> Applied, thanks!
>
> This would need
1001 - 1100 of 1167 matches
Mail list logo
