Re: [pve-devel] [RFC qemu-server 21/22] blockdev: add support for NBD paths

2025-06-16 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- I think I have wrongly dropped nbd with unix socket in my last patch series, but previously it was: +} elsif ($path =~ m/^nbd:(\S+):(\d+):exportname=(\S+)$/) { + my $server = { type => 'inet', host => $1, port => $2 }; + $blockdev = { driver => 'nbd', serve

Re: [pve-devel] [PATCH qemu-server 20/22] blockdev: add helpers to generate blockdev commandline

2025-06-16 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>The 'snapshot' option, for QEMU's snapshot mode, i.e. writes are only >>temporary, is not yet supported. from qemu manpage: " -snapshot Write to temporary files instead of disk image files. In this case, the raw disk image you use is not written back.

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>With '-blockdev', it is necessary to activate the volumes to generate >>the command line, because it can be necessary to check whether the >>volume is a block device or a regular file. I was thinking about that, but do we have storage with activate_volume need to be done fo

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread Fiona Ebner
Am 16.06.25 um 13:31 schrieb DERUMIER, Alexandre via pve-devel: >>> With '-blockdev', it is necessary to activate the volumes to generate >>> the command line, because it can be necessary to check whether the >>> volume is a block device or a regular file. > > I was thinking about that, but do we

Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ui: overflow error when `pending` chip comes to view

2025-06-16 Thread Shan Shaji
Thanks for the review. Will send another updated patch. On Fri Jun 13, 2025 at 1:19 PM CEST, Michael Köppl wrote: > Quickly tested this in my Android emulator by following the steps > described in the commit message (comment on that below). Was able to > reproduce the issue before the patch. Goo

Re: [pve-devel] [RFC qemu-server 22/22] command line: switch to blockdev starting with machine version 10.0

2025-06-16 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- >>+ # QEMU recursively auto-removes the file children, i.e. file >>and format node below the top From my tests, it's not removing backing nodes when snapshots are used, at least when then are defined with nodename. Don't have tested with autogenerated backing nodes, I'll

Re: [pve-devel] [PATCH qemu-server 12/22] vm start: move state file handling to dedicated module

2025-06-16 Thread Fabian Grünbichler
> Fiona Ebner hat am 16.06.2025 12:34 CEST geschrieben: > > > Am 13.06.25 um 12:00 schrieb Fabian Grünbichler: > > On June 12, 2025 4:02 pm, Fiona Ebner wrote: > >> @@ -5649,54 +5647,20 @@ sub vm_start_nolock { > >>$nodename, $migrate_opts->{network}); > >> } > >> > >> +my $

Re: [pve-devel] [PATCH qemu-server 13/22] vm start: move config_to_command() call further down

2025-06-16 Thread Fiona Ebner
Am 13.06.25 um 12:05 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> @@ -5654,16 +5642,28 @@ sub vm_start_nolock { >> ($state_cmdline, $res->{migrate}, $statefile_is_a_volume) = >> PVE::QemuServer::StateFile::statefile_cmdline_option( >> $sto

Re: [pve-devel] [PATCH qemu-server 12/22] vm start: move state file handling to dedicated module

2025-06-16 Thread Fiona Ebner
Am 16.06.25 um 12:54 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 16.06.2025 12:34 CEST geschrieben: >> Am 13.06.25 um 12:00 schrieb Fabian Grünbichler: >>> On June 12, 2025 4:02 pm, Fiona Ebner wrote: @@ -5649,54 +5647,20 @@ sub vm_start_nolock { $nodename, $migrate_opts->{n

Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-06-16 Thread Fiona Ebner
Am 13.06.25 um 12:25 schrieb joao.sousa: > On 12/06/25 10:12, Fiona Ebner wrote: >> The tests in qemu-server were updated since then. You can check out an >> earlier commit and apply on top of that. For pve-storage, I'd guess it >> was the code style changes, so same story: > > I reverted qemu-ser

Re: [pve-devel] [PATCH ha-manager 2/3] watchdog: warn when about to expire

2025-06-16 Thread Aaron Lauterer
On 2025-05-19 15:09, Maximiliano Sandoval wrote: Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index a9017b3..e14c768 100644 --- a/src/watchdog-mux.c +++ b

Re: [pve-devel] [PATCH ha-manager 0/3] watchdog: sync log to disk before and after expiring

2025-06-16 Thread Aaron Lauterer
tested it by applying this series to a node with HA guests and then disabling the corosync network completely or, to test the "averted" log, sleeping for 45 seconds before bringing the corosync network back up. So far, it seems that the "about to expire" warning did make it into the journal in

Re: [pve-devel] [PATCH-SERIES qemu-server 00/22] preparation for switch to blockdev

2025-06-16 Thread Fiona Ebner
Hi Alexandre, Am 16.06.25 um 08:22 schrieb DERUMIER, Alexandre via pve-devel: > Hi Fiona, > I'm going to test your patch serie this week > >>> While the last patch actually does the switch, many operations are >>> not >>> yet supported. It is included to show what changes I made there. It >> shou

Re: [pve-devel] [PATCH qemu-server 02/22] cfg2cmd: require at least QEMU binary version 6.0

2025-06-16 Thread Fiona Ebner
Am 13.06.25 um 11:18 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> The minimum supported binary version for Proxmox VE 9 is QEMU 10.0, so >> there still is more than enough room for eventual regression testing >> with older binaries. > > given that PVE 8.0 released

Re: [pve-devel] [PATCH qemu-server 05/22] restore: parse drive with additional properties

2025-06-16 Thread Fiona Ebner
Am 13.06.25 um 11:30 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> For backwards-compat, to allow dropping some drive properties that are >> long gone from QEMU. >> >> Signed-off-by: Fiona Ebner >> --- >> PVE/QemuServer.pm | 2 +- >> 1 file changed, 1 insertion(+),

Re: [pve-devel] [PATCH ha-manager 2/3] watchdog: warn when about to expire

2025-06-16 Thread Thomas Lamprecht
Am 19.05.25 um 15:09 schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > src/watchdog-mux.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c > index a9017b3..e14c768 100644 > --- a/src/watchdog-mu

[pve-devel] applied: [PATCH-SERIES qemu 0/2] update submodule and patches to QEMU 10.0.2

2025-06-16 Thread Thomas Lamprecht
On Mon, 02 Jun 2025 12:22:25 +0200, Fiona Ebner wrote: > Only minor changes this time: > > Adapt to changed include paths: > 32cad1ffb8 ("include: Rename sysemu/ -> system/") > 407bc4bf90 ("qapi: Move include/qapi/qmp/ to include/qobject/") > > Adapt to a function signature change: > 4822128693 (

Re: [pve-devel] [PATCH qemu-server 12/22] vm start: move state file handling to dedicated module

2025-06-16 Thread Fiona Ebner
Am 13.06.25 um 12:00 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> @@ -5649,54 +5647,20 @@ sub vm_start_nolock { >> $nodename, $migrate_opts->{network}); >> } >> >> +my $res = {}; >> +my $statefile_is_a_volume; >> +my $state_cmdline = [];

Re: [pve-devel] [PATCH promxox-mail-forward v2] fix logging by switching to proxmox-log

2025-06-16 Thread Thomas Lamprecht
Am 13.06.25 um 09:54 schrieb Lukas Wagner: > The proxmox-notify crate now uses tracing for logging, hence we have to > set up some tracing logging infrastructure if we want to see any > messages in the journal. Therefore we switch from the syslog crate to > proxmox-log, which configures the appropr

Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ui: overflow error when `pending` chip comes to view

2025-06-16 Thread Shan Shaji
Superseeded By v2: https://lore.proxmox.com/pve-devel/20250616125844.52117-1-s.sh...@proxmox.com/T/#u On Mon Jun 16, 2025 at 2:04 PM CEST, Shan Shaji wrote: > > Thanks for the review. Will send another updated patch. > > On Fri Jun 13, 2025 at 1:19 PM CEST, Michael Köppl wrote: > > Quickly teste

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread Fiona Ebner
Am 16.06.25 um 15:15 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 16.06.2025 14:57 CEST geschrieben: >> Am 16.06.25 um 14:46 schrieb Fabian Grünbichler: >>> variant B: >>> >>> move decision which driver to use to plugin via qemu_blockdev_options >> >> Yes. >> >>> how would the default/fallbac

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread Fabian Grünbichler
> Fiona Ebner hat am 16.06.2025 14:57 CEST geschrieben: > > > Am 16.06.25 um 14:46 schrieb Fabian Grünbichler: > >> Fiona Ebner hat am 16.06.2025 13:51 CEST geschrieben: > >> Am 16.06.25 um 13:31 schrieb DERUMIER, Alexandre via pve-devel: > > With '-blockdev', it is necessary to activate

[pve-devel] [PATCH pve_flutter_frontend v2] fix: ui: render pending chip widget in column to avoid overflow error

2025-06-16 Thread Shan Shaji
When the pending chip appears after enabling an option from the options page, Flutter throws an overflow error, causing the chip to render on top of the Switch widget due to insufficient space between the title and the switch toggle. To resolve this, modify the layout so that the pending chip widg

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread Fabian Grünbichler
> Fiona Ebner hat am 16.06.2025 13:51 CEST geschrieben: > > > Am 16.06.25 um 13:31 schrieb DERUMIER, Alexandre via pve-devel: > >>> With '-blockdev', it is necessary to activate the volumes to generate > >>> the command line, because it can be necessary to check whether the > >>> volume is a

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread Fiona Ebner
Am 16.06.25 um 14:46 schrieb Fabian Grünbichler: >> Fiona Ebner hat am 16.06.2025 13:51 CEST geschrieben: >> Am 16.06.25 um 13:31 schrieb DERUMIER, Alexandre via pve-devel: > With '-blockdev', it is necessary to activate the volumes to generate > the command line, because it can be necessa

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-16 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > With '-blockdev', it is necessary to activate the volumes to > > generate > > the command line, because it can be necessary to check whether the > > volume is a block device or a regular file. >>I was thinking about that, but do we have storage with >>activate_volume >>n

Re: [pve-devel] [PATCH ha-manager 3/3] watchdog: sync journal after sending expiration related messages

2025-06-16 Thread Thomas Lamprecht
Am 19.05.25 um 15:09 schrieb Maximiliano Sandoval: > One sync comes after warning that the watchdog is about to expire, and a > second right after the watchdog expires. > > To maximize the chances the log will contain entries relevant to a fence > event. This would be extremely useful for detectin