[pve-devel] [PATCH proxmox_dart_api_client v3 1/1] fix: ui: add missing `paused` status check

2025-06-05 Thread Shan Shaji
On the resources tab when the guest status was paused, the guest was showing the status as `unknown`. However on the overview page the status was shown correctly. The issue happens due to the `getStatus` function not returning the corresponding `PveResourceStatusType` when the status is `paused`.

[pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend v3 0/2] fix: resources: add filter option for `paused` guest status

2025-06-05 Thread Shan Shaji
This patch series adds a new `paused` filter option in the resources filter drawer. Additionaly also fixes the `unkown` status shown on the guest in the resources tab when the status is `paused`. History: v2: https://lore.proxmox.com/pve-devel/664b1efd-7b30-4796-b933-f2071adbd...@prox

[pve-devel] [PATCH pve_flutter_frontend v3 1/1] fix: resources: add filter option for `paused` guest status

2025-06-05 Thread Shan Shaji
In the resources tab there were no option to filter the guest when the status is `paused`. To fix the issue, add new `paused` filter option under status section of the drawer. Additionaly rather than copy pasting the `_ProxmoxResourceFilterLisTile`, add a for loop that will iterate over all the st

[pve-devel] [PATCH v3 storage 1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option

2025-06-05 Thread Fiona Ebner
Use '/dev/zvol' as a base path for new storages for providers 'iet' and 'LIO', because that is what modern distributions use. This is a breaking change regarding the addition of new storages on older distributions, but it's enough to specify the base path '/dev' explicitly for setups that require

[pve-devel] [PATCH v3 storage 2/2] zfs over iscsi: on-add hook: dynamically determine base path

2025-06-05 Thread Fiona Ebner
This reduces the potential breakage from commit "fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option". Only setups where '/dev/zvol' exists, but is not a valid base, will still be affected. Signed-off-by: Fiona Ebner Tested-by: Christoph Heiss --- No changes in v3. src/PVE/Sto

Re: [pve-devel] [PATCH v2 storage 1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option

2025-06-05 Thread Fiona Ebner
Am 05.06.25 um 13:02 schrieb Christoph Heiss: > Tested the series by setting up a iSCSI target using targetcli(d) (on a > separate PVE 8.4 system as a base, due to ZFS goodies) and then adding a > ZFS-over-iSCSI storage using the LIO provider to a test cluster. > > Confirmed that > > - `zfs-base-

Re: [pve-devel] [PATCH v2 storage 1/2] fix #5071: zfs over iscsi: add 'zfs-base-path' configuration option

2025-06-05 Thread Christoph Heiss
Tested the series by setting up a iSCSI target using targetcli(d) (on a separate PVE 8.4 system as a base, due to ZFS goodies) and then adding a ZFS-over-iSCSI storage using the LIO provider to a test cluster. Confirmed that - `zfs-base-path` is correctly detected when adding the storage - the i

Re: [pve-devel] [PATCH proxmox_dart_api_client/pve_flutter_frontend v2 0/3] fix: ui: guest missing in resources tab when status is `paused`

2025-06-05 Thread Shan Shaji
On Tue Jun 3, 2025 at 10:15 AM CEST, Michael Köppl wrote: > Thanks for tackling this! Definitely improves the UX. I tested this in > my Android emulator. Paused guests were displayed with the correct > status instead of "Unknown" and I was able to filter for the "Paused" > status. Did not notice an

Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-06-05 Thread Fiona Ebner
Am 05.06.25 um 16:08 schrieb DERUMIER, Alexandre: > Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: >> This new patch series enable blockdev for qemu machine > 10.0 to >> avoid breaking efidisk and maybe >> potential migrations bug > >>> Did you see any actual issues with migration

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-05 Thread Fabian Grünbichler
> Fiona Ebner hat am 05.06.2025 15:23 CEST geschrieben: > > > Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > > +sub encode_nodename { > > +my ($type, $volid, $snap) = @_; > > + > > +my $nodename = "$volid"; > > +$nodename .= "-$snap" if $snap; > > This will lead

[pve-devel] [PATCH cluster 2/2] fix #6434: pmxcfs: add context to *_initialize errors

2025-06-05 Thread Fabian Grünbichler
in case initializing fails with CS_ERR_LIBRARY, the connection to corosync failed - add that context to make the error message a bit less cryptic. Signed-off-by: Fabian Grünbichler --- src/pmxcfs/confdb.c | 9 - src/pmxcfs/dfsm.c | 11 ++- src/pmxcfs/quorum.c | 9 - 3

[pve-devel] [PATCH cluster 1/2] pmxcfs: pretty print corosync error codes

2025-06-05 Thread Fabian Grünbichler
this has always been a bit annoying to manually map via the header file, and while the helper does not do much more at the moment than translate them back to the enum keys, it is better than nothing. Signed-off-by: Fabian Grünbichler --- src/pmxcfs/Makefile | 2 +- src/pmxcfs/confdb.c | 33

Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-06-05 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > This new patch series enable blockdev for qemu machine > 10.0 to > avoid breaking efidisk and maybe > potential migrations bug >>Did you see any actual issues with migration or mirroring the EFI >>disk >>now or

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-05 Thread Fiona Ebner
Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > +sub encode_nodename { > +my ($type, $volid, $snap) = @_; > + > +my $nodename = "$volid"; > +$nodename .= "-$snap" if $snap; This will lead to clashes in some cases: 1. Currently, we allow attaching the same volume multip

Re: [pve-devel] [PATCH-SERIES v6 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support

2025-06-05 Thread Fiona Ebner
Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > This new patch series enable blockdev for qemu machine > 10.0 to avoid > breaking efidisk and maybe > potential migrations bug Did you see any actual issues with migration or mirroring the EFI disk now or is this just a gut feeling?

Re: [pve-devel] [PATCH qemu-server 01/13] blockdev: cmdline: add blockdev syntax support

2025-06-05 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > +sub encode_nodename { > +    my ($type, $volid, $snap) = @_; > + > +    my $nodename = "$volid"; > +    $nodename .= "-$snap" if $snap; This will lead to clashes in some cases: >>1. Currently, we allow attachin

[pve-devel] [PATCH pve_flutter_frontend v2] ui: replace deprecated `onBackground` property

2025-06-05 Thread Shan Shaji
As of flutter v3.22, the `onBackground` property is deprecated. The material guidelines suggest using the `onSurface` property instead. https://m3.material.io/styles/color/roles#8562cf18-5cc0-44ae-b783-2e38bdb39585 For dark theme, the `onSurface` color and `onBackground` color is different so it'

Re: [pve-devel] [PATCH http-server 3/3] formatter: html: update to bootstrap 5

2025-06-05 Thread Dominik Csapak
On 6/4/25 19:33, Thomas Lamprecht wrote: Am 03.06.25 um 15:04 schrieb Dominik Csapak: this makes a few changes necessary, but not too much: * include the different directory for bootstrap5 * use different navbar markup * different classes for navbar container + items * add classes to pre tag sin

Re: [pve-devel] [PATCH pve_flutter_frontend] ui: replace deprecated `onBackground` property

2025-06-05 Thread Shan Shaji
On Thu Jun 5, 2025 at 8:57 AM CEST, Shan Shaji wrote: > > Sure will send another patch. Thank you! > > On Wed Jun 4, 2025 at 12:11 PM CEST, Dominik Csapak wrote: > > this does not apply cleanly anymore (since we already applied the changes > > from > > background -> surfaceContainer) > > > > would

[pve-devel] [PATCH http-server v2] formatter: html: update to bootstrap 5

2025-06-05 Thread Dominik Csapak
this makes a few changes necessary, but not too much: * include the different directory for bootstrap5 * use different navbar markup * different classes for navbar container + items * add classes to pre tag since it's not styled anymore in newer bootstrap versions * add 'form-label' to labels * u

[pve-devel] [PATCH docs v1] clipboard: add hint that live-migration does not work

2025-06-05 Thread Markus Frank
Reported in the community forum: https://forum.proxmox.com/threads/133838/post-774638 Signed-off-by: Markus Frank --- qm.adoc | 8 1 file changed, 8 insertions(+) diff --git a/qm.adoc b/qm.adoc index 8b9e096..7501c0d 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1031,6 +1031,14 @@ SPICE, virt

[pve-devel] [PATCH storage] zfs plugin: alloc/clone: cleanup image when creating LU mapping fails

2025-06-05 Thread Fiona Ebner
Avoid leaving behind orphaned images if creating the associated LU mapping fails during image allocation or cloning. Reported-by: Christoph Heiss Signed-off-by: Fiona Ebner --- src/PVE/Storage/ZFSPlugin.pm | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff