Re: [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume()

2025-05-19 Thread Michael Köppl
On 5/14/25 16:18, Thomas Lamprecht wrote: > Am 13.05.25 um 15:48 schrieb Daniel Kral: >> On 5/13/25 10:03, Michael Köppl wrote: >>> The value in $conf->{opt} is not necessarily a volume ID. To ensure that >>> a valid volume ID is used, it is retrieved by calling parse_volume(). >>> >>> Co-authored-

Re: [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume()

2025-05-19 Thread Thomas Lamprecht
Am 19.05.25 um 09:50 schrieb Michael Köppl: > Thanks for the hint! It seems I have missed that option, wasn't sure how > to handle it otherwise. Will use it in the future. If a v6 of this > series becomes necessary, I'll add Stefan's former email address again. Please send a v6 in any case with th

[pve-devel] [PATCH pve-storage 2/2] common: qemu_img_create: add backing_file support

2025-05-19 Thread Alexandre Derumier via pve-devel
--- Begin Message --- and use it for plugin linked clone This also enable extended_l2=on, as it's mandatory for backing file preallocation. Preallocation was missing previously, so it should increase performance for linked clone now (around x5 in randwrite 4k) cluster_size is set to 128k, as it

[pve-devel] [PATCH pve-storage 1/2] common: add qemu_img_create an preallocation_cmd_option

2025-05-19 Thread Alexandre Derumier via pve-devel
--- Begin Message --- Signed-off-by: Alexandre Derumier --- src/PVE/Storage/Common.pm | 53 ++ src/PVE/Storage/GlusterfsPlugin.pm | 2 +- src/PVE/Storage/Plugin.pm | 47 +- 3 files changed, 55 insertions(+), 47 deletions(-) d

[pve-devel] [PATCH pve-storage 0/2] move qemu_img_create to common helpers and enable preallocation on backed images

2025-05-19 Thread Alexandre Derumier via pve-devel
--- Begin Message --- This is part of my work on qcow2 external snapshot, but could improve current qcow2 linked clone This patch serie move qemu_img_create to common helpers, and enable preallocation on backed_image to increase performance This require l2_extended=on on the backed image I have

[pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications

2025-05-19 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm index a3db78e..205b784 100644 --- a/src/PVE/DataCenterConfig.pm +++ b/src/PVE/DataCenterConfig.pm @@ -4

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-19 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > + #if first snapshot,as it should be bigger,  we merge child, and > rename the snapshot to child > + if(!$parentsnap) { > +     print "commit: merge content of $childpath into $snappath\n"; > +     $cmd = ['/usr/bin/qemu-img', 'commit', $childpath]; > +     eval { run_comman

[pve-devel] [PATCH ha-manager 3/3] watchdog: sync journal after sending expiration related messages

2025-05-19 Thread Maximiliano Sandoval
One sync comes after warning that the watchdog is about to expire, and a second right after the watchdog expires. To maximize the chances the log will contain entries relevant to a fence event. This would be extremely useful for detecting whether a node fenced. Signed-off-by: Maximiliano Sandoval

[pve-devel] [PATCH ha-manager 2/3] watchdog: warn when about to expire

2025-05-19 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index a9017b3..e14c768 100644 --- a/src/watchdog-mux.c +++ b/src/watchdog-mux.c @@ -29,15 +29,24 @@ #define JOURNAL

[pve-devel] [PATCH ha-manager 0/3] watchdog: sync log to disk before and after expiring

2025-05-19 Thread Maximiliano Sandoval
It is very hard to provide a definitive answer to whether a host fenced or not. In some cases the journal on the disk can be missing up to 2 minutes since its last logged entry and the time where another node detects the corosync link is down, with such a gap, the fenced node would not even record

[pve-devel] [PATCH ha-manager 1/3] watchdog: separate if in two parts

2025-05-19 Thread Maximiliano Sandoval
The sole purpose of this commit is to make the following commit's diff easier to read. Signed-off-by: Maximiliano Sandoval --- src/watchdog-mux.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/watchdog-mux.c b/src/watchdog-mux.c index b4bcc0c..a9017b3 100644

Re: [pve-devel] [PATCH flutter_frontend v2 1/2] fix typos

2025-05-19 Thread Shan Shaji
On Fri May 9, 2025 at 10:31 AM CEST, Michael Köppl wrote: > Signed-off-by: Michael Köppl > --- > README.md| 2 +- > lib/pages/main_layout_slim.dart | 2 +- > lib/widgets/pve_console_menu_widget.dart | 2 +- > lib/widgets/pve_guest_o

Re: [pve-devel] [PATCH pve-storage 2/5] qcow2: add external snapshot support

2025-05-19 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > > sub free_image { > my ($class, $storeid, $scfg, $volname, $isBase, $format) = @_; >   > @@ -980,6 +994,51 @@ sub free_image { >  # TODO taken from PVE/QemuServer/Drive.pm, avoiding duplication > would be nice >  my @checked_qemu_img_formats = qw(raw qcow qcow2 qed vmd

[pve-devel] [PATCH qemu-server] migrate: silence 'Use of uninitialized value' warning

2025-05-19 Thread Dominik Csapak
If no vfio device is present during migration, and the transferred (main) memory did not change between loop cycles, we get a warning: Use of uninitialized value $last_vfio_transferred in string ne To silence that, check if the transferred vfio value is defined before, and always write a defined