There are not used anywhere in the tui crate, so drop them.
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/Cargo.toml | 2 --
1 file changed, 2 deletions(-)
diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml
index 403d1ef..139c85c
Drops clap for pico-args, as the former is pretty heavy-weight and
completely overhauls its API with ~every major release.
While it results in a bit more boilerplate code, it makes (especially
long-term) maintenance simpler.
As for the resulting binary, there is a ~13.5% decrease in binary size,
This series first and foremost replaces clap, which is used by
proxmox-chroot and proxmox-auto-install-assistant for parsing CLI
arguments.
clap likes to completely overhaul its API with ~each major release,
which causes quite some churn. It is also quite heavyweight, both in
compile time and bina
Makes the whole routine a lot more robust by parsing the JSON output of
`lsblk` instead of the human-readable output from `btrfs filesystem
show`.
The labels of Btrfs filesystems are pretty much arbitrary labels, e.g.
the following is a valid filesystem and thus output from `btrfs
filesystem show`
On 4/28/25 15:51, Fiona Ebner wrote:
Am 25.03.25 um 16:12 schrieb Daniel Kral:
Add test cases for strict positive colocation rules, i.e. where services
must be kept on the same node together. These verify the behavior of the
services in strict positive colocation rules in case of a failover of
t
And here is a small script I used for testing to see if QMP blockdev-add
can deal with the results:
> [I] root@pve8a1 ~# cat test-storage-blockdev.pl
> #!/usr/bin/perl
>
> use strict;
> use warnings;
>
> use JSON;
> use PVE::QemuServer::Monitor qw(mon_cmd);
> use PVE::Storage;
>
> my $vmid = s
No other plugin activates the storage inside the path() method either.
The caller needs to ensure that the storage is activated before using
the result of path().
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/ESXiPlugin.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiP
Signed-off-by: Fiona Ebner
---
src/PVE/Storage/ISCSIDirectPlugin.pm | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm
b/src/PVE/Storage/ISCSIDirectPlugin.pm
index 829e0c4..d54dcd8 100644
--- a/src/PVE/Storage/ISCSIDirectPlugin
In addition to user-facing errors, a few internal variable names are
also fixed.
Signed-off-by: Michael Köppl
---
lib/src/client.dart | 2 +-
lib/src/handle_ticket_response.dart | 7 ---
lib/src/models/pve_cluster_resources_model.dart | 4 ++--
lib/src
Signed-off-by: Fiona Ebner
---
for me, it fails with
VM 102 qmp command 'blockdev-add' failed - LUN is write protected
but adding as a drive fails. Will need to investigate.
src/PVE/Storage/ISCSIDirectPlugin.pm | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/PVE/Stora
There intentionally is only handling for absolute paths in the default
plugin implementation. Any plugin requiring more needs to implement
the method itself.
Signed-off-by: Fiona Ebner
---
I discussed this with Fabian off-list. With PVE 9 being a major
release and most popular plugins not using
Signed-off-by: Fiona Ebner
---
I'll also submit this upstream.
block/rbd.c | 8
qapi/block-core.json | 4
2 files changed, 12 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index 24e820d056..53a9a785f0 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -272,6 +272,14 @@
When using -drive, storage plugins currently give us a path that QEMU
understands, some using special protocols such as 'iscsi://'. We'd
like to switch to using the more modern -blockdev for PVE 9. The
plan is to have the storage plugins return the very basic information
required to access the imag
Co-developed-by: Alexandre Derumier
Signed-off-by: Fiona Ebner
---
The mon host parsing is adapted from other places where we do that,
but I did not test it with IPv6 yet.
src/PVE/Storage/RBDPlugin.pm | 43
1 file changed, 43 insertions(+)
diff --git a/src
On May 6, 2025 10:33 am, Wolfgang Bumiller wrote:
> Apart from the vdisk_alloc param prototype issue the rest of the series
> LGTM.
>
> Reviewed-by: Wolfgang Bumiller
this series kind of clashes / doesn't go far enough w.r.t. the planned
changes surrounding volume types and disambiguation, pleas
This is a very slight abstraction on top of pico-args, to reduce
boilerplate code a bit for CLI subcommand handling.
No functional changes.
Signed-off-by: Christoph Heiss
---
Cargo.toml | 1 +
debian/control | 1 +
proxmox-installer-common/Cargo.t
Drops clap for pico-args, as the former is pretty heavy-weight and
completely overhauls its API with ~every major release.
As for the resulting binary, there is a ~18% decrease in binary size,
from 2.9M to 2.4MiB (after stripping).
textdata bss dec hex filename
2743595 274576
On 5/6/25 11:21, Christoph Heiss wrote:
> Apart from the one inline comment, looks good to me.
>
> IMO it's not too restrictive, since IPv4 network/broadcast addresses
> shouldn't really be used (and probably introduce subtle breakages)
> outside of /31 prefixes anyway.
>
> On Tue Apr 29, 2025 at
On 5/7/25 10:09, Thomas Lamprecht wrote:
> Am 02.05.25 um 14:10 schrieb Michael Köppl:
>> Signed-off-by: Michael Köppl
>> ---
>> While reviewing another series, I noticed a few typos in user-facing
>> errors. While I was at it, also fixed typos for a few variables.
>
> This seems to need a refres
On 4/28/25 16:44, Fiona Ebner wrote:
Am 25.03.25 um 16:12 schrieb Daniel Kral:
Add test cases for loose positive and negative colocation rules, i.e.
where services should be kept on the same node together or kept separate
nodes. These are copies of their strict counterpart tests, but verify
the
> Alexandre Derumier via pve-devel hat am
> 22.04.2025 13:51 CEST geschrieben:
> add a $include_snapshots param to free_image to
> remove the whole chain of snapshots when deleting the main image.
rbd, zfs, btrfs, lvmthin and qcow2 internal snapshots already all behave like
this by default..
> Alexandre Derumier via pve-devel hat am
> 22.04.2025 13:51 CEST geschrieben:
> we format lvm logical volume with qcow2 to handle snapshot chain.
>
> like for qcow2 file, when a snapshot is taken, the current lvm volume
> is renamed to snap volname, and a new current lvm volume is created
> wi
> Alexandre Derumier via pve-devel hat am
> 22.04.2025 13:51 CEST geschrieben:
> add a snapext option to enable the feature
>
> When a snapshot is taken, the current volume is renamed to snap volname
> and a current image is created with the snap volume as backing file
>
> Signed-off-by: Alex
> Alexandre Derumier via pve-devel hat am
> 22.04.2025 13:51 CEST geschrieben:
no commit message..
> Signed-off-by: Alexandre Derumier
> ---
> PVE/QemuConfig.pm | 4 +-
> PVE/QemuServer.pm | 237 +++-
> PVE/QemuServer/Drive.pm | 39 ---
the commit title is a bit weird, this actually adapts the qemu_img_convert
helper
to the new volume_has_feature values, supporting external snapshots is a side
effect
of that..
> Alexandre Derumier via pve-devel hat am
> 22.04.2025 13:51 CEST geschrieben:
> for external snapshot, we simply use
> Alexandre Derumier via pve-devel hat am
> 22.04.2025 13:51 CEST geschrieben:
> We need to define name-nodes for all backing chain images,
> to be able to live rename them with blockdev-reopen
>
> For linked clone, we don't need to definebase image(s) chain.
> They are auto added with #block
On 5/7/25 11:17, lou.lecriv...@wdz.de wrote:
Hannes,
Thank you for helping with getting the Netbox plugin in good shape, it's
appreciated, really :)
I just have two questions regarding the lack of range support in Nautobot:
- Was there an issue with the original workaround code? I find this o
On May 8, 2025 5:17 pm, Laurențiu Leahu-Vlăducu wrote:
> Thanks for your feedback! Some answers inline.
>
> On 08.05.25 11:14, Fabian Grünbichler wrote:
>> On May 6, 2025 11:09 am, Laurențiu Leahu-Vlăducu wrote:
>>> @@ -807,6 +801,42 @@ pub fn create_snapshot(
>>> total: Progress::new(),
Am 09.05.25 um 10:20 schrieb DERUMIER, Alexandre:
> Message initial
> De: Fiona Ebner
> À: "DERUMIER, Alexandre" , pve-
> de...@lists.proxmox.com
> Objet: Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline:
> convert drive to blockdev syntax
> Date: 08/05/2025 13:21:06
--- Begin Message ---
Re,
Ok, thanks for clarifying. Indeed the offset parameter is ineffective (I have
looked at the Nautobot code this morning). Tbqh I don't really like having to
create then delete an object in Nautobot for this, but I guess there's no other
way, given the limitations we're
On 5/7/25 10:12, Thomas Lamprecht wrote:
> Am 02.05.25 um 14:10 schrieb Michael Köppl:
>> To avoid confusion for users, consistent naming for LXC containers is
>> applied. Since the main screen uses the plural "Virtual Machines", LXC
>> containers is now also plural.
>>
>
> Hmm, I do not have hard
--- Begin Message ---
Message initial
De: Fiona Ebner
À: "DERUMIER, Alexandre" , pve-
de...@lists.proxmox.com
Objet: Re: [pve-devel] [PATCH qemu-server 02/14] blockdev: cmdline:
convert drive to blockdev syntax
Date: 08/05/2025 13:21:06
Am 06.05.25 um 17:40 schrieb DERUMIER, Al
Signed-off-by: Michael Köppl
---
README.md| 2 +-
lib/pages/main_layout_slim.dart | 2 +-
lib/widgets/pve_console_menu_widget.dart | 2 +-
lib/widgets/pve_guest_overview_header.dart | 4 ++--
lib/widgets/pve_node_overview.dart
To avoid confusion for users, consistent naming for containers is
applied. Since the main screen uses the plural "Virtual Machines",
"Containers" is now also plural.
Signed-off-by: Michael Köppl
---
lib/pages/main_layout_slim.dart | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
On 5/6/25 13:48, Christoph Heiss wrote:
> After testing this change and thinking about the maxroot change again,
> $hdsize / 4 doesn't really make sense. E.g. for an (unrealistically
> small, but still) disk of 8 GiB; if its unset, pve-root will be ~6.5 GiB
> in size, with the limit of 2 GiB, the i
35 matches
Mail list logo
